Page MenuHomePhabricator
Feed Advanced Search

Tue, Jun 30

j0le added a comment to D75453: [Driver][ARM] parse version of arm/thumb architecture correctly.

ping

Tue, Jun 30, 2:40 AM · Restricted Project

Mon, Jun 22

j0le added a comment to D75453: [Driver][ARM] parse version of arm/thumb architecture correctly.

Sorry for the delay, it is okay to say "ping" after a while :)
LGTM

Mon, Jun 22, 1:33 AM · Restricted Project

Apr 29 2020

j0le updated the diff for D75453: [Driver][ARM] parse version of arm/thumb architecture correctly.

Changed title and summary to not contain the phrase "undefined behaviour".
Extended the test case with a test, that passes the argument "-mcpu=cortex-m1" to clang, which causes the architecture part of the triple to become "thumbv6m". This tests the body of the if statement.

Apr 29 2020, 8:00 AM · Restricted Project

Apr 24 2020

j0le added a comment to D75453: [Driver][ARM] parse version of arm/thumb architecture correctly.

I would like to ask, whether I could "Accept the Revision" myself, or is this only allowed to be done by code owners or other reviewers?
And when the revision is accepted, do I have to commit this, or can this only be done by people who have commit access or is this done automatically?

Apr 24 2020, 4:49 AM · Restricted Project

Apr 6 2020

j0le updated the diff for D75453: [Driver][ARM] parse version of arm/thumb architecture correctly.

I added a test case.
I hope the folder "clang/tests/Driver" is the right one.

Apr 6 2020, 8:38 AM · Restricted Project

Mar 2 2020

j0le created D75453: [Driver][ARM] parse version of arm/thumb architecture correctly.
Mar 2 2020, 6:52 AM · Restricted Project