Page MenuHomePhabricator
Feed Advanced Search

Tue, Nov 24

akyrtzi accepted D91298: Frontend: Always create a new FileManager in ASTUnit::CodeComplete.
Tue, Nov 24, 11:14 AM

Tue, Nov 17

akyrtzi committed rG5834996fefc9: [Frontend] Add flag to allow PCM generation despite compiler errors (authored by bnbarham).
[Frontend] Add flag to allow PCM generation despite compiler errors
Tue, Nov 17, 5:30 PM
akyrtzi closed D91580: [Frontend] Add flag to allow PCM generation despite compiler errors.
Tue, Nov 17, 5:30 PM · Restricted Project
akyrtzi accepted D91580: [Frontend] Add flag to allow PCM generation despite compiler errors.
Tue, Nov 17, 4:45 PM · Restricted Project
akyrtzi added a comment to D91580: [Frontend] Add flag to allow PCM generation despite compiler errors.

I'd like if we only had to use one flag (-fallow-pcm-with-compiler-errors) and have it handle both modules and PCH. Could you make the flag also work for PCH and/or add a test that verifies it works?
You may only have to change

Opts.AllowPCHWithCompilerErrors = Args.hasArg(OPT_fallow_pch_with_errors);

to

Opts.AllowPCHWithCompilerErrors = Args.hasArg(OPT_fallow_pch_with_errors, OPT_fallow_pcm_with_errors);
Tue, Nov 17, 11:33 AM · Restricted Project

Oct 29 2020

akyrtzi accepted D90385: Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr.
Oct 29 2020, 8:30 AM · Restricted Project

Oct 21 2020

akyrtzi added inline comments to D60193: [OpenCL] Added addrspace_cast operator.
Oct 21 2020, 4:12 PM · Restricted Project

Oct 15 2020

akyrtzi added a comment to D89453: Fix hidden-redecls.m test for some environments.

Thank you! Are you able to commit it by yourself?

Oct 15 2020, 9:31 AM · Restricted Project
akyrtzi accepted D89453: Fix hidden-redecls.m test for some environments.
Oct 15 2020, 9:29 AM · Restricted Project

Oct 8 2020

akyrtzi committed rGfbb499ef255b: [AST] Fix crashes caused by redeclarations in hidden prototypes (authored by bnbarham).
[AST] Fix crashes caused by redeclarations in hidden prototypes
Oct 8 2020, 7:51 PM
akyrtzi closed D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes.
Oct 8 2020, 7:50 PM · Restricted Project

Oct 7 2020

akyrtzi accepted D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes.

Good catch!

Oct 7 2020, 8:09 PM · Restricted Project

Sep 3 2020

akyrtzi accepted D86990: [libclang] Source range conversion.
Sep 3 2020, 5:45 PM

Sep 2 2020

akyrtzi added inline comments to D86990: [libclang] Source range conversion.
Sep 2 2020, 2:20 PM
akyrtzi added a comment to D86990: [libclang] Source range conversion.

@akyrtzi IIUC you are saying we should try to push the char-range semantics from libclang API as deep as possible to see if we could avoid this annoying conversion. I think that's a reasonable long-term strategy.
But I also think we'll inevitably run into some clang APIs that use SourceRange for valid reasons and we won't be able to change those. Some other clang APIs might require significant amount of work to be enhanced.

Ultimately, given this conversion isn't part of public libclang API and has explicit semantics, I would keep it - I'd just add a warning to its doc comment.

On practical level - I need this conversion for my other work and I can't go just now and refactor the Rewriter interface.
https://reviews.llvm.org/D86992

Sep 2 2020, 10:08 AM

Sep 1 2020

akyrtzi added a comment to D86990: [libclang] Source range conversion.

SourceRange cxloc::translateCharRangeToTokenRange(CXTranslationUnit TU, CXSourceRange R) is an expensive operation and I'm concerned it will be easy to start calling at places and introduce performance degradation.

Sep 1 2020, 5:29 PM

Aug 31 2020

akyrtzi added a comment to D86840: [WIP] Fix Rewriter.

We may have places in the code where SourceRange is used as a pair of locations, and those locations are character locations instead of token ones, so essentially the information of whether the range is token-based or character-based gets lost, and we get into trouble when passing such a SourceRange to APIs that assume token-based.

Aug 31 2020, 6:19 PM
akyrtzi added a comment to D86840: [WIP] Fix Rewriter.

Thanks a lot for this clarification! So, does that mean the issue is actually here?

static inline SourceRange translateCXSourceRange(CXSourceRange R) {
  return SourceRange(SourceLocation::getFromRawEncoding(R.begin_int_data),
                     SourceLocation::getFromRawEncoding(R.end_int_data));
}
Aug 31 2020, 6:08 PM
akyrtzi added a comment to D86840: [WIP] Fix Rewriter.

AFAIK SourceRange is supposed to always represent a token range (begin loc points to beginning of first token, end loc points to beginning of last token). For representing a character range, CharSourceRange should be used, though IMO its IsTokenRange member was a mistake, CharSourceRange should have only being used to represent half-open character-based range. This distinction is thankfully more clear on the Swift side.

Aug 31 2020, 5:59 PM

Jul 14 2020

GitHub <noreply@github.com> committed rG466d67afe2b9: Merge pull request #887 from akyrtzi/usr-generation-objc-prop-external (authored by akyrtzi).
Merge pull request #887 from akyrtzi/usr-generation-objc-prop-external
Jul 14 2020, 4:32 PM
akyrtzi committed rGa7b73980f55a: [Index/USRGeneration] Make sure that ObjC properties in categories also get… (authored by akyrtzi).
[Index/USRGeneration] Make sure that ObjC properties in categories also get…
Jul 14 2020, 4:32 PM

Jun 29 2020

akyrtzi added reviewers for D82740: [libclang]: check validity before visiting Stmt node: arphaman, jkorous.
Jun 29 2020, 8:03 AM · Restricted Project

Jun 19 2020

akyrtzi added reviewers for D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test: arphaman, jkorous.
Jun 19 2020, 9:12 AM · Restricted Project

May 20 2020

akyrtzi added reviewers for D80279: [libclang] Extend clang_Cursor_Evaluate().: arphaman, jkorous.
May 20 2020, 11:27 AM · Restricted Project
akyrtzi added reviewers for D80126: Add documentation URL records to the .dia format and expose them via libclang: arphaman, jkorous.
May 20 2020, 11:27 AM · Restricted Project

Mar 31 2020

akyrtzi accepted D77180: Forward WrapperFrontendAction::shouldEraseOutputFiles().
Mar 31 2020, 4:33 PM · Restricted Project
akyrtzi accepted D77159: [pch] Honour -fallow-pch-with-compiler-errors for overall compilation status.
Mar 31 2020, 1:44 PM · Restricted Project

Mar 28 2020

akyrtzi added a comment to rG37943e518c5a: [docs] Added solutions to slow build under common problems..

I agree it makes sense to disable CLANG_ENABLE_ARCMT if CLANG_ENABLE_STATIC_ANALYZER is also disabled.

Mar 28 2020, 11:17 AM

Mar 7 2020

akyrtzi committed rG2b17438a92ea: [Index/USRGeneration] Make sure that ObjC properties in categories also get… (authored by akyrtzi).
[Index/USRGeneration] Make sure that ObjC properties in categories also get…
Mar 7 2020, 3:09 PM

Feb 11 2020

akyrtzi accepted D74385: [ARCMT][NFC] Reduce #include dependencies.
Feb 11 2020, 8:29 AM · Restricted Project

Dec 20 2019

akyrtzi removed a reviewer for D71758: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using -fdollars-in-identifiers flag.: akyrtzi.
Dec 20 2019, 10:29 AM · Restricted Project

Dec 16 2019

akyrtzi removed a reviewer for D71535: [clang][AST] Make 'getPartialSpecializations' const-qualified in DeclTemplate: akyrtzi.
Dec 16 2019, 10:16 AM · Restricted Project

Dec 12 2019

akyrtzi committed rG7d2bedeaf2a0: [CMake] Change `LLVM_DISABLE_INDEX_STORE` to be an option and remove 'FORCE'… (authored by akyrtzi).
[CMake] Change `LLVM_DISABLE_INDEX_STORE` to be an option and remove 'FORCE'…
Dec 12 2019, 1:55 PM
akyrtzi committed rG975f8f199173: [CMake] Enable '-index-store-path' compiler option on a Debug build, if the… (authored by akyrtzi).
[CMake] Enable '-index-store-path' compiler option on a Debug build, if the…
Dec 12 2019, 1:54 PM
GitHub <noreply@github.com> committed rG78775ce75a52: Merge pull request #157 from akyrtzi/cmake-index-store-flag (authored by akyrtzi).
Merge pull request #157 from akyrtzi/cmake-index-store-flag
Dec 12 2019, 1:54 PM
akyrtzi committed rG2bb27356b23a: [ASTDumper] Update to our 'upstream-with-swift'-only code to use new upstream… (authored by akyrtzi).
[ASTDumper] Update to our 'upstream-with-swift'-only code to use new upstream…
Dec 12 2019, 12:19 PM
akyrtzi committed rG2b5186e9329d: Fix compiler error due to our fork diverging from llvm.org because of the… (authored by akyrtzi).
Fix compiler error due to our fork diverging from llvm.org because of the…
Dec 12 2019, 12:18 PM
akyrtzi committed rGb2fe1b3718a1: [index/store] Put the USR validation checking logging behind an environment… (authored by akyrtzi).
[index/store] Put the USR validation checking logging behind an environment…
Dec 12 2019, 11:54 AM
akyrtzi committed rG9371ac6c2d0f: [indexstore] Enhancement for IndexStoreCXX.h's getUnitNameFromOutputPath (authored by akyrtzi).
[indexstore] Enhancement for IndexStoreCXX.h's getUnitNameFromOutputPath
Dec 12 2019, 11:53 AM
akyrtzi committed rGa7c300d2ef28: [indexstore] Fix crashing issue with indexstore_store_get_unit_name_from_output… (authored by akyrtzi).
[indexstore] Fix crashing issue with indexstore_store_get_unit_name_from_output…
Dec 12 2019, 11:53 AM
akyrtzi committed rG11ac34105082: [DirectoryWatcher] Add a linux-specific implementation using inotify (authored by akyrtzi).
[DirectoryWatcher] Add a linux-specific implementation using inotify
Dec 12 2019, 11:51 AM
GitHub <noreply@github.com> committed rG6ac75c4bceeb: Merge pull request #219 from akyrtzi/dir-watch-linux (authored by akyrtzi).
Merge pull request #219 from akyrtzi/dir-watch-linux
Dec 12 2019, 11:51 AM
akyrtzi committed rG1bd7215ddd58: [DirectoryWatcher] Move FSEvents implementation to a mac-platform specific… (authored by akyrtzi).
[DirectoryWatcher] Move FSEvents implementation to a mac-platform specific…
Dec 12 2019, 11:51 AM
akyrtzi committed rG11b8843679ab: [unittests] Add a unit test file for DirectoryWatcher library (authored by akyrtzi).
[unittests] Add a unit test file for DirectoryWatcher library
Dec 12 2019, 11:50 AM

Oct 29 2019

akyrtzi committed rG4fe1f93f74dc: [index/store] Changes to make libIndexStore available for linux (authored by akyrtzi).
[index/store] Changes to make libIndexStore available for linux
Oct 29 2019, 5:08 PM
akyrtzi committed rG3d14643f372a: [test/index/store] Remove or put 'XFAIL: linux' instances appropriately (authored by akyrtzi).
[test/index/store] Remove or put 'XFAIL: linux' instances appropriately
Oct 29 2019, 5:08 PM
akyrtzi committed rG6e57de226f06: [index] Some refactoring to simplify how DirectoryWatcher is used for index… (authored by akyrtzi).
[index] Some refactoring to simplify how DirectoryWatcher is used for index…
Oct 29 2019, 5:08 PM
akyrtzi committed rG4885e729c8fe: [DirectoryWatcher] Some enhancements to the DirectoryWatcher (authored by akyrtzi).
[DirectoryWatcher] Some enhancements to the DirectoryWatcher
Oct 29 2019, 5:00 PM
akyrtzi committed rGb4b9b63c1cd2: [index/store] Remove storing file size+mod time for dependencies (authored by akyrtzi).
[index/store] Remove storing file size+mod time for dependencies
Oct 29 2019, 5:00 PM
akyrtzi committed rGdaedbe5a073b: [index/store] Update to handle introduction of SymbolProperty::ProtocolInterface (authored by akyrtzi).
[index/store] Update to handle introduction of SymbolProperty::ProtocolInterface
Oct 29 2019, 4:59 PM
akyrtzi committed rG950964f68436: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 4:59 PM
akyrtzi committed rGdab5207354ee: [index/store] Improvements to make index store reading/writing more robust (authored by akyrtzi).
[index/store] Improvements to make index store reading/writing more robust
Oct 29 2019, 4:40 PM
akyrtzi committed rG6a19e7c8fc03: [index] Update in IndexingAction.cpp for upstream change (authored by akyrtzi).
[index] Update in IndexingAction.cpp for upstream change
Oct 29 2019, 4:05 PM
akyrtzi committed rG825f3f1489ca: [index/store] Make sure to ignore any decl occurrences from the predefines… (authored by akyrtzi).
[index/store] Make sure to ignore any decl occurrences from the predefines…
Oct 29 2019, 3:43 PM
akyrtzi committed rG47ee151b7b21: Fix Windows support for Driver and add support to Index (#127) (authored by troughton).
Fix Windows support for Driver and add support to Index (#127)
Oct 29 2019, 3:28 PM
akyrtzi committed rGa987013fcefe: [c-index-test] Fix compilation for linux (authored by akyrtzi).
[c-index-test] Fix compilation for linux
Oct 29 2019, 2:55 PM
akyrtzi committed rG6e7169a2d3ee: [index] Introduce 'CommentTag' symbol kind (authored by akyrtzi).
[index] Introduce 'CommentTag' symbol kind
Oct 29 2019, 2:40 PM
akyrtzi committed rG3549dfbba076: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 2:40 PM
akyrtzi committed rGc90c273ab9d1: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 2:23 PM
akyrtzi committed rG3c1a9d7bd860: [index] Remove SwiftAccessorGetter/Setter symbol subkinds. (authored by akyrtzi).
[index] Remove SwiftAccessorGetter/Setter symbol subkinds.
Oct 29 2019, 2:19 PM
akyrtzi committed rG9c1706450368: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 2:19 PM
akyrtzi committed rGbca93adf92fe: [index] Add Swift symbol language and Swift-specific symbol subkinds. (authored by akyrtzi).
[index] Add Swift symbol language and Swift-specific symbol subkinds.
Oct 29 2019, 2:18 PM
akyrtzi committed rGc99d9494d31e: [APINotes] Fix build error with creating 'AvailabilityAttr', after upstream… (authored by akyrtzi).
[APINotes] Fix build error with creating 'AvailabilityAttr', after upstream…
Oct 29 2019, 1:01 PM
akyrtzi committed rG952605f25b1a: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:56 PM
akyrtzi committed rGd2cbac0a9a43: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:56 PM
akyrtzi committed rG97b46aab9b05: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:56 PM
akyrtzi committed rG4f0e548493e7: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:55 PM
akyrtzi committed rG2400d6de15e1: [SemaAPINotes] Fix compiler error after change of r261163. (authored by akyrtzi).
[SemaAPINotes] Fix compiler error after change of r261163.
Oct 29 2019, 12:51 PM

Oct 8 2019

ham999 awarded D17325: Introduce llvm/ADT/OptionSet.h utility class a Mountain of Wealth token.
Oct 8 2019, 5:15 PM

Aug 28 2019

akyrtzi accepted D66884: Removed dead code from clang/AST/NSAPI.h.
Aug 28 2019, 10:33 AM · Restricted Project, Restricted Project

Aug 24 2019

akyrtzi accepted D66694: [libclang][index][NFCi] Refactor machinery for skipping already parsed function bodies.
Aug 24 2019, 10:48 AM · Restricted Project

Aug 23 2019

akyrtzi added a comment to D66690: [libclang][index] Skip already indexed function bodies more aggressively.

Are you sure the difference is not random noise? It's not clear to me under which conditions you would encounter the same region in NewParsedRegions within the same TU. I assume this would be the case if the same file is parsed multiple times, but I'd expect this to be uncommon within the same TU.
I'd recommend to add some counters of when NewParsedRegions.count(region) is true and when ParsedRegions.count(region) is true, and print them at the end.

Aug 23 2019, 4:20 PM

Aug 13 2019

akyrtzi accepted D66156: Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h}.
Aug 13 2019, 3:38 PM · Restricted Project, Restricted Project

Aug 7 2019

akyrtzi added a comment to D65846: Improve error message from FrontendAction.

clang -fmodules -fmodules-cache-path=... is supposed to create the directory for the cache path, including the parent directories, AFAIK. If this doesn't happen it is a behavior change (and undesirable IMO).

Is c-index-test invoking clang or do we just have a similar interface? Perhaps it's not doing it right (haven't seen this problem happening directly while invoking clang). Should -fallow-pch-with-compiler-errors be considered somehow here?

Aug 7 2019, 2:29 PM · Restricted Project
akyrtzi added a comment to D65846: Improve error message from FrontendAction.
In D65846#1619645, @jfb wrote:

My current guess is that this part of the test:

c-index-test -write-pch %t.h.pch %s -fmodules -fmodules-cache-path=%t.mcp -Xclang -triple -Xclang x86_64-apple-darwin

Is expected to generate the unknown type name error, but when than happens it ignores -fmodules-cache-path=%t.mcp and doesn't create the directory. The next line expects the directory to exist, which is why it can't create the lock file (because the directory it's trying to create it in doesn't exist).

Aug 7 2019, 1:13 PM · Restricted Project
akyrtzi added a comment to D65846: Improve error message from FrontendAction.

Sorry, it's not clear to me what is the issue.

Aug 7 2019, 9:56 AM · Restricted Project

Jul 22 2019

akyrtzi added a comment to D64384: [WIP] Index-while-building.

For now I went with IndexWhileBuilding name but I'm open to discussion.

Jul 22 2019, 4:42 PM · Restricted Project

Jul 16 2019

akyrtzi added reviewers for D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug: arphaman, jkorous.
Jul 16 2019, 9:45 AM · Restricted Project, Restricted Project

May 23 2019

akyrtzi added a reviewer for D48961: [Index] Add indexing support for MACROs.: jkorous.
May 23 2019, 10:00 AM · Restricted Project

May 10 2019

akyrtzi added a reviewer for D48116: [libclang] Allow skipping warnings from all included files: jkorous.
May 10 2019, 10:10 AM · Restricted Project, Restricted Project

Mar 6 2019

akyrtzi added inline comments to D39050: Add index-while-building support to Clang.
Mar 6 2019, 11:36 AM
akyrtzi added a reviewer for D39050: Add index-while-building support to Clang: jkorous.
Mar 6 2019, 10:08 AM

Mar 5 2019

akyrtzi accepted D58986: Fix typo in string returned from index::getSymbolKindString for SymbolKind::ConversionFunction.
Mar 5 2019, 11:28 AM · Restricted Project

Mar 1 2019

akyrtzi added a reviewer for D58814: [clang][Index] Mark references from Constructors and Destructors to class as NameReference : benlangmuir.
Mar 1 2019, 2:29 PM · Restricted Project

Feb 23 2019

akyrtzi added inline comments to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
Feb 23 2019, 2:21 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
Feb 23 2019, 1:50 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
Feb 23 2019, 11:57 AM · Restricted Project, Restricted Project
akyrtzi added inline comments to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
Feb 23 2019, 10:51 AM · Restricted Project, Restricted Project

Feb 8 2019

akyrtzi accepted D57949: [clang][Index] Add a knob to index function parameters in declarations.
Feb 8 2019, 8:40 AM · Restricted Project, Restricted Project

Dec 6 2018

akyrtzi added inline comments to D54862: [OpenCL] Add generic AS to 'this' pointer.
Dec 6 2018, 11:50 AM

Dec 5 2018

akyrtzi added inline comments to D54862: [OpenCL] Add generic AS to 'this' pointer.
Dec 5 2018, 8:17 AM

Nov 27 2018

akyrtzi added inline comments to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.
Nov 27 2018, 2:37 PM

Nov 25 2018

akyrtzi added a comment to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.

Thanks for reviewing Kristina & Aaron, much appreciated!

Nov 25 2018, 5:05 PM
akyrtzi updated the diff for D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.
  • Change #cmakedefine01 to #cmakedefine for consistency.
  • Add comments to getLastAccessedTime()/ getLastModificationTime() APIs to make sure people are aware that time resolution can differ among file systems.
  • Improve commit summary.
Nov 25 2018, 2:02 PM
akyrtzi added inline comments to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.
Nov 25 2018, 1:52 PM
akyrtzi added inline comments to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.
Nov 25 2018, 1:21 PM
akyrtzi added a comment to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.

I think that should be documented on the public API part with a mention that the resolution is expected to differ depending on the file system and OS. WDYT?

That is a good idea, the way I consider file_status is that it provides a cross-platform way to get at the file properties. It provides times in nanoseconds but leaves the precision as implementation detail of the underlying file system, which makes sense, people should not expect anything more than that.
I'll add some comments.

Nov 25 2018, 1:10 PM
akyrtzi added a comment to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.

Is it going to be an issue that the Windows side of things has a more wild idea of file timestamp resolution? NTFS has a theoretical max precision of 100ns intervals, though according to MSDN, the access time on NTFS has a resolution of 1 hour, which is better than FAT file systems, where the resolution is 1 day. It seems odd to rely on ns resolution for access time, as that seems like it's going to be highly platform and filesystem dependent.

I can't speak for the Windows side of things but what you are pointing out is a general question about applications taking into account that file properties may differ across platforms. This is orthogonal to file_status itself reporting file properties accurately.
If current file_status has 1 hour resolution on NTFS for access time, this patch is not going to make it any better or worse, nor affect behavior of applications that are querying files from NTFS.

Nov 25 2018, 12:28 PM
akyrtzi added a comment to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.

I think this is the most important bit of information here. It should have been in the description of the differential.
If the current precision was 1ms (or even 1us), then yes, going all the way down to 1ns may not be important/worthwhile.
But 1 sec precision is clearly laughably not great, and should be improved.

Ah good point, I didn't consider that people are not broadly aware that current file_status has only 'up to second' precision.

Nov 25 2018, 12:12 PM
akyrtzi added a comment to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.

On second look, if you are concerned with adding additional fields in basic_file_status, I can replace:

time_t fs_st_atime = 0;
time_t fs_st_mtime = 0;

with uint64_t's which are adequate to include nanosecond precision, while these time_t's are 64bits as well but waste space in the structure.

Nov 25 2018, 12:04 PM