Page MenuHomePhabricator
Feed Advanced Search

Thu, May 20

akyrtzi accepted D102614: [index] Add support for type of pointers to class members.
Thu, May 20, 10:05 AM · Restricted Project

Wed, May 19

akyrtzi added inline comments to D102614: [index] Add support for type of pointers to class members.
Wed, May 19, 3:25 PM · Restricted Project

May 11 2021

akyrtzi added a comment to D102159: [index][analyzer][ctu] Eliminate white spaces in the CTU lookup name..

To clarify, I was suggesting that in addition to removing the space from unhandled types, we also handle the member function pointer type and not leave it in this fallback case.
Types should have unique USR characters so that overloaded functions (overloaded on the type parameter) have unique USRs.

May 11 2021, 3:51 PM · Restricted Project

May 10 2021

akyrtzi added a comment to D102159: [index][analyzer][ctu] Eliminate white spaces in the CTU lookup name..

Maybe we could also handle this kind of type instead of leaving it 'unhandled'? What Type is it?

May 10 2021, 2:25 PM · Restricted Project

May 6 2021

akyrtzi committed rGa3a8a1a15b52: [Index] Ignore nullptr decls for indexing (authored by ahoppen).
[Index] Ignore nullptr decls for indexing
May 6 2021, 1:13 PM
akyrtzi closed D102001: [Index] Ignore nullptr decls for indexing.
May 6 2021, 1:12 PM · Restricted Project
akyrtzi accepted D102001: [Index] Ignore nullptr decls for indexing.
May 6 2021, 1:09 PM · Restricted Project

May 3 2021

akyrtzi added inline comments to D101645: [clang] RecursiveASTVisitor visits ObjCPropertyRefExpr's class receiver.
May 3 2021, 5:04 PM · Restricted Project, Restricted Project

Apr 23 2021

akyrtzi added inline comments to D93377: [Clang] Add __ibm128 type to represent ppc_fp128.
Apr 23 2021, 8:56 AM · Restricted Project

Apr 16 2021

akyrtzi committed rG1206b95e0703: [ASTReader] Only mark module out of date if not already compiled (authored by bnbarham).
[ASTReader] Only mark module out of date if not already compiled
Apr 16 2021, 5:58 PM
akyrtzi closed D100619: [ASTReader] Only mark module out of date if not already compiled.
Apr 16 2021, 5:58 PM · Restricted Project
akyrtzi accepted D100619: [ASTReader] Only mark module out of date if not already compiled.
Apr 16 2021, 5:33 PM · Restricted Project
akyrtzi added inline comments to D100619: [ASTReader] Only mark module out of date if not already compiled.
Apr 16 2021, 10:03 AM · Restricted Project

Apr 5 2021

akyrtzi accepted D99758: [index] Improve macro indexing support.
Apr 5 2021, 3:51 PM · Restricted Project

Apr 1 2021

akyrtzi resigned from D99732: [AST] Pick last tentative definition as the acting definition.
Apr 1 2021, 9:33 AM · Restricted Project

Feb 24 2021

akyrtzi added a comment to D97204: [RFC] Clang 64-bit source locations.

Can we avoid a libclang ABI break if we don't allow the use of 64-bit source locations for builds with 32-bit pointers?

Feb 24 2021, 4:31 PM · Restricted Project, Restricted Project

Feb 22 2021

akyrtzi added a comment to D97204: [RFC] Clang 64-bit source locations.

A major thing worth noting is that 64-bit source locations will
require an ABI breakage in libclang. This patch changes the bit width
in libclang unconditionally, rather than making it configurable.

Feb 22 2021, 5:27 PM · Restricted Project, Restricted Project

Feb 8 2021

akyrtzi committed rGa8cb39bab04c: Make sure a module file with errors produced via '-fallow-pcm-with-compiler… (authored by akyrtzi).
Make sure a module file with errors produced via '-fallow-pcm-with-compiler…
Feb 8 2021, 4:11 PM
akyrtzi closed D96246: Make sure a module file with errors produced via '-fallow-pcm-with-compiler-errors' can be loaded when using implicit modules.
Feb 8 2021, 4:11 PM · Restricted Project
akyrtzi updated the diff for D96246: Make sure a module file with errors produced via '-fallow-pcm-with-compiler-errors' can be loaded when using implicit modules.

clang-format change

Feb 8 2021, 10:41 AM · Restricted Project
akyrtzi added a reviewer for D96246: Make sure a module file with errors produced via '-fallow-pcm-with-compiler-errors' can be loaded when using implicit modules: bnbarham.
Feb 8 2021, 12:31 AM · Restricted Project
akyrtzi requested review of D96246: Make sure a module file with errors produced via '-fallow-pcm-with-compiler-errors' can be loaded when using implicit modules.
Feb 8 2021, 12:30 AM · Restricted Project

Feb 3 2021

akyrtzi committed rGa2c1054c303f: [ASTReader] Always rebuild a cached module that has errors (authored by bnbarham).
[ASTReader] Always rebuild a cached module that has errors
Feb 3 2021, 10:15 PM
akyrtzi closed D95989: [ASTReader] Always rebuild a cached module that has errors.
Feb 3 2021, 10:15 PM · Restricted Project
akyrtzi accepted D95989: [ASTReader] Always rebuild a cached module that has errors.
Feb 3 2021, 8:35 PM · Restricted Project

Jan 21 2021

akyrtzi committed rGb0e89906f5b7: [ASTReader] Allow controlling separately whether validation should be disabled… (authored by akyrtzi).
[ASTReader] Allow controlling separately whether validation should be disabled…
Jan 21 2021, 8:46 PM
akyrtzi closed D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file.
Jan 21 2021, 8:46 PM · Restricted Project
akyrtzi updated the diff for D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file.

Fix typo in commit message, 'state' -> 'stale'

Jan 21 2021, 3:38 PM · Restricted Project
akyrtzi updated the diff for D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file.

Use getValueOr

Jan 21 2021, 3:36 PM · Restricted Project
akyrtzi updated the diff for D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file.

clang-format changes

Jan 21 2021, 2:06 PM · Restricted Project
akyrtzi added a reviewer for D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file: bnbarham.
Jan 21 2021, 11:50 AM · Restricted Project
akyrtzi requested review of D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file.
Jan 21 2021, 11:46 AM · Restricted Project

Dec 21 2020

akyrtzi resigned from D93377: [Clang] Add __ibm128 type to represent ppc_fp128.
Dec 21 2020, 7:50 PM · Restricted Project

Nov 24 2020

akyrtzi accepted D91298: Frontend: Always create a new FileManager in ASTUnit::CodeComplete.
Nov 24 2020, 11:14 AM

Nov 17 2020

akyrtzi committed rG5834996fefc9: [Frontend] Add flag to allow PCM generation despite compiler errors (authored by bnbarham).
[Frontend] Add flag to allow PCM generation despite compiler errors
Nov 17 2020, 5:30 PM
akyrtzi closed D91580: [Frontend] Add flag to allow PCM generation despite compiler errors.
Nov 17 2020, 5:30 PM · Restricted Project
akyrtzi accepted D91580: [Frontend] Add flag to allow PCM generation despite compiler errors.
Nov 17 2020, 4:45 PM · Restricted Project
akyrtzi added a comment to D91580: [Frontend] Add flag to allow PCM generation despite compiler errors.

I'd like if we only had to use one flag (-fallow-pcm-with-compiler-errors) and have it handle both modules and PCH. Could you make the flag also work for PCH and/or add a test that verifies it works?
You may only have to change

Opts.AllowPCHWithCompilerErrors = Args.hasArg(OPT_fallow_pch_with_errors);

to

Opts.AllowPCHWithCompilerErrors = Args.hasArg(OPT_fallow_pch_with_errors, OPT_fallow_pcm_with_errors);
Nov 17 2020, 11:33 AM · Restricted Project

Oct 29 2020

akyrtzi accepted D90385: Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr.
Oct 29 2020, 8:30 AM · Restricted Project

Oct 21 2020

akyrtzi added inline comments to D60193: [OpenCL] Added addrspace_cast operator.
Oct 21 2020, 4:12 PM · Restricted Project

Oct 15 2020

akyrtzi added a comment to D89453: Fix hidden-redecls.m test for some environments.

Thank you! Are you able to commit it by yourself?

Oct 15 2020, 9:31 AM · Restricted Project
akyrtzi accepted D89453: Fix hidden-redecls.m test for some environments.
Oct 15 2020, 9:29 AM · Restricted Project

Oct 8 2020

akyrtzi committed rGfbb499ef255b: [AST] Fix crashes caused by redeclarations in hidden prototypes (authored by bnbarham).
[AST] Fix crashes caused by redeclarations in hidden prototypes
Oct 8 2020, 7:51 PM
akyrtzi closed D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes.
Oct 8 2020, 7:50 PM · Restricted Project

Oct 7 2020

akyrtzi accepted D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes.

Good catch!

Oct 7 2020, 8:09 PM · Restricted Project

Sep 3 2020

akyrtzi accepted D86990: [libclang] Source range conversion.
Sep 3 2020, 5:45 PM

Sep 2 2020

akyrtzi added inline comments to D86990: [libclang] Source range conversion.
Sep 2 2020, 2:20 PM
akyrtzi added a comment to D86990: [libclang] Source range conversion.

@akyrtzi IIUC you are saying we should try to push the char-range semantics from libclang API as deep as possible to see if we could avoid this annoying conversion. I think that's a reasonable long-term strategy.
But I also think we'll inevitably run into some clang APIs that use SourceRange for valid reasons and we won't be able to change those. Some other clang APIs might require significant amount of work to be enhanced.

Ultimately, given this conversion isn't part of public libclang API and has explicit semantics, I would keep it - I'd just add a warning to its doc comment.

On practical level - I need this conversion for my other work and I can't go just now and refactor the Rewriter interface.
https://reviews.llvm.org/D86992

Sep 2 2020, 10:08 AM

Sep 1 2020

akyrtzi added a comment to D86990: [libclang] Source range conversion.

SourceRange cxloc::translateCharRangeToTokenRange(CXTranslationUnit TU, CXSourceRange R) is an expensive operation and I'm concerned it will be easy to start calling at places and introduce performance degradation.

Sep 1 2020, 5:29 PM

Aug 31 2020

akyrtzi added a comment to D86840: [WIP] Fix Rewriter.

We may have places in the code where SourceRange is used as a pair of locations, and those locations are character locations instead of token ones, so essentially the information of whether the range is token-based or character-based gets lost, and we get into trouble when passing such a SourceRange to APIs that assume token-based.

Aug 31 2020, 6:19 PM
akyrtzi added a comment to D86840: [WIP] Fix Rewriter.

Thanks a lot for this clarification! So, does that mean the issue is actually here?

static inline SourceRange translateCXSourceRange(CXSourceRange R) {
  return SourceRange(SourceLocation::getFromRawEncoding(R.begin_int_data),
                     SourceLocation::getFromRawEncoding(R.end_int_data));
}
Aug 31 2020, 6:08 PM
akyrtzi added a comment to D86840: [WIP] Fix Rewriter.

AFAIK SourceRange is supposed to always represent a token range (begin loc points to beginning of first token, end loc points to beginning of last token). For representing a character range, CharSourceRange should be used, though IMO its IsTokenRange member was a mistake, CharSourceRange should have only being used to represent half-open character-based range. This distinction is thankfully more clear on the Swift side.

Aug 31 2020, 5:59 PM

Jul 14 2020

GitHub <noreply@github.com> committed rG466d67afe2b9: Merge pull request #887 from akyrtzi/usr-generation-objc-prop-external (authored by akyrtzi).
Merge pull request #887 from akyrtzi/usr-generation-objc-prop-external
Jul 14 2020, 4:32 PM
akyrtzi committed rGa7b73980f55a: [Index/USRGeneration] Make sure that ObjC properties in categories also get… (authored by akyrtzi).
[Index/USRGeneration] Make sure that ObjC properties in categories also get…
Jul 14 2020, 4:32 PM

Jun 29 2020

akyrtzi added reviewers for D82740: [libclang]: check validity before visiting Stmt node: arphaman, jkorous.
Jun 29 2020, 8:03 AM · Restricted Project

Jun 19 2020

akyrtzi added reviewers for D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test: arphaman, jkorous.
Jun 19 2020, 9:12 AM · Restricted Project

May 20 2020

akyrtzi added reviewers for D80279: [libclang] Extend clang_Cursor_Evaluate().: arphaman, jkorous.
May 20 2020, 11:27 AM · Restricted Project
akyrtzi added reviewers for D80126: Add documentation URL records to the .dia format and expose them via libclang: arphaman, jkorous.
May 20 2020, 11:27 AM · Restricted Project

Mar 31 2020

akyrtzi accepted D77180: Forward WrapperFrontendAction::shouldEraseOutputFiles().
Mar 31 2020, 4:33 PM · Restricted Project
akyrtzi accepted D77159: [pch] Honour -fallow-pch-with-compiler-errors for overall compilation status.
Mar 31 2020, 1:44 PM · Restricted Project

Mar 28 2020

akyrtzi added a comment to rG37943e518c5a: [docs] Added solutions to slow build under common problems..

I agree it makes sense to disable CLANG_ENABLE_ARCMT if CLANG_ENABLE_STATIC_ANALYZER is also disabled.

Mar 28 2020, 11:17 AM

Mar 7 2020

akyrtzi committed rG2b17438a92ea: [Index/USRGeneration] Make sure that ObjC properties in categories also get… (authored by akyrtzi).
[Index/USRGeneration] Make sure that ObjC properties in categories also get…
Mar 7 2020, 3:09 PM

Feb 11 2020

akyrtzi accepted D74385: [ARCMT][NFC] Reduce #include dependencies.
Feb 11 2020, 8:29 AM · Restricted Project

Dec 20 2019

akyrtzi removed a reviewer for D71758: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using -fdollars-in-identifiers flag.: akyrtzi.
Dec 20 2019, 10:29 AM · Restricted Project

Dec 16 2019

akyrtzi removed a reviewer for D71535: [clang][AST] Make 'getPartialSpecializations' const-qualified in DeclTemplate: akyrtzi.
Dec 16 2019, 10:16 AM · Restricted Project

Dec 12 2019

akyrtzi committed rG7d2bedeaf2a0: [CMake] Change `LLVM_DISABLE_INDEX_STORE` to be an option and remove 'FORCE'… (authored by akyrtzi).
[CMake] Change `LLVM_DISABLE_INDEX_STORE` to be an option and remove 'FORCE'…
Dec 12 2019, 1:55 PM
akyrtzi committed rG975f8f199173: [CMake] Enable '-index-store-path' compiler option on a Debug build, if the… (authored by akyrtzi).
[CMake] Enable '-index-store-path' compiler option on a Debug build, if the…
Dec 12 2019, 1:54 PM
GitHub <noreply@github.com> committed rG78775ce75a52: Merge pull request #157 from akyrtzi/cmake-index-store-flag (authored by akyrtzi).
Merge pull request #157 from akyrtzi/cmake-index-store-flag
Dec 12 2019, 1:54 PM
akyrtzi committed rG2bb27356b23a: [ASTDumper] Update to our 'upstream-with-swift'-only code to use new upstream… (authored by akyrtzi).
[ASTDumper] Update to our 'upstream-with-swift'-only code to use new upstream…
Dec 12 2019, 12:19 PM
akyrtzi committed rG2b5186e9329d: Fix compiler error due to our fork diverging from llvm.org because of the… (authored by akyrtzi).
Fix compiler error due to our fork diverging from llvm.org because of the…
Dec 12 2019, 12:18 PM
akyrtzi committed rGb2fe1b3718a1: [index/store] Put the USR validation checking logging behind an environment… (authored by akyrtzi).
[index/store] Put the USR validation checking logging behind an environment…
Dec 12 2019, 11:54 AM
akyrtzi committed rG9371ac6c2d0f: [indexstore] Enhancement for IndexStoreCXX.h's getUnitNameFromOutputPath (authored by akyrtzi).
[indexstore] Enhancement for IndexStoreCXX.h's getUnitNameFromOutputPath
Dec 12 2019, 11:53 AM
akyrtzi committed rGa7c300d2ef28: [indexstore] Fix crashing issue with indexstore_store_get_unit_name_from_output… (authored by akyrtzi).
[indexstore] Fix crashing issue with indexstore_store_get_unit_name_from_output…
Dec 12 2019, 11:53 AM
akyrtzi committed rG11ac34105082: [DirectoryWatcher] Add a linux-specific implementation using inotify (authored by akyrtzi).
[DirectoryWatcher] Add a linux-specific implementation using inotify
Dec 12 2019, 11:51 AM
GitHub <noreply@github.com> committed rG6ac75c4bceeb: Merge pull request #219 from akyrtzi/dir-watch-linux (authored by akyrtzi).
Merge pull request #219 from akyrtzi/dir-watch-linux
Dec 12 2019, 11:51 AM
akyrtzi committed rG1bd7215ddd58: [DirectoryWatcher] Move FSEvents implementation to a mac-platform specific… (authored by akyrtzi).
[DirectoryWatcher] Move FSEvents implementation to a mac-platform specific…
Dec 12 2019, 11:51 AM
akyrtzi committed rG11b8843679ab: [unittests] Add a unit test file for DirectoryWatcher library (authored by akyrtzi).
[unittests] Add a unit test file for DirectoryWatcher library
Dec 12 2019, 11:50 AM

Oct 29 2019

akyrtzi committed rG4fe1f93f74dc: [index/store] Changes to make libIndexStore available for linux (authored by akyrtzi).
[index/store] Changes to make libIndexStore available for linux
Oct 29 2019, 5:08 PM
akyrtzi committed rG3d14643f372a: [test/index/store] Remove or put 'XFAIL: linux' instances appropriately (authored by akyrtzi).
[test/index/store] Remove or put 'XFAIL: linux' instances appropriately
Oct 29 2019, 5:08 PM
akyrtzi committed rG6e57de226f06: [index] Some refactoring to simplify how DirectoryWatcher is used for index… (authored by akyrtzi).
[index] Some refactoring to simplify how DirectoryWatcher is used for index…
Oct 29 2019, 5:08 PM
akyrtzi committed rG4885e729c8fe: [DirectoryWatcher] Some enhancements to the DirectoryWatcher (authored by akyrtzi).
[DirectoryWatcher] Some enhancements to the DirectoryWatcher
Oct 29 2019, 5:00 PM
akyrtzi committed rGb4b9b63c1cd2: [index/store] Remove storing file size+mod time for dependencies (authored by akyrtzi).
[index/store] Remove storing file size+mod time for dependencies
Oct 29 2019, 5:00 PM
akyrtzi committed rGdaedbe5a073b: [index/store] Update to handle introduction of SymbolProperty::ProtocolInterface (authored by akyrtzi).
[index/store] Update to handle introduction of SymbolProperty::ProtocolInterface
Oct 29 2019, 4:59 PM
akyrtzi committed rG950964f68436: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 4:59 PM
akyrtzi committed rGdab5207354ee: [index/store] Improvements to make index store reading/writing more robust (authored by akyrtzi).
[index/store] Improvements to make index store reading/writing more robust
Oct 29 2019, 4:40 PM
akyrtzi committed rG6a19e7c8fc03: [index] Update in IndexingAction.cpp for upstream change (authored by akyrtzi).
[index] Update in IndexingAction.cpp for upstream change
Oct 29 2019, 4:05 PM
akyrtzi committed rG825f3f1489ca: [index/store] Make sure to ignore any decl occurrences from the predefines… (authored by akyrtzi).
[index/store] Make sure to ignore any decl occurrences from the predefines…
Oct 29 2019, 3:43 PM
akyrtzi committed rG47ee151b7b21: Fix Windows support for Driver and add support to Index (#127) (authored by troughton).
Fix Windows support for Driver and add support to Index (#127)
Oct 29 2019, 3:28 PM
akyrtzi committed rGa987013fcefe: [c-index-test] Fix compilation for linux (authored by akyrtzi).
[c-index-test] Fix compilation for linux
Oct 29 2019, 2:55 PM
akyrtzi committed rG6e7169a2d3ee: [index] Introduce 'CommentTag' symbol kind (authored by akyrtzi).
[index] Introduce 'CommentTag' symbol kind
Oct 29 2019, 2:40 PM
akyrtzi committed rG3549dfbba076: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 2:40 PM
akyrtzi committed rGc90c273ab9d1: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 2:23 PM
akyrtzi committed rG3c1a9d7bd860: [index] Remove SwiftAccessorGetter/Setter symbol subkinds. (authored by akyrtzi).
[index] Remove SwiftAccessorGetter/Setter symbol subkinds.
Oct 29 2019, 2:19 PM
akyrtzi committed rG9c1706450368: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 2:19 PM
akyrtzi committed rGbca93adf92fe: [index] Add Swift symbol language and Swift-specific symbol subkinds. (authored by akyrtzi).
[index] Add Swift symbol language and Swift-specific symbol subkinds.
Oct 29 2019, 2:18 PM
akyrtzi committed rGc99d9494d31e: [APINotes] Fix build error with creating 'AvailabilityAttr', after upstream… (authored by akyrtzi).
[APINotes] Fix build error with creating 'AvailabilityAttr', after upstream…
Oct 29 2019, 1:01 PM
akyrtzi committed rG952605f25b1a: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:56 PM
akyrtzi committed rGd2cbac0a9a43: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:56 PM
akyrtzi committed rG97b46aab9b05: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:56 PM
akyrtzi committed rG4f0e548493e7: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:55 PM