Oct 4 2019
I reverted this change due to the clang-x64-windows-msvc build bot failure.
You are correct that the locale is required to pass on linux. I had some trouble with this test as the behaviour of python in this area differs between linux / windows and python 2 / python 3. For example this fix appears to be fine for linux, however Windows with python 2 fails:
Oct 3 2019
Updated after Edd and Ruiu's suggestion.
Oct 1 2019
I asked because I want to make sure this patch is put up for practical use, not for a compatibility corner case that may rarely matter. I think most people may realize case insensitiveness on file systems is a bad idea. If my understanding is correct, llvm-lib used by Windows. llvm-ar is an ELF tool and it should match a generic ELF platform as close as possible and such platform disparity should be as little as possible.
Updated after rupprecht's suggestion.
Sep 30 2019
My understanding is that although NTFS is case sensitive, the windows API makes file operations case insensitive by default.
This is failing on the sphinx build bot:
Sep 27 2019
Sep 26 2019
Sep 25 2019
There are many tests in this area that use llvm-ar to test the underlying library. It may be better for these also to be in the llvm-ar test directory and have unit tests for specifically testing ArchiveWriter?
Sep 20 2019
Sep 19 2019
Sep 18 2019
Thanks for all the feedback. Regarding an error handler I think the introduction of an error handler could be left for another time.
Updated the test in line with suggested changes.
Sep 16 2019
Sep 11 2019
Aug 12 2019
I think it'd be good to also write a test that verifies the internal representation is always forward slashes on windows by running FileCheck directly on the thin archive instead of using llvm-ar t to look at it (e.g. see thin-archive.test). Or do we already have a test for that?
Aug 7 2019
Aug 5 2019
Jul 26 2019
Jul 24 2019
Jul 23 2019
Thanks rupprecht, I'll fix my clone before committing.
Jul 22 2019
I have not included a test for this change due to how large the test files would need to be.
Jul 17 2019
Jul 16 2019
Jul 10 2019
Simmilarly to D63197, I'm not sure if it's preferable to make this test XFAIL: darwin or explicitly call llvm-ar with --format=gnu. What do you think jfb?
I believe the test failure is based on an issue with output, specific to the darwin format:
Jul 9 2019
Thanks phosek and jfb, I will investigate this macOS issue.
Fixed a reapplied:
rG5d5078e341f5: [llvm-ar] Reapply Fix relative thin archive path handling
Jul 8 2019
Jul 5 2019
Jul 4 2019
Thanks for the comments MaskRay, I have updated the revision.
Jul 3 2019
Jul 1 2019
After MaskRay's suggestion I have removed all use of rm -f %t-*
Jun 28 2019
Jun 13 2019
Reverted in 363239 due to buildbot test failure