Page MenuHomePhabricator
Feed Advanced Search

Today

gbreynoo updated the diff for D68998: [docs][llvm-ar] Update llvm-ar command guide.

Fixed two format issues.

Thu, Oct 17, 7:58 AM · Restricted Project
gbreynoo added inline comments to D68998: [docs][llvm-ar] Update llvm-ar command guide.
Thu, Oct 17, 7:49 AM · Restricted Project
gbreynoo updated the diff for D68998: [docs][llvm-ar] Update llvm-ar command guide.

Renamed "Long Options" to "Other" and moved it below the other options, removed bad link to gnu-ar and updated with changes from D69087.

Thu, Oct 17, 7:39 AM · Restricted Project
gbreynoo accepted D69087: [llvm-ar] Implement the O modifier: display member offsets inside the archive.

LGTM

Thu, Oct 17, 4:01 AM · Restricted Project

Yesterday

gbreynoo added inline comments to D68998: [docs][llvm-ar] Update llvm-ar command guide.
Wed, Oct 16, 9:04 AM · Restricted Project
gbreynoo updated the diff for D68998: [docs][llvm-ar] Update llvm-ar command guide.

Fix nits, add missing options, remove old limitation and add information regarding deterministic archives.

Wed, Oct 16, 8:55 AM · Restricted Project
gbreynoo committed rG28a3b2aeb48f: [llvm-ar] Make paths case insensitive when on windows (authored by gbreynoo).
[llvm-ar] Make paths case insensitive when on windows
Wed, Oct 16, 7:11 AM
gbreynoo closed D68033: [llvm-ar] Make paths case insensitive when on windows.
Wed, Oct 16, 7:11 AM · Restricted Project
gbreynoo committed rL375002: [llvm-ar] Make paths case insensitive when on windows.
[llvm-ar] Make paths case insensitive when on windows
Wed, Oct 16, 7:11 AM
gbreynoo accepted D69007: [llvm-ar] Implement the V modifier as an alias for --version.

LGTM

Wed, Oct 16, 4:06 AM · Restricted Project

Tue, Oct 15

gbreynoo created D68998: [docs][llvm-ar] Update llvm-ar command guide.
Tue, Oct 15, 10:11 AM · Restricted Project
gbreynoo added inline comments to D68033: [llvm-ar] Make paths case insensitive when on windows.
Tue, Oct 15, 9:33 AM · Restricted Project
gbreynoo updated the diff for D68033: [llvm-ar] Make paths case insensitive when on windows.

Updated llvm-ar doc to clarify non-windows behaviour and why windows is not Unicode compliant.

Tue, Oct 15, 8:47 AM · Restricted Project

Fri, Oct 11

gbreynoo added inline comments to D68033: [llvm-ar] Make paths case insensitive when on windows.
Fri, Oct 11, 9:56 AM · Restricted Project
gbreynoo added a comment to D68033: [llvm-ar] Make paths case insensitive when on windows.

Due to updating the command guide I have not added the case insensitivity details to the llvm-ar help text. Would it be preferred to have these details in both?

Fri, Oct 11, 9:56 AM · Restricted Project
gbreynoo updated the diff for D68033: [llvm-ar] Make paths case insensitive when on windows.

Update llvm-ar command guide with case insensitivity details, and include a test for archived files with paths for names.

Fri, Oct 11, 9:56 AM · Restricted Project

Thu, Oct 10

gbreynoo added a comment to D68472: [test] Use system locale for mri-utf8.test.

I added the XFAIL to 3 llvm-ar tests I added earlier in the year, due to them failing on Darwin systems. See below:

Thu, Oct 10, 7:44 AM · Restricted Project

Tue, Oct 8

gbreynoo added a comment to D68472: [test] Use system locale for mri-utf8.test.

Thanks for adding the BOM. With the BOM, would it make sense to leave mri-utf8.test as the name of the file?

I think the testfile name should reflect what is being tested since that's the test identifier (ie. when a test fails lit prints the relative filepath) so the fact that the file is encoded in UTF-8 is irrelevant. Here the test is about llvm-ar handling non ascii filename, as the first comment explains it. How is the <pound sign>.txt file encoded would make a bit more sense as a name but then as I mentioned AFAIK the filename is encoded in UTF-16 on Windows anywat. In summary, I think the renaming is warranted.

Tue, Oct 8, 8:45 AM · Restricted Project
gbreynoo added a comment to D68472: [test] Use system locale for mri-utf8.test.

This functions on Windows fine.

Tue, Oct 8, 8:35 AM · Restricted Project
gbreynoo added inline comments to D68472: [test] Use system locale for mri-utf8.test.
Tue, Oct 8, 8:35 AM · Restricted Project
gbreynoo added inline comments to D68033: [llvm-ar] Make paths case insensitive when on windows.
Tue, Oct 8, 7:19 AM · Restricted Project
gbreynoo updated the diff for D68033: [llvm-ar] Make paths case insensitive when on windows.

Removed unneeded const, swapped use of ifndef and added comment to comparePaths function.

Tue, Oct 8, 6:42 AM · Restricted Project

Fri, Oct 4

gbreynoo committed rGe64369e76ea4: [llvm-ar][test] Clarified comment (authored by gbreynoo).
[llvm-ar][test] Clarified comment
Fri, Oct 4, 5:26 AM
gbreynoo committed rL373737: [llvm-ar][test] Clarified comment.
[llvm-ar][test] Clarified comment
Fri, Oct 4, 5:24 AM
gbreynoo added a comment to D68418: [test] Remove locale dependency for mri-utf8.test.

I reverted this change due to the clang-x64-windows-msvc build bot failure.

Fri, Oct 4, 4:13 AM · Restricted Project
gbreynoo committed rG4682b9c46b27: Revert [test] Remove locale dependency for mri-utf8.test (authored by gbreynoo).
Revert [test] Remove locale dependency for mri-utf8.test
Fri, Oct 4, 4:13 AM
gbreynoo committed rL373728: Revert [test] Remove locale dependency for mri-utf8.test.
Revert [test] Remove locale dependency for mri-utf8.test
Fri, Oct 4, 4:11 AM
gbreynoo added a comment to D68418: [test] Remove locale dependency for mri-utf8.test.

You are correct that the locale is required to pass on linux. I had some trouble with this test as the behaviour of python in this area differs between linux / windows and python 2 / python 3. For example this fix appears to be fine for linux, however Windows with python 2 fails:

Fri, Oct 4, 3:43 AM · Restricted Project

Thu, Oct 3

gbreynoo updated the diff for D68033: [llvm-ar] Make paths case insensitive when on windows.

Updated after Edd and Ruiu's suggestion.

Thu, Oct 3, 8:41 AM · Restricted Project

Tue, Oct 1

gbreynoo added inline comments to D68033: [llvm-ar] Make paths case insensitive when on windows.
Tue, Oct 1, 11:09 AM · Restricted Project
gbreynoo added a comment to D68033: [llvm-ar] Make paths case insensitive when on windows.

I asked because I want to make sure this patch is put up for practical use, not for a compatibility corner case that may rarely matter. I think most people may realize case insensitiveness on file systems is a bad idea. If my understanding is correct, llvm-lib used by Windows. llvm-ar is an ELF tool and it should match a generic ELF platform as close as possible and such platform disparity should be as little as possible.

Tue, Oct 1, 11:08 AM · Restricted Project
gbreynoo updated the diff for D68033: [llvm-ar] Make paths case insensitive when on windows.

Updated after rupprecht's suggestion.

Tue, Oct 1, 10:43 AM · Restricted Project

Mon, Sep 30

gbreynoo added a comment to D68033: [llvm-ar] Make paths case insensitive when on windows.

My understanding is that although NTFS is case sensitive, the windows API makes file operations case insensitive by default.

Mon, Sep 30, 7:31 AM · Restricted Project
gbreynoo added a comment to D67839: [FPEnv] Document requirement of function attributes with constrained floating point.

This is failing on the sphinx build bot:
lab.llvm.org:8011/builders/llvm-sphinx-docs

Mon, Sep 30, 6:33 AM · Restricted Project

Fri, Sep 27

gbreynoo added inline comments to D68033: [llvm-ar] Make paths case insensitive when on windows.
Fri, Sep 27, 11:13 AM · Restricted Project
gbreynoo updated the diff for D68033: [llvm-ar] Make paths case insensitive when on windows.
Fri, Sep 27, 11:05 AM · Restricted Project

Thu, Sep 26

gbreynoo committed rGb4e2d471f762: [llvm-ar][test] Move MRI tests from "llvm/test/Object/" (authored by gbreynoo).
[llvm-ar][test] Move MRI tests from "llvm/test/Object/"
Thu, Sep 26, 5:32 AM
gbreynoo committed rL372973: [llvm-ar][test] Move MRI tests from "llvm/test/Object/".
[llvm-ar][test] Move MRI tests from "llvm/test/Object/"
Thu, Sep 26, 5:30 AM
gbreynoo closed D68038: [llvm-ar][test] Move MRI tests from "llvm/test/Object/".
Thu, Sep 26, 5:30 AM · Restricted Project

Wed, Sep 25

gbreynoo added a comment to D68038: [llvm-ar][test] Move MRI tests from "llvm/test/Object/".

There are many tests in this area that use llvm-ar to test the underlying library. It may be better for these also to be in the llvm-ar test directory and have unit tests for specifically testing ArchiveWriter?

Wed, Sep 25, 10:36 AM · Restricted Project
gbreynoo created D68038: [llvm-ar][test] Move MRI tests from "llvm/test/Object/".
Wed, Sep 25, 10:30 AM · Restricted Project
gbreynoo created D68033: [llvm-ar] Make paths case insensitive when on windows.
Wed, Sep 25, 9:15 AM · Restricted Project
gbreynoo closed D47324: Add llvm-bcanalyzer as an LLD test dependency.
Wed, Sep 25, 5:44 AM · Restricted Project
gbreynoo abandoned D43942: [lld] Fix handling of output section selection for unmerged mergeable inputs and relocatable output.
Wed, Sep 25, 5:39 AM

Fri, Sep 20

gbreynoo committed rG25040f8dec2e: Reapply [llvm-ar] Include a line number when failing to parse an MRI script (authored by gbreynoo).
Reapply [llvm-ar] Include a line number when failing to parse an MRI script
Fri, Sep 20, 1:14 AM
gbreynoo committed rL372374: Reapply [llvm-ar] Include a line number when failing to parse an MRI script.
Reapply [llvm-ar] Include a line number when failing to parse an MRI script
Fri, Sep 20, 1:09 AM

Thu, Sep 19

gbreynoo committed rGaa03c14827fa: Revert [llvm-ar] Include a line number when failing to parse an MRI script (authored by gbreynoo).
Revert [llvm-ar] Include a line number when failing to parse an MRI script
Thu, Sep 19, 4:23 AM
gbreynoo committed rL372311: Revert [llvm-ar] Include a line number when failing to parse an MRI script.
Revert [llvm-ar] Include a line number when failing to parse an MRI script
Thu, Sep 19, 4:23 AM
gbreynoo committed rG04398c729b20: [llvm-ar] Include a line number when failing to parse an MRI script (authored by gbreynoo).
[llvm-ar] Include a line number when failing to parse an MRI script
Thu, Sep 19, 3:55 AM
gbreynoo committed rL372309: [llvm-ar] Include a line number when failing to parse an MRI script.
[llvm-ar] Include a line number when failing to parse an MRI script
Thu, Sep 19, 3:55 AM
gbreynoo closed D67449: [llvm-ar] Include a line number when failing to parse an MRI script.
Thu, Sep 19, 3:55 AM · Restricted Project

Wed, Sep 18

gbreynoo added a comment to D67449: [llvm-ar] Include a line number when failing to parse an MRI script.

Thanks for all the feedback. Regarding an error handler I think the introduction of an error handler could be left for another time.

Wed, Sep 18, 6:16 AM · Restricted Project
gbreynoo updated the diff for D67449: [llvm-ar] Include a line number when failing to parse an MRI script.

Updated the test in line with suggested changes.

Wed, Sep 18, 6:08 AM · Restricted Project

Sep 16 2019

gbreynoo committed rL372003: Request github commit access for gbreynoo.
Request github commit access for gbreynoo
Sep 16 2019, 8:27 AM

Sep 11 2019

gbreynoo created D67449: [llvm-ar] Include a line number when failing to parse an MRI script.
Sep 11 2019, 8:12 AM · Restricted Project

Aug 12 2019

gbreynoo added a comment to D65743: [llvm-ar] Accept file paths with windows format slashes.

I think it'd be good to also write a test that verifies the internal representation is always forward slashes on windows by running FileCheck directly on the thin archive instead of using llvm-ar t to look at it (e.g. see thin-archive.test). Or do we already have a test for that?

Aug 12 2019, 7:02 AM · Restricted Project
gbreynoo committed rG47298393d2e4: [llvm-ar] Accept file paths with windows format slashes (authored by gbreynoo).
[llvm-ar] Accept file paths with windows format slashes
Aug 12 2019, 7:01 AM
gbreynoo committed rL368573: [llvm-ar] Accept file paths with windows format slashes.
[llvm-ar] Accept file paths with windows format slashes
Aug 12 2019, 6:59 AM
gbreynoo closed D65743: [llvm-ar] Accept file paths with windows format slashes.
Aug 12 2019, 6:59 AM · Restricted Project
gbreynoo committed rG20b2cd3c0bfe: [llvm-ar][test] Correct tests marked as expected fails (authored by gbreynoo).
[llvm-ar][test] Correct tests marked as expected fails
Aug 12 2019, 6:04 AM
gbreynoo committed rL368564: [llvm-ar][test] Correct tests marked as expected fails.
[llvm-ar][test] Correct tests marked as expected fails
Aug 12 2019, 6:04 AM
gbreynoo closed D65745: [llvm-ar][test] Correct tests marked as expected fails.
Aug 12 2019, 6:04 AM · Restricted Project

Aug 7 2019

gbreynoo added inline comments to D65743: [llvm-ar] Accept file paths with windows format slashes.
Aug 7 2019, 8:03 AM · Restricted Project
gbreynoo updated the diff for D65743: [llvm-ar] Accept file paths with windows format slashes.
Aug 7 2019, 8:01 AM · Restricted Project
gbreynoo added inline comments to rG629273ec0982: [llvm-ar][test] Add tests failing on Darwin.
Aug 7 2019, 7:14 AM

Aug 5 2019

gbreynoo created D65745: [llvm-ar][test] Correct tests marked as expected fails.
Aug 5 2019, 6:58 AM · Restricted Project
gbreynoo created D65743: [llvm-ar] Accept file paths with windows format slashes.
Aug 5 2019, 6:18 AM · Restricted Project

Jul 26 2019

gbreynoo added a comment to D64802: [llvm-ar][test] Add tests failing on Darwin.

Hi James,

Jul 26 2019, 9:44 AM · Restricted Project

Jul 24 2019

gbreynoo committed rG18c267135225: [llvm-ar][test] Fix move operation tests (authored by gbreynoo).
[llvm-ar][test] Fix move operation tests
Jul 24 2019, 7:27 AM
gbreynoo committed rL366908: [llvm-ar][test] Fix move operation tests.
[llvm-ar][test] Fix move operation tests
Jul 24 2019, 7:25 AM

Jul 23 2019

gbreynoo committed rG24f3e102a678: [llvm-ar] Fix support for archives with members larger than 4GB (authored by gbreynoo).
[llvm-ar] Fix support for archives with members larger than 4GB
Jul 23 2019, 7:47 AM
gbreynoo committed rL366813: [llvm-ar] Fix support for archives with members larger than 4GB.
[llvm-ar] Fix support for archives with members larger than 4GB
Jul 23 2019, 7:44 AM
gbreynoo closed D65093: [llvm-ar] Fix support for archives with members larger than 4GB.
Jul 23 2019, 7:44 AM · Restricted Project
gbreynoo added a comment to D65093: [llvm-ar] Fix support for archives with members larger than 4GB.

Thanks rupprecht, I'll fix my clone before committing.

Jul 23 2019, 4:09 AM · Restricted Project

Jul 22 2019

gbreynoo added inline comments to D65093: [llvm-ar] Fix support for archives with members larger than 4GB.
Jul 22 2019, 8:10 AM · Restricted Project
gbreynoo added a comment to D65093: [llvm-ar] Fix support for archives with members larger than 4GB.

I have not included a test for this change due to how large the test files would need to be.

Jul 22 2019, 7:57 AM · Restricted Project
gbreynoo created D65093: [llvm-ar] Fix support for archives with members larger than 4GB.
Jul 22 2019, 7:26 AM · Restricted Project

Jul 17 2019

gbreynoo committed rG629273ec0982: [llvm-ar][test] Add tests failing on Darwin (authored by gbreynoo).
[llvm-ar][test] Add tests failing on Darwin
Jul 17 2019, 8:12 AM
gbreynoo committed rL366334: [llvm-ar][test] Add tests failing on Darwin.
[llvm-ar][test] Add tests failing on Darwin
Jul 17 2019, 8:09 AM
gbreynoo closed D64802: [llvm-ar][test] Add tests failing on Darwin.
Jul 17 2019, 8:09 AM · Restricted Project
gbreynoo added inline comments to D64802: [llvm-ar][test] Add tests failing on Darwin.
Jul 17 2019, 8:04 AM · Restricted Project
gbreynoo committed rG247add6f3a37: [llvm-ar][test] Add coverage for replace and update key letters (authored by gbreynoo).
[llvm-ar][test] Add coverage for replace and update key letters
Jul 17 2019, 3:20 AM
gbreynoo committed rL366309: [llvm-ar][test] Add coverage for replace and update key letters.
[llvm-ar][test] Add coverage for replace and update key letters
Jul 17 2019, 3:20 AM
gbreynoo closed D64803: [llvm-ar][test] Add coverage for replace and update key letters.
Jul 17 2019, 3:20 AM · Restricted Project

Jul 16 2019

gbreynoo created D64803: [llvm-ar][test] Add coverage for replace and update key letters.
Jul 16 2019, 9:03 AM · Restricted Project
gbreynoo created D64802: [llvm-ar][test] Add tests failing on Darwin.
Jul 16 2019, 8:58 AM · Restricted Project
gbreynoo committed rG8e482eb5cbb8: [llvm-ar][test] Add to llvm-ar test coverage (authored by gbreynoo).
[llvm-ar][test] Add to llvm-ar test coverage
Jul 16 2019, 7:29 AM
gbreynoo committed rL366209: [llvm-ar][test] Add to llvm-ar test coverage.
[llvm-ar][test] Add to llvm-ar test coverage
Jul 16 2019, 7:29 AM
gbreynoo closed D64330: [llvm-ar][test] Add to llvm-ar test coverage .
Jul 16 2019, 7:29 AM · Restricted Project
gbreynoo committed rG3a6aaa4391f0: Reapply [llvm-ar][test] Increase llvm-ar test coverage (authored by gbreynoo).
Reapply [llvm-ar][test] Increase llvm-ar test coverage
Jul 16 2019, 5:57 AM
gbreynoo committed rL366206: Reapply [llvm-ar][test] Increase llvm-ar test coverage.
Reapply [llvm-ar][test] Increase llvm-ar test coverage
Jul 16 2019, 5:56 AM
gbreynoo committed rG971ac4ca2cb8: Reapply [llvm-ar][test] Add to MRI test coverage (authored by gbreynoo).
Reapply [llvm-ar][test] Add to MRI test coverage
Jul 16 2019, 4:03 AM
gbreynoo committed rL366201: Reapply [llvm-ar][test] Add to MRI test coverage.
Reapply [llvm-ar][test] Add to MRI test coverage
Jul 16 2019, 4:01 AM

Jul 10 2019

gbreynoo updated the diff for D64330: [llvm-ar][test] Add to llvm-ar test coverage .
Jul 10 2019, 8:37 AM · Restricted Project
gbreynoo added a comment to D63935: [llvm-ar][test] Increase llvm-ar test coverage.

Simmilarly to D63197, I'm not sure if it's preferable to make this test XFAIL: darwin or explicitly call llvm-ar with --format=gnu. What do you think jfb?

Jul 10 2019, 7:37 AM · Restricted Project
gbreynoo added a comment to D63197: [llvm-ar][test] Add to MRI test coverage .

I believe the test failure is based on an issue with output, specific to the darwin format:

Jul 10 2019, 7:34 AM · Restricted Project

Jul 9 2019

gbreynoo retitled D64330: [llvm-ar][test] Add to llvm-ar test coverage from [llvm-ar][test] Add to MRI test coverage to [llvm-ar][test] Add to llvm-ar test coverage .
Jul 9 2019, 11:03 AM · Restricted Project
gbreynoo added a comment to D63935: [llvm-ar][test] Increase llvm-ar test coverage.

Thanks phosek and jfb, I will investigate this macOS issue.

Jul 9 2019, 3:34 AM · Restricted Project
gbreynoo added a comment to D59491: Fix relative thin archive path handling.

Fixed a reapplied:
rG5d5078e341f5: [llvm-ar] Reapply Fix relative thin archive path handling

Jul 9 2019, 3:27 AM · Restricted Project

Jul 8 2019

gbreynoo created D64330: [llvm-ar][test] Add to llvm-ar test coverage .
Jul 8 2019, 6:49 AM · Restricted Project