Page MenuHomePhabricator
Feed Advanced Search

Wed, Jul 1

gbreynoo committed rG41ca82cbe815: [llvm-size] Output REL, RELA and STRTAB sections when allocatable (authored by gbreynoo).
[llvm-size] Output REL, RELA and STRTAB sections when allocatable
Wed, Jul 1, 4:18 AM
gbreynoo closed D82479: [llvm-size] Output REL, RELA and STRTAB sections in some cases.
Wed, Jul 1, 4:18 AM · Restricted Project

Fri, Jun 26

gbreynoo updated the diff for D82479: [llvm-size] Output REL, RELA and STRTAB sections in some cases.
Fri, Jun 26, 10:23 AM · Restricted Project
gbreynoo updated the diff for D82479: [llvm-size] Output REL, RELA and STRTAB sections in some cases.

Thanks for the comments Grimar. I have removed the check specifically for .shstrtab as it should not have the SHF_ALLOC flag anyway and simplified the area as suggested.

Fri, Jun 26, 10:22 AM · Restricted Project

Thu, Jun 25

gbreynoo added a comment to D82479: [llvm-size] Output REL, RELA and STRTAB sections in some cases.

There may be some confusion on my part. My understanding is that size is used to measure the memory footprint whilst there are other utilities for viewing information regarding the files themselves. See https://bugs.llvm.org/show_bug.cgi?id=46299 for a bug involving the use of size and the expectation of its output.

Thu, Jun 25, 9:40 AM · Restricted Project

Wed, Jun 24

gbreynoo created D82479: [llvm-size] Output REL, RELA and STRTAB sections in some cases.
Wed, Jun 24, 10:15 AM · Restricted Project

Wed, Jun 10

gbreynoo committed rGbe44b7925722: [lld][test] Expand testing for dynamic-list and export-dynamic (authored by gbreynoo).
[lld][test] Expand testing for dynamic-list and export-dynamic
Wed, Jun 10, 6:32 AM
gbreynoo closed D80311: [lld][test] Expand testing for dynamic-list and export-dynamic.
Wed, Jun 10, 6:32 AM · Restricted Project

Tue, Jun 9

gbreynoo added a comment to D80311: [lld][test] Expand testing for dynamic-list and export-dynamic.

Thanks again MaskRay, to avoid confusion surrounding the term "type" I have renamed the test export-symbols and removed the list of symbols, a number of new uses of weak symbols have also been added to the test. I have also split dynamic-list-cpp into a new test due to the dynamic-list-glob.s name change.

Tue, Jun 9, 9:19 AM · Restricted Project
gbreynoo updated the diff for D80311: [lld][test] Expand testing for dynamic-list and export-dynamic.
  • Fixed use of %t.elf
Tue, Jun 9, 9:19 AM · Restricted Project
gbreynoo updated the diff for D80311: [lld][test] Expand testing for dynamic-list and export-dynamic.
Tue, Jun 9, 8:46 AM · Restricted Project
gbreynoo updated the diff for D80311: [lld][test] Expand testing for dynamic-list and export-dynamic.
  • Corrected use of pattern with entry
  • Renamed dynamic-list-patterns.s
  • Removed changes to export-dynamic-symbol.s
  • Change input file names
  • Updated quotes
Tue, Jun 9, 8:46 AM · Restricted Project

Jun 1 2020

gbreynoo added a comment to D80311: [lld][test] Expand testing for dynamic-list and export-dynamic.

Thanks for the comments Maskray. I had some questions regarding the comments for expanding the test for use of -shared and the similarities with dynsym-pie.s, symbols.s and visibility.s. My intention with the test export-symbol-types.s was to confirm the symbols types that are placed in the dynamic symbol table with use of --export-dynamic and --dynamic-list. I considered the other tests mentioned as covering related but different functionality using similar methods. For example symbol.s being for correct symbol output as a whole, not specifically exports etc.

Jun 1 2020, 11:18 AM · Restricted Project
gbreynoo updated the diff for D80311: [lld][test] Expand testing for dynamic-list and export-dynamic.

Fixed use of echo

Jun 1 2020, 11:18 AM · Restricted Project
gbreynoo updated the diff for D80311: [lld][test] Expand testing for dynamic-list and export-dynamic.

Made the following changes:

  • Fixed up a comment
  • Added x86 requirement
  • Changed the creation of the dynamic list in export-symbol-types.s
  • Made file names more consistent
  • Use CHECK-NEXT
  • Use ABS for abs
  • rename symbol
Jun 1 2020, 10:46 AM · Restricted Project
gbreynoo added a comment to D80838: [llvm-ar] Add more tests for errors in opening archives.

The test you have modified is for testing the "p" (print) operation, but your new test cases are not really about that option, but rather about generic file handling. I'm not convinced they belong in this test file, but @gbreynoo might have other opinions, since he's the one who's been working on the llvm-ar testing recently.

Could you clarify why you are adding these test cases? I don't think the behaviour is really part of llvm-ar, but rather part of the underlying support libraries which control when a file can be opened or not.

Jun 1 2020, 8:00 AM · Restricted Project

May 22 2020

gbreynoo added inline comments to D80311: [lld][test] Expand testing for dynamic-list and export-dynamic.
May 22 2020, 9:05 AM · Restricted Project
gbreynoo updated the diff for D80311: [lld][test] Expand testing for dynamic-list and export-dynamic.

Changes based on MaskRay's comments:

  • Replace use of --dyn-symbols with --dynsyms
  • Remove use of -unknown-linux
  • Correct use of quotes
May 22 2020, 9:05 AM · Restricted Project

May 21 2020

gbreynoo added a comment to D80311: [lld][test] Expand testing for dynamic-list and export-dynamic.

Thanks MaskRay, I was not aware of that.

May 21 2020, 8:36 AM · Restricted Project
gbreynoo updated the diff for D80311: [lld][test] Expand testing for dynamic-list and export-dynamic.

Changes based on grimars comments:

  • Corrected white space and comments
  • Replaced the use of input file "Inputs/export-symbol-types.s" with use of echo
May 21 2020, 8:35 AM · Restricted Project

May 20 2020

gbreynoo created D80311: [lld][test] Expand testing for dynamic-list and export-dynamic.
May 20 2020, 10:22 AM · Restricted Project

Mar 26 2020

gbreynoo committed rGa945037e8fd0: Tools emit the bug report URL on crash (authored by gbreynoo).
Tools emit the bug report URL on crash
Mar 26 2020, 3:45 AM
gbreynoo closed D74324: Tools emit the bug report URL on crash.
Mar 26 2020, 3:45 AM · Restricted Project, Restricted Project

Mar 25 2020

gbreynoo updated the diff for D74324: Tools emit the bug report URL on crash.

Apologies James, this fixes the case issues.

Mar 25 2020, 4:50 AM · Restricted Project, Restricted Project

Mar 23 2020

gbreynoo updated the diff for D74324: Tools emit the bug report URL on crash.

Changes made in response to James' comments

Mar 23 2020, 12:00 PM · Restricted Project, Restricted Project
gbreynoo added inline comments to D74324: Tools emit the bug report URL on crash.
Mar 23 2020, 12:00 PM · Restricted Project, Restricted Project

Mar 19 2020

gbreynoo added a comment to D74324: Tools emit the bug report URL on crash.

Thanks Paul.

Mar 19 2020, 8:40 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D74324: Tools emit the bug report URL on crash.

After Paul's comment, a custom message can now be used to replace the generic one.

Mar 19 2020, 8:37 AM · Restricted Project, Restricted Project

Mar 11 2020

gbreynoo added reviewers for D74324: Tools emit the bug report URL on crash: bogner, bruno.

Hi James,

Mar 11 2020, 8:31 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D74324: Tools emit the bug report URL on crash.

Removed Clangs use of the same message.

Mar 11 2020, 8:31 AM · Restricted Project, Restricted Project

Mar 4 2020

gbreynoo committed rG5e0f9d5d3c6b: [llvm-ar][test] Add to llvm-ar test coverage (authored by gbreynoo).
[llvm-ar][test] Add to llvm-ar test coverage
Mar 4 2020, 3:28 AM
gbreynoo closed D73333: [llvm-ar][test] Add to llvm-ar test coverage .
Mar 4 2020, 3:27 AM · Restricted Project
gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

Hi sbc100, thanks for highlighting this inconsistency. I think ideally for the sake of consistency, wasm-ld and clang would be updated too. I wonder if it would be worth the effort to have some kind of shared implementation for this?

Mar 4 2020, 1:13 AM · Restricted Project

Mar 3 2020

gbreynoo committed rG62fa3332c9c1: [llvm-ar] Fix llvm-ar response file reading on Windows (authored by gbreynoo).
[llvm-ar] Fix llvm-ar response file reading on Windows
Mar 3 2020, 5:46 AM
gbreynoo closed D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Mar 3 2020, 5:45 AM · Restricted Project

Mar 2 2020

gbreynoo added a reviewer for D74324: Tools emit the bug report URL on crash: jhenderson.
Mar 2 2020, 8:29 AM · Restricted Project, Restricted Project
gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

ping

Mar 2 2020, 5:29 AM · Restricted Project

Feb 24 2020

gbreynoo added inline comments to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Feb 24 2020, 7:53 AM · Restricted Project
gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
  • Removed unused function removeHyphens
  • Fixed matchFlagWithArg so 3 hyphens are no longer excepted before an argument
  • getRspQuoting now uses ArraryRef instead of SmallVector
Feb 24 2020, 7:53 AM · Restricted Project

Feb 21 2020

gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

ping

Feb 21 2020, 6:51 AM · Restricted Project
gbreynoo added a comment to D74324: Tools emit the bug report URL on crash.

ping

Feb 21 2020, 4:17 AM · Restricted Project, Restricted Project
gbreynoo added a reviewer for D74324: Tools emit the bug report URL on crash: dsanders.
Feb 21 2020, 4:17 AM · Restricted Project, Restricted Project

Feb 18 2020

gbreynoo added a comment to D74599: llvm-ar: Fix MinGW compilation.

I agree with mstorsjo, matching what what LLVM is documented to require seems best.
LGTM

Feb 18 2020, 7:39 AM · Restricted Project

Feb 14 2020

gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

Thanks Maskray for your comment regarding marking comments as "done", I'll look out for that in future.

Feb 14 2020, 5:46 AM · Restricted Project
gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

Inlined removeHyphens function

Feb 14 2020, 5:46 AM · Restricted Project
gbreynoo added inline comments to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Feb 14 2020, 5:38 AM · Restricted Project

Feb 13 2020

gbreynoo added a reviewer for D74324: Tools emit the bug report URL on crash: chandlerc.
Feb 13 2020, 5:41 AM · Restricted Project, Restricted Project

Feb 10 2020

gbreynoo created D74324: Tools emit the bug report URL on crash.
Feb 10 2020, 6:44 AM · Restricted Project, Restricted Project
gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

ping

Feb 10 2020, 6:05 AM · Restricted Project

Jan 24 2020

gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

ping

Jan 24 2020, 1:00 AM · Restricted Project
gbreynoo created D73333: [llvm-ar][test] Add to llvm-ar test coverage .
Jan 24 2020, 1:00 AM · Restricted Project
gbreynoo added a child revision for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows: D73333: [llvm-ar][test] Add to llvm-ar test coverage .
Jan 24 2020, 1:00 AM · Restricted Project

Jan 16 2020

gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

The use of python in the test response.test was failing on my Windows machine with Python 3. This patch fixes the issue.

Jan 16 2020, 9:44 AM · Restricted Project
gbreynoo added inline comments to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Jan 16 2020, 9:44 AM · Restricted Project
gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
  • Use single quotes in tests
  • Clarify use of echo in response.test
Jan 16 2020, 9:34 AM · Restricted Project

Jan 10 2020

gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

ping

Jan 10 2020, 5:47 AM · Restricted Project

Jan 2 2020

gbreynoo added inline comments to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Jan 2 2020, 9:19 AM · Restricted Project
gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
  • Removed --rsp-quoting=default
    • Reverted rename of Options
    • Removed use of using
Jan 2 2020, 9:10 AM · Restricted Project

Dec 12 2019

gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

ping

Dec 12 2019, 8:23 AM · Restricted Project

Dec 4 2019

gbreynoo added inline comments to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Dec 4 2019, 10:59 AM · Restricted Project
gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

Fixed:

  • Redundant pair of braces
  • space after ,
  • indent the continuation lines
Dec 4 2019, 10:19 AM · Restricted Project
gbreynoo committed rG8c1e1d148273: [llvm-ar][test] Add to thin archive test coverage (authored by gbreynoo).
[llvm-ar][test] Add to thin archive test coverage
Dec 4 2019, 8:27 AM
gbreynoo closed D70969: [llvm-ar][test] Add to thin archive test coverage .
Dec 4 2019, 8:27 AM · Restricted Project

Dec 3 2019

gbreynoo created D70969: [llvm-ar][test] Add to thin archive test coverage .
Dec 3 2019, 10:05 AM · Restricted Project
gbreynoo added inline comments to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Dec 3 2019, 9:28 AM · Restricted Project
gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
  • Use using instead of typedef
  • removeHyphens is now called from matchFlagWithArg
  • Removed Argv reference argument from getRspQuoting
  • Fix response.test that failed on linux
Dec 3 2019, 8:50 AM · Restricted Project

Nov 22 2019

gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
  • Pulled out the MatchFlagWithArg lambda expression into static function, and done the same with some code that handles hyphen removal.
  • Added test cases to response.test.
  • Removed the python call in response-utf8.test. I would prefer the file comparison but it should be sufficient to show the archive is functioning properly.
Nov 22 2019, 9:31 AM · Restricted Project

Nov 13 2019

gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

Added rsp-quoting switch as thopre requested.

Nov 13 2019, 3:38 AM · Restricted Project

Nov 4 2019

gbreynoo added inline comments to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Nov 4 2019, 6:00 AM · Restricted Project

Oct 31 2019

gbreynoo created D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Oct 31 2019, 9:05 AM · Restricted Project
gbreynoo set the repository for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows to rL LLVM.
Oct 31 2019, 9:05 AM · Restricted Project

Oct 25 2019

gbreynoo added a reviewer for D69418: [llvm-ar] Add output option for extract operation: ruiu.

This looks good to me, although with llvm-ar there is a balance between adding useful functionality and keeping command compatibility with other archivers. I've added Rui as a reviewer in case.

Oct 25 2019, 3:15 AM · Restricted Project

Oct 24 2019

gbreynoo abandoned D69343: [llvm-ar] Allow MRI scripts to be passed via command line argument .

Rui makes good points that I struggle to argue with. I'll abandon this review as their is no interest.

Oct 24 2019, 5:53 AM · Restricted Project

Oct 23 2019

gbreynoo created D69343: [llvm-ar] Allow MRI scripts to be passed via command line argument .
Oct 23 2019, 8:42 AM · Restricted Project

Oct 21 2019

gbreynoo committed rGfe263c4f0f8b: [docs][llvm-ar] Update llvm-ar command guide (authored by gbreynoo).
[docs][llvm-ar] Update llvm-ar command guide
Oct 21 2019, 6:16 AM
gbreynoo committed rL375412: [docs][llvm-ar] Update llvm-ar command guide.
[docs][llvm-ar] Update llvm-ar command guide
Oct 21 2019, 6:16 AM
gbreynoo closed D68998: [docs][llvm-ar] Update llvm-ar command guide.
Oct 21 2019, 6:16 AM · Restricted Project

Oct 17 2019

gbreynoo updated the diff for D68998: [docs][llvm-ar] Update llvm-ar command guide.

Fixed two format issues.

Oct 17 2019, 7:58 AM · Restricted Project
gbreynoo added inline comments to D68998: [docs][llvm-ar] Update llvm-ar command guide.
Oct 17 2019, 7:49 AM · Restricted Project
gbreynoo updated the diff for D68998: [docs][llvm-ar] Update llvm-ar command guide.

Renamed "Long Options" to "Other" and moved it below the other options, removed bad link to gnu-ar and updated with changes from D69087.

Oct 17 2019, 7:39 AM · Restricted Project
gbreynoo accepted D69087: [llvm-ar] Implement the O modifier: display member offsets inside the archive.

LGTM

Oct 17 2019, 4:01 AM · Restricted Project

Oct 16 2019

gbreynoo added inline comments to D68998: [docs][llvm-ar] Update llvm-ar command guide.
Oct 16 2019, 9:04 AM · Restricted Project
gbreynoo updated the diff for D68998: [docs][llvm-ar] Update llvm-ar command guide.

Fix nits, add missing options, remove old limitation and add information regarding deterministic archives.

Oct 16 2019, 8:55 AM · Restricted Project
gbreynoo committed rG28a3b2aeb48f: [llvm-ar] Make paths case insensitive when on windows (authored by gbreynoo).
[llvm-ar] Make paths case insensitive when on windows
Oct 16 2019, 7:11 AM
gbreynoo closed D68033: [llvm-ar] Make paths case insensitive when on windows.
Oct 16 2019, 7:11 AM · Restricted Project
gbreynoo committed rL375002: [llvm-ar] Make paths case insensitive when on windows.
[llvm-ar] Make paths case insensitive when on windows
Oct 16 2019, 7:11 AM
gbreynoo accepted D69007: [llvm-ar] Implement the V modifier as an alias for --version.

LGTM

Oct 16 2019, 4:06 AM · Restricted Project

Oct 15 2019

gbreynoo created D68998: [docs][llvm-ar] Update llvm-ar command guide.
Oct 15 2019, 10:11 AM · Restricted Project
gbreynoo added inline comments to D68033: [llvm-ar] Make paths case insensitive when on windows.
Oct 15 2019, 9:33 AM · Restricted Project
gbreynoo updated the diff for D68033: [llvm-ar] Make paths case insensitive when on windows.

Updated llvm-ar doc to clarify non-windows behaviour and why the windows file system is not Unicode compliant.

Oct 15 2019, 8:47 AM · Restricted Project

Oct 11 2019

gbreynoo added inline comments to D68033: [llvm-ar] Make paths case insensitive when on windows.
Oct 11 2019, 9:56 AM · Restricted Project
gbreynoo added a comment to D68033: [llvm-ar] Make paths case insensitive when on windows.

Due to updating the command guide I have not added the case insensitivity details to the llvm-ar help text. Would it be preferred to have these details in both? Also the test name "path-names" feels awkward, if anyone has a better suggestion I would be happy to change it.

Oct 11 2019, 9:56 AM · Restricted Project
gbreynoo updated the diff for D68033: [llvm-ar] Make paths case insensitive when on windows.

Update llvm-ar command guide with case insensitivity details, and include a test for archived files with paths for names.

Oct 11 2019, 9:56 AM · Restricted Project

Oct 10 2019

gbreynoo added a comment to D68472: [test] Use system locale for mri-utf8.test.

I added the XFAIL to 3 llvm-ar tests I added earlier in the year, due to them failing on Darwin systems. See below:

Oct 10 2019, 7:44 AM · Restricted Project

Oct 8 2019

gbreynoo added a comment to D68472: [test] Use system locale for mri-utf8.test.

Thanks for adding the BOM. With the BOM, would it make sense to leave mri-utf8.test as the name of the file?

I think the testfile name should reflect what is being tested since that's the test identifier (ie. when a test fails lit prints the relative filepath) so the fact that the file is encoded in UTF-8 is irrelevant. Here the test is about llvm-ar handling non ascii filename, as the first comment explains it. How is the <pound sign>.txt file encoded would make a bit more sense as a name but then as I mentioned AFAIK the filename is encoded in UTF-16 on Windows anywat. In summary, I think the renaming is warranted.

Oct 8 2019, 8:45 AM · Restricted Project
gbreynoo added a comment to D68472: [test] Use system locale for mri-utf8.test.

This functions on Windows fine.

Oct 8 2019, 8:35 AM · Restricted Project
gbreynoo added inline comments to D68472: [test] Use system locale for mri-utf8.test.
Oct 8 2019, 8:35 AM · Restricted Project
gbreynoo added inline comments to D68033: [llvm-ar] Make paths case insensitive when on windows.
Oct 8 2019, 7:19 AM · Restricted Project
gbreynoo updated the diff for D68033: [llvm-ar] Make paths case insensitive when on windows.

Removed unneeded const, swapped use of ifndef and added comment to comparePaths function.

Oct 8 2019, 6:42 AM · Restricted Project

Oct 4 2019

gbreynoo committed rGe64369e76ea4: [llvm-ar][test] Clarified comment (authored by gbreynoo).
[llvm-ar][test] Clarified comment
Oct 4 2019, 5:26 AM