Page MenuHomePhabricator
Feed Advanced Search

Tue, Jul 27

zsrkmyn added a comment to D106751: [OpenMP][Libomptarget] Adding `print_device_info` to RTL and `omptarget`.

Thanks for quickly fixing it :-)

Tue, Jul 27, 10:49 PM · Restricted Project
zsrkmyn added inline comments to D106751: [OpenMP][Libomptarget] Adding `print_device_info` to RTL and `omptarget`.
Tue, Jul 27, 9:05 PM · Restricted Project
zsrkmyn added inline comments to D106751: [OpenMP][Libomptarget] Adding `print_device_info` to RTL and `omptarget`.
Tue, Jul 27, 8:35 PM · Restricted Project
zsrkmyn added inline comments to D106751: [OpenMP][Libomptarget] Adding `print_device_info` to RTL and `omptarget`.
Tue, Jul 27, 8:19 PM · Restricted Project

Mon, Jul 26

zsrkmyn added a comment to D106334: Initialize common options in `getRegisteredOptions`.

Test added ;-)

Mon, Jul 26, 5:28 AM · Restricted Project
zsrkmyn updated the diff for D106334: Initialize common options in `getRegisteredOptions`.
Mon, Jul 26, 5:27 AM · Restricted Project

Tue, Jul 20

zsrkmyn added a comment to D106334: Initialize common options in `getRegisteredOptions`.

I'm guessing even if it were, it might not solve our problems though, since the variables are local statics, so resetting wouldn't cause them to be reinstantiated...

Tue, Jul 20, 1:08 AM · Restricted Project

Mon, Jul 19

zsrkmyn added a comment to D106334: Initialize common options in `getRegisteredOptions`.

I'm not sure if we need a test for it. I tried to add one but the test passed even without this patch, as those options were already initialized before running the test.

Mon, Jul 19, 7:40 PM · Restricted Project
zsrkmyn requested review of D106334: Initialize common options in `getRegisteredOptions`.
Mon, Jul 19, 7:38 PM · Restricted Project

May 16 2021

zsrkmyn added a comment to D101135: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives.

Would you mind helping me commit this patch if there's no further comment? Thanks :-)

May 16 2021, 6:40 PM · Restricted Project

May 12 2021

zsrkmyn updated the diff for D101135: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives.
May 12 2021, 1:38 AM · Restricted Project

Apr 25 2021

zsrkmyn added a comment to D101135: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives.

Note, many prefixes are not called CHECK*...

Apr 25 2021, 8:41 PM · Restricted Project

Apr 22 2021

zsrkmyn requested review of D101135: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives.
Apr 22 2021, 11:08 PM · Restricted Project

Mar 19 2021

zsrkmyn added a comment to D98927: [Utils][vim] Highlight `poison` keyword.

Would you mind helping me commit it? Thanks! :-D

Mar 19 2021, 6:51 PM · Restricted Project
zsrkmyn requested review of D98927: [Utils][vim] Highlight `poison` keyword.
Mar 19 2021, 12:56 AM · Restricted Project

Apr 20 2020

Herald added a reviewer for D63291: [RFC] Initial patch to support IR extensions for annotating directive region entry/exit : jdoerfert.
Apr 20 2020, 1:34 AM · Restricted Project

Nov 25 2019

zsrkmyn updated the diff for D70671: [clang][CodeGen] Fix wrong memcpy size of no_unique_address in FieldMemcpyizer.

Thanks for reviewing! Would you mind helping me commit this patch? Thanks :-D

Nov 25 2019, 5:43 PM · Restricted Project
zsrkmyn added a reviewer for D70671: [clang][CodeGen] Fix wrong memcpy size of no_unique_address in FieldMemcpyizer: rsmith.
Nov 25 2019, 9:14 AM · Restricted Project
zsrkmyn created D70671: [clang][CodeGen] Fix wrong memcpy size of no_unique_address in FieldMemcpyizer.
Nov 25 2019, 7:06 AM · Restricted Project

Sep 10 2019

zsrkmyn added a comment to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.

All done IMO. :-) Thank Erich a lot for reviewing! Would you mind helping me commit it?

Sep 10 2019, 10:55 AM · Restricted Project, Restricted Project
zsrkmyn updated the diff for D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 10 2019, 10:44 AM · Restricted Project, Restricted Project
zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 10 2019, 9:19 AM · Restricted Project, Restricted Project
zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 10 2019, 8:46 AM · Restricted Project, Restricted Project
zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 10 2019, 2:13 AM · Restricted Project, Restricted Project

Sep 7 2019

zsrkmyn added a comment to D67206: [ELF][MC] Fix IFunc alias resolving issue.

Thank @MaskRay for reviewing. Would you mind helping me commit it? :-)

Sep 7 2019, 6:25 AM · Restricted Project
zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 7 2019, 12:50 AM · Restricted Project, Restricted Project
zsrkmyn updated the diff for D67206: [ELF][MC] Fix IFunc alias resolving issue.
Sep 7 2019, 12:27 AM · Restricted Project

Sep 6 2019

zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 6 2019, 8:16 AM · Restricted Project, Restricted Project
zsrkmyn updated the diff for D67206: [ELF][MC] Fix IFunc alias resolving issue.
Sep 6 2019, 1:57 AM · Restricted Project
zsrkmyn updated the diff for D67206: [ELF][MC] Fix IFunc alias resolving issue.
Sep 6 2019, 1:55 AM · Restricted Project
zsrkmyn updated the diff for D67206: [ELF][MC] Fix IFunc alias resolving issue.
Sep 6 2019, 12:53 AM · Restricted Project

Sep 5 2019

zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 5 2019, 8:35 PM · Restricted Project, Restricted Project
zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 5 2019, 7:45 PM · Restricted Project, Restricted Project

Sep 4 2019

zsrkmyn updated the diff for D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 4 2019, 8:31 PM · Restricted Project, Restricted Project
zsrkmyn added inline comments to D67206: [ELF][MC] Fix IFunc alias resolving issue.
Sep 4 2019, 8:02 PM · Restricted Project
zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 4 2019, 7:47 PM · Restricted Project, Restricted Project
zsrkmyn added a comment to D67206: [ELF][MC] Fix IFunc alias resolving issue.

Suppose we have foo.s as follows:

Sep 4 2019, 6:30 PM · Restricted Project
zsrkmyn created D67206: [ELF][MC] Fix IFunc alias resolving issue.
Sep 4 2019, 6:29 PM · Restricted Project
zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 4 2019, 6:06 AM · Restricted Project, Restricted Project

Sep 2 2019

zsrkmyn added a comment to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.

Thanks @lebedev.ri , I'm currently under discussion with @erichkeane , and I'll add lit test after the final decision on how to solve the issue.

Sep 2 2019, 7:14 PM · Restricted Project, Restricted Project

Sep 1 2019

zsrkmyn created D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 1 2019, 8:10 PM · Restricted Project, Restricted Project

Aug 21 2019

zsrkmyn added a comment to D66458: [COFF] Fix section name for constants larger than 64 bits on Windows.

Changed according to MaskRay's comment.
BTW, I cannot commit the patch myself. Can someone help commit it? Thanks a lot!

Aug 21 2019, 6:31 PM · Restricted Project
zsrkmyn updated the diff for D66458: [COFF] Fix section name for constants larger than 64 bits on Windows.
Aug 21 2019, 6:29 PM · Restricted Project
zsrkmyn added a reviewer for D63061: [builtins] Fix overflow issue for complex division with big numbers: ddunbar.
Aug 21 2019, 8:02 AM · Restricted Project, Restricted Project
zsrkmyn added a comment to D63061: [builtins] Fix overflow issue for complex division with big numbers.

ping

Aug 21 2019, 8:02 AM · Restricted Project, Restricted Project
zsrkmyn added reviewers for D66458: [COFF] Fix section name for constants larger than 64 bits on Windows: craig.topper, rnk, annita.zhang, LuoYuanke.
Aug 21 2019, 7:55 AM · Restricted Project

Aug 19 2019

zsrkmyn created D66458: [COFF] Fix section name for constants larger than 64 bits on Windows.
Aug 19 2019, 6:47 PM · Restricted Project

Jul 9 2019

zsrkmyn added reviewers for D63061: [builtins] Fix overflow issue for complex division with big numbers: nsz, phosek.
Jul 9 2019, 10:02 PM · Restricted Project, Restricted Project

Jun 9 2019

zsrkmyn created D63061: [builtins] Fix overflow issue for complex division with big numbers.
Jun 9 2019, 9:58 AM · Restricted Project, Restricted Project