Page MenuHomePhabricator
Feed Advanced Search

Wed, May 10

sebastianpoeplau added a comment to D150231: [libFuzzer] always install signal handler with SA_ONSTACK.

Looks good to me in principle. I'm wondering whether there could be situations where a signal stack has been established with sigaltstack but it's intended for some specific signal(s) only - if we were to set SA_ONSTACK uncontitionally, we would run all of the fuzzer's signal handlers on the signal stack. That said, none of the handlers seem to require a lot of stack space, so it's probably fine.

Wed, May 10, 2:40 AM · Restricted Project

Jan 24 2023

sebastianpoeplau updated the diff for D141836: [AArch64] Disable __muloti4 libcalls for AArch64.

Added requested comment

Jan 24 2023, 1:17 AM · Restricted Project, Restricted Project

Jan 23 2023

sebastianpoeplau added a comment to D141836: [AArch64] Disable __muloti4 libcalls for AArch64.

From reading the thread on https://github.com/llvm/llvm-project/issues/16778 (which is closed, although the issue doesn't seem resolved), this is a stop-gap for toolchains that don't include an implementation for __muloti4. An implementation seems to exist in compiler-rt, but compiler-rt isn't linked with by default. It seems unfortunate that there is no way to still emit a call to __muloti4 when we do link with compiler-rt, but from reading that thread there is currently no way to tell LLVM that an implementation of __muloti4 is available.

Jan 23 2023, 5:58 AM · Restricted Project, Restricted Project

Jan 22 2023

sebastianpoeplau added a comment to D141836: [AArch64] Disable __muloti4 libcalls for AArch64.

Ping

Jan 22 2023, 11:54 PM · Restricted Project, Restricted Project

Jan 16 2023

sebastianpoeplau added a comment to D141836: [AArch64] Disable __muloti4 libcalls for AArch64.

The build failure on Debian is caused by a clangd unit test that seems unrelated to AArch64 codegen; I'm assuming for now that the failure isn't caused by this change.

Jan 16 2023, 5:03 AM · Restricted Project, Restricted Project
sebastianpoeplau added a reviewer for D141836: [AArch64] Disable __muloti4 libcalls for AArch64: sdesmalen.
Jan 16 2023, 3:13 AM · Restricted Project, Restricted Project
sebastianpoeplau updated the diff for D141836: [AArch64] Disable __muloti4 libcalls for AArch64.

Removed internal ticket identifiers from the commit message

Jan 16 2023, 3:05 AM · Restricted Project, Restricted Project
sebastianpoeplau requested review of D141836: [AArch64] Disable __muloti4 libcalls for AArch64.
Jan 16 2023, 3:02 AM · Restricted Project, Restricted Project

May 7 2021

sebastianpoeplau added a comment to D101824: [libFuzzer] Fix stack overflow detection.

Looks like I made a mistake in the test that causes the Windows build to fail (just received an email notification): infinite_recursion should be declared with return type void. Should I submit a new differential, or is there some way to fix this one?

May 7 2021, 8:34 AM · Restricted Project
sebastianpoeplau added a comment to D101824: [libFuzzer] Fix stack overflow detection.

compiler-rt/test/fuzzer is better. Most tests there already build with ASan + libFuzzer.

May 7 2021, 2:53 AM · Restricted Project
sebastianpoeplau updated the diff for D101824: [libFuzzer] Fix stack overflow detection.

Added a test and rephrased the commit message accordingly.

May 7 2021, 2:51 AM · Restricted Project

May 5 2021

sebastianpoeplau added a comment to D101824: [libFuzzer] Fix stack overflow detection.

Thanks for the fix. Could you add a test that fails before this fix and passes after it?

May 5 2021, 3:31 AM · Restricted Project

May 4 2021

sebastianpoeplau added a reviewer for D101824: [libFuzzer] Fix stack overflow detection: morehouse.
May 4 2021, 2:33 AM · Restricted Project
sebastianpoeplau requested review of D101824: [libFuzzer] Fix stack overflow detection.
May 4 2021, 2:19 AM · Restricted Project