Page MenuHomePhabricator
Feed Advanced Search

May 29 2019

petecoup committed rGd80024c68759: [ARC] Cleanup ARCAsmPrinter. (authored by petecoup).
[ARC] Cleanup ARCAsmPrinter.
May 29 2019, 1:05 PM
petecoup committed rL362021: [ARC] Cleanup ARCAsmPrinter..
[ARC] Cleanup ARCAsmPrinter.
May 29 2019, 1:05 PM
petecoup closed D62549: [ARC] Cleanup ARCAsmPrinter..
May 29 2019, 1:05 PM · Restricted Project

May 28 2019

petecoup created D62549: [ARC] Cleanup ARCAsmPrinter..
May 28 2019, 1:49 PM · Restricted Project

May 20 2019

petecoup committed rG380eaa0cfabe: [TableGen] - Type comparison LE should be LT or equal. (authored by petecoup).
[TableGen] - Type comparison LE should be LT or equal.
May 20 2019, 11:08 AM
petecoup committed rL361183: [TableGen] - Type comparison LE should be LT or equal..
[TableGen] - Type comparison LE should be LT or equal.
May 20 2019, 11:07 AM
petecoup closed D61705: Tablegen type comparison LE should be LT or equal..
May 20 2019, 11:07 AM · Restricted Project

May 15 2019

petecoup committed rG1ca049959f57: Uncomment LLVM_FALLTHROUGH. (authored by petecoup).
Uncomment LLVM_FALLTHROUGH.
May 15 2019, 12:46 PM
petecoup committed rL360798: Uncomment LLVM_FALLTHROUGH..
Uncomment LLVM_FALLTHROUGH.
May 15 2019, 12:43 PM

May 9 2019

petecoup added a comment to D61705: Tablegen type comparison LE should be LT or equal..

@craig.topper Yes, X86GenDAGIsel.inc generates the same before/after this change.

May 9 2019, 1:13 PM · Restricted Project

May 8 2019

petecoup added inline comments to D61705: Tablegen type comparison LE should be LT or equal..
May 8 2019, 4:10 PM · Restricted Project
petecoup added a reviewer for D61705: Tablegen type comparison LE should be LT or equal.: kparzysz.
May 8 2019, 4:05 PM · Restricted Project
petecoup created D61705: Tablegen type comparison LE should be LT or equal..
May 8 2019, 4:05 PM · Restricted Project

Apr 15 2019

petecoup committed rG3929c432e65c: Add explicit dependency to MCDwarf.h in ARC backend. (authored by petecoup).
Add explicit dependency to MCDwarf.h in ARC backend.
Apr 15 2019, 10:40 AM
petecoup committed rL358430: Add explicit dependency to MCDwarf.h in ARC backend..
Add explicit dependency to MCDwarf.h in ARC backend.
Apr 15 2019, 10:40 AM

Mar 20 2019

petecoup committed rGb062239d638b: [ARC] Add ARCOptAddrMode pass to generate postincrement loads/stores. (authored by petecoup).
[ARC] Add ARCOptAddrMode pass to generate postincrement loads/stores.
Mar 20 2019, 1:06 PM
petecoup committed rL356606: [ARC] Add ARCOptAddrMode pass to generate postincrement loads/stores..
[ARC] Add ARCOptAddrMode pass to generate postincrement loads/stores.
Mar 20 2019, 1:05 PM
petecoup closed D59409: [ARC] ARCOptAddrMode pass to generate postincrement loads/stores.
Mar 20 2019, 1:05 PM · Restricted Project

Mar 18 2019

petecoup accepted D59409: [ARC] ARCOptAddrMode pass to generate postincrement loads/stores.

Thanks again Denis, this looks good to me. Shall I commit this piece as well?

Mar 18 2019, 9:08 AM · Restricted Project

Mar 14 2019

petecoup committed rG9fd18488231c: [ARC] Add more load/store variants. (authored by petecoup).
[ARC] Add more load/store variants.
Mar 14 2019, 1:50 PM
petecoup committed rL356200: [ARC] Add more load/store variants..
[ARC] Add more load/store variants.
Mar 14 2019, 1:50 PM
petecoup closed D58980: [ARC] Add more load/store variants and simple pass to generate postincrement instructions.
Mar 14 2019, 1:50 PM · Restricted Project
petecoup committed rG225c0bd61ee1: [ARC] Better classify add/sub immediate instructions in frame lowering. (authored by petecoup).
[ARC] Better classify add/sub immediate instructions in frame lowering.
Mar 14 2019, 10:51 AM
petecoup committed rL356179: [ARC] Better classify add/sub immediate instructions in frame lowering..
[ARC] Better classify add/sub immediate instructions in frame lowering.
Mar 14 2019, 10:51 AM
petecoup closed D59326: [ARC] Better classify add/sub immediate instructions in frame lowering..
Mar 14 2019, 10:51 AM · Restricted Project

Mar 13 2019

petecoup added reviewers for D59326: [ARC] Better classify add/sub immediate instructions in frame lowering.: dantrushin, yan_luo, kparzysz.
Mar 13 2019, 2:20 PM · Restricted Project
petecoup created D59326: [ARC] Better classify add/sub immediate instructions in frame lowering..
Mar 13 2019, 1:50 PM · Restricted Project

Mar 12 2019

petecoup added a comment to D58980: [ARC] Add more load/store variants and simple pass to generate postincrement instructions.

Yes Denis, I will try to push this for you tomorrow. Thanks!

Mar 12 2019, 4:31 PM · Restricted Project

Mar 7 2019

petecoup accepted D58980: [ARC] Add more load/store variants and simple pass to generate postincrement instructions.

Yes, this looks fine with me too Denis. As a process matter, perhaps it makes sense to split into 2 pieces: "Just add the instruction encodings + disasm tests", and then "add the pass to generate pre-/post-increment instructions + tests"
Both pieces look fine with me.

Mar 7 2019, 8:16 AM · Restricted Project

Mar 5 2019

petecoup added a comment to D58980: [ARC] Add more load/store variants and simple pass to generate postincrement instructions.

Can you add a few disassembler tests for the new variants here?

Mar 5 2019, 4:26 PM · Restricted Project

Sep 6 2018

petecoup accepted D51728: [ARC] Prevent InstPrinter from crashing on unknown condition codes..

Great, thanks for doing this!

Sep 6 2018, 12:54 PM
petecoup added a comment to D51728: [ARC] Prevent InstPrinter from crashing on unknown condition codes..

Thanks, can you add a test to make sure the disassembler doesn't crash in this case?

Sep 6 2018, 12:15 PM

Apr 13 2018

petecoup accepted D45309: [ARC] Add LImm support for J/JL.

Yes, this looks good to me.

Apr 13 2018, 7:37 AM

Apr 6 2018

petecoup closed D45148: [ARC] Add <.f> suffix for F32_GEN4_{DOP|SOP}.

Committed in r329404.
Thanks!

Apr 6 2018, 8:52 AM
petecoup committed rL329404: [ARC] Add <.f> suffix for F32_GEN4_{DOP|SOP}..
[ARC] Add <.f> suffix for F32_GEN4_{DOP|SOP}.
Apr 6 2018, 8:46 AM

Apr 5 2018

petecoup added a reviewer for D45309: [ARC] Add LImm support for J/JL: tatyana-krasnukha.

Hi Yan,

Apr 5 2018, 5:08 PM

Apr 4 2018

petecoup accepted D45148: [ARC] Add <.f> suffix for F32_GEN4_{DOP|SOP}.

Great, thanks!
Do you need me to commit this for you?

Apr 4 2018, 3:34 PM

Apr 2 2018

petecoup added a comment to D45148: [ARC] Add <.f> suffix for F32_GEN4_{DOP|SOP}.

Hi Yan,

Apr 2 2018, 10:39 AM

Feb 14 2018

petecoup added reviewers for D43089: clang: Add ARCTargetInfo: rsmith, rjmccall.
Feb 14 2018, 8:53 AM
petecoup added a comment to D43089: clang: Add ARCTargetInfo.

Hi Tatyana,

Feb 14 2018, 8:50 AM

Feb 9 2018

petecoup added a comment to D43089: clang: Add ARCTargetInfo.

Hi Tatyana,

Feb 9 2018, 2:47 PM
petecoup updated the diff for D43089: clang: Add ARCTargetInfo.

Hello Eugene,

Feb 9 2018, 1:07 PM

Feb 8 2018

petecoup created D43089: clang: Add ARCTargetInfo.
Feb 8 2018, 1:41 PM

Jan 17 2018

petecoup accepted D42172: [ARC] Add missing condition codes..

Hi Tatyana,

Jan 17 2018, 9:40 AM

Nov 28 2017

petecoup added a comment to D37983: Add instruction subset for the ARC backend.

Hello Tatyana,

Nov 28 2017, 2:20 PM

Nov 27 2017

petecoup accepted D37983: Add instruction subset for the ARC backend.

OK, I was aware of these...but didn't know that you'd need them for the debugger. There are a couple of others (mayLoad, mayStore, Defs STATUS32), but I was going to add them when the code generation uses them. Thanks!

Nov 27 2017, 8:49 PM

Nov 15 2017

petecoup added a comment to D37983: Add instruction subset for the ARC backend.

@kparzysz, procedural question...am I OK to commit this for Tatyana, or do we need someone else to also sign off on this as well?

Nov 15 2017, 8:14 AM

Nov 13 2017

petecoup accepted D37983: Add instruction subset for the ARC backend.

Hi Tatyana,

Nov 13 2017, 6:53 PM

Nov 8 2017

petecoup requested changes to D37983: Add instruction subset for the ARC backend.

I don't personally feel strongly about either of these.
I'm generally trying to match the style in other backends, which on observation I thinke would either just implement the logic inline, or create a new static routine...and omit auto.
I was wrong on other details myself originally.
But, I'm also a newbie at this reviewing bit (like I somehow mistakenly marked this as accepted?), so I'm happy to be told otherwise.

Nov 8 2017, 10:51 AM
petecoup accepted D37983: Add instruction subset for the ARC backend.

Hi Tatyana,

Nov 8 2017, 8:35 AM

Oct 12 2017

petecoup added a comment to D37983: Add instruction subset for the ARC backend.

I'm getting a few errors when running these tests now?

Oct 12 2017, 9:49 AM
petecoup added a comment to D37983: Add instruction subset for the ARC backend.

Hello Tatyana,

Oct 12 2017, 8:33 AM

Sep 20 2017

petecoup updated subscribers of D37983: Add instruction subset for the ARC backend.
Sep 20 2017, 8:09 AM

Sep 19 2017

petecoup added a comment to D37983: Add instruction subset for the ARC backend.

Hello Tatyana,

Sep 19 2017, 7:44 PM

Sep 18 2017

petecoup added a comment to D37983: Add instruction subset for the ARC backend.

Hi Tatyana,

Sep 18 2017, 11:30 AM

Sep 1 2017

xiangzhai awarded D36331: Add ARC backend a Like token.
Sep 1 2017, 1:48 AM

Aug 31 2017

petecoup closed D36331: Add ARC backend.

Yes, sorry for missing that.

Aug 31 2017, 12:49 PM

Aug 24 2017

petecoup committed rL311667: [ARC] Add ARC backend..
[ARC] Add ARC backend.
Aug 24 2017, 8:41 AM

Aug 23 2017

petecoup committed rL311598: Test commit..
Test commit.
Aug 23 2017, 1:59 PM
petecoup updated the diff for D36331: Add ARC backend.

Thanks for the help/comments everyone. Is this all OK to submit?

  • Remove copyright notices
  • Add myself as the ARC backend owner in CODE_OWNERS.txt
Aug 23 2017, 1:39 PM

Aug 22 2017

petecoup added a comment to D36331: Add ARC backend.

Hello Kamil,

Aug 22 2017, 8:54 AM
petecoup added a reviewer for D36331: Add ARC backend: dberlin.

Any comments or suggestions about Krzysztof's copyright notice question here? Are they OK in, or should the notices be taken out?

Aug 22 2017, 8:29 AM

Aug 18 2017

petecoup added a comment to D36331: Add ARC backend.

Hello Krzysztof,

Aug 18 2017, 2:58 PM
petecoup updated the diff for D36331: Add ARC backend.

Hello Krzysztof,

Aug 18 2017, 9:49 AM

Aug 17 2017

petecoup updated the diff for D36331: Add ARC backend.

Hello Krzysztof,

Aug 17 2017, 11:35 AM

Aug 16 2017

petecoup added a comment to D36331: Add ARC backend.

Hello Matt, Eugene,

Aug 16 2017, 8:36 AM

Aug 9 2017

petecoup updated the diff for D36331: Add ARC backend.

Hello Eugene,

Aug 9 2017, 9:22 AM

Aug 8 2017

petecoup updated the diff for D36331: Add ARC backend.

Hello Eugene, Matt,
Thanks again for taking a look. This should address all of the comments so far.

  • Change line-1 comments to be 80-characters, and unify format.
  • Add appropriate spacing around namespaces, and add '// end namespace XYZ' comments.
  • Fix some other spacing issues, and remove some empty comment lines.
  • Remove a couple of useless .str() calls.
  • Implement TII getInstSizeInBytes method. Use this method in ARCBranchFinalize pass.
  • Change Expand Pseudos to delete Instructions as encountered, rather than collect and delete at end.
  • Remove all target-specific Load/Store lowering: The target independent path works fine for what we have.
  • Add tests for unaligned load/store.
  • Remove noisy DEBUG output from ARCISelLowering.
  • Use getStoreSize where appropriate in ARCISelLowering.
  • Run missed clang-tidy checks from last time (fixes ARCTargetLowering::isLegalAddressingMode, static isBRccPseudo in ARCBranchFinalize).
Aug 8 2017, 12:56 PM

Aug 7 2017

petecoup added inline comments to D36331: Add ARC backend.
Aug 7 2017, 11:07 AM

Aug 4 2017

petecoup updated the diff for D36331: Add ARC backend.

Hello Eugene,
Thanks for the comments and suggestions. I think I've addressed you're comments, let me know if you find things I missed.

  • Run clang-tidy modernize, and fix resulting issues.
  • Add ending "#endif // THIS_FILE" to a number of files.
  • Remove a few needless extra lines, and a couple of required separating lines.
  • Change a couple typedef -> using.
Aug 4 2017, 10:39 PM
petecoup created D36331: Add ARC backend.
Aug 4 2017, 11:07 AM