Page MenuHomePhabricator
Feed Advanced Search

Sat, Jul 27

nicolas updated the diff for D63276: [AST] Add FunctionDecl::getParametersSourceRange().

Add a default value for FunctionProtoType::getEllipsisLoc

Sat, Jul 27, 10:09 AM · Restricted Project
nicolas updated the diff for D63276: [AST] Add FunctionDecl::getParametersSourceRange().
  • getEllipsisSourceRange -> getEllipsisLoc
  • Updated the doc comment
  • Removed auto where necessary
Sat, Jul 27, 7:52 AM · Restricted Project

Thu, Jul 25

nicolas updated the diff for D63276: [AST] Add FunctionDecl::getParametersSourceRange().

I added the SourceLocation of the ellipsis to FunctionProtoType in addition to the Variadic boolean.

Thu, Jul 25, 4:21 PM · Restricted Project

Jun 25 2019

nicolas added inline comments to D63276: [AST] Add FunctionDecl::getParametersSourceRange().
Jun 25 2019, 8:11 AM · Restricted Project
nicolas updated the diff for D63276: [AST] Add FunctionDecl::getParametersSourceRange().
  • Added tests of instance and static functions
  • Added tests of parameters with cv qualifiers
  • Added tests of parameters with attributes
  • Removed auto
Jun 25 2019, 7:54 AM · Restricted Project

Jun 21 2019

nicolas added a comment to D63276: [AST] Add FunctionDecl::getParametersSourceRange().

Ping

Jun 21 2019, 4:44 PM · Restricted Project

Jun 13 2019

nicolas created D63276: [AST] Add FunctionDecl::getParametersSourceRange().
Jun 13 2019, 8:21 AM · Restricted Project

Apr 12 2019

nicolas added a comment to D60029: Add const children() accessors to all AST nodes..

Yes, thank you very much!

Apr 12 2019, 7:45 AM · Restricted Project

Apr 10 2019

nicolas added a comment to D60029: Add const children() accessors to all AST nodes..

Ping

Apr 10 2019, 2:18 AM · Restricted Project

Apr 2 2019

nicolas updated the summary of D60029: Add const children() accessors to all AST nodes..
Apr 2 2019, 7:38 AM · Restricted Project
nicolas added a reviewer for D60029: Add const children() accessors to all AST nodes.: riccibruno.
Apr 2 2019, 7:38 AM · Restricted Project
nicolas updated the diff for D60029: Add const children() accessors to all AST nodes..

Added children() const to all AST nodes.

Apr 2 2019, 7:36 AM · Restricted Project

Mar 30 2019

nicolas added a comment to D60029: Add const children() accessors to all AST nodes..

Did you go over all the statements on Stmt.h systematically ?

Yes.

You could also do the same thing for all of the statements/expressions in StmtCXX.h, Expr.h, ExprCXX.h, and so on.

I will go over those soon. I believe that Expr.h is mostly done.

Apart from this did you run clang-format on the patch ?

I tried to stick to the style of the non-const functions, even when it was wrong. I will clang-format the next patch!

Mar 30 2019, 11:05 AM · Restricted Project
nicolas changed the repository for D60029: Add const children() accessors to all AST nodes. from rC Clang to rG LLVM Github Monorepo.
Mar 30 2019, 8:27 AM · Restricted Project
nicolas created D60029: Add const children() accessors to all AST nodes..
Mar 30 2019, 6:25 AM · Restricted Project