Page MenuHomePhabricator
Feed Advanced Search

Yesterday

thakis committed rG0eb64fcb89a5: Fix clangd-xpc-test-client build after 777180a32b6107 (authored by thakis).
Fix clangd-xpc-test-client build after 777180a32b6107
Tue, Jan 28, 4:52 PM
thakis committed rG95cb22d0f9f3: Fix xpc build after 777180a32b6107 (authored by thakis).
Fix xpc build after 777180a32b6107
Tue, Jan 28, 4:44 PM
thakis committed rGce70eb76ea05: Fix AVR build after 777180a32b6107 (authored by thakis).
Fix AVR build after 777180a32b6107
Tue, Jan 28, 4:25 PM
thakis committed rG776937c3e881: [gn build] (manually) port 90a10f00ff8 (authored by thakis).
[gn build] (manually) port 90a10f00ff8
Tue, Jan 28, 1:11 PM
thakis added a comment to D73299: [HIP] Fix environment variable HIP_DEVICE_LIB_PATH.

This breaks check-clang on Windows: http://45.33.8.238/win/6843/step_7.txt

Tue, Jan 28, 10:49 AM · Restricted Project
thakis added a comment to D72723: Built-in functions for AMDGPU MFMA instructions..

Things have been broken for 1.5 hours now. Time to revert?

Tue, Jan 28, 10:21 AM · Restricted Project, Restricted Project, Restricted Project
thakis added a comment to D72723: Built-in functions for AMDGPU MFMA instructions..

This seems to break check-clang everywhere. If the fix isn't obvious, please revert and analyze asynchronously.

Tue, Jan 28, 9:02 AM · Restricted Project, Restricted Project, Restricted Project
thakis committed rG0d17410e9191: Prevent building with MSVC 14.24 (authored by thakis).
Prevent building with MSVC 14.24
Tue, Jan 28, 7:18 AM
thakis closed D73550: Prevent building with MSVC 14.24.
Tue, Jan 28, 7:17 AM · Restricted Project
thakis added a comment to D73550: Prevent building with MSVC 14.24.

Seems reasonable to me. Should we comment on the upstream bug that this breaks LLVM? I see there's a reduced repro, but I don't see LLVM mentioned.

Tue, Jan 28, 7:01 AM · Restricted Project
thakis created D73550: Prevent building with MSVC 14.24.
Tue, Jan 28, 6:50 AM · Restricted Project
thakis committed rGe916c8dfe461: Revert "[Clang] Warn about 'z' printf modifier in old MSVC." (authored by thakis).
Revert "[Clang] Warn about 'z' printf modifier in old MSVC."
Tue, Jan 28, 6:32 AM
thakis added a reverting change for rGfe0d1b6a8ac5: [Clang] Warn about 'z' printf modifier in old MSVC.: rGe916c8dfe461: Revert "[Clang] Warn about 'z' printf modifier in old MSVC.".
Tue, Jan 28, 6:32 AM
thakis added a comment to D73457: [Clang] Warn about 'z' printf modifier in old MSVC..

This breaks tests on Windows: http://45.33.8.238/win/6812/step_7.txt

Tue, Jan 28, 6:31 AM · Restricted Project
thakis committed rGaaae6b1b6173: Revert "PR44684: Look through parens and similar constructs when determining" (authored by thakis).
Revert "PR44684: Look through parens and similar constructs when determining"
Tue, Jan 28, 6:05 AM
thakis added a reverting change for rGaf80b8ccc577: PR44684: Look through parens and similar constructs when determining whether a…: rGaaae6b1b6173: Revert "PR44684: Look through parens and similar constructs when determining".
Tue, Jan 28, 6:05 AM

Mon, Jan 27

thakis committed rG49532137d087: Make AST reading work better with LLVM_APPEND_VC_REV=NO (authored by thakis).
Make AST reading work better with LLVM_APPEND_VC_REV=NO
Mon, Jan 27, 7:13 PM
thakis closed D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO.
Mon, Jan 27, 7:12 PM · Restricted Project
thakis added inline comments to D73486: [ms] [llvm-ml] Add support for attempted register parsing.
Mon, Jan 27, 3:47 PM · Restricted Project
thakis added inline comments to D73486: [ms] [llvm-ml] Add support for attempted register parsing.
Mon, Jan 27, 8:44 AM · Restricted Project
thakis committed rG68051c122440: Revert "[StackColoring] Remap PseudoSourceValue frame indices via… (authored by thakis).
Revert "[StackColoring] Remap PseudoSourceValue frame indices via…
Mon, Jan 27, 8:25 AM
thakis added a reverting change for rG7a8b0b1595e7: [StackColoring] Remap PseudoSourceValue frame indices via MachineFunction…: rG68051c122440: Revert "[StackColoring] Remap PseudoSourceValue frame indices via….
Mon, Jan 27, 8:25 AM
thakis accepted D72680: [ms] [llvm-ml] Add a draft MASM parser.

Make sense. If it's easy to pull out the one part mentioned above, give that a try, else I think it's fine as-is too.

Mon, Jan 27, 7:43 AM · Restricted Project
thakis added a comment to D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO.

rnk, could you maybe take a look?

Mon, Jan 27, 6:58 AM · Restricted Project
thakis added a reviewer for D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO: rnk.
Mon, Jan 27, 6:58 AM · Restricted Project
thakis added inline comments to D73300: [clang-tidy] Add library for clang-tidy main function.
Mon, Jan 27, 6:49 AM · Restricted Project, Restricted Project

Sat, Jan 25

thakis accepted D73234: [gn] Paper over Py3 urllib2 incompatibility in gn/get.py.
Sat, Jan 25, 8:37 PM · Restricted Project
thakis added a comment to D73374: [msan] Instrument x86.pclmulqdq* intrinsics..

Not easily. But if this lands, we'll know within a few hours if it helps, we have a bot that does this.

Sat, Jan 25, 10:25 AM · Restricted Project

Fri, Jan 24

thakis committed rG8d35c798f198: [gn build] (manually) merge 81b700e302b1 (authored by thakis).
[gn build] (manually) merge 81b700e302b1
Fri, Jan 24, 6:43 PM
thakis accepted D73374: [msan] Instrument x86.pclmulqdq* intrinsics..
Fri, Jan 24, 1:23 PM · Restricted Project
thakis added a comment to D73374: [msan] Instrument x86.pclmulqdq* intrinsics..

@thakis Please can you confirm this fixes the original bug in your codebase (not just the reduced case)?

Fri, Jan 24, 12:45 PM · Restricted Project
thakis added a comment to D72680: [ms] [llvm-ml] Add a draft MASM parser.

This is a big diff. But AsmParser is a big interface, so I'm not sure it can be all that much smaller.

Fri, Jan 24, 12:36 PM · Restricted Project
thakis added a comment to D73351: [libcxx] Define _LIBCPP_HAS_NO_SPACESHIP_OPERATOR using feature test macro.

This is a duplicate of D72980

Fri, Jan 24, 7:17 AM · Restricted Project
thakis added a comment to D65887: [TargetLowering] SimplifyDemandedBits - call SimplifyMultipleUseDemandedBits for ISD::EXTRACT_VECTOR_ELT.

I made a reduced repro: https://bugs.llvm.org/show_bug.cgi?id=44652

Fri, Jan 24, 7:17 AM · Restricted Project
thakis added a comment to D65887: [TargetLowering] SimplifyDemandedBits - call SimplifyMultipleUseDemandedBits for ISD::EXTRACT_VECTOR_ELT.

Heads-up: We're again seeing msan reports after this landed, https://bugs.chromium.org/p/chromium/issues/detail?id=1045291

Fri, Jan 24, 6:49 AM · Restricted Project

Thu, Jan 23

thakis closed D68623: Optimize and fix basic_string move assignment operator.

Looks like this landed in November: http://reviews.llvm.org/rG703c26f03be74daf6e483380e6b23029a3851081

Thu, Jan 23, 6:07 PM · Restricted Project
thakis added a comment to D68623: Optimize and fix basic_string move assignment operator.

(ps: I think you've contributed enough good patches to apply for commit access: https://llvm.org/docs/DeveloperPolicy.html#new-contributors)

Thu, Jan 23, 6:07 PM · Restricted Project

Wed, Jan 22

thakis added a comment to D72991: AMDGPU/R600: Emit rodata in text segment.

This seems to break tests everywhere, e.g. http://45.33.8.238/linux/8152/step_12.txt

Wed, Jan 22, 12:05 PM · Restricted Project
thakis committed rG8f21acbf52bb: [gn build] reformat all build files again (authored by thakis).
[gn build] reformat all build files again
Wed, Jan 22, 11:10 AM
thakis added a reverting change for rGa90a6502ab35: [DA][TTI][AMDGPU] Add option to select GPUDA with TTI: rGcd470717d158: Revert "[DA][TTI][AMDGPU] Add option to select GPUDA with TTI".
Wed, Jan 22, 10:05 AM
thakis committed rGcd470717d158: Revert "[DA][TTI][AMDGPU] Add option to select GPUDA with TTI" (authored by thakis).
Revert "[DA][TTI][AMDGPU] Add option to select GPUDA with TTI"
Wed, Jan 22, 10:05 AM
thakis added a comment to D73049: [DA][TTI][AMDGPU] Add option to select GPUDA with TTI.

Tests on Windows have been broken for over 12h now: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/13808 I've reverted this for now in cd470717d15854fb778f2c96667ba36672af6cf5 . Sorry about the toil!

Wed, Jan 22, 10:05 AM · Restricted Project
thakis added a reverting change for rGfd98eccf984f: [gn build] [win] produce symbolized stack frames in release builds too: rGbfcfa53c3df6: Revert "[gn build] [win] produce symbolized stack frames in release builds too".
Wed, Jan 22, 9:55 AM
thakis committed rGbfcfa53c3df6: Revert "[gn build] [win] produce symbolized stack frames in release builds too" (authored by thakis).
Revert "[gn build] [win] produce symbolized stack frames in release builds too"
Wed, Jan 22, 9:55 AM
thakis committed rGfd98eccf984f: [gn build] [win] produce symbolized stack frames in release builds too (authored by thakis).
[gn build] [win] produce symbolized stack frames in release builds too
Wed, Jan 22, 9:37 AM
thakis committed rG349f6bb873df: [gn build] (manually) port a174f0da62f (authored by thakis).
[gn build] (manually) port a174f0da62f
Wed, Jan 22, 8:12 AM
thakis added inline comments to D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO.
Wed, Jan 22, 8:02 AM · Restricted Project
thakis created D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO.
Wed, Jan 22, 8:02 AM · Restricted Project
thakis added a comment to D50360: [Concepts] Requires Expressions.

I figured out the incremental build test problem, see D73202.

Wed, Jan 22, 8:02 AM · Restricted Project
thakis added a comment to D73075: [utils] Add initial llvm-patch helper to manage patches..

Have you seen D67747? Probably makes sense to combine forces there.

Wed, Jan 22, 7:55 AM · Restricted Project
thakis added a comment to D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef.

Looks like this breaks tests: http://45.33.8.238/linux/8102/step_8.txt

Wed, Jan 22, 5:56 AM · Restricted Project, Restricted Project
thakis added a comment to D73091: [llvm-as] Fix assembling of index with multiple summaries sharing the same GUID.

Looks like this breaks tests on Windows: http://45.33.8.238/win/6326/step_11.txt

Wed, Jan 22, 4:43 AM · Restricted Project

Mon, Jan 20

thakis added a comment to D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc.

Only supporting x86 targets for llvm-ml makes sense to me. As far as I know, msvc doesn't have an ml.exe for arm64 either (?).

Mon, Jan 20, 7:03 AM · Restricted Project

Sun, Jan 19

thakis committed rGa7818e6f29c1: fix doc typos to cycle bots (authored by thakis).
fix doc typos to cycle bots
Sun, Jan 19, 3:14 PM
thakis added a comment to D50360: [Concepts] Requires Expressions.

Doesn't this still break check-clang everywhere? See e.g. http://45.33.8.238/linux/7860/step_7.txt

Sun, Jan 19, 10:12 AM · Restricted Project
thakis committed rG46be16897706: fix doc typos to cycle bots (authored by thakis).
fix doc typos to cycle bots
Sun, Jan 19, 6:59 AM

Sat, Jan 18

thakis added a comment to D50360: [Concepts] Requires Expressions.

Doesn't this still break check-clang everywhere? See e.g. http://45.33.8.238/linux/7860/step_7.txt

Sat, Jan 18, 7:22 PM · Restricted Project
thakis added a comment to D50360: [Concepts] Requires Expressions.

This breaks tests on non-Win, see e.g. http://45.33.8.238/linux/7846/step_7.txt http://45.33.8.238/mac/6120/step_7.txt

Sat, Jan 18, 3:57 AM · Restricted Project

Fri, Jan 17

thakis committed rG1d568bf9605c: Remove AllTargetsAsmPrinters (authored by thakis).
Remove AllTargetsAsmPrinters
Fri, Jan 17, 4:27 PM
thakis closed D72966: Remove AllTargetsAsmPrinters.

Bleh, forgot to add "Differential Revision:" footer. Landed in 1d568bf9605c05ff088b244d7894ab2d88da9811

Fri, Jan 17, 4:27 PM · Restricted Project
thakis added a comment to D72966: Remove AllTargetsAsmPrinters.

Thanks for fixing CMake:)

The empty target seems to have caused the failure in http://45.33.8.238/linux/7815/step_4.txt

Fri, Jan 17, 4:17 PM · Restricted Project
Herald added a reviewer for D72966: Remove AllTargetsAsmPrinters: andreadb.
Fri, Jan 17, 4:08 PM · Restricted Project
thakis committed rG6afa0e88e325: [gn build] fix build after 22af2cbefc (authored by thakis).
[gn build] fix build after 22af2cbefc
Fri, Jan 17, 3:30 PM
thakis accepted D72948: Unconditionally enable lvalue function designators; NFC.

Realistically, the the only way to find out if this works is to land and see.

Fri, Jan 17, 12:56 PM · Restricted Project
thakis added a comment to D72792: [SVE] Pass Scalable argument to VectorType::get in Bitcode Reader.

This breaks check-llvm everywhere, e.g. http://45.33.8.238/linux/7807/step_12.txt

Fri, Jan 17, 11:58 AM · Restricted Project
thakis added a comment to D72818: [GlobalsModRef] Add invalidate method.

This breaks check-clang everywhere, see e.g. http://45.33.8.238/linux/7798/step_7.txt

Fri, Jan 17, 10:51 AM · Restricted Project
thakis added a comment to D72378: [clang-tidy] Add `bugprone-reserved-identifier`.

cl.exe prints a different error: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/13716/steps/stage%201%20build/logs/stdio

Fri, Jan 17, 6:49 AM · Restricted Project, Restricted Project
thakis added a comment to D72378: [clang-tidy] Add `bugprone-reserved-identifier`.

Looks like this isn't building on Windows: http://45.33.8.238/win/6039/step_4.txt

Fri, Jan 17, 6:49 AM · Restricted Project, Restricted Project

Thu, Jan 16

thakis added inline comments to D63744: In the libc++ unstable ABI, use [[no_unique_address]] instead of __compressed_pair when available..
Thu, Jan 16, 6:33 PM · Restricted Project
thakis committed rG1645f5e496b9: [gn build] replace llvm_allow_tardy_revision with llvm_append_vc_rev (authored by thakis).
[gn build] replace llvm_allow_tardy_revision with llvm_append_vc_rev
Thu, Jan 16, 4:12 PM
thakis committed rGfb5fafb23cc2: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well. (authored by thakis).
Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.
Thu, Jan 16, 4:12 PM
thakis closed D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well..
Thu, Jan 16, 4:12 PM · Restricted Project, Restricted Project, Restricted Project
thakis closed D72859: [gn build] replace llvm_allow_tardy_revision with llvm_append_vc_rev.
Thu, Jan 16, 4:12 PM · Restricted Project
thakis added a comment to D72479: [PowerPC][AIX] Make PIC the default relocation model for AIX.

Thanks, Windows cycled green: http://45.33.8.238/win/5959/summary.html

Thu, Jan 16, 12:18 PM · Restricted Project
thakis added a comment to D72479: [PowerPC][AIX] Make PIC the default relocation model for AIX.

Also, this breaks tests on Windows: http://45.33.8.238/win/5946/step_11.txt

Thanks for noting, looking into it now.

Thu, Jan 16, 11:49 AM · Restricted Project
thakis added a parent revision for D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.: D72803: Make lld cmake not compute commit revision twice.
Thu, Jan 16, 11:11 AM · Restricted Project, Restricted Project, Restricted Project
thakis added a parent revision for D72859: [gn build] replace llvm_allow_tardy_revision with llvm_append_vc_rev: D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well..
Thu, Jan 16, 11:11 AM · Restricted Project
thakis added a child revision for D72803: Make lld cmake not compute commit revision twice: D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well..
Thu, Jan 16, 11:11 AM · Restricted Project
thakis created D72859: [gn build] replace llvm_allow_tardy_revision with llvm_append_vc_rev.
Thu, Jan 16, 11:11 AM · Restricted Project
thakis added a child revision for D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.: D72859: [gn build] replace llvm_allow_tardy_revision with llvm_append_vc_rev.
Thu, Jan 16, 11:11 AM · Restricted Project, Restricted Project, Restricted Project
thakis added a comment to D72479: [PowerPC][AIX] Make PIC the default relocation model for AIX.

In addition to the lit issue on Windows, it looks like the test is also missing a REQUIRES: powerpc-registered-target line: http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/12986/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Aaix-pic-setting.ll

Thu, Jan 16, 11:01 AM · Restricted Project
thakis added a comment to D72479: [PowerPC][AIX] Make PIC the default relocation model for AIX.

Also, this breaks tests on Windows: http://45.33.8.238/win/5946/step_11.txt

Thu, Jan 16, 10:32 AM · Restricted Project
thakis committed rGd51a15d86a25: [gn build] (manually) port bed7626f04f7 (authored by thakis).
[gn build] (manually) port bed7626f04f7
Thu, Jan 16, 10:23 AM
thakis added inline comments to D72479: [PowerPC][AIX] Make PIC the default relocation model for AIX.
Thu, Jan 16, 10:22 AM · Restricted Project
thakis committed rG5caa12129574: [gn build] include revision information in lld --version output (authored by thakis).
[gn build] include revision information in lld --version output
Thu, Jan 16, 10:13 AM
thakis committed rG81c67da0f20a: remove an include that's unused after r347592 (authored by thakis).
remove an include that's unused after r347592
Thu, Jan 16, 9:54 AM
thakis added a comment to D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well..

A very late follow-up to my question in D37272 :)

Thu, Jan 16, 8:38 AM · Restricted Project, Restricted Project, Restricted Project
thakis created D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well..
Thu, Jan 16, 8:38 AM · Restricted Project, Restricted Project, Restricted Project
thakis committed rGfb9413cb84cc: Remove some SVN-specific code. (authored by thakis).
Remove some SVN-specific code.
Thu, Jan 16, 8:10 AM
thakis closed D72848: Remove some SVN-specific code..
Thu, Jan 16, 8:09 AM · Restricted Project
thakis created D72848: Remove some SVN-specific code..
Thu, Jan 16, 7:40 AM · Restricted Project
thakis committed rG4f5c65a5c804: try to unbreak build after 4b6d9ac392613 (authored by thakis).
try to unbreak build after 4b6d9ac392613
Thu, Jan 16, 7:13 AM
thakis committed rG4b6d9ac39261: Make lld cmake not compute commit revision twice (authored by thakis).
Make lld cmake not compute commit revision twice
Thu, Jan 16, 6:56 AM
thakis closed D72803: Make lld cmake not compute commit revision twice.
Thu, Jan 16, 6:56 AM · Restricted Project

Wed, Jan 15

thakis accepted D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc.

Looks fine to me as a first step, with more uncommented code and a not very actionable FIXME removed :)

Wed, Jan 15, 1:19 PM · Restricted Project
thakis created D72803: Make lld cmake not compute commit revision twice.
Wed, Jan 15, 1:00 PM · Restricted Project
thakis committed rG527281a8432f: [gn build] re-run "gn format" with trunk gn (authored by thakis).
[gn build] re-run "gn format" with trunk gn
Wed, Jan 15, 10:41 AM
thakis committed rGeadc28274b95: [gn build] add multi-line forcing comments in more places (authored by thakis).
[gn build] add multi-line forcing comments in more places
Wed, Jan 15, 10:41 AM
thakis committed rGaed52fd48374: [gn build] make "gn format" comment slightly more concise (authored by thakis).
[gn build] make "gn format" comment slightly more concise
Wed, Jan 15, 10:41 AM
thakis committed rG082962dec846: [gn build] Reformat all build files (authored by thakis).
[gn build] Reformat all build files
Wed, Jan 15, 10:03 AM