Page MenuHomePhabricator
Feed Advanced Search

Mon, Jan 9

avogelsgesang accepted D141304: [libc++][doc] Updates the release notes..
Mon, Jan 9, 11:22 PM · Restricted Project, Restricted Project

Dec 17 2022

avogelsgesang updated the diff for D131395: [libc++] Implement `lexicographical_compare_three_way`.
  • static_assert for signed integral
  • add missing includes
Dec 17 2022, 11:52 AM · Restricted Project, Restricted Project
avogelsgesang added a comment to D132735: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer.

I reapplied this patch locally on top of the latest main and tried to reproduce the issue on my Mac using

Dec 17 2022, 11:47 AM · Restricted Project, Restricted Project
avogelsgesang added a comment to D138006: [libc++abi] Refactoring works around __dynamic_cast.

Seems like the failed unit tests are not related to this patch nor the parent revision.

Dec 17 2022, 8:04 AM · Restricted Project, Restricted Project, Restricted Project
avogelsgesang reopened D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer.
Dec 17 2022, 4:26 AM · Restricted Project, Restricted Project
avogelsgesang reopened D132735: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer.
Dec 17 2022, 4:26 AM · Restricted Project, Restricted Project
avogelsgesang added a comment to D138006: [libc++abi] Refactoring works around __dynamic_cast.

Here is one of the error messages produced on Apple

Dec 17 2022, 3:06 AM · Restricted Project, Restricted Project, Restricted Project

Dec 11 2022

avogelsgesang added inline comments to D131395: [libc++] Implement `lexicographical_compare_three_way`.
Dec 11 2022, 6:57 AM · Restricted Project, Restricted Project
avogelsgesang updated the diff for D131395: [libc++] Implement `lexicographical_compare_three_way`.

Adress a couple of varconst's comments. Not completely done, yet. Want to get feedback from the CI

Dec 11 2022, 6:56 AM · Restricted Project, Restricted Project

Dec 7 2022

avogelsgesang added a comment to D138006: [libc++abi] Refactoring works around __dynamic_cast.

Ah, now I understand how you are planning to apply your changes. I assumed you first wanted to apply this patch, and then https://reviews.llvm.org/D138005 on top of it (i.e. first the refactoring, then the perf improvement). But you want to apply them exactly the other way around.

Dec 7 2022, 7:09 PM · Restricted Project, Restricted Project, Restricted Project
avogelsgesang added a reviewer for D138006: [libc++abi] Refactoring works around __dynamic_cast: avogelsgesang.
Dec 7 2022, 5:47 PM · Restricted Project, Restricted Project, Restricted Project
avogelsgesang added a comment to D138006: [libc++abi] Refactoring works around __dynamic_cast.

Thanks for looking into the performance of dynamic_cast and for splitting your initial patch from https://reviews.llvm.org/D137315!
Unfortunately, it looks like your patch is still not rebased onto current main. E.g., your patch claims to delete a couple of lines which are not currently on https://github.com/llvm/llvm-project/blob/main/libcxxabi/src/private_typeinfo.cpp. I marked one of those examples below. That's also why the CI currently fails (see "patch application failed" link further up on this page). Let's get that sorted out first, and as soon as the diff is correct, I will start reviewing your changes (I see little value in reviewing a non-applicable patch)

Dec 7 2022, 5:44 PM · Restricted Project, Restricted Project, Restricted Project

Dec 5 2022

avogelsgesang added inline comments to D131395: [libc++] Implement `lexicographical_compare_three_way`.
Dec 5 2022, 4:47 AM · Restricted Project, Restricted Project

Nov 30 2022

avogelsgesang added inline comments to D131395: [libc++] Implement `lexicographical_compare_three_way`.
Nov 30 2022, 7:05 PM · Restricted Project, Restricted Project
avogelsgesang updated the diff for D131395: [libc++] Implement `lexicographical_compare_three_way`.

address varconst's commments

Nov 30 2022, 7:05 PM · Restricted Project, Restricted Project
avogelsgesang added a comment to D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer.

The issue with this change was that if devirtualization is failing, then in the line

Nov 30 2022, 1:24 AM · Restricted Project, Restricted Project
avogelsgesang updated subscribers of D132735: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer.

As discussed via email, the reason for the test failures on green dragon is, that green dragon seems to be using some compiler which passes the test

Nov 30 2022, 1:21 AM · Restricted Project, Restricted Project

Nov 29 2022

avogelsgesang added inline comments to D131395: [libc++] Implement `lexicographical_compare_three_way`.
Nov 29 2022, 3:37 PM · Restricted Project, Restricted Project
avogelsgesang updated the diff for D131395: [libc++] Implement `lexicographical_compare_three_way`.
  • forward -> move
  • move iterator initialization out of benchmarking loop
  • remove #if _LIB_CPP_VERSION check from benchmark
Nov 29 2022, 3:36 PM · Restricted Project, Restricted Project

Nov 25 2022

avogelsgesang added a comment to D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`.

@jasonmolenda I am a bit confused about your revert.
Did you indeed revert this change here? Afaict, you reverted https://reviews.llvm.org/D132735 and https://reviews.llvm.org/D132815, but left this commit in place. I did not actually read through your code changes, though, I only looked at the commit messages so far. Is my understanding of which commits you actually reverted correct?

Nov 25 2022, 1:48 PM · Restricted Project, Restricted Project

Nov 24 2022

avogelsgesang updated the diff for D131395: [libc++] Implement `lexicographical_compare_three_way`.
  • sort includes correctly
  • work around NASTY_MACRO
Nov 24 2022, 5:01 PM · Restricted Project, Restricted Project
avogelsgesang updated the diff for D131395: [libc++] Implement `lexicographical_compare_three_way`.
  • use explicit types instead of auto
  • make benchmark runnable on non-libcxx
Nov 24 2022, 1:19 PM · Restricted Project, Restricted Project

Nov 23 2022

avogelsgesang added a comment to D134010: [C++] [Coroutines] Introduce `coro_always_done` attribute to help optimizations (2/2).

And now, it should be clear that why the coro_always_done and coro_always_resume is helpful for coroutine elision. Since it is helpful for such cases.

Nov 23 2022, 7:28 AM · Restricted Project

Nov 22 2022

avogelsgesang added a comment to D134010: [C++] [Coroutines] Introduce `coro_always_done` attribute to help optimizations (2/2).

Interesting... . I will need to read up on coro_always_elide a bit before being able to form an informed opinion.
I found https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2594r0.pdf
Any other relevant resources?

Nov 22 2022, 4:23 AM · Restricted Project

Nov 21 2022

avogelsgesang updated the diff for D131395: [libc++] Implement `lexicographical_compare_three_way`.

Another try at fixing the CI; this time the benchmarks

Nov 21 2022, 1:21 PM · Restricted Project, Restricted Project

Nov 20 2022

avogelsgesang abandoned D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments.
Nov 20 2022, 6:51 PM · Restricted Project, Restricted Project, Restricted Project
avogelsgesang updated the diff for D132268: [libc++][spaceship] Implement `operator<=>` for `vector`.

add missing _LIBCPP_HIDE_FROM_ABI; use new test utility

Nov 20 2022, 6:50 PM · Restricted Project, Restricted Project
avogelsgesang updated the diff for D132312: [libc++][spaceship] Implement `operator<=>` for `list`.

add inline

Nov 20 2022, 6:45 PM · Restricted Project, Restricted Project
avogelsgesang added inline comments to D132312: [libc++][spaceship] Implement `operator<=>` for `list`.
Nov 20 2022, 6:43 PM · Restricted Project, Restricted Project
avogelsgesang updated the diff for D132312: [libc++][spaceship] Implement `operator<=>` for `list`.

Introduce reusable test function

Nov 20 2022, 6:43 PM · Restricted Project, Restricted Project
avogelsgesang updated the diff for D131395: [libc++] Implement `lexicographical_compare_three_way`.

fix CI... maybe...

Nov 20 2022, 5:08 PM · Restricted Project, Restricted Project
avogelsgesang committed rGcd3091a88f7c: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer (authored by avogelsgesang).
[LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer
Nov 20 2022, 2:29 PM · Restricted Project
avogelsgesang closed D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer.
Nov 20 2022, 2:29 PM · Restricted Project, Restricted Project
avogelsgesang committed rG4346318f5c70: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty… (authored by avogelsgesang).
[LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty…
Nov 20 2022, 11:19 AM · Restricted Project
avogelsgesang closed D132735: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer.
Nov 20 2022, 11:19 AM · Restricted Project, Restricted Project
avogelsgesang committed rGfb61dce1adc4: [lldb] Fix test expectation in `TestCoroutineHandle.py` for 32-bit systems (authored by avogelsgesang).
[lldb] Fix test expectation in `TestCoroutineHandle.py` for 32-bit systems
Nov 20 2022, 10:31 AM · Restricted Project
avogelsgesang committed rG01f4c305fae9: Reapply "[LLDB] Devirtualize coroutine promise types for `std… (authored by avogelsgesang).
Reapply "[LLDB] Devirtualize coroutine promise types for `std…
Nov 20 2022, 6:36 AM · Restricted Project
avogelsgesang closed D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`.
Nov 20 2022, 6:35 AM · Restricted Project, Restricted Project
avogelsgesang updated the diff for D131395: [libc++] Implement `lexicographical_compare_three_way`.

fix CI

Nov 20 2022, 5:50 AM · Restricted Project, Restricted Project
avogelsgesang updated the diff for D131395: [libc++] Implement `lexicographical_compare_three_way`.

fix CI

Nov 20 2022, 4:26 AM · Restricted Project, Restricted Project

Nov 19 2022

avogelsgesang added inline comments to D136268: [libc++][ranges] implement `std::views::elements_view`.
Nov 19 2022, 9:11 PM · Restricted Project, Restricted Project, Restricted Project
avogelsgesang updated the diff for D131395: [libc++] Implement `lexicographical_compare_three_way`.

fix CI

Nov 19 2022, 9:03 PM · Restricted Project, Restricted Project
avogelsgesang planned changes to D132268: [libc++][spaceship] Implement `operator<=>` for `vector`.

needs to be adjusted to use the still-to-be-introduced test utilities from https://reviews.llvm.org/D132312 is done

Nov 19 2022, 8:59 PM · Restricted Project, Restricted Project
avogelsgesang planned changes to D132265: [libc++][spaceship] Implement `operator<=>` for `array`.

needs to be adjusted to use the still-to-be-introduced test utilities from https://reviews.llvm.org/D132312 is done

Nov 19 2022, 8:56 PM · Restricted Project, Restricted Project
avogelsgesang added inline comments to D132265: [libc++][spaceship] Implement `operator<=>` for `array`.
Nov 19 2022, 8:55 PM · Restricted Project, Restricted Project
avogelsgesang updated the diff for D131395: [libc++] Implement `lexicographical_compare_three_way`.

fix CI

Nov 19 2022, 8:35 PM · Restricted Project, Restricted Project
avogelsgesang added a comment to D131395: [libc++] Implement `lexicographical_compare_three_way`.

I think I addressed all actionable review comments now.

Nov 19 2022, 8:30 PM · Restricted Project, Restricted Project
avogelsgesang added inline comments to D131395: [libc++] Implement `lexicographical_compare_three_way`.
Nov 19 2022, 7:57 PM · Restricted Project, Restricted Project
avogelsgesang updated the diff for D131395: [libc++] Implement `lexicographical_compare_three_way`.

Address mordante's comments about test cases:

Nov 19 2022, 7:56 PM · Restricted Project, Restricted Project
avogelsgesang updated the diff for D131395: [libc++] Implement `lexicographical_compare_three_way`.

Updated benchmark code to directly compare the slow and the fast path

Nov 19 2022, 5:34 PM · Restricted Project, Restricted Project
avogelsgesang added a comment to D131395: [libc++] Implement `lexicographical_compare_three_way`.

@var-const As requested, I updated the benchmark to benchmark int* on both the fast and the slow path.

Nov 19 2022, 5:30 PM · Restricted Project, Restricted Project
avogelsgesang added a comment to D134010: [C++] [Coroutines] Introduce `coro_always_done` attribute to help optimizations (2/2).

Sorry for the late reply - and thanks for your detailed answers!

Nov 19 2022, 9:46 AM · Restricted Project

Nov 14 2022

avogelsgesang added a comment to D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines.

Personally, I am fine with this change as in review right now.

Nov 14 2022, 7:06 PM · Restricted Project, Restricted Project
avogelsgesang added a comment to D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`.

@aprantl I still had to adjust the code slightly to copy the type from the ASTContext for '.../a.out' to the scratch ASTContext (without this, my code was triggering an assert).
See https://reviews.llvm.org/D132624?vs=474793&id=475327 for the related changes.
Because I have no prior experience with ClangASTImporter and the usage of multiple different TypeSystemClang instances, I would appreciate if you could take another quick look

Nov 14 2022, 6:57 PM · Restricted Project, Restricted Project
avogelsgesang updated the diff for D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`.

Fix ownership of CompilerType between "scratch typesystem" and "module type system"

Nov 14 2022, 6:17 PM · Restricted Project, Restricted Project
avogelsgesang reopened D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`.
Nov 14 2022, 6:17 PM · Restricted Project, Restricted Project
avogelsgesang added a comment to D137893: [AsmWriter] Do not write a comma when varargs is the only argument.

Pushed upstream. Thank you for the fix!

Nov 14 2022, 2:47 AM · Restricted Project, Restricted Project
avogelsgesang committed rG8ad88f129cc4: Do not write a comma when varargs is the only argument (authored by caojoshua).
Do not write a comma when varargs is the only argument
Nov 14 2022, 2:47 AM · Restricted Project, Restricted Project
avogelsgesang closed D137893: [AsmWriter] Do not write a comma when varargs is the only argument.
Nov 14 2022, 2:46 AM · Restricted Project, Restricted Project

Nov 13 2022

avogelsgesang added a comment to D137893: [AsmWriter] Do not write a comma when varargs is the only argument.

Can you provide me a git patch, including the meta data (email address, ...)?
Not sure how to get this from Differential, I am rather inexperienced with it myself...

Nov 13 2022, 5:44 PM · Restricted Project, Restricted Project

Nov 12 2022

avogelsgesang accepted D137893: [AsmWriter] Do not write a comma when varargs is the only argument.

LGTM, with small nit:

Nov 12 2022, 2:48 PM · Restricted Project, Restricted Project

Nov 11 2022

avogelsgesang added a reverting change for D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`: rGd7e1c2770fa5: Revert "[LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`".
Nov 11 2022, 10:01 AM · Restricted Project, Restricted Project
avogelsgesang added a reverting change for rG558db7787005: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`: rGd7e1c2770fa5: Revert "[LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`".
Nov 11 2022, 10:01 AM · Restricted Project
avogelsgesang committed rGd7e1c2770fa5: Revert "[LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`" (authored by avogelsgesang).
Revert "[LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`"
Nov 11 2022, 10:01 AM · Restricted Project
avogelsgesang committed rG558db7787005: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle` (authored by avogelsgesang).
[LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`
Nov 11 2022, 9:38 AM · Restricted Project
avogelsgesang closed D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`.
Nov 11 2022, 9:38 AM · Restricted Project, Restricted Project

Nov 4 2022

avogelsgesang added a comment to D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`.

@labath @aprantl Thank you for your reviews on https://reviews.llvm.org/D132815 and https://reviews.llvm.org/D132735
I would appreciate if you also have time to review this change here, as it is a pre-requisite for the other two changes :)

Nov 4 2022, 4:56 AM · Restricted Project, Restricted Project
avogelsgesang planned changes to D131395: [libc++] Implement `lexicographical_compare_three_way`.

@avogelsgesang Do you need anything from us to make progress on this patch? I'd like to make sure you're unblocked.

Nov 4 2022, 4:39 AM · Restricted Project, Restricted Project

Sep 20 2022

avogelsgesang added a comment to D134019: [MachineCycle][NFC]add a cache for block and top level cycle mapping.

does it make sense to add a regression test?

Sep 20 2022, 6:22 PM · Restricted Project, Restricted Project
avogelsgesang added inline comments to D134010: [C++] [Coroutines] Introduce `coro_always_done` attribute to help optimizations (2/2).
Sep 20 2022, 8:28 AM · Restricted Project
avogelsgesang added inline comments to D134010: [C++] [Coroutines] Introduce `coro_always_done` attribute to help optimizations (2/2).
Sep 20 2022, 4:35 AM · Restricted Project
avogelsgesang added inline comments to D134269: [docs] Document the one-phase style compilation to c++ standard modules.
Sep 20 2022, 4:12 AM · Restricted Project, Restricted Project, Restricted Project
avogelsgesang added inline comments to D134009: [Coroutines] Introduce `always_complete_coroutine` attribute to guide optimization (1/2).
Sep 20 2022, 3:46 AM · Restricted Project, Restricted Project

Sep 19 2022

avogelsgesang updated the diff for D132735: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer.

rename IsNoopResumeDestroy -> IsNoopCoroFunction

Sep 19 2022, 9:39 AM · Restricted Project, Restricted Project
avogelsgesang added inline comments to D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer.
Sep 19 2022, 9:28 AM · Restricted Project, Restricted Project
avogelsgesang added a comment to D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer.

wondering if we couldn't fix this by creating the (non-pointer) object using the CreateValueObjectFromAddress function, as above, but then actually use valobj->AddressOf as the synthetic child

Sep 19 2022, 9:27 AM · Restricted Project, Restricted Project
avogelsgesang updated the diff for D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer.

address review comments

Sep 19 2022, 9:25 AM · Restricted Project, Restricted Project
avogelsgesang added inline comments to D134009: [Coroutines] Introduce `always_complete_coroutine` attribute to guide optimization (1/2).
Sep 19 2022, 6:51 AM · Restricted Project, Restricted Project
avogelsgesang added a comment to D134010: [C++] [Coroutines] Introduce `coro_always_done` attribute to help optimizations (2/2).

took a look at the documentation; didn't read the implementation itself

Sep 19 2022, 5:52 AM · Restricted Project

Sep 17 2022

avogelsgesang added a comment to D134009: [Coroutines] Introduce `always_complete_coroutine` attribute to guide optimization (1/2).

Agree, not a blocker

Sep 17 2022, 9:53 AM · Restricted Project, Restricted Project

Sep 16 2022

avogelsgesang added a comment to D134009: [Coroutines] Introduce `always_complete_coroutine` attribute to guide optimization (1/2).

high-level design comment (I didn't look at the code; wouldn't understand it anyway):
I think there is another important case to cover, besides "a coroutine can only be destroyed after it ran to its final suspension point":
"A coroutine can only be destroy after it ran to its final suspension point *or* before it executed until after its initial suspension point"

Sep 16 2022, 1:33 PM · Restricted Project, Restricted Project
avogelsgesang added a comment to D134019: [MachineCycle][NFC]add a cache for block and top level cycle mapping.

Thanks for the quick fix!
I unfortunately don't understand this code here, and can't give you a review, though

Sep 16 2022, 6:38 AM · Restricted Project, Restricted Project
avogelsgesang added a comment to D133846: [libunwind] Fix usage of `_dl_find_object` on 32-bit x86.

Thanks for the quick review, @MaskRay!

Sep 16 2022, 6:37 AM · Restricted Project, Restricted Project, Restricted Project
avogelsgesang committed rGc9cffdde393f: [libunwind] Fix usage of `_dl_find_object` on 32-bit x86 (authored by avogelsgesang).
[libunwind] Fix usage of `_dl_find_object` on 32-bit x86
Sep 16 2022, 6:30 AM · Restricted Project
avogelsgesang closed D133846: [libunwind] Fix usage of `_dl_find_object` on 32-bit x86.
Sep 16 2022, 6:30 AM · Restricted Project, Restricted Project, Restricted Project
avogelsgesang updated the summary of D133846: [libunwind] Fix usage of `_dl_find_object` on 32-bit x86.
Sep 16 2022, 6:29 AM · Restricted Project, Restricted Project, Restricted Project

Sep 15 2022

avogelsgesang updated subscribers of D133846: [libunwind] Fix usage of `_dl_find_object` on 32-bit x86.

My understanding is, that I am not supposed to merge to main until after I got approval from the libunwind review group.
Not sure how the priority of following those process requirements compare to the unblocking Gentoo testing. I am too new to LLVM to really make a call here...

Sep 15 2022, 11:37 AM · Restricted Project, Restricted Project, Restricted Project
avogelsgesang added reviewers for D133846: [libunwind] Fix usage of `_dl_find_object` on 32-bit x86: MaskRay, compnerd.

@MaskRay and @compnerd could I get a review from you on this change, please :)

Sep 15 2022, 7:04 AM · Restricted Project, Restricted Project, Restricted Project
avogelsgesang added a comment to D133846: [libunwind] Fix usage of `_dl_find_object` on 32-bit x86.

Thanks for those build instructions! I was able to reproduce the test failures.
The updated review now fixes the failures for me. Could you please double-check if it also fixes the failures for you?

Sep 15 2022, 5:28 AM · Restricted Project, Restricted Project, Restricted Project
avogelsgesang updated the summary of D133846: [libunwind] Fix usage of `_dl_find_object` on 32-bit x86.
Sep 15 2022, 5:27 AM · Restricted Project, Restricted Project, Restricted Project
avogelsgesang updated the diff for D133846: [libunwind] Fix usage of `_dl_find_object` on 32-bit x86.

remove assert completely

Sep 15 2022, 5:26 AM · Restricted Project, Restricted Project, Restricted Project

Sep 14 2022

avogelsgesang added a comment to D133846: [libunwind] Fix usage of `_dl_find_object` on 32-bit x86.

Thanks for checking this, @mgorny!
Well, I guess I will have to dig deeper, then...
Can you share a (preferably minimal) command line how to reproduce the test failures on a 64-bit Linux machine?

Sep 14 2022, 7:41 AM · Restricted Project, Restricted Project, Restricted Project
avogelsgesang requested review of D133846: [libunwind] Fix usage of `_dl_find_object` on 32-bit x86.
Sep 14 2022, 3:42 AM · Restricted Project, Restricted Project, Restricted Project

Sep 9 2022

avogelsgesang added a comment to D123995: [MachineSink] replace MachineLoop with MachineCycle.

FYI: I suspect this change caused a compile-time regression from 60sec to >40 minutes for an interpreter-loop based on computed-gotos. See https://github.com/llvm/llvm-project/issues/57664

Sep 9 2022, 4:41 PM · Restricted Project, Restricted Project

Sep 6 2022

avogelsgesang added a comment to D126122: Fix RUNPATH not accounting for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR.

for what it's worth: As part of upgrading the Salesforce-internal clang toolchain to clang 15.0.0, I also ran into the RUNPATH issues. This patch here solved those issues for us

Sep 6 2022, 4:47 AM · Restricted Project, Restricted Project

Sep 5 2022

avogelsgesang accepted D133323: [libc++] Bump _LIBCPP_STD_VER to the next expected C++ version.

Are you planning to also replace existing usages of, e.g. #if _LIBCPP_STD_VER > 17 by #if _LIBCPP_STD_VER >= 20?

Sep 5 2022, 4:03 PM · Restricted Project, Restricted Project

Aug 31 2022

avogelsgesang added inline comments to D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer.
Aug 31 2022, 7:56 AM · Restricted Project, Restricted Project
avogelsgesang added inline comments to D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer.
Aug 31 2022, 7:04 AM · Restricted Project, Restricted Project

Aug 28 2022

avogelsgesang added inline comments to D131395: [libc++] Implement `lexicographical_compare_three_way`.
Aug 28 2022, 2:00 PM · Restricted Project, Restricted Project
avogelsgesang added a comment to D131963: [libc++] Add custom clang-tidy checks.

is there a reason why we add our own clang-tidy plugin instead of upstreaming this to clang-tidy itself? I could imagine that other library developers could also benefit from this clang-tidy check, if we make the list of allowed customization points a configuration option

Aug 28 2022, 1:35 PM · Restricted Project, Restricted Project, Restricted Project