Page MenuHomePhabricator
Feed Advanced Search

Tue, Jun 11

yln committed rG6d9ce4e5a2a4: [Sanitizers] Add case MACOS_VERSION_CATALINA (authored by yln).
[Sanitizers] Add case MACOS_VERSION_CATALINA
Tue, Jun 11, 2:53 PM
yln committed rL363104: [Sanitizers] Add case MACOS_VERSION_CATALINA.
[Sanitizers] Add case MACOS_VERSION_CATALINA
Tue, Jun 11, 2:52 PM
yln closed D63096: [Sanitizers] Add case MACOS_VERSION_CATALINA.
Tue, Jun 11, 2:52 PM · Restricted Project, Restricted Project

Mon, Jun 10

yln added reviewers for D63096: [Sanitizers] Add case MACOS_VERSION_CATALINA: delcypher, dcoughlin, kubamracek.
Mon, Jun 10, 2:53 PM · Restricted Project, Restricted Project
yln created D63096: [Sanitizers] Add case MACOS_VERSION_CATALINA.
Mon, Jun 10, 1:47 PM · Restricted Project, Restricted Project

Tue, May 28

yln added a comment to D61919: [builtins] Deduplicate __eqsf2 and __gtsf2.

Hi Petr (@phosek),

Tue, May 28, 11:59 AM · Restricted Project, Restricted Project

Tue, May 21

yln added a comment to D61708: [TSan] Support `ignore_noninstrumented_modules` on Linux.

I am still a bit worried by the amount of complex code we have for this. I wonder if there is a simpler way to do this. Have you considered any other alternatives?

I agree with you on the complexity here. Alternatives: it's the only thing I was able to come up with without the help of the compiler.

Tue, May 21, 10:01 AM · Restricted Project, Restricted Project

Mon, May 20

yln updated the summary of D61708: [TSan] Support `ignore_noninstrumented_modules` on Linux.
Mon, May 20, 1:22 PM · Restricted Project, Restricted Project
yln added a comment to D61708: [TSan] Support `ignore_noninstrumented_modules` on Linux.

*ping*

Mon, May 20, 1:21 PM · Restricted Project, Restricted Project

May 16 2019

yln committed rGa59dad920ffb: [TSan][libdispatch] Use FileCheck's --implicit-check-not=... (authored by yln).
[TSan][libdispatch] Use FileCheck's --implicit-check-not=...
May 16 2019, 11:57 AM
yln abandoned D60575: [TSan][libdispatch] Use FileCheck's --implicit-check-not=....
May 16 2019, 11:57 AM · Restricted Project, Restricted Project
yln committed rL360927: [TSan][libdispatch] Use FileCheck's --implicit-check-not=....
[TSan][libdispatch] Use FileCheck's --implicit-check-not=...
May 16 2019, 11:55 AM
yln committed rCRT360927: [TSan][libdispatch] Use FileCheck's --implicit-check-not=....
[TSan][libdispatch] Use FileCheck's --implicit-check-not=...
May 16 2019, 11:55 AM

May 14 2019

yln updated the diff for D61708: [TSan] Support `ignore_noninstrumented_modules` on Linux.

Fix linker error in test.

May 14 2019, 11:34 AM · Restricted Project, Restricted Project

May 10 2019

yln committed rGe24ed10aac1d: [NFC][TSan][libdispatch] Tiny CMake file cleanup (authored by yln).
[NFC][TSan][libdispatch] Tiny CMake file cleanup
May 10 2019, 11:37 AM
yln committed rL360453: [NFC][TSan][libdispatch] Tiny CMake file cleanup.
[NFC][TSan][libdispatch] Tiny CMake file cleanup
May 10 2019, 11:35 AM
yln committed rCRT360453: [NFC][TSan][libdispatch] Tiny CMake file cleanup.
[NFC][TSan][libdispatch] Tiny CMake file cleanup
May 10 2019, 11:34 AM

May 9 2019

yln committed rGa335d8576397: [TSan][libdispatch] Enable test that supposedly deadlocks on bot (authored by yln).
[TSan][libdispatch] Enable test that supposedly deadlocks on bot
May 9 2019, 3:45 PM
yln committed rL360388: [TSan][libdispatch] Enable test that supposedly deadlocks on bot.
[TSan][libdispatch] Enable test that supposedly deadlocks on bot
May 9 2019, 3:45 PM
yln committed rCRT360388: [TSan][libdispatch] Enable test that supposedly deadlocks on bot.
[TSan][libdispatch] Enable test that supposedly deadlocks on bot
May 9 2019, 3:45 PM
yln updated the diff for D61708: [TSan] Support `ignore_noninstrumented_modules` on Linux.

Chang symbol name check to require an exact match with the TSan
initializer called from the module ctor. This should avoid
accidental matches, e.g., __tsan_testonly_barrier_wait in tests.
My assumption is that this symbol is present in all modules
instrumented with TSan.

May 9 2019, 2:40 PM · Restricted Project, Restricted Project

May 8 2019

yln added a comment to D60575: [TSan][libdispatch] Use FileCheck's --implicit-check-not=....

@dvyukov, what do you think?

May 8 2019, 6:00 PM · Restricted Project, Restricted Project
yln updated the summary of D61708: [TSan] Support `ignore_noninstrumented_modules` on Linux.
May 8 2019, 5:51 PM · Restricted Project, Restricted Project
yln added inline comments to D61708: [TSan] Support `ignore_noninstrumented_modules` on Linux.
May 8 2019, 5:47 PM · Restricted Project, Restricted Project
yln created D61708: [TSan] Support `ignore_noninstrumented_modules` on Linux.
May 8 2019, 5:45 PM · Restricted Project, Restricted Project

May 1 2019

yln committed rG91c166cbb035: [Sanitizer] Reland "Cleanup INTERCEPT_FUNCTION macro" (authored by yln).
[Sanitizer] Reland "Cleanup INTERCEPT_FUNCTION macro"
May 1 2019, 1:57 PM
yln committed rL359725: [Sanitizer] Reland "Cleanup INTERCEPT_FUNCTION macro".
[Sanitizer] Reland "Cleanup INTERCEPT_FUNCTION macro"
May 1 2019, 1:56 PM
yln committed rCRT359725: [Sanitizer] Reland "Cleanup INTERCEPT_FUNCTION macro".
[Sanitizer] Reland "Cleanup INTERCEPT_FUNCTION macro"
May 1 2019, 1:56 PM
yln closed D61358: [Sanitizer] Reland "Cleanup INTERCEPT_FUNCTION macro".
May 1 2019, 1:55 PM · Restricted Project, Restricted Project
yln added a comment to D61358: [Sanitizer] Reland "Cleanup INTERCEPT_FUNCTION macro".

Cool, thanks Vitaly! Waiting for sign-off from Reid.

May 1 2019, 10:32 AM · Restricted Project, Restricted Project

Apr 30 2019

yln added reviewers for D61358: [Sanitizer] Reland "Cleanup INTERCEPT_FUNCTION macro": vitalybuka, rnk.
Apr 30 2019, 6:09 PM · Restricted Project, Restricted Project
yln created D61358: [Sanitizer] Reland "Cleanup INTERCEPT_FUNCTION macro".
Apr 30 2019, 5:54 PM · Restricted Project, Restricted Project
yln abandoned D61347: [Sanitizer] Reland of "Cleanup of INTERCEPT_FUNCTION macro".
Apr 30 2019, 5:48 PM · Restricted Project, Restricted Project
yln updated the diff for D61347: [Sanitizer] Reland of "Cleanup of INTERCEPT_FUNCTION macro".

Forgot to take address of wrapper.

Apr 30 2019, 3:09 PM · Restricted Project, Restricted Project
yln updated the summary of D61347: [Sanitizer] Reland of "Cleanup of INTERCEPT_FUNCTION macro".
Apr 30 2019, 3:08 PM · Restricted Project, Restricted Project
yln created D61347: [Sanitizer] Reland of "Cleanup of INTERCEPT_FUNCTION macro".
Apr 30 2019, 3:06 PM · Restricted Project, Restricted Project
yln added inline comments to D61145: [NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void.
Apr 30 2019, 1:57 PM · Restricted Project, Restricted Project

Apr 29 2019

yln committed rG1f10f6ea51f4: [Sanitizer] Cleanup {ASAN, MSAN}_INTERCEPT_FUNC[_VER] macro (authored by yln).
[Sanitizer] Cleanup {ASAN, MSAN}_INTERCEPT_FUNC[_VER] macro
Apr 29 2019, 9:38 AM
yln committed rCRT359466: [Sanitizer] Cleanup {ASAN, MSAN}_INTERCEPT_FUNC[_VER] macro.
[Sanitizer] Cleanup {ASAN, MSAN}_INTERCEPT_FUNC[_VER] macro
Apr 29 2019, 9:38 AM
yln committed rL359466: [Sanitizer] Cleanup {ASAN, MSAN}_INTERCEPT_FUNC[_VER] macro.
[Sanitizer] Cleanup {ASAN, MSAN}_INTERCEPT_FUNC[_VER] macro
Apr 29 2019, 9:38 AM
yln closed D61204: [Sanitizer] Cleanup {ASAN, MSAN}_INTERCEPT_FUNC[_VER] macro.
Apr 29 2019, 9:38 AM · Restricted Project, Restricted Project

Apr 26 2019

yln committed rGc1008e4d3dab: [NFC][Sanitizer] Remove GetRealFunctionAddress and replace usages (authored by yln).
[NFC][Sanitizer] Remove GetRealFunctionAddress and replace usages
Apr 26 2019, 5:48 PM
yln committed rCRT359362: [NFC][Sanitizer] Remove GetRealFunctionAddress and replace usages.
[NFC][Sanitizer] Remove GetRealFunctionAddress and replace usages
Apr 26 2019, 5:47 PM
yln committed rL359362: [NFC][Sanitizer] Remove GetRealFunctionAddress and replace usages.
[NFC][Sanitizer] Remove GetRealFunctionAddress and replace usages
Apr 26 2019, 5:47 PM
yln closed D61205: [NFC][Sanitizer] Remove GetRealFunctionAddress and replace usages.
Apr 26 2019, 5:47 PM · Restricted Project, Restricted Project
yln committed rG93c05f097a96: [Sanitizer][Windows] Speculative fix for broken build on Windows (authored by yln).
[Sanitizer][Windows] Speculative fix for broken build on Windows
Apr 26 2019, 12:05 PM
yln committed rL359339: [Sanitizer][Windows] Speculative fix for broken build on Windows.
[Sanitizer][Windows] Speculative fix for broken build on Windows
Apr 26 2019, 12:04 PM
yln committed rCRT359339: [Sanitizer][Windows] Speculative fix for broken build on Windows.
[Sanitizer][Windows] Speculative fix for broken build on Windows
Apr 26 2019, 12:04 PM
yln committed rG74967cb4e04c: [Sanitizer] Fix test (authored by yln).
[Sanitizer] Fix test
Apr 26 2019, 11:37 AM
yln committed rL359336: [Sanitizer] Fix test.
[Sanitizer] Fix test
Apr 26 2019, 11:37 AM
yln committed rCRT359336: [Sanitizer] Fix test.
[Sanitizer] Fix test
Apr 26 2019, 11:37 AM
yln committed rGd0e583001720: [Sanitizer] Fix compliation error in test (authored by yln).
[Sanitizer] Fix compliation error in test
Apr 26 2019, 11:28 AM
yln committed rL359335: [Sanitizer] Fix compliation error in test.
[Sanitizer] Fix compliation error in test
Apr 26 2019, 11:28 AM
yln committed rCRT359335: [Sanitizer] Fix compliation error in test.
[Sanitizer] Fix compliation error in test
Apr 26 2019, 11:28 AM
yln created D61205: [NFC][Sanitizer] Remove GetRealFunctionAddress and replace usages.
Apr 26 2019, 11:02 AM · Restricted Project, Restricted Project
yln created D61204: [Sanitizer] Cleanup {ASAN, MSAN}_INTERCEPT_FUNC[_VER] macro.
Apr 26 2019, 11:01 AM · Restricted Project, Restricted Project
yln committed rGaebd3014a595: [NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void (authored by yln).
[NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void
Apr 26 2019, 10:29 AM
yln committed rCRT359325: [NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void.
[NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void
Apr 26 2019, 10:29 AM
yln committed rL359325: [NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void.
[NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void
Apr 26 2019, 10:29 AM
yln closed D61145: [NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void.
Apr 26 2019, 10:29 AM · Restricted Project, Restricted Project

Apr 25 2019

yln added inline comments to D61145: [NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void.
Apr 25 2019, 2:38 PM · Restricted Project, Restricted Project
yln updated the summary of D61145: [NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void.
Apr 25 2019, 1:41 PM · Restricted Project, Restricted Project
yln added a reviewer for D61145: [NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void: vitalybuka.
Apr 25 2019, 1:39 PM · Restricted Project, Restricted Project
yln added inline comments to D61145: [NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void.
Apr 25 2019, 1:39 PM · Restricted Project, Restricted Project
yln created D61145: [NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void.
Apr 25 2019, 1:28 PM · Restricted Project, Restricted Project
yln committed rG8b36610bfa50: [NFC][Sanitizer] Extract GetFuncAddr from GetRealFunctionAddress (authored by yln).
[NFC][Sanitizer] Extract GetFuncAddr from GetRealFunctionAddress
Apr 25 2019, 10:45 AM
yln committed rL359213: [NFC][Sanitizer] Extract GetFuncAddr from GetRealFunctionAddress.
[NFC][Sanitizer] Extract GetFuncAddr from GetRealFunctionAddress
Apr 25 2019, 10:44 AM
yln committed rCRT359213: [NFC][Sanitizer] Extract GetFuncAddr from GetRealFunctionAddress.
[NFC][Sanitizer] Extract GetFuncAddr from GetRealFunctionAddress
Apr 25 2019, 10:44 AM
yln closed D61110: [NFC][Sanitizer] Extract GetFuncAddr from GetRealFunctionAddress.
Apr 25 2019, 10:44 AM · Restricted Project, Restricted Project

Apr 24 2019

yln updated the diff for D61110: [NFC][Sanitizer] Extract GetFuncAddr from GetRealFunctionAddress.

Update variable name for consistency.

Apr 24 2019, 7:34 PM · Restricted Project, Restricted Project
yln updated the summary of D61110: [NFC][Sanitizer] Extract GetFuncAddr from GetRealFunctionAddress.
Apr 24 2019, 7:18 PM · Restricted Project, Restricted Project
yln created D61110: [NFC][Sanitizer] Extract GetFuncAddr from GetRealFunctionAddress.
Apr 24 2019, 7:15 PM · Restricted Project, Restricted Project
yln abandoned D59504: [NFC][Sanitizer] Clean up GetRealFunctionAddress.
Apr 24 2019, 7:15 PM · Restricted Project, Restricted Project
yln added a comment to D59504: [NFC][Sanitizer] Clean up GetRealFunctionAddress.
#define ASAN_INTERCEPT_FUNC(name)                                        \
  do {                                                                   \
    if ((!INTERCEPT_FUNCTION(name) || !REAL(name)))                      \
      VReport(1, "AddressSanitizer: failed to intercept '" #name "'\n"); \
  } while (0)

I understand that as weird protection against double intercept

Apr 24 2019, 7:09 PM · Restricted Project, Restricted Project

Apr 23 2019

yln accepted D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms..

Overall changes: LGTM, thanks!

Apr 23 2019, 10:48 AM · Restricted Project, Restricted Project
yln accepted D60933: [CommandLine] Provide parser<unsigned long> instantiation to allow cl::opt<uint64_t> on LP64 platforms.

thanks!

Apr 23 2019, 10:34 AM · Restricted Project

Apr 22 2019

yln created D60981: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.1.
Apr 22 2019, 2:47 PM · Restricted Project, Restricted Project
yln added inline comments to D60933: [CommandLine] Provide parser<unsigned long> instantiation to allow cl::opt<uint64_t> on LP64 platforms.
Apr 22 2019, 9:59 AM · Restricted Project

Apr 19 2019

yln committed rG4d2b9426b99f: [TSan] Support fiber API on macOS (authored by yln).
[TSan] Support fiber API on macOS
Apr 19 2019, 5:18 PM
yln committed rCRT358802: [TSan] Support fiber API on macOS.
[TSan] Support fiber API on macOS
Apr 19 2019, 5:18 PM
yln committed rL358802: [TSan] Support fiber API on macOS.
[TSan] Support fiber API on macOS
Apr 19 2019, 5:17 PM
yln closed D58110: Support fiber API on macOS.
Apr 19 2019, 5:17 PM · Restricted Project, Restricted Project

Apr 15 2019

yln committed rCRT358469: [TSan][libdispatch] Port gcd-sync-block-copy.mm to C++.
[TSan][libdispatch] Port gcd-sync-block-copy.mm to C++
Apr 15 2019, 6:40 PM
yln committed rG263264345485: [TSan][libdispatch] Port gcd-sync-block-copy.mm to C++ (authored by yln).
[TSan][libdispatch] Port gcd-sync-block-copy.mm to C++
Apr 15 2019, 6:35 PM
yln committed rL358469: [TSan][libdispatch] Port gcd-sync-block-copy.mm to C++.
[TSan][libdispatch] Port gcd-sync-block-copy.mm to C++
Apr 15 2019, 6:34 PM
yln closed D60639: [TSan][libdispatch] Port gcd-sync-block-copy.mm to C++.
Apr 15 2019, 6:34 PM · Restricted Project, Restricted Project
yln added inline comments to D60575: [TSan][libdispatch] Use FileCheck's --implicit-check-not=....
Apr 15 2019, 10:39 AM · Restricted Project, Restricted Project
yln added inline comments to D60639: [TSan][libdispatch] Port gcd-sync-block-copy.mm to C++.
Apr 15 2019, 10:39 AM · Restricted Project, Restricted Project

Apr 12 2019

yln updated the diff for D60575: [TSan][libdispatch] Use FileCheck's --implicit-check-not=....

Update comment.

Apr 12 2019, 6:03 PM · Restricted Project, Restricted Project
yln added a reviewer for D60575: [TSan][libdispatch] Use FileCheck's --implicit-check-not=...: dvyukov.
Apr 12 2019, 5:45 PM · Restricted Project, Restricted Project
yln updated the diff for D60575: [TSan][libdispatch] Use FileCheck's --implicit-check-not=....

Extend to most TSan tests that matched "CHECK-NOT:.*ThreadSanitizer".
Skipped big, complicated tests with multiple run lines and CHECK prefixes.

Apr 12 2019, 5:44 PM · Restricted Project, Restricted Project
yln committed rGc77bf89dcce8: [TSan][libdispatch] Move libdispatch tests out of Darwin folder (authored by yln).
[TSan][libdispatch] Move libdispatch tests out of Darwin folder
Apr 12 2019, 4:06 PM
yln committed rL358316: [TSan][libdispatch] Move libdispatch tests out of Darwin folder.
[TSan][libdispatch] Move libdispatch tests out of Darwin folder
Apr 12 2019, 4:05 PM
yln committed rCRT358316: [TSan][libdispatch] Move libdispatch tests out of Darwin folder.
[TSan][libdispatch] Move libdispatch tests out of Darwin folder
Apr 12 2019, 4:05 PM
yln added reviewers for D60639: [TSan][libdispatch] Port gcd-sync-block-copy.mm to C++: kubamracek, dcoughlin.
Apr 12 2019, 3:36 PM · Restricted Project, Restricted Project
yln created D60639: [TSan][libdispatch] Port gcd-sync-block-copy.mm to C++.
Apr 12 2019, 3:36 PM · Restricted Project, Restricted Project
yln committed rG663697824341: [TSan][libdispatch] Don't link against Foundation (authored by yln).
[TSan][libdispatch] Don't link against Foundation
Apr 12 2019, 1:29 PM
yln committed rGbfcbd677c8b8: [TSan][libdispatch] Replace NSTemporaryDirectory in tests (authored by yln).
[TSan][libdispatch] Replace NSTemporaryDirectory in tests
Apr 12 2019, 1:29 PM
yln committed rCRT358309: [TSan][libdispatch] Don't link against Foundation.
[TSan][libdispatch] Don't link against Foundation
Apr 12 2019, 1:28 PM
yln committed rCRT358308: [TSan][libdispatch] Replace NSTemporaryDirectory in tests.
[TSan][libdispatch] Replace NSTemporaryDirectory in tests
Apr 12 2019, 1:28 PM