Page MenuHomePhabricator
Feed Advanced Search

Oct 2 2019

hiraditya closed D68318: Fix: Actually erase remove the elements from AssumeHandles.
Oct 2 2019, 10:33 AM · Restricted Project
hiraditya added a comment to D68318: Fix: Actually erase remove the elements from AssumeHandles.

Splitting the verifier into a separate diff: https://reviews.llvm.org/D68345

Oct 2 2019, 10:15 AM · Restricted Project
hiraditya added inline comments to D68345: Verify that assumption cache has valid entries..
Oct 2 2019, 10:09 AM · Restricted Project
hiraditya created D68345: Verify that assumption cache has valid entries..
Oct 2 2019, 10:09 AM · Restricted Project
hiraditya added a comment to D68318: Fix: Actually erase remove the elements from AssumeHandles.

It depends on the verifier function (CodeExtractor::verifyAssumptionCache) from D67941 to fail with the test case in: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll

Oct 2 2019, 9:37 AM · Restricted Project
hiraditya added a comment to D68318: Fix: Actually erase remove the elements from AssumeHandles.

Relevant test case: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll is already in trunk.

Oct 2 2019, 8:39 AM · Restricted Project
hiraditya committed rGc4a7b912c26e: [CodeExtractor] NFC: Refactor sanity checks into isEligible (authored by hiraditya).
[CodeExtractor] NFC: Refactor sanity checks into isEligible
Oct 2 2019, 8:36 AM
hiraditya added a comment to D68318: Fix: Actually erase remove the elements from AssumeHandles.

passed ninja check-all

Oct 2 2019, 8:36 AM · Restricted Project
hiraditya updated the summary of D68318: Fix: Actually erase remove the elements from AssumeHandles.
Oct 2 2019, 8:36 AM · Restricted Project
hiraditya added reviewers for D68318: Fix: Actually erase remove the elements from AssumeHandles: fhahn, tejohnson.
Oct 2 2019, 8:36 AM · Restricted Project
hiraditya committed rL373479: [CodeExtractor] NFC: Refactor sanity checks into isEligible.
[CodeExtractor] NFC: Refactor sanity checks into isEligible
Oct 2 2019, 8:35 AM
hiraditya closed D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible.
Oct 2 2019, 8:34 AM · Restricted Project
hiraditya updated the diff for D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible.

addressed comments

Oct 2 2019, 8:27 AM · Restricted Project
hiraditya added a comment to D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible.

ninja check passed

Oct 2 2019, 6:13 AM · Restricted Project
hiraditya added a reviewer for D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible: tejohnson.
Oct 2 2019, 5:57 AM · Restricted Project
hiraditya created D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible.
Oct 2 2019, 5:57 AM · Restricted Project
hiraditya committed rGb1fe6c90e66b: NFC: directly return when CommonExitBlock != Succ (authored by hiraditya).
NFC: directly return when CommonExitBlock != Succ
Oct 2 2019, 5:18 AM
hiraditya committed rL373456: NFC: directly return when CommonExitBlock != Succ.
NFC: directly return when CommonExitBlock != Succ
Oct 2 2019, 5:13 AM
hiraditya closed D68330: NFC: directly return when CommonExitBlock != Succ.
Oct 2 2019, 5:13 AM · Restricted Project
hiraditya created D68330: NFC: directly return when CommonExitBlock != Succ.
Oct 2 2019, 5:13 AM · Restricted Project

Oct 1 2019

hiraditya created D68318: Fix: Actually erase remove the elements from AssumeHandles.
Oct 1 2019, 9:13 PM · Restricted Project
hiraditya accepted D68159: [ThinLTO/WPD] Ensure devirtualized targets use promoted symbol when necessary.
Oct 1 2019, 5:56 PM · Restricted Project
hiraditya added a comment to D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.

Essentially did this:

diff --git a/llvm/lib/Transforms/Utils/CodeExtractor.cpp b/llvm/lib/Transforms/Utils/CodeExtractor.cpp
index 952263c0b1f..49fa07a3648 100644
--- a/llvm/lib/Transforms/Utils/CodeExtractor.cpp
+++ b/llvm/lib/Transforms/Utils/CodeExtractor.cpp
@@ -1336,13 +1336,13 @@ void CodeExtractor::calculateNewCallTerminatorWeights(
Oct 1 2019, 3:40 PM · Restricted Project
hiraditya added inline comments to D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.
Oct 1 2019, 3:27 PM · Restricted Project
hiraditya added inline comments to D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.
Oct 1 2019, 3:08 PM · Restricted Project
hiraditya added inline comments to D68159: [ThinLTO/WPD] Ensure devirtualized targets use promoted symbol when necessary.
Oct 1 2019, 2:42 PM · Restricted Project
hiraditya added inline comments to D67941: Invalidate assumption cache before outlining..
Oct 1 2019, 2:36 PM · Restricted Project
hiraditya updated the diff for D67941: Invalidate assumption cache before outlining..
Oct 1 2019, 2:36 PM · Restricted Project
hiraditya added a comment to D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.

Do we have further feedback for this patch?

Oct 1 2019, 1:49 PM · Restricted Project
hiraditya added inline comments to D67941: Invalidate assumption cache before outlining..
Oct 1 2019, 1:41 PM · Restricted Project
hiraditya added a comment to D68154: [Dominators][CodeGen] Fix MachineDominatorTree preservation in PHIElimination.

LGTM, thanks for committing.

Oct 1 2019, 11:42 AM · Restricted Project
hiraditya added inline comments to D67941: Invalidate assumption cache before outlining..
Oct 1 2019, 7:01 AM · Restricted Project
hiraditya updated the diff for D67941: Invalidate assumption cache before outlining..

Fixed a bug in assumption cache where the AssumeVH wasn't getting cleared.

Oct 1 2019, 6:56 AM · Restricted Project
hiraditya updated the diff for D67941: Invalidate assumption cache before outlining..
Oct 1 2019, 6:08 AM · Restricted Project
hiraditya updated the diff for D68095: Add a unittest to verify for assumption cache.
Oct 1 2019, 5:24 AM · Restricted Project
hiraditya updated the diff for D68095: Add a unittest to verify for assumption cache.
Oct 1 2019, 5:14 AM · Restricted Project

Sep 30 2019

hiraditya committed rG07286cb384c4: [OCaml] Handle nullptr in Llvm.global_initializer (authored by hiraditya).
[OCaml] Handle nullptr in Llvm.global_initializer
Sep 30 2019, 8:44 PM
hiraditya committed rL373299: [OCaml] Handle nullptr in Llvm.global_initializer.
[OCaml] Handle nullptr in Llvm.global_initializer
Sep 30 2019, 8:43 PM
hiraditya closed D65195: [OCaml] Handle nullptr in Llvm.global_initializer.
Sep 30 2019, 8:43 PM · Restricted Project
hiraditya updated the diff for D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.
Sep 30 2019, 6:09 PM · Restricted Project
hiraditya updated the diff for D67941: Invalidate assumption cache before outlining..

added flag to the testcase.

Sep 30 2019, 2:50 PM · Restricted Project
hiraditya updated the diff for D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.

Addressed comments from @vsk

  • Move input parameter validation to isEligible().

This now requires recomputing inputs in extractCodeRegion because PHI nodes, and return blocks are split. The computation cost of input is same as before because previously the input parameter would be computed on the client side (caller of extractCodeRegion) and introduce extra overhead to be taken care of.

Sep 30 2019, 1:59 PM · Restricted Project
hiraditya added inline comments to D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.
Sep 30 2019, 1:19 PM · Restricted Project
hiraditya updated the diff for D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.

Comments from @compnerd

Sep 30 2019, 9:37 AM · Restricted Project
hiraditya accepted D68228: [bugpoint] Update runPasses to take ArrayRef instead of a pointer (NFC).

LGTM, makes it easier to read as well!

Sep 30 2019, 9:00 AM · Restricted Project
hiraditya added inline comments to D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.
Sep 30 2019, 8:56 AM · Restricted Project

Sep 29 2019

hiraditya updated the diff for D52896: MergeSimilarFunctions 1/n: a code size pass to merge functions with small differences.

fix clonetype tests

Sep 29 2019, 11:13 PM · Restricted Project
hiraditya updated the diff for D52966: [Merge SImilar Function ThinLTO 3/n] Add hash code to function summary.

port to llvm bitcode version 8

Sep 29 2019, 11:13 PM · Restricted Project
hiraditya updated the diff for D52896: MergeSimilarFunctions 1/n: a code size pass to merge functions with small differences.

rebase

Sep 29 2019, 10:36 PM · Restricted Project
hiraditya updated the diff for D52898: [Porting MergeSimilarFunctions 2/n] Changes to DataLayout.

rebase

Sep 29 2019, 10:36 PM · Restricted Project, Restricted Project
hiraditya updated the diff for D52966: [Merge SImilar Function ThinLTO 3/n] Add hash code to function summary.

rebase

Sep 29 2019, 10:36 PM · Restricted Project
hiraditya updated the diff for D53253: [Merge SImilar Function ThinLTO 4/n] Make merge function decisions before the thin-lto stage.

rebase

Sep 29 2019, 10:36 PM · Restricted Project
hiraditya updated the diff for D53254: [Merge SImilar Function ThinLTO 5/n] Set up similar function to be imported.

rebase

Sep 29 2019, 10:36 PM · Restricted Project
hiraditya abandoned D45924: Set calling convention for varargs .
Sep 29 2019, 8:28 PM
hiraditya committed rG9a5e3d39f693: Undef the macros after their use (authored by hiraditya).
Undef the macros after their use
Sep 29 2019, 7:46 PM
hiraditya committed rL373176: Undef the macros after their use.
Undef the macros after their use
Sep 29 2019, 7:46 PM
hiraditya closed D46378: Undef the macros after their use.
Sep 29 2019, 7:45 PM · Restricted Project
hiraditya updated the diff for D46378: Undef the macros after their use.

rebase

Sep 29 2019, 7:41 PM · Restricted Project
hiraditya planned changes to D66614: Add inline to uflow and underflow.

after collecting numbers

Sep 29 2019, 7:35 PM
hiraditya added a comment to D67941: Invalidate assumption cache before outlining..

@vsk Fixed the unittest in: D68095, it triggers the failure when AssumptionCache is stale.

Sep 29 2019, 7:14 PM · Restricted Project
hiraditya updated the diff for D68095: Add a unittest to verify for assumption cache.

rename test

Sep 29 2019, 7:11 PM · Restricted Project
hiraditya added a reviewer for D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic: fhahn.
Sep 29 2019, 5:33 PM · Restricted Project
hiraditya added a comment to D57123: [MergeSets] Add infrastructure to build merge sets based on Das and Ramakrishna's paper..

Great, looking forward to it!

Sep 29 2019, 3:03 PM · Restricted Project
hiraditya added inline comments to D67941: Invalidate assumption cache before outlining..
Sep 29 2019, 3:01 PM · Restricted Project
hiraditya added inline comments to D68154: [Dominators][CodeGen] Fix MachineDominatorTree preservation in PHIElimination.
Sep 29 2019, 11:18 AM · Restricted Project
hiraditya added a reviewer for D68076: [AArch64] Enable unwind tables by default for Gnu targets: t.p.northover.
Sep 29 2019, 11:10 AM · Restricted Project
hiraditya added a reviewer for D68076: [AArch64] Enable unwind tables by default for Gnu targets: hiraditya.
Sep 29 2019, 11:10 AM · Restricted Project
hiraditya added a comment to D68076: [AArch64] Enable unwind tables by default for Gnu targets.

Can we add a test to verify cfi instructions are present without debug flag.

Sep 29 2019, 11:10 AM · Restricted Project
hiraditya added inline comments to D68191: Simplify function llvm::removeUnreachableBlocks() to avoid (re-)computation..
Sep 29 2019, 10:59 AM · Restricted Project
hiraditya added inline comments to D57123: [MergeSets] Add infrastructure to build merge sets based on Das and Ramakrishna's paper..
Sep 29 2019, 10:40 AM · Restricted Project
hiraditya requested changes to D57123: [MergeSets] Add infrastructure to build merge sets based on Das and Ramakrishna's paper..
Sep 29 2019, 10:38 AM · Restricted Project
hiraditya accepted D57123: [MergeSets] Add infrastructure to build merge sets based on Das and Ramakrishna's paper..

i think this will help quite a few optimizations get faster and enable others like instruction scheduling in SSA. We can push this patch and make incremental improvements as needed. Thanks for working on this!

Sep 29 2019, 10:20 AM · Restricted Project
hiraditya accepted D67199: [InstCombine] Expand the simplification of log().
Sep 29 2019, 10:03 AM · Restricted Project
hiraditya added inline comments to D68154: [Dominators][CodeGen] Fix MachineDominatorTree preservation in PHIElimination.
Sep 29 2019, 9:58 AM · Restricted Project
hiraditya resigned from D64380: Add 'require_designated_init' and 'required' attribute to clang.
Sep 29 2019, 9:43 AM · Restricted Project
hiraditya added a reviewer for D67941: Invalidate assumption cache before outlining.: fhahn.
Sep 29 2019, 9:43 AM · Restricted Project
hiraditya added a comment to D68194: [LCSSA] Forget values we create LCSSA phis for.

LGTM, can we add test case from the PR?
https://bugs.llvm.org/show_bug.cgi?id=43458

Sep 29 2019, 9:39 AM · Restricted Project
hiraditya closed D53514: os_log: make buffer size an integer constant expression..

closed in r345828, 314fbfa1c4c6665c54a220eefb10a6f23010a352

Sep 29 2019, 9:16 AM · Restricted Project
hiraditya added a comment to D65070: [LLVM-C][OCaml] Add a fast linker binding.

Can we get review on this patch.

Sep 29 2019, 9:09 AM · Restricted Project
hiraditya committed rGa6d9d31279c8: [LLVM-C][Ocaml] Add MergeFunctions and DCE pass (authored by hiraditya).
[LLVM-C][Ocaml] Add MergeFunctions and DCE pass
Sep 29 2019, 9:06 AM
hiraditya committed rL373170: [LLVM-C][Ocaml] Add MergeFunctions and DCE pass.
[LLVM-C][Ocaml] Add MergeFunctions and DCE pass
Sep 29 2019, 9:06 AM
hiraditya closed D65071: [LLVM-C][Ocaml] Add MergeFunctions and DCE pass.
Sep 29 2019, 9:06 AM · Restricted Project
hiraditya added a reviewer for D67941: Invalidate assumption cache before outlining.: sebpop.
Sep 29 2019, 9:00 AM · Restricted Project
hiraditya added a comment to D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting.

it will be great to merge this patch.

Sep 29 2019, 7:30 AM · Restricted Project
hiraditya updated the diff for D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.
Sep 29 2019, 7:30 AM · Restricted Project
hiraditya updated the diff for D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.
Sep 29 2019, 7:25 AM · Restricted Project
hiraditya updated the diff for D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.
Sep 29 2019, 7:23 AM · Restricted Project
hiraditya updated the diff for D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.
Sep 29 2019, 7:20 AM · Restricted Project
hiraditya created D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.
Sep 29 2019, 7:02 AM · Restricted Project

Sep 28 2019

hiraditya committed rG2adae76cc601: [NFC] Move hot cold splitting class to header file (authored by hiraditya).
[NFC] Move hot cold splitting class to header file
Sep 28 2019, 11:14 AM
hiraditya committed rL373151: [NFC] Move hot cold splitting class to header file.
[NFC] Move hot cold splitting class to header file
Sep 28 2019, 11:14 AM
hiraditya closed D68079: [NFC] Move hot cold splitting class to header file.
Sep 28 2019, 11:14 AM · Restricted Project
hiraditya added a comment to D67941: Invalidate assumption cache before outlining..

Is there any feedback for improvement, I'd like to push this if reasonable.

Sep 28 2019, 9:56 AM · Restricted Project

Sep 26 2019

hiraditya added a comment to D67941: Invalidate assumption cache before outlining..

@vsk I tried adding test to CodeExtractorTest (D68095), for some reason the verifier didn't fail. I may be missing something and can use some help.
We can follow up on the test in the new diff if that is reasonable.

Sep 26 2019, 11:40 AM · Restricted Project
hiraditya created D68095: Add a unittest to verify for assumption cache.
Sep 26 2019, 11:39 AM · Restricted Project
hiraditya updated the diff for D67941: Invalidate assumption cache before outlining..

Added AssumptionCache verifier to verify the original function.

Sep 26 2019, 11:38 AM · Restricted Project
hiraditya added reviewers for D68079: [NFC] Move hot cold splitting class to header file: sebpop, brzycki, SirishP.
Sep 26 2019, 4:43 AM · Restricted Project
hiraditya updated the diff for D68079: [NFC] Move hot cold splitting class to header file.
Sep 26 2019, 4:42 AM · Restricted Project
hiraditya created D68079: [NFC] Move hot cold splitting class to header file.
Sep 26 2019, 4:32 AM · Restricted Project

Sep 25 2019

hiraditya added inline comments to D67941: Invalidate assumption cache before outlining..
Sep 25 2019, 3:25 PM · Restricted Project