Page MenuHomePhabricator
Feed Advanced Search

Tue, Jun 30

hiraditya added a comment to D81369: [Alignment][NFC] Migrate AtomicExpandPass to Align.

@vish99 will your work in https://reviews.llvm.org/D82892
check alignment changes as well?

Tue, Jun 30, 11:56 AM · Restricted Project
hiraditya added a comment to D82832: Correctly generate invert xor value for Binary Atomics of int size > 64.

Nice find!

Tue, Jun 30, 11:56 AM
hiraditya added a comment to D82730: [SimplifyCFG] Merge identical basic blocks (WIP).

SimplifyCFG doesn't look like a good place to put this as it is called multiple times and impacts compile time significantly.
Agreed with @jfb that having hasher as a separate pass which other passes can consume. @vish99 may have more ideas on hashing.
Hashing can be expensive and we could use clever tricks to make it cheaper. D52896 could help, happy to provide more input.

Tue, Jun 30, 11:56 AM · Restricted Project

Mon, Jun 22

hiraditya added inline comments to D82085: [TRE] allow TRE for non-capturing calls..
Mon, Jun 22, 4:07 PM · Restricted Project, Restricted Project
hiraditya added reviewers for D82039: Integrated cmpOperations() of FunctionComparator into tblgen: hiraditya, jfb.
Mon, Jun 22, 10:44 AM · Restricted Project

Sun, Jun 21

hiraditya removed a reviewer for D76480: [MergeSimilarFunctions] Merge D52896 with current trunk: hiraditya.
Sun, Jun 21, 9:00 AM · Restricted Project
hiraditya removed reviewers for D76481: [MergeSimilarFunctions] Merge {D52896, D52898} with current trunk: hiraditya, tejohnson, jfb.
Sun, Jun 21, 9:00 AM · Restricted Project

Sat, Jun 13

hiraditya added a comment to D81768: [llvm-objcopy][MachO] Add support for LC_CODE_SIGNATURE.

Thanks a lot for fixing this, this was blocking me earlier yesterday and @smeenai asked me to reach out to you.

Sat, Jun 13, 7:30 AM · Restricted Project

Fri, Jun 12

hiraditya added a comment to D81768: [llvm-objcopy][MachO] Add support for LC_CODE_SIGNATURE.

Not sure if this will also fix: "llvm-objcopy: error: unsupported load command (cmd=0x1d)" error. https://bugs.llvm.org/show_bug.cgi?id=46306

Fri, Jun 12, 8:01 PM · Restricted Project

Thu, Jun 4

hiraditya updated the diff for D81187: Add cl::ZeroOrMore to get around build system issues.
Thu, Jun 4, 4:03 PM · Restricted Project
hiraditya created D81187: Add cl::ZeroOrMore to get around build system issues.
Thu, Jun 4, 12:42 PM · Restricted Project

Wed, Jun 3

hiraditya added a comment to D74362: Cheap Function Entry Instrumentation for Dead Code Detection.

The results of fxray as compared to function entry instrumentation.

Wed, Jun 3, 4:35 PM · Restricted Project
hiraditya added a reviewer for D74362: Cheap Function Entry Instrumentation for Dead Code Detection: dberris.
Wed, Jun 3, 4:35 PM · Restricted Project
hiraditya added a comment to D74362: Cheap Function Entry Instrumentation for Dead Code Detection.

A high-level comment: does this pass achieve something not doable with XRay, a mature instrumentation framework in LLVM?

All of this can be implemented as a runtime plugged into the XRay framework. If you just want to see which functions have been called (or executed) in this documentation I have an example of how to do precisely what this is attempting to do:

https://reviews.llvm.org/D56244

That implementation works for basic and FDR modes.

Thanks for the link.
The code size overhead of this instrumentation is 12bytes per function(adrp+strb+1byte in global array) + 13bytes per module. how does this compare to xray instrumentation?

Wed, Jun 3, 12:05 PM · Restricted Project

May 30 2020

hiraditya updated the diff for D74362: Cheap Function Entry Instrumentation for Dead Code Detection.
May 30 2020, 1:47 PM · Restricted Project
hiraditya removed reviewers for D74362: Cheap Function Entry Instrumentation for Dead Code Detection: kyulee, Nikolai.
May 30 2020, 1:46 PM · Restricted Project

May 27 2020

hiraditya added inline comments to D44823: [libcxx] Improving std::vector<char> and std::deque<char> perfomance.
May 27 2020, 2:43 PM

May 6 2020

hiraditya added reviewers for D78129: Add Marvell ThunderX3T110 support: evandro, SirishP, jverma.
May 6 2020, 2:44 PM · Restricted Project, Restricted Project

Mar 31 2020

hiraditya added inline comments to D69257: Outline non returning functions unless a longjmp.
Mar 31 2020, 6:36 AM · Restricted Project

Mar 24 2020

hiraditya added a comment to D22630: Loop rotation.

An interesting case to explore: https://bugs.llvm.org/show_bug.cgi?id=27360
LLVM does not peel/unroll loops with multiple exits. With this loop rotation this should be possible.

Mar 24 2020, 10:12 AM

Mar 23 2020

hiraditya updated subscribers of D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.
Mar 23 2020, 11:57 PM · Restricted Project

Mar 22 2020

hiraditya accepted D76566: MergeFunctions.rst - multiply vs shift typo (PR44717).
Mar 22 2020, 4:38 PM · Restricted Project

Mar 21 2020

hiraditya added a comment to D76517: [MegreSimilarFunctions] D52896, D52898 and D52966 merged into LLVM trunk.

This is only for preliminary assignment for the student to get some idea of the project. We'll most likely restart with previous suggestions from the original patch and the mailing list. Please ignore this patch for now. Sorry for introducing noise.

Mar 21 2020, 5:06 PM · Restricted Project, Restricted Project
hiraditya added reviewers for D22630: Loop rotation: Meinersbur, kbarton.
Mar 21 2020, 4:34 PM

Mar 1 2020

hiraditya updated subscribers of D75233: [LoopTerminology] LCSSA Form.

FYI: Here's the paper by @sebpop explaining loop-closed SSA http://cri.ensmp.fr/classement/doc/E-285.pdf hth.

Mar 1 2020, 12:05 PM · Restricted Project

Feb 10 2020

hiraditya created D74362: Cheap Function Entry Instrumentation for Dead Code Detection.
Feb 10 2020, 3:10 PM · Restricted Project

Jan 17 2020

hiraditya accepted D72873: [clang][xray] Add -fxray-ignore-loops option.

The test case is in another patch so LGTM.

Jan 17 2020, 10:22 AM · Restricted Project
hiraditya added inline comments to D72873: [clang][xray] Add -fxray-ignore-loops option.
Jan 17 2020, 10:22 AM · Restricted Project

Jan 7 2020

hiraditya added a comment to D71733: [NFC][InlineCost] Factor cost modeling out of CallAnalyzer traversal..

Thanks for refactoring LGTM.

Jan 7 2020, 11:41 AM · Restricted Project

Nov 8 2019

hiraditya added inline comments to D70014: ThinLTO : Import always_inline functions irrespective of the threshold.
Nov 8 2019, 9:58 AM · Restricted Project
hiraditya committed rG1d321434a202: [llvm-xray] Add AArch64 to llvm-xray extract (authored by hiraditya).
[llvm-xray] Add AArch64 to llvm-xray extract
Nov 8 2019, 6:44 AM
hiraditya closed D69967: [llvm-xray] Add AArch64 to llvm-xray extract.
Nov 8 2019, 6:44 AM · Restricted Project

Oct 31 2019

hiraditya updated the diff for D65376: Randomly outline code for cold regions.

Rebase

Oct 31 2019, 9:05 PM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Rebase against master.

Oct 31 2019, 4:35 PM · Restricted Project
hiraditya added a comment to D57123: [MergeSets] Add infrastructure to build merge sets based on Das and Ramakrishna's paper..

Thanks for rebasing the patch.

Oct 31 2019, 11:18 AM · Restricted Project

Oct 30 2019

hiraditya updated the summary of D32140: Global code motion of congruent computations.
Oct 30 2019, 10:02 AM · Restricted Project

Oct 29 2019

hiraditya updated the summary of D32140: Global code motion of congruent computations.
Oct 29 2019, 1:44 PM · Restricted Project
hiraditya added a comment to D32140: Global code motion of congruent computations.

GVNHoist was recently reverted maily due to big regressions:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20181001/591519.html

Oct 29 2019, 7:11 AM · Restricted Project
hiraditya added a comment to D32140: Global code motion of congruent computations.

Two high level comments after a quick glance

  1. gnv-sink & gvn-hoist are still disabled by default AFAIK and there are still a few known bugs that need to be addressed (https://bugs.llvm.org/buglist.cgi?quicksearch=gvn-hoist, https://bugs.llvm.org/buglist.cgi?quicksearch=gvn-sink). It would be good to guard this change by a new flag that's off by default, otherwise it might hinder work towards weeding out the existing bugs.
Oct 29 2019, 7:11 AM · Restricted Project
hiraditya added a comment to D32140: Global code motion of congruent computations.

Hi @hiraditya , thanks for your work. I want to test your patch on PowerPC, however current patch seems unable to be applied to current master branch.

Oct 29 2019, 7:02 AM · Restricted Project

Oct 28 2019

hiraditya updated the summary of D32140: Global code motion of congruent computations.
Oct 28 2019, 9:49 PM · Restricted Project
hiraditya updated the summary of D32140: Global code motion of congruent computations.
Oct 28 2019, 9:47 PM · Restricted Project
hiraditya updated the summary of D32140: Global code motion of congruent computations.
Oct 28 2019, 9:44 PM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Add testcase for sinking

Oct 28 2019, 5:30 PM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Remove unused variable and use function for updating local stats.

Oct 28 2019, 11:00 AM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Make MaxSinkChainLength a flag.

Oct 28 2019, 10:42 AM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Remove VNs already handled to reduce redundant lookups.

Oct 28 2019, 10:35 AM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Sink iteratively.

Oct 28 2019, 10:23 AM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Sink iteratively

Oct 28 2019, 6:54 AM · Restricted Project

Oct 27 2019

hiraditya removed reviewers for D32140: Global code motion of congruent computations: dberlin, chandlerc, efriedma.
Oct 27 2019, 12:53 PM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Rebase against master and use profitability to reduce liveness

Oct 27 2019, 12:48 PM · Restricted Project

Oct 25 2019

hiraditya added a comment to D69257: Outline non returning functions unless a longjmp.

ping.

Oct 25 2019, 8:15 AM · Restricted Project

Oct 24 2019

hiraditya updated the diff for D69384: Add unlikely attribute to outlined function.

Add check for both hot and cold prefixes.

Oct 24 2019, 3:02 PM · Restricted Project
hiraditya added a comment to D69384: Add unlikely attribute to outlined function.

btw, I had this patch in mind:

Oct 24 2019, 2:50 PM · Restricted Project
hiraditya updated the diff for D69384: Add unlikely attribute to outlined function.
Oct 24 2019, 2:50 PM · Restricted Project
hiraditya updated the diff for D69384: Add unlikely attribute to outlined function.

It is happening without my changes with -codegenprepare. So just keeping the testcase.

Oct 24 2019, 2:50 PM · Restricted Project
hiraditya updated the diff for D69384: Add unlikely attribute to outlined function.

test case

Oct 24 2019, 2:26 PM · Restricted Project
hiraditya updated the diff for D69257: Outline non returning functions unless a longjmp.

Added testcase

Oct 24 2019, 2:16 PM · Restricted Project
hiraditya added a comment to D69384: Add unlikely attribute to outlined function.

Because my goal is to improve outlining without PGO (with static analysis), I'm wondering what would be the best place to put this other than HotColdSplitting.

Oct 24 2019, 2:14 PM · Restricted Project
hiraditya created D69384: Add unlikely attribute to outlined function.
Oct 24 2019, 7:02 AM · Restricted Project

Oct 21 2019

hiraditya updated the diff for D69257: Outline non returning functions unless a longjmp.
Oct 21 2019, 2:41 PM · Restricted Project
hiraditya updated the diff for D69257: Outline non returning functions unless a longjmp.
Oct 21 2019, 2:41 PM · Restricted Project
hiraditya updated the diff for D69257: Outline non returning functions unless a longjmp.
Oct 21 2019, 10:37 AM · Restricted Project
hiraditya updated the diff for D65376: Randomly outline code for cold regions.

WIP

Oct 21 2019, 7:06 AM · Restricted Project
hiraditya created D69257: Outline non returning functions unless a longjmp.
Oct 21 2019, 6:43 AM · Restricted Project
hiraditya added a comment to D69257: Outline non returning functions unless a longjmp.

Will add test case soon.

Oct 21 2019, 6:43 AM · Restricted Project

Oct 18 2019

hiraditya updated the diff for D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.

rebase against latest changes

Oct 18 2019, 5:19 AM · Restricted Project

Oct 15 2019

hiraditya committed rL374966: Request commit access for nadavrot.
Request commit access for nadavrot
Oct 15 2019, 7:19 PM
hiraditya committed rG9d10b9d99b4d: CodeExtractor: NFC: Use Range based loop (authored by hiraditya).
CodeExtractor: NFC: Use Range based loop
Oct 15 2019, 6:52 PM
hiraditya closed D68924: CodeExtractor: NFC: Use Range based loop.
Oct 15 2019, 6:51 PM · Restricted Project
hiraditya committed rL374963: CodeExtractor: NFC: Use Range based loop.
CodeExtractor: NFC: Use Range based loop
Oct 15 2019, 6:51 PM
hiraditya committed rL374960: Request commit access for nadav.
Request commit access for nadav
Oct 15 2019, 5:54 PM

Oct 13 2019

hiraditya abandoned D66614: Add inline to uflow and underflow.
Oct 13 2019, 4:27 PM
hiraditya added a comment to D68924: CodeExtractor: NFC: Use Range based loop.

Good point, there's something about updating the users that copying maybe required. make_early_inc_range didn't work, I searched for uses cases of replaceUsesOfWith and I couldn't find any instance where we use 'users'.

Oct 13 2019, 12:27 PM · Restricted Project
hiraditya added a comment to D68924: CodeExtractor: NFC: Use Range based loop.

Tried the following, I get test failures and crashes.

Oct 13 2019, 10:28 AM · Restricted Project

Oct 12 2019

hiraditya created D68924: CodeExtractor: NFC: Use Range based loop.
Oct 12 2019, 6:58 PM · Restricted Project

Oct 7 2019

hiraditya accepted D68257: [Support] Add mathematical constants.

LGTM as the comments have been addressed.

Oct 7 2019, 2:45 PM · Restricted Project
hiraditya accepted D68285: [AMDGPU] Use math constants defined in MathExtras (NFC).
Oct 7 2019, 2:43 PM · Restricted Project
hiraditya accepted D68399: Update lit infra to detect "MemoryWithOrigins' sanitizer build..
Oct 7 2019, 2:36 PM · Restricted Project
hiraditya added inline comments to D68559: [RISCV] Support fast calling convention.
Oct 7 2019, 2:30 PM · Restricted Project
hiraditya added inline comments to D68579: [HardwareLoops] Optimisation remarks.
Oct 7 2019, 2:06 PM · Restricted Project
hiraditya added a comment to D68579: [HardwareLoops] Optimisation remarks.

Nice!

Oct 7 2019, 12:38 PM · Restricted Project
hiraditya added inline comments to D68570: Unify the two CRC implementations.
Oct 7 2019, 12:16 PM · Restricted Project, Restricted Project, Restricted Project
hiraditya added inline comments to D68093: [clang-scan-deps][static analyzer] Support for clang --analyze in scan-deps.
Oct 7 2019, 12:05 PM · Restricted Project, Restricted Project
hiraditya closed D22834: Added 'inline' attribute to basic_string's destructor.
Oct 7 2019, 6:47 AM · Restricted Project

Oct 4 2019

hiraditya committed rG50afaa9d34d6: Add a unittest to verify for assumption cache (authored by hiraditya).
Add a unittest to verify for assumption cache
Oct 4 2019, 4:37 PM
hiraditya committed rL373811: Add a unittest to verify for assumption cache.
Add a unittest to verify for assumption cache
Oct 4 2019, 4:37 PM
hiraditya closed D68095: Add a unittest to verify for assumption cache.
Oct 4 2019, 4:37 PM · Restricted Project
hiraditya abandoned D68345: Verify that assumption cache has valid entries..

Reviewed and committed: https://reviews.llvm.org/D67941

Oct 4 2019, 4:28 PM · Restricted Project
hiraditya added a comment to D68478: Invalidate assumption cache before outlining..

Reviewed here: https://reviews.llvm.org/D67941

Oct 4 2019, 4:22 PM · Restricted Project
hiraditya closed D67941: Invalidate assumption cache before outlining..

Closed in: https://reviews.llvm.org/rL373807

Oct 4 2019, 4:22 PM · Restricted Project
hiraditya committed rG6a2673605e50: Invalidate assumption cache before outlining. (authored by hiraditya).
Invalidate assumption cache before outlining.
Oct 4 2019, 3:46 PM
hiraditya committed rL373807: Invalidate assumption cache before outlining..
Invalidate assumption cache before outlining.
Oct 4 2019, 3:45 PM
hiraditya closed D68478: Invalidate assumption cache before outlining..
Oct 4 2019, 3:45 PM · Restricted Project
hiraditya created D68478: Invalidate assumption cache before outlining..
Oct 4 2019, 12:12 PM · Restricted Project

Oct 2 2019

hiraditya added inline comments to D67941: Invalidate assumption cache before outlining..
Oct 2 2019, 2:13 PM · Restricted Project
hiraditya updated the diff for D68345: Verify that assumption cache has valid entries..

remove XFAIL now that fix had landed

Oct 2 2019, 10:37 AM · Restricted Project
hiraditya added a reviewer for D68345: Verify that assumption cache has valid entries.: fhahn.
Oct 2 2019, 10:36 AM · Restricted Project
hiraditya committed rG0cacf136fcbc: Fix: Actually erase remove the elements from AssumeHandles (authored by hiraditya).
Fix: Actually erase remove the elements from AssumeHandles
Oct 2 2019, 10:35 AM
hiraditya committed rL373494: Fix: Actually erase remove the elements from AssumeHandles.
Fix: Actually erase remove the elements from AssumeHandles
Oct 2 2019, 10:33 AM