Page MenuHomePhabricator
Feed Advanced Search

Sat, Jan 16

hiraditya added inline comments to D94202: Preserve the lexical order of global variables during llvm-link merge.
Sat, Jan 16, 10:01 AM · Restricted Project

Thu, Jan 14

hiraditya added a reviewer for D94167: [ARM][GISel] Treat calls as variadic even if only fixed arguments provided: t.p.northover.
Thu, Jan 14, 8:30 AM · Restricted Project

Tue, Jan 5

hiraditya committed rW98514120753a: Added note about video recording (authored by hiraditya).
Added note about video recording
Tue, Jan 5, 1:07 PM
hiraditya committed rW54461db6c77e: Extending the deadline by another 10 days (authored by hiraditya).
Extending the deadline by another 10 days
Tue, Jan 5, 7:08 AM

Dec 18 2020

hiraditya committed rG1ab4db0f847f: [HotColdSplit] Reflect full cost of parameters in split penalty (authored by hiraditya).
[HotColdSplit] Reflect full cost of parameters in split penalty
Dec 18 2020, 5:07 PM
hiraditya closed D59715: [HotColdSplit] Reflect full cost of parameters in split penalty.
Dec 18 2020, 5:06 PM · Restricted Project
hiraditya committed rW4eae6584ffb0: [LLVM CGO Workshop] Formatting fixes (authored by hiraditya).
[LLVM CGO Workshop] Formatting fixes
Dec 18 2020, 4:52 PM
hiraditya added a comment to D93559: Rename files with same (case insensitive) name.

I need to setup access token because github has changed commit policy recently.

Dec 18 2020, 12:57 PM · Restricted Project
hiraditya added a comment to D93559: Rename files with same (case insensitive) name.

It seems, I'm no longer having access to the llvm-project. Please commit this for me.

Dec 18 2020, 12:55 PM · Restricted Project
hiraditya updated the diff for D93559: Rename files with same (case insensitive) name.

rename

Dec 18 2020, 12:08 PM · Restricted Project
hiraditya added a comment to D93559: Rename files with same (case insensitive) name.

ok i'll rename this before commit.

Dec 18 2020, 12:07 PM · Restricted Project
hiraditya added a reviewer for D93559: Rename files with same (case insensitive) name: smeenai.
Dec 18 2020, 11:52 AM · Restricted Project
hiraditya updated the summary of D93559: Rename files with same (case insensitive) name.
Dec 18 2020, 11:46 AM · Restricted Project
hiraditya requested review of D93559: Rename files with same (case insensitive) name.
Dec 18 2020, 11:44 AM · Restricted Project
hiraditya updated the diff for D59715: [HotColdSplit] Reflect full cost of parameters in split penalty.

Rebase, fix a typo, change default hotcoldsplit-max-params=4

Dec 18 2020, 11:30 AM · Restricted Project
hiraditya added a reviewer for D91718: [LV] Legalize scalable VF hints: zinob.
Dec 18 2020, 10:01 AM · Restricted Project

Dec 17 2020

hiraditya retitled D93518: [Not for review, only reference] Adding private method attribute by inferring from the program from [Not fore review, only reference] Adding private method attribute by inferring from the program to [Not for review, only reference] Adding private method attribute by inferring from the program.
Dec 17 2020, 11:57 PM
hiraditya retitled D93518: [Not for review, only reference] Adding private method attribute by inferring from the program from Adding private method attribute by inferring from the program to [Not fore review, only reference] Adding private method attribute by inferring from the program.
Dec 17 2020, 11:57 PM
hiraditya retitled D93519: [Not for review, only reference] Add objc_private_attr as function attribute from [Not fore review, only reference] Add objc_private_attr as function attribute to [Not for review, only reference] Add objc_private_attr as function attribute.
Dec 17 2020, 11:57 PM
hiraditya requested review of D93519: [Not for review, only reference] Add objc_private_attr as function attribute.
Dec 17 2020, 11:57 PM
hiraditya requested review of D93518: [Not for review, only reference] Adding private method attribute by inferring from the program.
Dec 17 2020, 11:56 PM
hiraditya edited reviewers for D93517: [Not for review, only reference] Adding attribute to private method for inlining, added: hiraditya; removed: aaron.ballman.
Dec 17 2020, 11:54 PM
hiraditya retitled D93517: [Not for review, only reference] Adding attribute to private method for inlining from Adding attribute to private method for inlining to [Not for review, only reference] Adding attribute to private method for inlining.
Dec 17 2020, 11:54 PM
hiraditya requested review of D93517: [Not for review, only reference] Adding attribute to private method for inlining.
Dec 17 2020, 11:54 PM
hiraditya updated subscribers of D93515: [Not for review, only for reference] Devirtualize private methods which are annotated with private attribute.
Dec 17 2020, 11:34 PM
hiraditya updated the diff for D93515: [Not for review, only for reference] Devirtualize private methods which are annotated with private attribute.
Dec 17 2020, 11:34 PM
hiraditya requested review of D93515: [Not for review, only for reference] Devirtualize private methods which are annotated with private attribute.
Dec 17 2020, 11:28 PM
hiraditya added a comment to D88460: Strlen loop idiom recognition.

It'll be nice to know if this patch worked fine with a set of regression tests.
results on LLVM testsuite, or clang bootstrap will really help.

Thanks for working on this.

Thank you for the feedback @hiraditya! I have tested the latest patch at various options (O2, O3, LTO and PGO) against the SPEC benchmarks as well as run the lnt tests and bootstrap tests successfully. If you were concerned about any other specific testsuite, pls let me know.

Dec 17 2020, 11:14 PM · Restricted Project

Dec 5 2020

hiraditya added a comment to D92506: Remove memory allocation with string.

the following failures reported by buildbot are unrelated to this change:

Dec 5 2020, 3:17 PM · Restricted Project
hiraditya committed rGc4e327a960d2: Remove memory allocation with string (authored by hiraditya).
Remove memory allocation with string
Dec 5 2020, 3:15 PM
hiraditya closed D92506: Remove memory allocation with string.
Dec 5 2020, 3:15 PM · Restricted Project
hiraditya updated the diff for D92506: Remove memory allocation with string.

remove consume

Dec 5 2020, 11:44 AM · Restricted Project

Dec 4 2020

hiraditya updated the diff for D92506: Remove memory allocation with string.

Rebase

Dec 4 2020, 4:45 PM · Restricted Project

Dec 2 2020

hiraditya added a reviewer for D92506: Remove memory allocation with string: zinob.
Dec 2 2020, 1:10 PM · Restricted Project
hiraditya added a reviewer for D92506: Remove memory allocation with string: nadav.
Dec 2 2020, 1:09 PM · Restricted Project
hiraditya requested review of D92506: Remove memory allocation with string.
Dec 2 2020, 1:09 PM · Restricted Project
hiraditya added a comment to D90831: DebugInfo support for OCaml bindings.

Maybe ask in Discord to get reviewers?

Dec 2 2020, 10:26 AM · Restricted Project

Nov 3 2020

hiraditya added a comment to D90708: [LangRef] Clarify GEP inbounds wrapping semantics.

LGTM, an example of a gep with inbounds wouldbe nice. there are some test cases like: CodeGen/2009-02-13-zerosize-union-field.c, CodeGen/2010-07-14-ref-off-end.c etc from where we can take a reduced example for the doc.

Nov 3 2020, 2:16 PM · Restricted Project
hiraditya updated subscribers of D90342: [POC][LoopVectorizer] Propagate ElementCount to interfaces in preparation for scalable auto-vec. .
Nov 3 2020, 2:08 PM · Restricted Project
hiraditya added inline comments to D90342: [POC][LoopVectorizer] Propagate ElementCount to interfaces in preparation for scalable auto-vec. .
Nov 3 2020, 2:07 PM · Restricted Project
hiraditya added a reviewer for D89322: [LV] Initial VPlan cost modelling: nadav.
Nov 3 2020, 2:04 PM · Restricted Project
hiraditya added a comment to D59715: [HotColdSplit] Reflect full cost of parameters in split penalty.

@vsk Let me know if you dont have bandwidth to land. I can land it otherwise.

Nov 3 2020, 2:01 PM · Restricted Project

Oct 24 2020

hiraditya added a reviewer for D82892: [NFC] Methods to compare IR added in each IR subclass: hiraditya.
Oct 24 2020, 4:26 AM · Restricted Project
hiraditya added a comment to D79485: [BPI] Improve static heuristics for "cold" paths..

Please fix clang-format issues.

Oct 24 2020, 4:21 AM · Restricted Project
hiraditya added a comment to D88893: [SROA] Only generate memcpy if the slices is large 'enough' (WIP)..

Instcombine also expands small (16 bytes, hardcoded) memcpy's

Oct 24 2020, 4:18 AM · Restricted Project
hiraditya accepted D59715: [HotColdSplit] Reflect full cost of parameters in split penalty.

or if you prefer, I can land it in its current state.

Oct 24 2020, 4:05 AM · Restricted Project

Oct 20 2020

hiraditya added a comment to D88392: [M68k] (Patch 6/8) IR Tests.

Good to have these tests. I'd wait for the previous patches in the stack to be reviewed.

Oct 20 2020, 2:56 PM · Restricted Project
hiraditya added a comment to D59715: [HotColdSplit] Reflect full cost of parameters in split penalty.

@rjf do you have numbers on Firefox. Let us know.

Oct 20 2020, 2:54 PM · Restricted Project
hiraditya added a comment to D88460: Strlen loop idiom recognition.

It'll be nice to know if this patch worked fine with a set of regression tests.
results on LLVM testsuite, or clang bootstrap will really help.

Oct 20 2020, 2:51 PM · Restricted Project

Oct 3 2020

hiraditya added a reviewer for D24033: Convert clamp into fmaxnum/fminnum pairs.: hiraditya.
Oct 3 2020, 7:22 PM · Restricted Project

Sep 9 2020

hiraditya added a comment to D59715: [HotColdSplit] Reflect full cost of parameters in split penalty.

Any plans to merge this patch?

Sep 9 2020, 10:00 AM · Restricted Project
hiraditya accepted D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.
Sep 9 2020, 9:51 AM · Restricted Project, Restricted Project

Aug 28 2020

hiraditya added a comment to D85368: [llvm][CodeGen] Machine Function Splitter.

nit: If FIXME's are mostly future works, then please replace them with TODOs.

Aug 28 2020, 8:58 AM · Restricted Project
hiraditya added inline comments to D85368: [llvm][CodeGen] Machine Function Splitter.
Aug 28 2020, 8:43 AM · Restricted Project

Aug 21 2020

hiraditya added a comment to D79485: [BPI] Improve static heuristics for "cold" paths..

Is the test failure related to this patch?

Aug 21 2020, 3:18 PM · Restricted Project

Aug 17 2020

hiraditya added a reviewer for D86032: NFC: [GVNHoist] Outline functions from the class: hiraditya.
Aug 17 2020, 5:41 PM · Restricted Project
hiraditya added a comment to D86032: NFC: [GVNHoist] Outline functions from the class.

Self approving because this is NFC change to outline function definitions.

Aug 17 2020, 5:40 PM · Restricted Project
hiraditya committed rG370330f084c0: NFC: [GVNHoist] Outline functions from the class (authored by hiraditya).
NFC: [GVNHoist] Outline functions from the class
Aug 17 2020, 5:40 PM
hiraditya closed D86032: NFC: [GVNHoist] Outline functions from the class.
Aug 17 2020, 5:40 PM · Restricted Project
hiraditya updated the diff for D86032: NFC: [GVNHoist] Outline functions from the class.

rebase

Aug 17 2020, 1:51 PM · Restricted Project
hiraditya added a comment to D85628: [HotColdSplitting] Add command line options for supplying cold function names via user input..

then it may be possible to construct a synthetic/fake profile as a pre-processing step

Aug 17 2020, 11:31 AM · Restricted Project
hiraditya updated the diff for D86032: NFC: [GVNHoist] Outline functions from the class.

Rebase

Aug 17 2020, 11:02 AM · Restricted Project
hiraditya committed rGcb6e6936db35: NFC: [GVNHoist] Hoist loop invariant code and rename variables for readability (authored by hiraditya).
NFC: [GVNHoist] Hoist loop invariant code and rename variables for readability
Aug 17 2020, 9:44 AM
hiraditya closed D86031: NFC: [GVNHoist] Hoist loop invariant code and rename variables for readability.
Aug 17 2020, 9:43 AM · Restricted Project
hiraditya updated the diff for D86031: NFC: [GVNHoist] Hoist loop invariant code and rename variables for readability.

Addressed fhahn's comments

Aug 17 2020, 9:22 AM · Restricted Project
hiraditya added a comment to D82892: [NFC] Methods to compare IR added in each IR subclass.

please run clang-format

Aug 17 2020, 9:17 AM · Restricted Project
hiraditya added a reviewer for D86031: NFC: [GVNHoist] Hoist loop invariant code and rename variables for readability: sebpop.
Aug 17 2020, 6:35 AM · Restricted Project

Aug 15 2020

hiraditya closed D85975: [NFC] Fix typo and variable names.

49a944af7f1980b54d8a2be0ef640f5a956bc423

Aug 15 2020, 10:12 PM · Restricted Project
hiraditya requested review of D86032: NFC: [GVNHoist] Outline functions from the class.
Aug 15 2020, 8:44 PM · Restricted Project
hiraditya requested review of D86031: NFC: [GVNHoist] Hoist loop invariant code and rename variables for readability.
Aug 15 2020, 8:00 PM · Restricted Project
hiraditya committed rG49a944af7f19: [NFC] Fix typo and variable names (authored by hiraditya).
[NFC] Fix typo and variable names
Aug 15 2020, 9:06 AM

Aug 14 2020

hiraditya added a comment to D85975: [NFC] Fix typo and variable names.

FWIW C++ doesn't really have a lattice anymore: https://wg21.link/p0418

Is there a guidance for the users of 'isStrongerThan', isStrongerThanUnordered etc.?

Aug 14 2020, 11:12 AM · Restricted Project
Herald added a project to D53779: [CodeExtractor] Allow extracting allocas within simple stack{save,restore} pairs: Restricted Project.

Is this patch still useful now that D53514 has landed?

Aug 14 2020, 10:47 AM · Restricted Project
hiraditya added inline comments to D82892: [NFC] Methods to compare IR added in each IR subclass.
Aug 14 2020, 10:27 AM · Restricted Project
hiraditya added reviewers for D85975: [NFC] Fix typo and variable names: jfb, chandlerc.
Aug 14 2020, 10:24 AM · Restricted Project
hiraditya added inline comments to D59715: [HotColdSplit] Reflect full cost of parameters in split penalty.
Aug 14 2020, 10:17 AM · Restricted Project
hiraditya added a comment to D79485: [BPI] Improve static heuristics for "cold" paths..

please run clang-format.

Aug 14 2020, 9:24 AM · Restricted Project
hiraditya added a comment to D79485: [BPI] Improve static heuristics for "cold" paths..

..anyway I can try to describe how thing work using some example. Is this what you are looking for?

yes. Thank you.

Aug 14 2020, 9:23 AM · Restricted Project
hiraditya requested review of D85975: [NFC] Fix typo and variable names.
Aug 14 2020, 9:08 AM · Restricted Project
hiraditya added a comment to D85368: [llvm][CodeGen] Machine Function Splitter.

Can we add more test cases to include eh_pad, invokeinst,

Aug 14 2020, 12:23 AM · Restricted Project
hiraditya requested changes to D85368: [llvm][CodeGen] Machine Function Splitter.

please run clang-format on the patch.

Aug 14 2020, 12:10 AM · Restricted Project
hiraditya added a reviewer for D85368: [llvm][CodeGen] Machine Function Splitter: hiraditya.
Aug 14 2020, 12:07 AM · Restricted Project
hiraditya added a comment to D85368: [llvm][CodeGen] Machine Function Splitter.

Overall approach looks good to me even when we don't see good SPEC-17 numbers as the optimization is intended to reduce page faults. The improvements would be more pronounced in large applications. I'll review the code in more detail in the next few days. Thanks for working on this.

Aug 14 2020, 12:07 AM · Restricted Project

Aug 13 2020

hiraditya added a comment to D79485: [BPI] Improve static heuristics for "cold" paths..

Is this work based on any paper/implementation?
Can we add some documentation at the top of the file to get an overall idea of the cost model?

Aug 13 2020, 3:41 PM · Restricted Project
hiraditya added a comment to D85881: Fix PR45442: Bail out when MemorySSA information is not available.

Fixed the bug in: https://bugs.llvm.org/show_bug.cgi?id=45442

Aug 13 2020, 11:28 AM · Restricted Project
hiraditya committed rG1a8c9cd1d96e: Fix PR45442: Bail out when MemorySSA information is not available (authored by hiraditya).
Fix PR45442: Bail out when MemorySSA information is not available
Aug 13 2020, 11:27 AM
hiraditya closed D85881: Fix PR45442: Bail out when MemorySSA information is not available.
Aug 13 2020, 11:27 AM · Restricted Project
hiraditya updated the diff for D85881: Fix PR45442: Bail out when MemorySSA information is not available.
Aug 13 2020, 11:25 AM · Restricted Project
hiraditya added a comment to D85881: Fix PR45442: Bail out when MemorySSA information is not available.

Updated test cases.

Aug 13 2020, 10:30 AM · Restricted Project
hiraditya updated the diff for D85881: Fix PR45442: Bail out when MemorySSA information is not available.
Aug 13 2020, 10:30 AM · Restricted Project
hiraditya added a comment to D85873: Add cold attribute to one time construction APIs.

FYI: libstdc++ patch sent for review: https://gcc.gnu.org/pipermail/gcc-patches/2020-August/551934.html

Aug 13 2020, 9:59 AM · Restricted Project
hiraditya added inline comments to D85881: Fix PR45442: Bail out when MemorySSA information is not available.
Aug 13 2020, 9:54 AM · Restricted Project
hiraditya committed rG44716856db59: Fix PR45442: Bail out when MemorySSA information is not available (authored by hiraditya).
Fix PR45442: Bail out when MemorySSA information is not available
Aug 13 2020, 9:32 AM
hiraditya accepted D85881: Fix PR45442: Bail out when MemorySSA information is not available.

Self approving as it is a trivial change and fixes PR45442

Aug 13 2020, 9:31 AM · Restricted Project
hiraditya committed rGd54f5979bb82: Add cold attribute to one time construction APIs (authored by hiraditya).
Add cold attribute to one time construction APIs
Aug 13 2020, 9:30 AM
hiraditya closed D85873: Add cold attribute to one time construction APIs.
Aug 13 2020, 9:30 AM · Restricted Project
hiraditya added a comment to D85628: [HotColdSplitting] Add command line options for supplying cold function names via user input..
In D85628#2214119, @jfb wrote:
In D85628#2213940, @rjf wrote:
In D85628#2213919, @vsk wrote:

I’m not convinced this is a good idea. In what use case is it not possible to mark up relevant functions? It doesn’t make sense to me to make alternations to standard library functions within the compiler. It seems better to simply patch the standard library. In some cases llvm does infer function attributes for library functions, but these are generally lower level attributes that can’t be specified at the source level, and the attribute is made available to other passes in the pipeline.

Do you mean this patch isn't a good idea in general, or the recent revision isn't a good idea? For the latter, I'm not sure if you meant we should not outline declarations or we should not split the original loop into two (e.g. marking as cold before outlining). IMO splitting the loop into two simply addresses what the original intent of what we're doing, which is to mark certain functions as cold before outlining. Whereas, if we don't outline declarations via user-provided input, it renders @hiraditya 's proposed testcase useless. Alternatively, we don't have to make the testcase involving standard library functions if that's what you want :).

My understanding is that today code can be considered "cold" based on the following:

  1. Attribute on the function
  2. Likely / unlikely annotations
  3. Profile information
  4. Other compiler heuristics

This adds another way to do it, but it's kind of a side-injection and it doesn't seem particularly principled. Presumably the list you're feeding through the command-line comes from a profile? Why isn't it provided as profile information?

Aug 13 2020, 8:00 AM · Restricted Project
hiraditya added a comment to D85628: [HotColdSplitting] Add command line options for supplying cold function names via user input..

The patch looks legit. Wonder if such a patch should be sent to libstdc++ too.

Aug 13 2020, 7:42 AM · Restricted Project
hiraditya updated the diff for D85881: Fix PR45442: Bail out when MemorySSA information is not available.
Aug 13 2020, 12:11 AM · Restricted Project
hiraditya requested review of D85881: Fix PR45442: Bail out when MemorySSA information is not available.
Aug 13 2020, 12:08 AM · Restricted Project