Page MenuHomePhabricator
Feed Advanced Search

May 2 2019

fgross committed rGe25a0e95104b: Fixed: Duck-typing in readability-redundant-smartptr-get didn't catch MSVC STL… (authored by fgross).
Fixed: Duck-typing in readability-redundant-smartptr-get didn't catch MSVC STL…
May 2 2019, 9:42 AM
fgross committed rL359801: Fixed: Duck-typing in readability-redundant-smartptr-get didn't catch MSVC STL….
Fixed: Duck-typing in readability-redundant-smartptr-get didn't catch MSVC STL…
May 2 2019, 9:39 AM
fgross committed rCTE359801: Fixed: Duck-typing in readability-redundant-smartptr-get didn't catch MSVC STL….
Fixed: Duck-typing in readability-redundant-smartptr-get didn't catch MSVC STL…
May 2 2019, 9:39 AM
fgross closed D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL.
May 2 2019, 9:39 AM · Restricted Project, Restricted Project

Apr 27 2019

fgross updated the diff for D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL.

Fixed test file format

Apr 27 2019, 3:16 AM · Restricted Project, Restricted Project

Apr 26 2019

fgross updated the diff for D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL.

Fixed format

Apr 26 2019, 12:57 PM · Restricted Project, Restricted Project
fgross created D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL.
Apr 26 2019, 12:34 PM · Restricted Project, Restricted Project
fgross awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Like token.
Apr 26 2019, 5:01 AM · Restricted Project, Restricted Project

Nov 24 2017

fgross added a comment to D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check.

If you've written your own copy functions then you probably want to write your own move functions to allow moving, so AllowMissingMoveFunctions doesn't make sense.

Nov 24 2017, 12:40 PM

Aug 4 2017

fgross committed rL310096: [clang-tidy] Added clang-tidy test cases related to rL310095.
[clang-tidy] Added clang-tidy test cases related to rL310095
Aug 4 2017, 12:02 PM
fgross committed rL310095: [ASTMatcher] Add handling for DeducedType to HasDeclarationMatcher.
[ASTMatcher] Add handling for DeducedType to HasDeclarationMatcher
Aug 4 2017, 12:00 PM
fgross closed D36308: Add handling for DeducedType to HasDeclarationMatcher by committing rL310095: [ASTMatcher] Add handling for DeducedType to HasDeclarationMatcher.
Aug 4 2017, 12:00 PM
fgross updated the diff for D36308: Add handling for DeducedType to HasDeclarationMatcher .

Changed comment, added some clang-tidy test cases.

Aug 4 2017, 11:56 AM
fgross created D36308: Add handling for DeducedType to HasDeclarationMatcher .
Aug 4 2017, 5:33 AM
fgross committed rL310048: [AMDGPU] Fixed MSVC build break.
[AMDGPU] Fixed MSVC build break
Aug 4 2017, 3:54 AM

Jun 3 2017

fgross committed rL304657: [clang-tidy] Make misc-static-assert accept assert(!"msg").
[clang-tidy] Make misc-static-assert accept assert(!"msg")
Jun 3 2017, 3:14 AM
fgross closed D33827: [clang-tidy] misc-static-assert shouldn't flag assert(!"msg") by committing rL304657: [clang-tidy] Make misc-static-assert accept assert(!"msg").
Jun 3 2017, 3:14 AM · Restricted Project

Jun 2 2017

fgross created D33827: [clang-tidy] misc-static-assert shouldn't flag assert(!"msg").
Jun 2 2017, 6:20 AM · Restricted Project

May 25 2017

fgross committed rL303849.
May 25 2017, 4:43 AM

May 23 2017

fgross added a comment to D33354: [clang-tidy] readability-braces-around-statements false positive with char literals.

Thanks a lot, will do.

May 23 2017, 9:25 AM

May 19 2017

fgross updated the diff for D33354: [clang-tidy] readability-braces-around-statements false positive with char literals.

After some digging into it, here is my uneducated guess:

May 19 2017, 9:35 AM
fgross created D33358: [clang-tidy] readability-redundant-declaration false positive for defaulted function.
May 19 2017, 7:59 AM
fgross created D33354: [clang-tidy] readability-braces-around-statements false positive with char literals.
May 19 2017, 6:01 AM

Mar 16 2017

fgross updated the diff for D30841: [clang-tidy] readability-misleading-indentation: fix chained if.

Now using ASTContext::getParents instead of ChainedIfs map.

Mar 16 2017, 11:17 AM

Mar 15 2017

fgross added a comment to D30841: [clang-tidy] readability-misleading-indentation: fix chained if.

I don't have commit access, so could someone please commit this for me? Thanks!

Mar 15 2017, 10:58 AM

Mar 13 2017

fgross added a comment to D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check.

No commit access, could someone please take care of this? Thanks!

Mar 13 2017, 11:16 AM

Mar 11 2017

fgross updated the diff for D30841: [clang-tidy] readability-misleading-indentation: fix chained if.

Replaced std::map with llvm::DenseMap, added comment about traversal.

Mar 11 2017, 8:16 AM

Mar 10 2017

fgross created D30841: [clang-tidy] readability-misleading-indentation: fix chained if.
Mar 10 2017, 11:49 AM

Mar 9 2017

fgross updated the diff for D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check.

Diff was missing cppcoreguidelines-special-member-functions-relaxed.cpp...

Mar 9 2017, 10:13 AM
fgross updated the diff for D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check.

Added examples to options doc.

Mar 9 2017, 10:08 AM

Mar 5 2017

fgross updated the diff for D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check.

reformatted

Mar 5 2017, 6:26 AM

Mar 4 2017

fgross added inline comments to D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check.
Mar 4 2017, 3:28 PM
fgross updated the diff for D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check.

Updated documentation, got rid of code duplication.

Mar 4 2017, 3:21 PM
fgross created D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check.
Mar 4 2017, 9:23 AM
fgross updated the diff for D30592: [clang-tidy] Fix diag message for catch-by-value.

Updated test case.

Mar 4 2017, 4:44 AM

Mar 3 2017

fgross created D30592: [clang-tidy] Fix diag message for catch-by-value.
Mar 3 2017, 1:52 PM