Page MenuHomePhabricator
Feed Advanced Search

Oct 10 2019

a.elovikov added inline comments to D68484: [PATCH 01/38] [noalias] LangRef: noalias intrinsics and noalias_sidechannel documentation..
Oct 10 2019, 1:46 PM · Restricted Project
a.elovikov added inline comments to D68498: [PATCH 15/38] [noalias] D9382: llvm.noalias - don't prevent loop vectorization.
Oct 10 2019, 11:04 AM · Restricted Project
a.elovikov added inline comments to D68492: [PATCH 09/38] [noalias] D9376: llvm.noalias - handling of dead intrinsics.
Oct 10 2019, 10:23 AM · Restricted Project
a.elovikov added inline comments to D68488: [PATCH 05/38] [noalias] [IR] Introduce noalias_sidechannel for LoadInst/StoreInst.
Oct 10 2019, 9:45 AM · Restricted Project

Oct 9 2019

a.elovikov added inline comments to D68484: [PATCH 01/38] [noalias] LangRef: noalias intrinsics and noalias_sidechannel documentation..
Oct 9 2019, 4:40 PM · Restricted Project

Aug 1 2019

a.elovikov added a comment to D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer..

Thanks for working on this! I'm really interested in using this functionality so here are some comments on the main interface header.

Aug 1 2019, 10:19 AM · Restricted Project

Aug 30 2018

a.elovikov added inline comments to D49273: [InstCombine] Expand the simplification of pow() into exp2().
Aug 30 2018, 1:16 AM · Restricted Project

Aug 28 2018

a.elovikov added inline comments to D50894: Pull google/benchmark library to the LLVM tree.
Aug 28 2018, 3:49 AM

Aug 27 2018

a.elovikov added inline comments to D50935: Add data structure to form equivalence classes of mangled names..
Aug 27 2018, 7:32 AM
a.elovikov added inline comments to D50935: Add data structure to form equivalence classes of mangled names..
Aug 27 2018, 6:15 AM

Aug 20 2018

a.elovikov committed rC340174: [NFC] Don't define static function in header (UninitializedObject.h).
[NFC] Don't define static function in header (UninitializedObject.h)
Aug 20 2018, 6:47 AM
a.elovikov committed rL340174: [NFC] Don't define static function in header (UninitializedObject.h).
[NFC] Don't define static function in header (UninitializedObject.h)
Aug 20 2018, 6:46 AM
a.elovikov closed D50963: [NFC] Don't define static function in header (UninitializedObject.h).
Aug 20 2018, 6:46 AM
a.elovikov created D50963: [NFC] Don't define static function in header (UninitializedObject.h).
Aug 20 2018, 3:30 AM

Aug 1 2018

a.elovikov committed rL338551: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang….
[NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang…
Aug 1 2018, 6:42 AM
a.elovikov committed rC338551: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang….
[NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang…
Aug 1 2018, 6:42 AM
a.elovikov closed D50056: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang-fuzzer/handle-llvm/handle_llvm.cpp..
Aug 1 2018, 6:42 AM
a.elovikov updated the diff for D50056: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang-fuzzer/handle-llvm/handle_llvm.cpp..
  • Address Erich's comment + clang-format.
Aug 1 2018, 2:42 AM

Jul 31 2018

a.elovikov created D50056: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang-fuzzer/handle-llvm/handle_llvm.cpp..
Jul 31 2018, 5:46 AM

Jul 26 2018

a.elovikov added a comment to D47895: llvm: Add support for "-fno-delete-null-pointer-checks".

to change this logic if there is a consensus on how inlining should be handled in case of "null-pointer-isvalid" attribute mismatches.

Jul 26 2018, 12:30 AM

Jul 25 2018

a.elovikov added a comment to D47895: llvm: Add support for "-fno-delete-null-pointer-checks".

Note that, I am expecting that functions with alwaysinline attribute should still get inlined. If that happens and caller does not have this attribute, then optimizer is free to remove the checks.

Jul 25 2018, 7:48 AM

Jun 26 2018

a.elovikov committed rL335581: [NFC] Prefer (void) to LLVM_ATTRIBUTE_UNUSED for unused var in….
[NFC] Prefer (void) to LLVM_ATTRIBUTE_UNUSED for unused var in…
Jun 26 2018, 12:09 AM
a.elovikov closed D48534: [NFC] Prefer (void) to LLVM_ATTRIBUTE_UNUSED for unused var in GlobalISElemitter.cpp..
Jun 26 2018, 12:09 AM

Jun 25 2018

a.elovikov created D48534: [NFC] Prefer (void) to LLVM_ATTRIBUTE_UNUSED for unused var in GlobalISElemitter.cpp..
Jun 25 2018, 1:39 AM
a.elovikov added inline comments to rL335433: [DAGCombiner] eliminate setcc bool math when input is low-bit of some value.
Jun 25 2018, 1:36 AM

May 24 2018

a.elovikov committed rL333187: [NFC][VPlan] Wrap PlainCFGBuilder with an anonymous namespace..
[NFC][VPlan] Wrap PlainCFGBuilder with an anonymous namespace.
May 24 2018, 7:35 AM
a.elovikov closed D47312: [NFC][VPlan] Wrap PlainCFGBuilder with an anonymous namespace..
May 24 2018, 7:35 AM
a.elovikov created D47312: [NFC][VPlan] Wrap PlainCFGBuilder with an anonymous namespace..
May 24 2018, 2:10 AM

Apr 24 2018

a.elovikov committed rL330700: [CodeGen] Do not allow opt-bisect-limit to skip ScalarizeMaskedMemIntrin..
[CodeGen] Do not allow opt-bisect-limit to skip ScalarizeMaskedMemIntrin.
Apr 24 2018, 2:27 AM
a.elovikov closed D45947: [CodeGen] Do not allow opt-bisect-limit to skip ScalarizeMaskedMemIntrin..
Apr 24 2018, 2:27 AM

Apr 23 2018

a.elovikov created D45947: [CodeGen] Do not allow opt-bisect-limit to skip ScalarizeMaskedMemIntrin..
Apr 23 2018, 6:13 AM

Mar 21 2018

a.elovikov added a comment to D44737: [LV] Remove unnecessary -O2 from the X86/reg-usage.ll test. NFC..

The test passes without that "-O2" but I'm not sure why it was there originally...

Mar 21 2018, 7:30 AM
a.elovikov created D44737: [LV] Remove unnecessary -O2 from the X86/reg-usage.ll test. NFC..
Mar 21 2018, 7:30 AM

Mar 20 2018

a.elovikov committed rL327960: [LV] Let recordVectorLoopValueForInductionCast to check if IV was created from….
[LV] Let recordVectorLoopValueForInductionCast to check if IV was created from…
Mar 20 2018, 2:08 AM
a.elovikov closed D43812: [LV] Let recordVectorLoopValueForInductionCast to check if IV was created from the cast..
Mar 20 2018, 2:08 AM

Mar 16 2018

a.elovikov added inline comments to D44338: [LV][VPlan] Build plain CFG with simple VPInstructions for outer loops..
Mar 16 2018, 5:45 AM

Mar 15 2018

a.elovikov committed rL327617: [LoopUnroll] Ignore ephemeral values when checking full unroll profitability..
[LoopUnroll] Ignore ephemeral values when checking full unroll profitability.
Mar 15 2018, 3:03 AM
a.elovikov closed D43931: [LoopUnroll] Ignore ephemeral values when checking full unroll profitability..
Mar 15 2018, 3:03 AM
a.elovikov updated the diff for D43812: [LV] Let recordVectorLoopValueForInductionCast to check if IV was created from the cast..

Improve some comments.

Mar 15 2018, 2:26 AM

Mar 14 2018

a.elovikov added inline comments to D43812: [LV] Let recordVectorLoopValueForInductionCast to check if IV was created from the cast..
Mar 14 2018, 6:10 AM

Mar 1 2018

a.elovikov updated the summary of D43931: [LoopUnroll] Ignore ephemeral values when checking full unroll profitability..
Mar 1 2018, 1:59 AM
a.elovikov created D43931: [LoopUnroll] Ignore ephemeral values when checking full unroll profitability..
Mar 1 2018, 1:59 AM

Feb 27 2018

a.elovikov updated the diff for D43812: [LV] Let recordVectorLoopValueForInductionCast to check if IV was created from the cast..
Feb 27 2018, 11:25 AM
a.elovikov created D43812: [LV] Let recordVectorLoopValueForInductionCast to check if IV was created from the cast..
Feb 27 2018, 2:23 AM

Feb 15 2018

a.elovikov added a comment to D42717: [JumpThreading] sync DT for LVI analysis (PR 36133).

@a.elovikov and @dberlin does this look good to commit?

Feb 15 2018, 9:51 AM

Feb 14 2018

a.elovikov added a comment to D42717: [JumpThreading] sync DT for LVI analysis (PR 36133).

I might be missing something, but why don't we enable DT back in LVI after the JT pass finishes and flushes the DDT? Is it possible that we end up with disabled DT *after* the JT?

Feb 14 2018, 3:47 AM

Feb 13 2018

a.elovikov added inline comments to D42717: [JumpThreading] sync DT for LVI analysis (PR 36133).
Feb 13 2018, 1:45 AM

Jan 30 2018

a.elovikov committed rL323762: [X86FixupBWInsts] mir-simplify fixup-bw-inst.mir test. NFC..
[X86FixupBWInsts] mir-simplify fixup-bw-inst.mir test. NFC.
Jan 30 2018, 6:26 AM

Jan 29 2018

a.elovikov added a comment to D34135: [JumpThreading] Use DT to avoid processing dead blocks.

I've just submitted https://llvm.org/PR36133 containing a testcase that show how JumpThreadings miscompiles (without crashes) the code due to DomTree not being updated between the iterations of JumpThreading itself.

Jan 29 2018, 3:21 AM
a.elovikov committed rL323635: [X86FixupBWInsts] Fix miscompilation if sibling sub-register is live..
[X86FixupBWInsts] Fix miscompilation if sibling sub-register is live.
Jan 29 2018, 1:29 AM
a.elovikov closed D42533: [X86FixupBWInsts] Fix miscompilation if sibling sub-register is live..
Jan 29 2018, 1:29 AM

Jan 26 2018

a.elovikov added inline comments to D42533: [X86FixupBWInsts] Fix miscompilation if sibling sub-register is live..
Jan 26 2018, 7:31 AM
a.elovikov updated the diff for D42533: [X86FixupBWInsts] Fix miscompilation if sibling sub-register is live..

Use regsOverlap instead of isSuperOrSubRegisterEq.

Jan 26 2018, 7:30 AM
Herald updated subscribers of D40146: [JumpThreading] Preservation of DT and LVI across the pass.
Jan 26 2018, 6:01 AM
a.elovikov committed rL323513: [X86FixupBWInsts] Prefer positive checks in the test. NFC.
[X86FixupBWInsts] Prefer positive checks in the test. NFC
Jan 26 2018, 1:54 AM
a.elovikov closed D42531: [X86FixupBWInsts] Prefer positive checks in the test. NFC.
Jan 26 2018, 1:54 AM

Jan 25 2018

a.elovikov updated the diff for D42533: [X86FixupBWInsts] Fix miscompilation if sibling sub-register is live..

Indeed, on X86 checkRegistersAlias is just isSuperOrSubRegisterEq (although the former would be the right choice if that was not so :)).
Comment was added - thanks for the exact text!

Jan 25 2018, 10:00 AM
a.elovikov created D42533: [X86FixupBWInsts] Fix miscompilation if sibling sub-register is live..
Jan 25 2018, 5:59 AM
a.elovikov created D42531: [X86FixupBWInsts] Prefer positive checks in the test. NFC.
Jan 25 2018, 5:49 AM

Jan 15 2018

a.elovikov committed rL322473: [LV] Don't call recordVectorLoopValueForInductionCast for newly-created IV from….
[LV] Don't call recordVectorLoopValueForInductionCast for newly-created IV from…
Jan 15 2018, 2:57 AM
a.elovikov closed D41913: [LV] Don't call recordVectorLoopValueForInductionCast for newly-created IV from a trunc..
Jan 15 2018, 2:57 AM

Jan 11 2018

a.elovikov updated the diff for D41913: [LV] Don't call recordVectorLoopValueForInductionCast for newly-created IV from a trunc..
  • Move TODO from the test to the actual code.
Jan 11 2018, 2:12 PM
a.elovikov added a comment to D41913: [LV] Don't call recordVectorLoopValueForInductionCast for newly-created IV from a trunc..

Also, this should be a release blocker if it's not already. Thanks!

Jan 11 2018, 1:35 PM

Jan 10 2018

a.elovikov created D41913: [LV] Don't call recordVectorLoopValueForInductionCast for newly-created IV from a trunc..
Jan 10 2018, 11:35 AM

Dec 12 2017

a.elovikov added a comment to D40524: Handle the case of live 16-bit subregisters in X86FixupBWInsts.

In D40524#951832, @andrew.w.kaylor wrote:
I'm not terribly familiar with MIR as it appears in a test like this, but I can't see any reason that your proposed testcase would be invalid. I do think it's extremely unlikely to arise in actual generated Machine IR, since we hardly ever use the 8-bit high registers. What I'd like to do is commit the change from this review as is, and file a new Bugzilla report to track the 8bit_hi issue. Does that sound reasonable to you?

Dec 12 2017, 12:33 AM

Nov 30 2017

a.elovikov added inline comments to D40524: Handle the case of live 16-bit subregisters in X86FixupBWInsts.
Nov 30 2017, 4:12 AM
a.elovikov added a comment to D40524: Handle the case of live 16-bit subregisters in X86FixupBWInsts.

I'm not sure if the following is possible/legal but it fails even with this patch:

Nov 30 2017, 4:06 AM

Nov 28 2017

a.elovikov added inline comments to D40524: Handle the case of live 16-bit subregisters in X86FixupBWInsts.
Nov 28 2017, 8:16 AM

Sep 19 2017

a.elovikov committed rL313617: Test commit..
Test commit.
Sep 19 2017, 12:58 AM

Sep 14 2017

a.elovikov added a comment to D37453: [X86] In combineLoopSADPattern, pad result with zeros and use full size add instead of using a smaller add and inserting..

There is a typo in the summary: "were are", "make award".

Sep 14 2017, 3:02 PM
a.elovikov updated the diff for D37559: [X86FixupBWInsts] More presise register liveness if no <imp-use> on MOVs..
  • Address review comments.
Sep 14 2017, 12:59 AM

Sep 12 2017

a.elovikov added a comment to D37559: [X86FixupBWInsts] More presise register liveness if no <imp-use> on MOVs..

Ping.

Sep 12 2017, 11:28 AM

Sep 7 2017

a.elovikov created D37559: [X86FixupBWInsts] More presise register liveness if no <imp-use> on MOVs..
Sep 7 2017, 4:07 AM

Jul 27 2017

a.elovikov updated the diff for D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..

Rebased to updated D35002 where fptosi tests were added. That also included re-base to the current master.
No changes in the instcombine results for these added tests though.

Jul 27 2017, 4:24 AM
a.elovikov updated the diff for D35002: Add some tests for cast+clamp/min/max before D33186..

Added mixed clamp tests with fptosi.

Jul 27 2017, 4:14 AM

Jul 5 2017

a.elovikov added a child revision for D35002: Add some tests for cast+clamp/min/max before D33186.: D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..
Jul 5 2017, 11:21 AM
a.elovikov added a parent revision for D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode.: D35002: Add some tests for cast+clamp/min/max before D33186..
Jul 5 2017, 11:21 AM
a.elovikov updated the diff for D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..

Compare types instead of their sizes to decide if CastInst is needed.

Jul 5 2017, 2:23 AM
a.elovikov updated the diff for D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..

Rebase onto D35002.

Jul 5 2017, 2:21 AM
a.elovikov created D35002: Add some tests for cast+clamp/min/max before D33186..
Jul 5 2017, 2:18 AM

Jul 3 2017

a.elovikov added inline comments to D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..
Jul 3 2017, 12:59 PM
a.elovikov added inline comments to D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..
Jul 3 2017, 12:55 PM
a.elovikov requested review of D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..
Jul 3 2017, 7:33 AM
a.elovikov added a comment to D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..

Hi @efriedma, original commit caused the failure under UBSan. The latest uploaded revision fixes it.
Can you please take a look and say if it's ok?

Jul 3 2017, 7:33 AM
a.elovikov updated the diff for D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..
  • Fix UBSan error after D33186/r306525.
Jul 3 2017, 7:33 AM
a.elovikov reopened D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..
Jul 3 2017, 7:33 AM

Jun 28 2017

a.elovikov added a comment to D32994: [NFC] Use stdin for some tests instead of positional argument..

Remove the '-o -' too?

Just curious: why only these files? The problem occurs in hundreds of tests from what I can tell. Shouldn't we fix all of them?

Jun 28 2017, 6:26 AM
a.elovikov updated the diff for D32994: [NFC] Use stdin for some tests instead of positional argument..
  • Remove "-o -" too.
Jun 28 2017, 6:24 AM
a.elovikov added reviewers for D32994: [NFC] Use stdin for some tests instead of positional argument.: spatel, efriedma.

Ping.

Jun 28 2017, 1:40 AM

Jun 27 2017

a.elovikov updated the diff for D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..

Limit clamp->min/max transformation to float types only.

Jun 27 2017, 12:55 PM
a.elovikov added a comment to D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..

I'm okay with limiting it to FP vectors for now.

Jun 27 2017, 12:06 PM
a.elovikov added inline comments to D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..
Jun 27 2017, 2:00 AM

Jun 26 2017

a.elovikov added a comment to D34350: Add tests to document current InstCombine behavior for clamp pattern..

Do you need someone to commit this for you?

Jun 26 2017, 8:29 AM
a.elovikov added a child revision for D34350: Add tests to document current InstCombine behavior for clamp pattern.: D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..
Jun 26 2017, 3:45 AM
a.elovikov added a parent revision for D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode.: D34350: Add tests to document current InstCombine behavior for clamp pattern..
Jun 26 2017, 3:45 AM
a.elovikov updated the diff for D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..

Properly update keeping the dependence on D34350.

Jun 26 2017, 3:44 AM
a.elovikov added inline comments to D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..
Jun 26 2017, 3:33 AM
a.elovikov updated the diff for D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..
  • Update comments as requested in the review.
Jun 26 2017, 3:30 AM

Jun 19 2017

a.elovikov updated the diff for D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..

Now, properly re-base onto D34350 where the current status of the tests was captured.

Jun 19 2017, 8:26 AM
a.elovikov updated the diff for D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..
Re-base onto D34350 where the current status of the tests was captured.
Jun 19 2017, 8:05 AM