Page MenuHomePhabricator
Feed Advanced Search

Feb 28 2022

a.elovikov committed rG6e9a8cdcfb15: [NFC][LoopVectorizer] Simplify LoopVectorize/X86/gather_scatter.ll (authored by a.elovikov).
[NFC][LoopVectorizer] Simplify LoopVectorize/X86/gather_scatter.ll
Feb 28 2022, 11:13 AM
a.elovikov closed D119786: [NFC][LoopVectorizer] Simplify LoopVectorize/X86/gather_scatter.ll.
Feb 28 2022, 11:13 AM · Restricted Project
a.elovikov added a comment to D119786: [NFC][LoopVectorizer] Simplify LoopVectorize/X86/gather_scatter.ll.

Ping x2. Can you suggest who can I ask to review this?

Feb 28 2022, 9:22 AM · Restricted Project

Feb 22 2022

a.elovikov added a comment to D119786: [NFC][LoopVectorizer] Simplify LoopVectorize/X86/gather_scatter.ll.

Ping.

Feb 22 2022, 8:49 AM · Restricted Project

Feb 14 2022

a.elovikov added reviewers for D119786: [NFC][LoopVectorizer] Simplify LoopVectorize/X86/gather_scatter.ll: greened, fhahn, spatel.
Feb 14 2022, 2:47 PM · Restricted Project
a.elovikov requested review of D119786: [NFC][LoopVectorizer] Simplify LoopVectorize/X86/gather_scatter.ll.
Feb 14 2022, 2:46 PM · Restricted Project

Oct 11 2021

a.elovikov accepted D111298: [VPlan] Print live-in backedge taken count as part of plan..

Thanks!

Oct 11 2021, 9:18 AM · Restricted Project

Oct 7 2021

a.elovikov added a comment to D111298: [VPlan] Print live-in backedge taken count as part of plan..

LGTM other than a minor nit.

Oct 7 2021, 11:08 AM · Restricted Project

Sep 3 2021

a.elovikov added a comment to D108424: [NFC][clang] Move multiversion resolver code generation to llvm/ subdirectory.

ping.

Sep 3 2021, 9:22 AM · Restricted Project, Restricted Project

Aug 30 2021

a.elovikov updated the diff for D108424: [NFC][clang] Move multiversion resolver code generation to llvm/ subdirectory.

Rebase + ping

Aug 30 2021, 10:34 AM · Restricted Project, Restricted Project
a.elovikov committed rG1724a164378f: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser. (authored by a.elovikov).
[NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.
Aug 30 2021, 9:49 AM
a.elovikov closed D108423: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp.
Aug 30 2021, 9:49 AM · Restricted Project, Restricted Project

Aug 26 2021

a.elovikov added a comment to D108423: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp.

Ping

Aug 26 2021, 3:09 PM · Restricted Project, Restricted Project

Aug 24 2021

a.elovikov updated the diff for D108423: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp.

Rebase

Aug 24 2021, 10:30 AM · Restricted Project, Restricted Project
a.elovikov committed rG4c418c1bfbc5: Try to fix build with modules enabled after D108422 (authored by a.elovikov).
Try to fix build with modules enabled after D108422
Aug 24 2021, 10:18 AM
a.elovikov committed rGf387a3617860: [NFC][clang] Move remaining part of X86Target.def to… (authored by a.elovikov).
[NFC][clang] Move remaining part of X86Target.def to…
Aug 24 2021, 9:17 AM
a.elovikov closed D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def.
Aug 24 2021, 9:17 AM · Restricted Project, Restricted Project

Aug 23 2021

a.elovikov committed rGf5c288948844: [NFC][clang] Use X86 Features declaration from X86TargetParser (authored by a.elovikov).
[NFC][clang] Use X86 Features declaration from X86TargetParser
Aug 23 2021, 12:31 PM
a.elovikov closed D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser.
Aug 23 2021, 12:30 PM · Restricted Project, Restricted Project
a.elovikov updated the diff for D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser.

Address Erich's comments

Aug 23 2021, 11:52 AM · Restricted Project, Restricted Project
a.elovikov added a comment to D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser.

Hi guys, do you want me to fix anything else? I think I've addressed what I could.

Aug 23 2021, 9:26 AM · Restricted Project, Restricted Project

Aug 20 2021

a.elovikov updated the diff for D108424: [NFC][clang] Move multiversion resolver code generation to llvm/ subdirectory.

Fix a bug with not saving builder's insertion point.

Aug 20 2021, 2:07 PM · Restricted Project, Restricted Project
a.elovikov updated the diff for D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def.

Remove stale FIXME comment in the code being moved

Aug 20 2021, 9:58 AM · Restricted Project, Restricted Project
a.elovikov added inline comments to D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def.
Aug 20 2021, 9:51 AM · Restricted Project, Restricted Project

Aug 19 2021

a.elovikov requested review of D108424: [NFC][clang] Move multiversion resolver code generation to llvm/ subdirectory.
Aug 19 2021, 4:18 PM · Restricted Project, Restricted Project
a.elovikov requested review of D108423: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp.
Aug 19 2021, 4:17 PM · Restricted Project, Restricted Project
a.elovikov requested review of D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def.
Aug 19 2021, 4:17 PM · Restricted Project, Restricted Project
a.elovikov added inline comments to D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser.
Aug 19 2021, 3:56 PM · Restricted Project, Restricted Project
a.elovikov updated the diff for D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser.

Apply reviewers' suggestions. Thanks!

Aug 19 2021, 3:53 PM · Restricted Project, Restricted Project

Aug 16 2021

a.elovikov updated the diff for D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser.

Another version. My main goal here is to gradually move more stuff from clang/
to llvm/ so I'm open to other suggestions in doing so.

Aug 16 2021, 4:06 PM · Restricted Project, Restricted Project
a.elovikov planned changes to D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser.
Aug 16 2021, 1:42 PM · Restricted Project, Restricted Project
a.elovikov requested review of D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser.
Aug 16 2021, 11:59 AM · Restricted Project, Restricted Project

Jul 15 2021

a.elovikov added inline comments to D104795: [IVDescriptors] Make pointer inductions compatible with opaque pointers.
Jul 15 2021, 10:37 AM · Restricted Project

Jul 1 2021

a.elovikov added a comment to D104795: [IVDescriptors] Make pointer inductions compatible with opaque pointers.

The main alternative I see here is to use different logic for opaque pointers and always base them off an i8 element type

Jul 1 2021, 2:04 PM · Restricted Project

Jun 2 2021

a.elovikov added a comment to D103515: [VPlan] Print successors of VPRegionBlocks..

Currently I am not sure how to best write a CHECK-line that will fail if a new successor gets added, e.g. CHECK: Successor(s): if.then.0 will also pass if an additional successor gets added. Perhaps we should just include the number of successors, something like 1 Successor: if.then, or 3 Successors: a, b, c.

Jun 2 2021, 8:53 AM · Restricted Project
a.elovikov accepted D103515: [VPlan] Print successors of VPRegionBlocks..

Looks good to me. Thanks for following up on that.

Jun 2 2021, 8:42 AM · Restricted Project

Apr 30 2021

a.elovikov added a comment to D100257: [VPlan] Add VPUserID to distinguish between recipes and others..

IIUC we will have non-recipe users in the future (e.g. live-outs)

Apr 30 2021, 4:34 PM · Restricted Project

Apr 26 2021

a.elovikov accepted D100257: [VPlan] Add VPUserID to distinguish between recipes and others..

LGTM.

Apr 26 2021, 9:29 AM · Restricted Project

Apr 22 2021

a.elovikov accepted D100176: [VPlan] Use recursive traversal iterator in VPSlotTracker..

LGTM, thanks!

Apr 22 2021, 12:22 PM · Restricted Project
a.elovikov accepted D101093: [VPlan] Add VPBlockUtils::basicBlocksOnly helper..

VPlan part looks good to me. I'm not familiar with implementation details of the filtered_iterator to discuss the to_reference->filter->to_pointer approach though. Regardless of that, it's an improvement in interfaces, so LGTM unless someone has a way to make filtering work with pointer directly.

Apr 22 2021, 12:21 PM · Restricted Project
a.elovikov accepted D100175: [VPlan] Add GraphTraits impl to traverse through VPRegionBlock..

LGTM, thanks!

Apr 22 2021, 9:20 AM · Restricted Project

Apr 19 2021

a.elovikov added a comment to D100175: [VPlan] Add GraphTraits impl to traverse through VPRegionBlock..

I think it's functionally correct now, just have a few suggestions to simplify the code a little bit.

Apr 19 2021, 1:50 PM · Restricted Project

Apr 12 2021

a.elovikov accepted D100259: [VPlan] Add VPRecipeBase::mayHaveSideEffects..

LGTM, please wait a day or two to let others take a look.

Apr 12 2021, 11:42 AM · Restricted Project
a.elovikov added inline comments to D100257: [VPlan] Add VPUserID to distinguish between recipes and others..
Apr 12 2021, 11:40 AM · Restricted Project
a.elovikov added inline comments to D100176: [VPlan] Use recursive traversal iterator in VPSlotTracker..
Apr 12 2021, 11:33 AM · Restricted Project
a.elovikov added inline comments to D100175: [VPlan] Add GraphTraits impl to traverse through VPRegionBlock..
Apr 12 2021, 11:30 AM · Restricted Project
a.elovikov added inline comments to D100175: [VPlan] Add GraphTraits impl to traverse through VPRegionBlock..
Apr 12 2021, 11:26 AM · Restricted Project

Mar 19 2021

a.elovikov committed rG92205cb27fd8: [NFC][VPlan] Guard print routines with "#if !defined(NDEBUG) || defined… (authored by a.elovikov).
[NFC][VPlan] Guard print routines with "#if !defined(NDEBUG) || defined…
Mar 19 2021, 10:51 AM
a.elovikov committed rG93a9d2de8f4f: [VPlan] Add plain text (not DOT's digraph) dumps (authored by a.elovikov).
[VPlan] Add plain text (not DOT's digraph) dumps
Mar 19 2021, 10:51 AM
a.elovikov closed D98897: [NFC][VPlan] Guard print routines with "#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)".
Mar 19 2021, 10:51 AM · Restricted Project
a.elovikov closed D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 19 2021, 10:51 AM · Restricted Project

Mar 18 2021

a.elovikov updated the diff for D98897: [NFC][VPlan] Guard print routines with "#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)".
Mar 18 2021, 3:21 PM · Restricted Project
a.elovikov requested review of D98897: [NFC][VPlan] Guard print routines with "#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)".
Mar 18 2021, 2:11 PM · Restricted Project
a.elovikov updated the diff for D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 18 2021, 1:30 PM · Restricted Project
a.elovikov reopened D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 18 2021, 1:30 PM · Restricted Project
a.elovikov added a comment to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.

It seems the code wasn't properly guarded before this change, and the proper fix would require changing too many places. I'd prefer to do it in separate patch.

Mar 18 2021, 12:55 PM · Restricted Project
a.elovikov added a comment to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.

Sorry for the troubles and thanks for reverting that for me - I didn't receive notifications from buildbots for it. Yes, it's probably related to those #ifs. I'm starting a Release build to reproduce and create a fix.

Mar 18 2021, 12:27 PM · Restricted Project
a.elovikov committed rG6b053c9867a3: [VPlan] Add plain text (not DOT's digraph) dumps (authored by a.elovikov).
[VPlan] Add plain text (not DOT's digraph) dumps
Mar 18 2021, 11:46 AM
a.elovikov closed D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 18 2021, 11:46 AM · Restricted Project

Mar 14 2021

a.elovikov added inline comments to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 14 2021, 7:29 PM · Restricted Project

Mar 12 2021

a.elovikov added inline comments to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 12 2021, 11:53 AM · Restricted Project
a.elovikov updated the diff for D96628: [VPlan] Add plain text (not DOT's digraph) dumps.

Address review comments.

Mar 12 2021, 11:53 AM · Restricted Project

Mar 11 2021

a.elovikov added inline comments to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 11 2021, 12:36 PM · Restricted Project
a.elovikov updated the diff for D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
  • Improve comments.
  • Don't add a new dump point via cl::opt. Instead, add cl::opt to toggle behavior (dot/plain dumps) for the LVP::printPlans method.
Mar 11 2021, 12:36 PM · Restricted Project

Mar 9 2021

a.elovikov added inline comments to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Mar 9 2021, 2:02 PM · Restricted Project

Mar 8 2021

a.elovikov added a comment to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.

Ping.

Mar 8 2021, 9:47 AM · Restricted Project

Mar 4 2021

a.elovikov added inline comments to D97278: [VPlan] Support to widen call intructions in VPlan native path.
Mar 4 2021, 9:55 AM · Restricted Project
a.elovikov added inline comments to D89322: [LV] Initial VPlan cost modelling.
Mar 4 2021, 9:24 AM · Restricted Project

Mar 3 2021

a.elovikov added a comment to D97712: [VPlan] Clone original VPlan and specialize for each VF (WIP)..

I didn't recognize that it's still WIP until some point, so some nitpicking comments aren't very useful probably...

Mar 3 2021, 2:08 PM · Restricted Project
a.elovikov added inline comments to D97711: [VPlan] Introduce VPWidenIntOrFpInductionRecipes to original plan..
Mar 3 2021, 1:47 PM · Restricted Project
a.elovikov added inline comments to D97378: [VPlan] Support to vectorize inner loops with VPlan native path enabled.
Mar 3 2021, 1:31 PM · Restricted Project
a.elovikov added inline comments to D97136: [VPlan] Support to widen select intructions in VPlan native path.
Mar 3 2021, 1:24 PM · Restricted Project
a.elovikov added inline comments to D97278: [VPlan] Support to widen call intructions in VPlan native path.
Mar 3 2021, 11:28 AM · Restricted Project

Mar 2 2021

a.elovikov committed rGb24afec8ae58: [NFCI][VPlan] Modify Recipes' print methods to honor Indent parameter (authored by a.elovikov).
[NFCI][VPlan] Modify Recipes' print methods to honor Indent parameter
Mar 2 2021, 3:35 PM
a.elovikov closed D97787: [NFCI][VPlan] Modify Recipes' print methods to honor Indent parameter.
Mar 2 2021, 3:35 PM · Restricted Project
a.elovikov updated the diff for D96628: [VPlan] Add plain text (not DOT's digraph) dumps.

Rebased on top of D97787.

Mar 2 2021, 10:56 AM · Restricted Project
a.elovikov requested review of D97787: [NFCI][VPlan] Modify Recipes' print methods to honor Indent parameter.
Mar 2 2021, 10:51 AM · Restricted Project

Feb 25 2021

a.elovikov added a comment to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.

Ping

Feb 25 2021, 8:55 AM · Restricted Project

Feb 23 2021

a.elovikov committed rG3605b873f6f0: [NFC][VPlan] Use VPUser to store block's predicate (authored by a.elovikov).
[NFC][VPlan] Use VPUser to store block's predicate
Feb 23 2021, 11:09 AM
a.elovikov closed D96529: [NFC][VPlan] Use VPUser to store block's predicate.
Feb 23 2021, 11:09 AM · Restricted Project

Feb 16 2021

a.elovikov updated the diff for D96529: [NFC][VPlan] Use VPUser to store block's predicate.

Move common implementation of get/set methods into helpers

Feb 16 2021, 9:10 AM · Restricted Project

Feb 12 2021

a.elovikov requested review of D96628: [VPlan] Add plain text (not DOT's digraph) dumps.
Feb 12 2021, 12:42 PM · Restricted Project

Feb 11 2021

a.elovikov requested review of D96529: [NFC][VPlan] Use VPUser to store block's predicate.
Feb 11 2021, 11:01 AM · Restricted Project

Feb 1 2021

a.elovikov added inline comments to D92285: [VPlan] Manage scalarized values using VPValues..
Feb 1 2021, 10:35 AM · Restricted Project

Jan 28 2021

a.elovikov added a comment to D91501: [VPlan] VPTransformState::get() can always return lane 0 for uniforms..

Not blocking this review, but I think it's bug-prone to mix lane 0 of scalarized divergent values and truly uniform values that can be kept on a single scalar. Possible examples:

Jan 28 2021, 1:18 PM · Restricted Project
a.elovikov added a comment to D95382: [VPlan] Use VPUser to manage CondBit.

Hi Florian, I'm starting to familiarize myself with VPlan and wonder if that is a short/mid-term solution or something that is expected to be a long-term.

Jan 28 2021, 10:28 AM · Restricted Project

Jun 8 2020

a.elovikov added inline comments to D72425: [OptRemark] RFC: Introduce a message table for OptRemarks.
Jun 8 2020, 5:12 PM · Restricted Project

Jan 21 2020

a.elovikov committed rGe1d6d3685293: [SLP] Don't allow Div/Rem as alternate opcodes (authored by a.elovikov).
[SLP] Don't allow Div/Rem as alternate opcodes
Jan 21 2020, 3:28 PM
a.elovikov closed D72740: [SLP] Don't allow Div/Rem as alternate opcodes.
Jan 21 2020, 3:27 PM · Restricted Project
a.elovikov committed rG757fe53994c1: [SLP] Add a test showing miscompilation in AltOpcode support (authored by a.elovikov).
[SLP] Add a test showing miscompilation in AltOpcode support
Jan 21 2020, 2:24 PM
a.elovikov closed D72739: [SLP] Add a test showing miscompilation in AltOpcode support.
Jan 21 2020, 2:23 PM · Restricted Project
a.elovikov added a comment to D72740: [SLP] Don't allow Div/Rem as alternate opcodes.

Ping. I don't see any comments that require action on my side.

Jan 21 2020, 9:29 AM · Restricted Project

Jan 15 2020

a.elovikov added a comment to D72740: [SLP] Don't allow Div/Rem as alternate opcodes.

This (and D72739) should be in 10.0 - please can you raise a bug and block https://bugs.llvm.org/show_bug.cgi?id=44555

Jan 15 2020, 9:06 AM · Restricted Project
a.elovikov updated the diff for D72739: [SLP] Add a test showing miscompilation in AltOpcode support.

Remove target datalayout string from the test

Jan 15 2020, 8:26 AM · Restricted Project

Jan 14 2020

a.elovikov updated the diff for D72739: [SLP] Add a test showing miscompilation in AltOpcode support.

Pass tripple/target-cpu via opt's --triple/--mcpu options

Jan 14 2020, 5:42 PM · Restricted Project
a.elovikov added inline comments to D72740: [SLP] Don't allow Div/Rem as alternate opcodes.
Jan 14 2020, 4:23 PM · Restricted Project
a.elovikov added inline comments to D72740: [SLP] Don't allow Div/Rem as alternate opcodes.
Jan 14 2020, 3:52 PM · Restricted Project
a.elovikov added inline comments to D72740: [SLP] Don't allow Div/Rem as alternate opcodes.
Jan 14 2020, 3:44 PM · Restricted Project
a.elovikov created D72740: [SLP] Don't allow Div/Rem as alternate opcodes.
Jan 14 2020, 3:14 PM · Restricted Project
a.elovikov created D72739: [SLP] Add a test showing miscompilation in AltOpcode support.
Jan 14 2020, 3:14 PM · Restricted Project