Page MenuHomePhabricator
Feed Advanced Search

Jul 2 2020

lei added inline comments to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.
Jul 2 2020, 9:42 AM · Restricted Project, Restricted Project, Restricted Project
lei requested changes to D83052: [PowerPC][Power10] Add Vector Insert Instruction Definitions and MC Tests.
Jul 2 2020, 8:37 AM · Restricted Project, Restricted Project
lei added inline comments to D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang.
Jul 2 2020, 7:31 AM · Restricted Project, Restricted Project
lei added inline comments to D82869: [Power10] Implement Vector Permute Extended Builtins in LLVM/Clang.
Jul 2 2020, 6:57 AM · Restricted Project, Restricted Project

Jul 1 2020

lei committed rG88874f074644: [PowerPC]Implement Vector Shift Double Bit Immediate Builtins (authored by biplmish).
[PowerPC]Implement Vector Shift Double Bit Immediate Builtins
Jul 1 2020, 6:55 PM
lei closed D82440: [Power10] Implement Vector Shift Double Bit Immediate Builtins in LLVM/Clang.
Jul 1 2020, 6:54 PM · Restricted Project, Restricted Project
lei committed rG99c4207d428b: [PowerPC][NFC] Update doc for FeatureISA3_1/FeatureISA3_0 definitions (authored by lei).
[PowerPC][NFC] Update doc for FeatureISA3_1/FeatureISA3_0 definitions
Jul 1 2020, 5:51 PM
lei committed rGc5b4f03b53a4: [PowerPC] Exploit xxspltiw and xxspltidp instructions (authored by anil9).
[PowerPC] Exploit xxspltiw and xxspltidp instructions
Jul 1 2020, 5:22 PM
lei closed D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
Jul 1 2020, 5:22 PM · Restricted Project
lei added inline comments to D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
Jul 1 2020, 1:32 PM · Restricted Project
lei updated the diff for D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..

rename test file and add additional ccomments to code.

Jul 1 2020, 1:32 PM · Restricted Project
lei updated the diff for D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..

revert changes to the if condition

Jul 1 2020, 12:59 PM · Restricted Project
lei added inline comments to D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
Jul 1 2020, 12:26 PM · Restricted Project
lei updated the diff for D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..

Remove unnecessary FIXME message, accidental formating, and simplify if-condition as suggested by Victor.

Jul 1 2020, 12:26 PM · Restricted Project
lei updated the diff for D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
  • clean up condition code in isFPImmLegal()
  • split test file into pcrel and non-pcrel related, clean up checks
  • add test for BE elfv2
Jul 1 2020, 10:48 AM · Restricted Project
lei commandeered D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..

Taking over ownership to address review comments.

Jul 1 2020, 10:48 AM · Restricted Project
lei added inline comments to D82869: [Power10] Implement Vector Permute Extended Builtins in LLVM/Clang.
Jul 1 2020, 7:00 AM · Restricted Project, Restricted Project
lei accepted D82440: [Power10] Implement Vector Shift Double Bit Immediate Builtins in LLVM/Clang.

Please address nits and file name changes on commit.

Jul 1 2020, 7:00 AM · Restricted Project, Restricted Project
lei added a comment to D82869: [Power10] Implement Vector Permute Extended Builtins in LLVM/Clang.

p10-permute-ops.ll => builtins-ppc-p10permute.ll
Looks like this file is being created in several diff patches you have up for review.

Jul 1 2020, 6:28 AM · Restricted Project, Restricted Project
lei added a comment to D82774: [Power10] Implement Vector Blend Builtins in LLVM/Clang.

p10-permute-ops.ll => builtins-ppc-p10permute.ll

Jul 1 2020, 6:28 AM · Restricted Project, Restricted Project
lei requested changes to D82440: [Power10] Implement Vector Shift Double Bit Immediate Builtins in LLVM/Clang.

Please use similar naming for all new builtin test files:
p10-permute-ops.ll => builtins-ppc-p10permute.ll

Jul 1 2020, 6:27 AM · Restricted Project, Restricted Project
lei added inline comments to D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins.
Jul 1 2020, 5:54 AM · Restricted Project, Restricted Project, Restricted Project
lei accepted D82929: [PowerPC][Power10] Add Vector Multiply/Mod/Divide Instruction Definitions and MC Tests.

LGTM

Jul 1 2020, 5:22 AM · Restricted Project, Restricted Project

Jun 30 2020

lei requested changes to D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins.

Please move encoding tests to ppc64-encoding-ISA31.[txt|s].

Jun 30 2020, 8:35 PM · Restricted Project, Restricted Project, Restricted Project
lei accepted D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang.

LGTM thx!

Jun 30 2020, 8:35 PM · Restricted Project, Restricted Project, Restricted Project
lei added inline comments to D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
Jun 30 2020, 8:35 PM · Restricted Project
lei added inline comments to D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
Jun 30 2020, 8:35 PM · Restricted Project
lei added a comment to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.

Please move encoding tests to ppc64-encoding-ISA31.[txt|s].

Jun 30 2020, 4:18 PM · Restricted Project, Restricted Project, Restricted Project
lei added inline comments to D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
Jun 30 2020, 3:14 PM · Restricted Project
lei added a comment to D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang.

encoding tests need to be placed in corresponding ppc64-encoding-ISA31* files

Jun 30 2020, 11:56 AM · Restricted Project, Restricted Project, Restricted Project
lei accepted D82896: [PowerPC][Power10] Add Vector Splat Immediate, Permute, Blend, Shift Double Bit immediate Instruction Definitions and MC Tests .

LGTM other then the minor nit that can be address on commit.

Jun 30 2020, 11:56 AM · Restricted Project, Restricted Project
lei committed rG3163269275dc: [PowerPC][NFC] Rename/organize encoding test files for ISA3.1 (authored by lei).
[PowerPC][NFC] Rename/organize encoding test files for ISA3.1
Jun 30 2020, 10:19 AM
lei requested changes to D82859: [Power10] Implement VSX vector permute extended instruction.

The asm instr should go into the appropriate files. Nothing with p10 in them.

Jun 30 2020, 6:28 AM · Restricted Project

Jun 29 2020

lei committed rGaf9cc2d2afe8: [PowerPC] Fix FeatureISA3_1 def in PPC.td to imply FeatureISA3_0. (authored by lei).
[PowerPC] Fix FeatureISA3_1 def in PPC.td to imply FeatureISA3_0.
Jun 29 2020, 2:25 PM

Jun 26 2020

lei accepted D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang.

LGTM

Jun 26 2020, 1:08 PM · Restricted Project, Restricted Project, Restricted Project

Jun 23 2020

lei added inline comments to D82359: [Power10] Implement Vector Replace Builtins in LLVM/Clang.
Jun 23 2020, 7:58 AM · Restricted Project
lei added inline comments to D82365: [Power10] Implement Vector Insert Builtins in LLVM/Clang.
Jun 23 2020, 7:58 AM · Restricted Project, Restricted Project
lei added a comment to D81836: [PowerPC][Power10] Implement Vector Permute Builtins in LLVM/Clang.

This is PR still valid? I see dup def in https://reviews.llvm.org/D82365.

Jun 23 2020, 7:58 AM · Restricted Project, Restricted Project, Restricted Project
lei accepted D81816: [PowerPC] Add support for vector bool __int128 for Power10.

LGTM, please address the 1 comment I have on commit.

Jun 23 2020, 6:21 AM · Restricted Project, Restricted Project, Restricted Project
lei accepted D81816: [PowerPC] Add support for vector bool __int128 for Power10.
Jun 23 2020, 6:21 AM · Restricted Project, Restricted Project, Restricted Project

Jun 17 2020

lei added inline comments to D81816: [PowerPC] Add support for vector bool __int128 for Power10.
Jun 17 2020, 2:02 PM · Restricted Project, Restricted Project, Restricted Project
lei added inline comments to D79625: [PowerPC] Extend .reloc directive on PowerPC.
Jun 17 2020, 1:29 PM · Restricted Project

Jun 16 2020

lei added inline comments to D81816: [PowerPC] Add support for vector bool __int128 for Power10.
Jun 16 2020, 12:05 PM · Restricted Project, Restricted Project, Restricted Project
lei added inline comments to D81816: [PowerPC] Add support for vector bool __int128 for Power10.
Jun 16 2020, 12:04 PM · Restricted Project, Restricted Project, Restricted Project
lei added inline comments to D81816: [PowerPC] Add support for vector bool __int128 for Power10.
Jun 16 2020, 11:32 AM · Restricted Project, Restricted Project, Restricted Project
lei requested changes to D81816: [PowerPC] Add support for vector bool __int128 for Power10.
Jun 16 2020, 8:49 AM · Restricted Project, Restricted Project, Restricted Project

Jun 15 2020

lei accepted D81707: [PowerPC][Power10] Implement Vector Clear Left/Rightmost Bytes Builtins in LLVM/Clang.

LGTM
Minor nit to be addressed during commit.

Jun 15 2020, 12:38 PM · Restricted Project, Restricted Project, Restricted Project
lei accepted D81774: [PowerPC][Power10] Implement VSX PCV Generate Operations in LLVM/Clang.

LGTM

Jun 15 2020, 12:37 PM · Restricted Project, Restricted Project, Restricted Project
lei accepted D80935: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang.

LGTM, just 1 minor comment/question.

Jun 15 2020, 12:37 PM · Restricted Project, Restricted Project, Restricted Project
lei accepted D80970: [PowerPC][Power10] Implement centrifuge, vector gather every nth bit, vector evaluate Builtins in LLVM/Clang.

LGTM

Jun 15 2020, 12:37 PM · Restricted Project, Restricted Project, Restricted Project

Jun 2 2020

lei accepted D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option.

LGTM.
Minor nit can be addressed during commit.

Jun 2 2020, 7:08 AM · Restricted Project, Restricted Project, Restricted Project

Jun 1 2020

lei committed rG7cfded350a7e: [PowerPC] Add clang option -m[no-]pcrel (authored by lei).
[PowerPC] Add clang option -m[no-]pcrel
Jun 1 2020, 1:35 PM
lei closed D80757: [PowerPC] Add clang option -m[no-]pcrel.
Jun 1 2020, 1:35 PM · Restricted Project, Restricted Project

May 29 2020

lei added inline comments to D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option.
May 29 2020, 10:53 AM · Restricted Project, Restricted Project, Restricted Project
lei added inline comments to D80757: [PowerPC] Add clang option -m[no-]pcrel.
May 29 2020, 5:56 AM · Restricted Project, Restricted Project

May 28 2020

lei created D80757: [PowerPC] Add clang option -m[no-]pcrel.
May 28 2020, 1:45 PM · Restricted Project, Restricted Project

May 27 2020

lei committed rG2368bf52cd77: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm (authored by lei).
[PowerPC] Add support for -mcpu=pwr10 in both clang and llvm
May 27 2020, 11:24 AM
lei closed D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.
May 27 2020, 11:24 AM · Restricted Project, Restricted Project, Restricted Project
lei committed rG559845f8fe53: Revert "[PowerPC] Add support for -mcpu=pwr10 in both clang and llvm" (authored by lei).
Revert "[PowerPC] Add support for -mcpu=pwr10 in both clang and llvm"
May 27 2020, 8:06 AM
lei added a reverting change for rG7eb666b1556b: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm: rG559845f8fe53: Revert "[PowerPC] Add support for -mcpu=pwr10 in both clang and llvm".
May 27 2020, 8:06 AM
lei updated the diff for D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.

fix up rebase issue after revert

May 27 2020, 8:05 AM · Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.

rebased

May 27 2020, 7:33 AM · Restricted Project, Restricted Project, Restricted Project

May 26 2020

lei updated the diff for D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.

change how we generate p10 feature list.

May 26 2020, 1:38 PM · Restricted Project, Restricted Project, Restricted Project
lei reopened D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.
May 26 2020, 1:05 PM · Restricted Project, Restricted Project, Restricted Project
lei committed rG7eb666b1556b: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm (authored by lei).
[PowerPC] Add support for -mcpu=pwr10 in both clang and llvm
May 26 2020, 12:00 PM
lei closed D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.
May 26 2020, 11:59 AM · Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.

update as per reviewers comments

May 26 2020, 11:58 AM · Restricted Project, Restricted Project, Restricted Project

May 25 2020

lei added inline comments to D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.
May 25 2020, 1:56 PM · Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.

address review comments

May 25 2020, 1:56 PM · Restricted Project, Restricted Project, Restricted Project

May 19 2020

lei committed rG2e6e27583ce1: [PowerPC][NFC] Cleanup load/store spilling code (authored by lei).
[PowerPC][NFC] Cleanup load/store spilling code
May 19 2020, 1:12 PM
lei closed D79736: [PowerPC][NFC] Cleanup load/store spilling code.
May 19 2020, 1:12 PM · Restricted Project, Restricted Project
lei updated the diff for D79736: [PowerPC][NFC] Cleanup load/store spilling code.

rebase

May 19 2020, 1:10 PM · Restricted Project, Restricted Project

May 15 2020

lei updated the diff for D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.

missed a file

May 15 2020, 11:57 AM · Restricted Project, Restricted Project, Restricted Project
lei retitled D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm from [PowerPC] Add support for -mcpu=pwr10 in the front end to [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.
May 15 2020, 11:57 AM · Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.

Add support in llvm.

May 15 2020, 11:57 AM · Restricted Project, Restricted Project, Restricted Project
lei created D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.
May 15 2020, 10:51 AM · Restricted Project, Restricted Project, Restricted Project

May 14 2020

lei added inline comments to D79736: [PowerPC][NFC] Cleanup load/store spilling code.
May 14 2020, 2:41 PM · Restricted Project, Restricted Project

May 11 2020

lei accepted D79633: [PowerPC] Add support for llvm.ppc.dcbt, llvm.ppc.dcbtst, llvm.ppc.isync intrinsics.

LGTM

May 11 2020, 3:07 PM · Restricted Project
lei added inline comments to D77646: [PowerPC] Fold vector merges of swapped vectors to merge the opposite half.
May 11 2020, 2:35 PM · Restricted Project
lei retitled D79736: [PowerPC][NFC] Cleanup load/store spilling code from [rton,PowerPC][NFC] Cleanup load/store spilling code to [PowerPC][NFC] Cleanup load/store spilling code.
May 11 2020, 12:55 PM · Restricted Project, Restricted Project
lei created D79736: [PowerPC][NFC] Cleanup load/store spilling code.
May 11 2020, 12:22 PM · Restricted Project, Restricted Project

May 5 2020

lei added inline comments to D77448: [PowerPC] Canonicalize shuffles to match more single-instruction masks on LE.
May 5 2020, 11:53 AM · Restricted Project

May 4 2020

lei accepted D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint.

LGTM

May 4 2020, 11:48 AM · Restricted Project

Apr 17 2020

lei added inline comments to D77101: [AIX] Return the correct set of callee saved regs.
Apr 17 2020, 3:11 PM · Restricted Project
lei committed rG10b60dde7670: [PowerPC] Refactor ppcUserFeaturesCheck() (authored by lei).
[PowerPC] Refactor ppcUserFeaturesCheck()
Apr 17 2020, 1:32 PM
lei closed D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck().
Apr 17 2020, 1:32 PM · Restricted Project, Restricted Project
lei updated the diff for D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck().

Address review comments

Apr 17 2020, 11:20 AM · Restricted Project, Restricted Project
lei added inline comments to D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck().
Apr 17 2020, 10:47 AM · Restricted Project, Restricted Project

Apr 16 2020

lei updated the diff for D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck().

updated.

Apr 16 2020, 3:04 PM · Restricted Project, Restricted Project
lei updated the diff for D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck().
Apr 16 2020, 12:14 PM · Restricted Project, Restricted Project
lei updated the diff for D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck().
Apr 16 2020, 12:14 PM · Restricted Project, Restricted Project
lei created D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck().
Apr 16 2020, 10:01 AM · Restricted Project, Restricted Project

Mar 11 2020

lei added a comment to D75819: [PowerPC][NFC] Rename instruction formats in PPCInstrPrefix.td.

Thanks for the update!

Mar 11 2020, 5:03 PM · Restricted Project

Mar 10 2020

lei added inline comments to D75280: [PowerPC][Future] Add initial support for PC Relative addressing for global values.
Mar 10 2020, 2:13 PM · Restricted Project
lei accepted D75819: [PowerPC][NFC] Rename instruction formats in PPCInstrPrefix.td.

Just 1 minor name change. Otherwise LGTM.

Mar 10 2020, 6:58 AM · Restricted Project

Feb 12 2020

lei added a comment to rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.

Thanks! Unfortunately we don't have a machine that is publically accessible. We are actively working on getting a reproducer right now, will let you know as soon as it's ready.

Feb 12 2020, 12:43 PM
lei added a comment to rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.

This patch broke our multistage bot during stage 2 build: http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/23546
We are investigating, please pull until we can provide a reproducer.

Feb 12 2020, 11:28 AM

Feb 7 2020

lei accepted D72660: [PowerPC] Improve handling of some BUILD_VECTOR nodes.

LGTM

Feb 7 2020, 5:45 AM · Restricted Project

Nov 25 2019

lei committed rG9e676d9c7e64: [PowerPC][compiler-rt][builtins]Add __fixtfti builtin on PowerPC (authored by lei).
[PowerPC][compiler-rt][builtins]Add __fixtfti builtin on PowerPC
Nov 25 2019, 12:56 PM
lei closed D69730: [compiler-rt][builtins][PowerPC] Add __fixtfti builtin on PowerPC.
Nov 25 2019, 12:56 PM · Restricted Project, Restricted Project