Page MenuHomePhabricator
Feed Advanced Search

Jun 16 2020

lei requested changes to D81816: [PowerPC] Add support for vector bool __int128 for Power10.
Jun 16 2020, 8:49 AM · Restricted Project, Restricted Project, Restricted Project

Jun 15 2020

lei accepted D81707: [PowerPC][Power10] Implement Vector Clear Left/Rightmost Bytes Builtins in LLVM/Clang.

LGTM
Minor nit to be addressed during commit.

Jun 15 2020, 12:38 PM · Restricted Project, Restricted Project, Restricted Project
lei accepted D81774: [PowerPC][Power10] Implement VSX PCV Generate Operations in LLVM/Clang.

LGTM

Jun 15 2020, 12:37 PM · Restricted Project, Restricted Project, Restricted Project
lei accepted D80935: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang.

LGTM, just 1 minor comment/question.

Jun 15 2020, 12:37 PM · Restricted Project, Restricted Project, Restricted Project
lei accepted D80970: [PowerPC][Power10] Implement centrifuge, vector gather every nth bit, vector evaluate Builtins in LLVM/Clang.

LGTM

Jun 15 2020, 12:37 PM · Restricted Project, Restricted Project, Restricted Project

Jun 2 2020

lei accepted D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option.

LGTM.
Minor nit can be addressed during commit.

Jun 2 2020, 7:08 AM · Restricted Project, Restricted Project, Restricted Project

Jun 1 2020

lei committed rG7cfded350a7e: [PowerPC] Add clang option -m[no-]pcrel (authored by lei).
[PowerPC] Add clang option -m[no-]pcrel
Jun 1 2020, 1:35 PM
lei closed D80757: [PowerPC] Add clang option -m[no-]pcrel.
Jun 1 2020, 1:35 PM · Restricted Project, Restricted Project

May 29 2020

lei added inline comments to D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option.
May 29 2020, 10:53 AM · Restricted Project, Restricted Project, Restricted Project
lei added inline comments to D80757: [PowerPC] Add clang option -m[no-]pcrel.
May 29 2020, 5:56 AM · Restricted Project, Restricted Project

May 28 2020

lei created D80757: [PowerPC] Add clang option -m[no-]pcrel.
May 28 2020, 1:45 PM · Restricted Project, Restricted Project

May 27 2020

lei committed rG2368bf52cd77: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm (authored by lei).
[PowerPC] Add support for -mcpu=pwr10 in both clang and llvm
May 27 2020, 11:24 AM
lei closed D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.
May 27 2020, 11:24 AM · Restricted Project, Restricted Project, Restricted Project
lei committed rG559845f8fe53: Revert "[PowerPC] Add support for -mcpu=pwr10 in both clang and llvm" (authored by lei).
Revert "[PowerPC] Add support for -mcpu=pwr10 in both clang and llvm"
May 27 2020, 8:06 AM
lei added a reverting change for rG7eb666b1556b: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm: rG559845f8fe53: Revert "[PowerPC] Add support for -mcpu=pwr10 in both clang and llvm".
May 27 2020, 8:06 AM
lei updated the diff for D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.

fix up rebase issue after revert

May 27 2020, 8:05 AM · Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.

rebased

May 27 2020, 7:33 AM · Restricted Project, Restricted Project, Restricted Project

May 26 2020

lei updated the diff for D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.

change how we generate p10 feature list.

May 26 2020, 1:38 PM · Restricted Project, Restricted Project, Restricted Project
lei reopened D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.
May 26 2020, 1:05 PM · Restricted Project, Restricted Project, Restricted Project
lei committed rG7eb666b1556b: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm (authored by lei).
[PowerPC] Add support for -mcpu=pwr10 in both clang and llvm
May 26 2020, 12:00 PM
lei closed D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.
May 26 2020, 11:59 AM · Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.

update as per reviewers comments

May 26 2020, 11:58 AM · Restricted Project, Restricted Project, Restricted Project

May 25 2020

lei added inline comments to D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.
May 25 2020, 1:56 PM · Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.

address review comments

May 25 2020, 1:56 PM · Restricted Project, Restricted Project, Restricted Project

May 19 2020

lei committed rG2e6e27583ce1: [PowerPC][NFC] Cleanup load/store spilling code (authored by lei).
[PowerPC][NFC] Cleanup load/store spilling code
May 19 2020, 1:12 PM
lei closed D79736: [PowerPC][NFC] Cleanup load/store spilling code.
May 19 2020, 1:12 PM · Restricted Project, Restricted Project
lei updated the diff for D79736: [PowerPC][NFC] Cleanup load/store spilling code.

rebase

May 19 2020, 1:10 PM · Restricted Project, Restricted Project

May 15 2020

lei updated the diff for D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.

missed a file

May 15 2020, 11:57 AM · Restricted Project, Restricted Project, Restricted Project
lei retitled D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm from [PowerPC] Add support for -mcpu=pwr10 in the front end to [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.
May 15 2020, 11:57 AM · Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.

Add support in llvm.

May 15 2020, 11:57 AM · Restricted Project, Restricted Project, Restricted Project
lei created D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm.
May 15 2020, 10:51 AM · Restricted Project, Restricted Project, Restricted Project

May 14 2020

lei added inline comments to D79736: [PowerPC][NFC] Cleanup load/store spilling code.
May 14 2020, 2:41 PM · Restricted Project, Restricted Project

May 11 2020

lei accepted D79633: [PowerPC] Add support for llvm.ppc.dcbt, llvm.ppc.dcbtst, llvm.ppc.isync intrinsics.

LGTM

May 11 2020, 3:07 PM · Restricted Project
lei added inline comments to D77646: [PowerPC] Fold vector merges of swapped vectors to merge the opposite half.
May 11 2020, 2:35 PM · Restricted Project
lei retitled D79736: [PowerPC][NFC] Cleanup load/store spilling code from [rton,PowerPC][NFC] Cleanup load/store spilling code to [PowerPC][NFC] Cleanup load/store spilling code.
May 11 2020, 12:55 PM · Restricted Project, Restricted Project
lei created D79736: [PowerPC][NFC] Cleanup load/store spilling code.
May 11 2020, 12:22 PM · Restricted Project, Restricted Project

May 5 2020

lei added inline comments to D77448: [PowerPC] Canonicalize shuffles to match more single-instruction masks on LE.
May 5 2020, 11:53 AM · Restricted Project

May 4 2020

lei accepted D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint.

LGTM

May 4 2020, 11:48 AM · Restricted Project

Apr 17 2020

lei added inline comments to D77101: [AIX] Return the correct set of callee saved regs.
Apr 17 2020, 3:11 PM · Restricted Project
lei committed rG10b60dde7670: [PowerPC] Refactor ppcUserFeaturesCheck() (authored by lei).
[PowerPC] Refactor ppcUserFeaturesCheck()
Apr 17 2020, 1:32 PM
lei closed D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck().
Apr 17 2020, 1:32 PM · Restricted Project, Restricted Project
lei updated the diff for D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck().

Address review comments

Apr 17 2020, 11:20 AM · Restricted Project, Restricted Project
lei added inline comments to D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck().
Apr 17 2020, 10:47 AM · Restricted Project, Restricted Project

Apr 16 2020

lei updated the diff for D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck().

updated.

Apr 16 2020, 3:04 PM · Restricted Project, Restricted Project
lei updated the diff for D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck().
Apr 16 2020, 12:14 PM · Restricted Project, Restricted Project
lei updated the diff for D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck().
Apr 16 2020, 12:14 PM · Restricted Project, Restricted Project
lei created D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck().
Apr 16 2020, 10:01 AM · Restricted Project, Restricted Project

Mar 11 2020

lei added a comment to D75819: [PowerPC][NFC] Rename instruction formats in PPCInstrPrefix.td.

Thanks for the update!

Mar 11 2020, 5:03 PM · Restricted Project

Mar 10 2020

lei added inline comments to D75280: [PowerPC][Future] Add initial support for PC Relative addressing for global values.
Mar 10 2020, 2:13 PM · Restricted Project
lei accepted D75819: [PowerPC][NFC] Rename instruction formats in PPCInstrPrefix.td.

Just 1 minor name change. Otherwise LGTM.

Mar 10 2020, 6:58 AM · Restricted Project

Feb 12 2020

lei added a comment to rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.

Thanks! Unfortunately we don't have a machine that is publically accessible. We are actively working on getting a reproducer right now, will let you know as soon as it's ready.

Feb 12 2020, 12:43 PM
lei added a comment to rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.

This patch broke our multistage bot during stage 2 build: http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/23546
We are investigating, please pull until we can provide a reproducer.

Feb 12 2020, 11:28 AM

Feb 7 2020

lei accepted D72660: [PowerPC] Improve handling of some BUILD_VECTOR nodes.

LGTM

Feb 7 2020, 5:45 AM · Restricted Project

Nov 25 2019

lei committed rG9e676d9c7e64: [PowerPC][compiler-rt][builtins]Add __fixtfti builtin on PowerPC (authored by lei).
[PowerPC][compiler-rt][builtins]Add __fixtfti builtin on PowerPC
Nov 25 2019, 12:56 PM
lei closed D69730: [compiler-rt][builtins][PowerPC] Add __fixtfti builtin on PowerPC.
Nov 25 2019, 12:56 PM · Restricted Project, Restricted Project

Nov 12 2019

lei added inline comments to D68237: [PowerPC] Handle f16 as a storage type only.
Nov 12 2019, 7:41 AM · Restricted Project
lei accepted D68576: [PowerPC] Fix VSX clobbers of CSR registers.

LGTM.
Please address Amy's comment on commit.

Nov 12 2019, 7:22 AM · Restricted Project
lei accepted D69949: [PowerPC] Legalize rounding nodes.

LGTM

Nov 12 2019, 7:22 AM · Restricted Project

Nov 8 2019

lei committed rG71f4761431a7: [PowerPC][compiler-rt][builtins]Fix __fixunstfti builtin on PowerPC (authored by lei).
[PowerPC][compiler-rt][builtins]Fix __fixunstfti builtin on PowerPC
Nov 8 2019, 9:58 AM
lei closed D69193: [compiler-rt][builtins][PowerPC] Fix __fixunstfti builtin on PowerPC.
Nov 8 2019, 9:58 AM · Restricted Project, Restricted Project

Oct 22 2019

lei added inline comments to D69066: Add support for intrinsic llvm.ppc.eieio.
Oct 22 2019, 11:34 AM · Restricted Project
lei added a comment to D68411: Add support for intrinsics llvm.ppc.dcbfl and llvm.ppc.dcbflp.

Since these are just mnemonics for using dcbf, why not just add the tests to llvm/test/CodeGen/PowerPC/dcbf.ll instead of creating 2 small test files.

Oct 22 2019, 11:05 AM · Restricted Project
lei accepted D69193: [compiler-rt][builtins][PowerPC] Fix __fixunstfti builtin on PowerPC.

LGTM

Oct 22 2019, 10:22 AM · Restricted Project, Restricted Project

Sep 16 2019

lei committed rGbfb197d7a3b3: [PowerPC] Cust lower fpext v2f32 to v2f64 from extract_subvector v4f32 (authored by lei).
[PowerPC] Cust lower fpext v2f32 to v2f64 from extract_subvector v4f32
Sep 16 2019, 1:05 PM
lei committed rL372029: [PowerPC] Cust lower fpext v2f32 to v2f64 from extract_subvector v4f32.
[PowerPC] Cust lower fpext v2f32 to v2f64 from extract_subvector v4f32
Sep 16 2019, 1:05 PM
lei closed D61961: [PowerPC] Cust lower fpext v2f32 to v2f64 from extract_subvector v4f32.
Sep 16 2019, 1:05 PM · Restricted Project

Sep 12 2019

lei added inline comments to D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Sep 12 2019, 4:45 PM · Restricted Project
lei added a comment to D61961: [PowerPC] Cust lower fpext v2f32 to v2f64 from extract_subvector v4f32.

@nemanjai All comments have been addressed. Please take another look. Thx!

Sep 12 2019, 12:36 PM · Restricted Project

Sep 11 2019

lei added inline comments to D63676: Disable hoisting MI to hotter basic blocks.
Sep 11 2019, 7:28 AM · Restricted Project
lei updated the diff for D61961: [PowerPC] Cust lower fpext v2f32 to v2f64 from extract_subvector v4f32.

Addressed reviewer comments.

Sep 11 2019, 7:02 AM · Restricted Project

Jul 23 2019

lei committed rG686cee09450e: [NFC][ASAN] Add brackets around not command (authored by lei).
[NFC][ASAN] Add brackets around not command
Jul 23 2019, 6:12 AM
lei committed rL366805: [NFC][ASAN] Add brackets around not command.
[NFC][ASAN] Add brackets around not command
Jul 23 2019, 6:12 AM

Jul 22 2019

lei updated the diff for D61961: [PowerPC] Cust lower fpext v2f32 to v2f64 from extract_subvector v4f32.

Address review comments.

Jul 22 2019, 11:49 AM · Restricted Project

Jul 5 2019

lei added a comment to D61961: [PowerPC] Cust lower fpext v2f32 to v2f64 from extract_subvector v4f32.

Ping

Jul 5 2019, 9:40 AM · Restricted Project

Jun 12 2019

lei added inline comments to D61249: [NFC] Refactor the systemZ scheduler strategy to adapt with the new schedule state forwarding infrastructure.
Jun 12 2019, 7:43 AM · Restricted Project
lei added inline comments to D61248: [NFC] Add the infrastructure to forward the scheduled state between MBB.
Jun 12 2019, 5:17 AM · Restricted Project

May 15 2019

lei updated the diff for D61961: [PowerPC] Cust lower fpext v2f32 to v2f64 from extract_subvector v4f32.
May 15 2019, 1:46 PM · Restricted Project
lei created D61961: [PowerPC] Cust lower fpext v2f32 to v2f64 from extract_subvector v4f32.
May 15 2019, 1:37 PM · Restricted Project

May 14 2019

lei committed rG22561972af47: [PowerPC] Custom lower known CR bit spills (authored by lei).
[PowerPC] Custom lower known CR bit spills
May 14 2019, 7:25 AM
lei committed rL360677: [PowerPC] Custom lower known CR bit spills.
[PowerPC] Custom lower known CR bit spills
May 14 2019, 7:24 AM
lei closed D61754: [PowerPC] Custom lower known CR bit spills.
May 14 2019, 7:24 AM · Restricted Project
lei added a comment to D61754: [PowerPC] Custom lower known CR bit spills.

LGTM.

If this test case proves too fragile in the future, we might replace it with an MIR test.

May 14 2019, 6:45 AM · Restricted Project

May 13 2019

lei added a comment to D61754: [PowerPC] Custom lower known CR bit spills.

address spacing issues.

May 13 2019, 1:11 PM · Restricted Project
lei updated the diff for D61754: [PowerPC] Custom lower known CR bit spills.
May 13 2019, 1:11 PM · Restricted Project
lei updated the diff for D61754: [PowerPC] Custom lower known CR bit spills.

Added option to specify cutoff for CR bit definition search with default of 100.

May 13 2019, 12:45 PM · Restricted Project

May 10 2019

lei added inline comments to D61754: [PowerPC] Custom lower known CR bit spills.
May 10 2019, 3:35 PM · Restricted Project
lei added inline comments to D61754: [PowerPC] Custom lower known CR bit spills.
May 10 2019, 12:47 PM · Restricted Project
lei committed rG1ac6e9636c9e: [PowerPC] custom lower `v2f64 fpext v2f32` (authored by lei).
[PowerPC] custom lower `v2f64 fpext v2f32`
May 10 2019, 7:03 AM
lei committed rL360429: [PowerPC] custom lower `v2f64 fpext v2f32`.
[PowerPC] custom lower `v2f64 fpext v2f32`
May 10 2019, 7:02 AM
lei closed D57857: [PowerPC] custom lower `v2f64 fpext v2f32`.
May 10 2019, 7:02 AM · Restricted Project

May 9 2019

lei created D61754: [PowerPC] Custom lower known CR bit spills.
May 9 2019, 12:38 PM · Restricted Project

Apr 8 2019

lei requested review of D57857: [PowerPC] custom lower `v2f64 fpext v2f32`.
Apr 8 2019, 11:56 AM · Restricted Project
lei updated the diff for D57857: [PowerPC] custom lower `v2f64 fpext v2f32`.

Update comments and renamed new ppc ISD nodes.

Apr 8 2019, 11:41 AM · Restricted Project

Feb 13 2019

lei updated the diff for D57857: [PowerPC] custom lower `v2f64 fpext v2f32`.

Address review comments.

Feb 13 2019, 11:42 AM · Restricted Project
lei requested review of D57857: [PowerPC] custom lower `v2f64 fpext v2f32`.
Feb 13 2019, 5:21 AM · Restricted Project

Feb 6 2019

lei created D57857: [PowerPC] custom lower `v2f64 fpext v2f32`.
Feb 6 2019, 3:46 PM · Restricted Project
lei added a comment to D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used..

@delcypher I am having a problem with my internal build after this change have gone in. Can you please help to determine what went wrong? Previously I was able to do the following:

$ cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=On '-DLLVM_ENABLE_PROJECTS=clang;llvm;compiler-rt;clang-tools-extra;openmp;lld' -DCMAKE_C_COMPILER=/home/llvm/gcc/7.3.0/bin/gcc -DCMAKE_CXX_COMPILER=/home/llvm/gcc/7.3.0/bin/g++ -DLLVM_BINUTILS_INCDIR=/usr/include $LLVM_SRC
$ ninja -j 20
$ ninja check-libomptarget check-openmp
Feb 6 2019, 1:02 PM · Restricted Project

Nov 2 2018

lei committed rCRT346030: [PowerPC]Disable randomized address space on Linux ppc64le.
[PowerPC]Disable randomized address space on Linux ppc64le
Nov 2 2018, 12:03 PM
lei committed rL346030: [PowerPC]Disable randomized address space on Linux ppc64le.
[PowerPC]Disable randomized address space on Linux ppc64le
Nov 2 2018, 12:02 PM
lei closed D52900: [PowerPC]Disable randomized address space on Linux ppc64le.
Nov 2 2018, 12:02 PM