LGTM
Thx

LGTM

For new passes, maybe we can commit it as off first and then subsequent patch to turn it on by default? That way if it causes any issues we can just revert the default on patch.

Keep original order

nit: can we rename the new test files tobe mergeable-string-pool.ll mergeable-string-pool-large.ll?

@nickdesaulniers I have verified this patch on top of 40ee8abee77a2e8fb0089d4c7f5723b71f27d416 passes our multistage bot http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage

Sorry I missed this. Will kick off now and let you know the results soon.

Rebase to ToT

I was thinking to commit this patch to minimize the dependencies if there are no objections. @MaskRay @nemanjai any preferences?

This is causing a ld.lld link failure in https://lab.llvm.org/buildbot/#/builders/57

FAILED: tools/clang/tools/extra/include-cleaner/unittests/ClangIncludeCleanerTests 
: && /home/buildbots/clang.15.0.4/bin/clang++ --gcc-toolchain=/usr -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -Wl,--color-diagnostics     -Wl,--gc-sections tools/clang/tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/AnalysisTest.cpp.o tools/clang/tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/FindHeadersTest.cpp.o tools/clang/tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/IncludeSpellerTest.cpp.o tools/clang/tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/LocateSymbolTest.cpp.o tools/clang/tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/RecordTest.cpp.o tools/clang/tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/TypesTest.cpp.o tools/clang/tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/WalkASTTest.cpp.o -o tools/clang/tools/extra/include-cleaner/unittests/ClangIncludeCleanerTests  -Wl,-rpath,/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/lib  -lpthread  lib/libllvm_gtest_main.so.18git  -lpthread  lib/libclangIncludeCleaner.so.18git  lib/libclangTesting.so.18git  lib/libLLVMTestingAnnotations.so.18git  lib/libLLVMTestingSupport.so.18git  lib/libclangFormat.so.18git  lib/libclangToolingInclusionsStdlib.so.18git  lib/libllvm_gtest.so.18git  lib/libclangFrontend.so.18git  lib/libclangAST.so.18git  lib/libclangLex.so.18git  lib/libclangBasic.so.18git  lib/libLLVMSupport.so.18git  -Wl,-rpath-link,/home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/lib && :
ld.lld: error: undefined symbol: clang::PCHContainerOperations::PCHContainerOperations()
>>> referenced by RecordTest.cpp
>>>               tools/clang/tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/RecordTest.cpp.o:(clang::include_cleaner::(anonymous namespace)::PragmaIncludeTest_ExportInUnnamedBuffer_Test::TestBody())
clang-15: error: linker command failed with exit code 1 (use -v to see invocation)

Maybe a lib is needed?

fix encoding for diexq

address review comments

LGTM other then some nits.
Thx.

LGTM
Thx

add new tc and update to test for pwr8 since we are more interested
in the new tc behaviour for pwr8 and orig tc is same for pwr8 vs pwr7.

fix indentation.

update description

remove unrelated new line

rebase to ToT

address review comments

remove new class def as there's an existing one.

Move class and multi class def.

fix f8rc reg

fix error in instruction name from drmd[q] to drrnd[q].

Patch by Nemanja

clang-format

clang-format

fix indentation

fix indentation.

Just a few nits, otherwise LGTM.
Thanks for addressing the issue with increasing the usage of registers when we have a 64-bit load/store on a 32-bit system.

I don't know why adding new instructions would change where some older instructions are located in P10InstrResources.td, but since that is auto generated I will assume it is a separate issue that need to be looked into.
LGTM other then a nit.

LGTM

LGTM

Just a minor comment otherwise LGTM.
Thx

thx for the added coverage.
LGTM

LGTM
Thx

Since @phosek requested changes, this now require his review to see if his concerns are addressed.
@phosek can you please take a look at this patch to see if it addresses your concerns? PowerPC require this patch for our libcxx builds.

In D126122#4100211, @arcivanov wrote:

@lei long time ago. Let me rebase it on main.
I assume after that is committed you'll "cherry-pick" into 16.x via GH issue?

Since Eric mentioned above that he didn't mean to block this patch and he hasn't come back to it, I am going to assume it is okay to land this patch now. I can help to commit this tomorrow if we don't get any blocking comments by then.

@arcivanov are you still waiting for Eric to respond or are you looking for help to commit this patch?

@tstellar PowerPC would need this patch enable to publish a build with libcxx. When does this patch need to land enable to get this into LLVM 16.0?

It would be great if we can get this in 16.

This patch fixes the exact problem I am seeing when building on PowerPC for -DLLVM_ENABLE_RUNTIMES=compiler-rt;libcxx;libcxxabi -DLLVM_ENABLE_LIBCXX:BOOL=ON.
I have applied this patch and tested it on the ppcle rhel/aix/flang/mlir bots and it does not cause any regressions so this LGTM.

Thanks! This LGTM

fix test doc wording

Please note that this patch broke any bots that build this project with -Werror (example: https://lab.llvm.org/buildbot/#/builders/19/builds/14037). As a result, I have reverted it since there has been no fix within a reasonable time.
May I advise ensuring that a project is clean wrt. to the additional warnings when turning on extra warnings as there are bound to be some builds that use -Werror. Also, new warnings are almost always disruptive changes as there are many different build configurations that may be affected in unforeseen ways. If you have such a disruptive change ready to commit, it is advisable to wait until Monday to commit it rather than committing it on a Friday evening as most people are disconnecting.

LGTM
Thx!

LGTM
Thx

LGTM
Thx