Page MenuHomePhabricator
Feed Advanced Search

Tue, Nov 17

jroelofs committed rGa461e76b6f97: [MachineScheduler] Inform pass infra of post-ra scheduler's dependencies (authored by jroelofs).
[MachineScheduler] Inform pass infra of post-ra scheduler's dependencies
Tue, Nov 17, 10:56 AM
jroelofs closed D91561: [MachineScheduler] Inform pass infra of post-ra scheduler's dependencies.
Tue, Nov 17, 10:56 AM · Restricted Project

Mon, Nov 16

jroelofs added a comment to D69814: [Scheduling] Enable AA in PostRA Machine scheduler.

Since this adds a dependency on the AAResultsWrapperPass, shouldn't we be informing the pass manager about it?

diff --git a/llvm/lib/CodeGen/MachineScheduler.cpp b/llvm/lib/CodeGen/MachineScheduler.cpp
index 256628a179ae..950c87ea26f9 100644
--- a/llvm/lib/CodeGen/MachineScheduler.cpp
+++ b/llvm/lib/CodeGen/MachineScheduler.cpp
@@ -240,8 +240,11 @@ char PostMachineScheduler::ID = 0;
 
 char &llvm::PostMachineSchedulerID = PostMachineScheduler::ID;
 
-INITIALIZE_PASS(PostMachineScheduler, "postmisched",
-                "PostRA Machine Instruction Scheduler", false, false)
+INITIALIZE_PASS_BEGIN(PostMachineScheduler, "postmisched",
+                      "PostRA Machine Instruction Scheduler", false, false)
+INITIALIZE_PASS_DEPENDENCY(AAResultsWrapperPass)
+INITIALIZE_PASS_END(PostMachineScheduler, "postmisched",
+                    "PostRA Machine Instruction Scheduler", false, false)
 
 PostMachineScheduler::PostMachineScheduler() : MachineSchedulerBase(ID) {
   initializePostMachineSchedulerPass(*PassRegistry::getPassRegistry());
Mon, Nov 16, 12:36 PM · Restricted Project
jroelofs requested review of D91561: [MachineScheduler] Inform pass infra of post-ra scheduler's dependencies.
Mon, Nov 16, 12:36 PM · Restricted Project
jroelofs accepted D91559: Add sysroot/lib to library search path of baremetal toolchain..
Mon, Nov 16, 12:14 PM · Restricted Project
jroelofs added a comment to D69814: [Scheduling] Enable AA in PostRA Machine scheduler.

Since this adds a dependency on the AAResultsWrapperPass, shouldn't we be informing the pass manager about it?

Mon, Nov 16, 12:05 PM · Restricted Project

Fri, Nov 13

jroelofs accepted D91442: [clang][Driver] Handle risvc in Baremetal.cpp..

Seems reasonable.

Fri, Nov 13, 10:00 AM · Restricted Project
jroelofs added a comment to D13673: Add initial support for the MUSL C library..

More context: https://www.openwall.com/lists/musl/2013/03/29/13

Fri, Nov 13, 8:41 AM
jroelofs added a comment to D13673: Add initial support for the MUSL C library..

@vkalintiris @jroelofs Is it possible to detect Musl through some macro? I'd like to get rid of the CMake option -- this isn't the sort of property that we want to set explicitly at configure time, it's the sort of property we want to sniff out in the library instead.

Fri, Nov 13, 8:37 AM

Oct 5 2020

jroelofs committed rGdb80cc397e7e: [CodeGen][MachineSched] Fixup function name typo. NFC (authored by jroelofs).
[CodeGen][MachineSched] Fixup function name typo. NFC
Oct 5 2020, 12:44 PM

Sep 28 2020

jroelofs committed rG83dc53d30c27: [AArch64] reuse another map iterator. NFC (authored by jroelofs).
[AArch64] reuse another map iterator. NFC
Sep 28 2020, 11:31 AM
jroelofs committed rG37ef2255b642: [AArch64] Reuse map iterator instead of double lookup. NFC (authored by jroelofs).
[AArch64] Reuse map iterator instead of double lookup. NFC
Sep 28 2020, 9:47 AM

Sep 18 2020

jroelofs accepted D86978: [IROutliner] Deduplicating functions that only require inputs..

👍

Sep 18 2020, 10:44 PM · Restricted Project
jroelofs added inline comments to D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs.
Sep 18 2020, 3:48 PM · Restricted Project
jroelofs accepted D87742: [IROutliner] Adding support for swift errors.
Sep 18 2020, 12:09 PM · Restricted Project
jroelofs added inline comments to D86973: [IRSim] Adding wrapper pass for IRSimilarityIdentfier.
Sep 18 2020, 12:01 PM · Restricted Project
jroelofs added a comment to D86978: [IROutliner] Deduplicating functions that only require inputs..

There's quite a few dead variables added in this patch. Do they belong in later patches in the series?

Sep 18 2020, 11:56 AM · Restricted Project
jroelofs added inline comments to D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs.
Sep 18 2020, 10:23 AM · Restricted Project
jroelofs added inline comments to D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs.
Sep 18 2020, 9:47 AM · Restricted Project
jroelofs accepted D86976: [IRSim][IROutliner] Adding InstVisitor to disallow certain operations..

LGTM

Sep 18 2020, 9:33 AM · Restricted Project
jroelofs accepted D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.

LGTM

Sep 18 2020, 9:29 AM · Restricted Project
jroelofs accepted D87296: [IRSim][IROutliner] Adding support for consolidating functions with different output arguments..

LGTM

Sep 18 2020, 9:22 AM · Restricted Project
jroelofs committed rG51c5add8547a: Extending Baremetal toolchain's support for the rtlib option. (authored by jroelofs).
Extending Baremetal toolchain's support for the rtlib option.
Sep 18 2020, 9:20 AM
jroelofs closed D87164: Extending Baremetal toolchain's support for the rtlib option..
Sep 18 2020, 9:19 AM · Restricted Project, Restricted Project
jroelofs accepted D86972: [IRSim] Adding a basic similarity identifier..

small nits, otherwise LGTM

Sep 18 2020, 9:17 AM · Restricted Project
jroelofs added a comment to D86971: [IRSim] Adding structural comparison to IRSimilarityCandidate..

update LGTM too

Sep 18 2020, 9:05 AM · Restricted Project

Sep 17 2020

jroelofs added inline comments to D86973: [IRSim] Adding wrapper pass for IRSimilarityIdentfier.
Sep 17 2020, 1:48 PM · Restricted Project
jroelofs added a comment to D87164: Extending Baremetal toolchain's support for the rtlib option..

btw, do you need me to commit it for you?

Sep 17 2020, 12:57 PM · Restricted Project, Restricted Project
jroelofs committed rGc145a1ca2593: AArch64::ArchKind's underlying type is uint64_t (authored by jroelofs).
AArch64::ArchKind's underlying type is uint64_t
Sep 17 2020, 12:14 PM
jroelofs added inline comments to D86972: [IRSim] Adding a basic similarity identifier..
Sep 17 2020, 11:51 AM · Restricted Project
jroelofs accepted D87164: Extending Baremetal toolchain's support for the rtlib option..

Yeah, this should do what you're after. LGTM

Sep 17 2020, 8:44 AM · Restricted Project, Restricted Project

Sep 16 2020

jroelofs accepted D87294: [IRSim][IROutliner] Adding support for elevating constants that are not the same in each region to arguments.

LGTM

Sep 16 2020, 8:46 AM · Restricted Project
jroelofs accepted D86971: [IRSim] Adding structural comparison to IRSimilarityCandidate..

LGTM, with some optional suggestions.

Sep 16 2020, 8:37 AM · Restricted Project
jroelofs accepted D86970: [IRSim] Adding IRSimilarityCandidate that contains a region of IRInstructionData.

LGTM

Sep 16 2020, 8:19 AM · Restricted Project
jroelofs accepted D87309: [IRSim][IROutliner] Adding option to enable outlining from linkonceodr functions.

LGTM

Sep 16 2020, 8:12 AM · Restricted Project

Sep 15 2020

jroelofs added inline comments to D87294: [IRSim][IROutliner] Adding support for elevating constants that are not the same in each region to arguments.
Sep 15 2020, 4:30 PM · Restricted Project
jroelofs added inline comments to D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..
Sep 15 2020, 4:12 PM · Restricted Project
jroelofs added inline comments to D86968: [IRSim] Adding IR Instruction Mapper.
Sep 15 2020, 2:52 PM · Restricted Project
jroelofs added a comment to D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..

I know almost nothing about how DebugInfo is represented in llvm/dwarf, but is there not a way to represent what this transformation is doing in DI? It's always a little sad when you have to drop it, since doing so makes the debug experience worse.

Sep 15 2020, 12:33 PM · debug-info, Restricted Project
jroelofs added inline comments to D87309: [IRSim][IROutliner] Adding option to enable outlining from linkonceodr functions.
Sep 15 2020, 12:19 PM · Restricted Project
jroelofs added inline comments to D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.
Sep 15 2020, 12:13 PM · Restricted Project
jroelofs accepted D87317: [IRSim][IROutliner] Allowing GEP instructions to be outlined..

LGTM

Sep 15 2020, 10:47 AM · Restricted Project
jroelofs added inline comments to D87296: [IRSim][IROutliner] Adding support for consolidating functions with different output arguments..
Sep 15 2020, 10:44 AM · Restricted Project
jroelofs added inline comments to D87294: [IRSim][IROutliner] Adding support for elevating constants that are not the same in each region to arguments.
Sep 15 2020, 10:24 AM · Restricted Project
jroelofs accepted D87314: [IRSim][IROutliner] Allowing call instructions to be outlined..

LGTM

Sep 15 2020, 10:15 AM · Restricted Project
jroelofs accepted D87312: [IRSim] Letting call instructions be legal for similarity identification..

LGTM

Sep 15 2020, 10:13 AM · Restricted Project
jroelofs added inline comments to D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..
Sep 15 2020, 10:02 AM · Restricted Project
jroelofs accepted D86973: [IRSim] Adding wrapper pass for IRSimilarityIdentfier.

LGTM

Sep 15 2020, 9:45 AM · Restricted Project
jroelofs added inline comments to D86972: [IRSim] Adding a basic similarity identifier..
Sep 15 2020, 9:41 AM · Restricted Project
jroelofs added inline comments to D86971: [IRSim] Adding structural comparison to IRSimilarityCandidate..
Sep 15 2020, 9:34 AM · Restricted Project
jroelofs added inline comments to D86970: [IRSim] Adding IRSimilarityCandidate that contains a region of IRInstructionData.
Sep 15 2020, 9:21 AM · Restricted Project
jroelofs accepted D86969: [IRSim] Adding ilist for IRInstructionData.

LGTM

Sep 15 2020, 9:11 AM · Restricted Project
jroelofs added inline comments to D86968: [IRSim] Adding IR Instruction Mapper.
Sep 15 2020, 9:08 AM · Restricted Project
jroelofs accepted D86974: [IRSim] Adding basic implementation of llvm-sim..

LGTM

Sep 15 2020, 8:35 AM · Restricted Project

Sep 14 2020

jroelofs accepted D87315: [IRSim] Letting gep instructions be legal for similarity identification..

LGTM

Sep 14 2020, 5:21 PM · Restricted Project
jroelofs added inline comments to D87312: [IRSim] Letting call instructions be legal for similarity identification..
Sep 14 2020, 5:15 PM · Restricted Project
jroelofs added inline comments to D87314: [IRSim][IROutliner] Allowing call instructions to be outlined..
Sep 14 2020, 5:06 PM · Restricted Project
jroelofs added inline comments to D86974: [IRSim] Adding basic implementation of llvm-sim..
Sep 14 2020, 4:47 PM · Restricted Project
jroelofs added inline comments to D87296: [IRSim][IROutliner] Adding support for consolidating functions with different output arguments..
Sep 14 2020, 4:09 PM · Restricted Project
jroelofs added a comment to D87164: Extending Baremetal toolchain's support for the rtlib option..

@jroelofs no worries, thanks a lot for your time.

Please tell me if I understood you correctly.

It is acceptable just to append the -lgcc if -rtlib=libgcc is used, although the user is responsible to ensure that correct paths are provided so libgcc is found.

Sep 14 2020, 1:45 PM · Restricted Project, Restricted Project
jroelofs accepted D87300: [IRSim][IROutliner] Adding OptRemarks for the IROutliner..

LGTM

Sep 14 2020, 1:29 PM · Restricted Project
jroelofs accepted D87310: [IRSim] Adding support for isomorphic predicates.

LGTM

Sep 14 2020, 1:26 PM · Restricted Project
jroelofs accepted D87311: [IRSim] Adding commutativity matching to structure checking.

LGTM

Sep 14 2020, 12:54 PM · Restricted Project
jroelofs accepted D87299: [IRSim][IROutliner] Adding a cost model, and debug option to turn the model off..

LGTM

Sep 14 2020, 12:51 PM · Restricted Project

Sep 10 2020

jroelofs added inline comments to D87299: [IRSim][IROutliner] Adding a cost model, and debug option to turn the model off..
Sep 10 2020, 2:55 PM · Restricted Project
jroelofs added inline comments to D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.
Sep 10 2020, 2:48 PM · Restricted Project
jroelofs added inline comments to D87311: [IRSim] Adding commutativity matching to structure checking.
Sep 10 2020, 2:40 PM · Restricted Project
jroelofs added inline comments to D87310: [IRSim] Adding support for isomorphic predicates.
Sep 10 2020, 2:34 PM · Restricted Project
jroelofs added inline comments to D87310: [IRSim] Adding support for isomorphic predicates.
Sep 10 2020, 2:31 PM · Restricted Project
jroelofs added inline comments to D87300: [IRSim][IROutliner] Adding OptRemarks for the IROutliner..
Sep 10 2020, 2:19 PM · Restricted Project

Sep 9 2020

jroelofs added a comment to D87164: Extending Baremetal toolchain's support for the rtlib option..

The Baremetal toolchain currently has a fixed behavior regardless of the -rtlib option's value. It is always linking against compiler-rt unless -nodefaultlibs is enabled.

This proposal slightly changes the code in such a way that enabling -rtlib=libgcc implies linking against -libgcc.

Something that I'm unsure about this patch is that we are not enforcing the existence of such libgcc. By reading other toolchains, I understood that is not always enforced. Do you think this policy is acceptable? If it is not, how would you think it should be addressed?

Sep 9 2020, 12:47 PM · Restricted Project, Restricted Project

Sep 2 2020

jroelofs closed D86797: [early-ifcvt] Add OptRemarks.

b15f2bd3ad4ab614e75ff859b03c3c1eb9f1a9d3

Sep 2 2020, 8:47 AM · Restricted Project

Aug 28 2020

jroelofs committed rGb15f2bd3ad4a: [early-ifcvt] Add OptRemarks (authored by jroelofs).
[early-ifcvt] Add OptRemarks
Aug 28 2020, 2:56 PM
jroelofs added a comment to D63060: [InstCombine] usub.sat(a, b) + b => umax(a, b) (PR42178).

I was *just* thinking about the inverse of this transformation as a way to increase available ILP on CPUs where there are more pipes that can do arithmetic than compares.... cool!

Aug 28 2020, 2:49 PM · Restricted Project
jroelofs updated the diff for D86797: [early-ifcvt] Add OptRemarks.

I'm having trouble getting -stop-before MIR output to trigger these remarks when fed back into llc, so instead I've just relaxed the checks against specific cycle counts to be more forgiving.

Aug 28 2020, 2:27 PM · Restricted Project
jroelofs added a comment to D86797: [early-ifcvt] Add OptRemarks.

This looks great, thanks! Since it's a CodeGen pass, I would suggest using a MIR test instead of an IR one, but I think it's probably easier to read it as it is right now.

Aug 28 2020, 1:34 PM · Restricted Project
jroelofs requested review of D86797: [early-ifcvt] Add OptRemarks.
Aug 28 2020, 10:26 AM · Restricted Project

Aug 20 2020

jroelofs committed rG74ca5275e950: Fix a couple of typos. NFC (authored by jroelofs).
Fix a couple of typos. NFC
Aug 20 2020, 1:57 PM

Aug 3 2020

jroelofs committed rG7f1556f292cc: Fix typo: s/epomymous/eponymous/ NFC (authored by jroelofs).
Fix typo: s/epomymous/eponymous/ NFC
Aug 3 2020, 1:10 PM
jroelofs added a comment to D85004: [libunwind] Make the test depend on the libunwind explicitly..
Aug 3 2020, 8:48 AM · Restricted Project, Restricted Project

Jul 31 2020

jroelofs added a comment to D85004: [libunwind] Make the test depend on the libunwind explicitly..

Isn't it missing DEPENDS cxxabi the same way this was missing DEPENDS unwind?

Jul 31 2020, 11:26 AM · Restricted Project, Restricted Project
jroelofs added a comment to D85004: [libunwind] Make the test depend on the libunwind explicitly..

Mind doing the same thing for libcxxabi? I think it has the same problem.

Jul 31 2020, 9:02 AM · Restricted Project, Restricted Project
jroelofs accepted D85004: [libunwind] Make the test depend on the libunwind explicitly..

LGTM, thank you!

Jul 31 2020, 9:02 AM · Restricted Project, Restricted Project

Jul 30 2020

jroelofs committed rGafae6d97fa55: [SelectionDAG] Fix lowering of vector geps (authored by jroelofs).
[SelectionDAG] Fix lowering of vector geps
Jul 30 2020, 1:57 PM
jroelofs closed D84884: [SelectionDAG] Fix lowering of vector geps.
Jul 30 2020, 1:57 PM · Restricted Project

Jul 29 2020

jroelofs abandoned D23838: Unsuccessful stab at fuzzing for the bug in D23362.
Jul 29 2020, 2:00 PM
jroelofs abandoned D32178: Delete unstable integration tests.
Jul 29 2020, 1:59 PM
jroelofs abandoned D32866: Fix -DLLVM_BUILD_TESTS=ON lldb build.
Jul 29 2020, 1:58 PM
jroelofs abandoned D39146: WIP: fix ldscript AT> parsing.
Jul 29 2020, 1:58 PM
jroelofs requested review of D84884: [SelectionDAG] Fix lowering of vector geps.
Jul 29 2020, 12:18 PM · Restricted Project

Jul 28 2020

jroelofs added inline comments to D73151: [analyzer] Fix handle leak false positive when the handle dies too early.
Jul 28 2020, 4:30 PM · Restricted Project
jroelofs updated subscribers of D73151: [analyzer] Fix handle leak false positive when the handle dies too early.
Jul 28 2020, 4:28 PM · Restricted Project
jroelofs added a comment to rG7bae3188e087: [clang-tidy][NFC] Make OptionsView methods as const where missing.

@njames93 I believe this change broke one of the buildbots (verified by reverting it locally). Mind taking a look? From a quick glance, I can't tell where the functional change is here.

Jul 28 2020, 1:00 PM
jroelofs closed D84686: [OldPM] Print out a bit more when passes lie about changing IR.

736423af53d707e097a174c3a91b75132b8dc6b1

Jul 28 2020, 10:29 AM · Restricted Project
jroelofs committed rG736423af53d7: [OldPM] Print out a bit more when passes lie about changing IR (authored by jroelofs).
[OldPM] Print out a bit more when passes lie about changing IR
Jul 28 2020, 9:01 AM
jroelofs added a reverting change for rGb647d5d21dd8: [lit] Remove --repeat option, which wasn't that useful.: D84760: Revert: "[lit] Remove --repeat option, which wasn't that useful.".
Jul 28 2020, 8:24 AM
jroelofs requested review of D84760: Revert: "[lit] Remove --repeat option, which wasn't that useful.".
Jul 28 2020, 8:24 AM · Restricted Project

Jul 27 2020

jroelofs committed rG6dadf7cb654c: [llvm][examples][SimplifyCFG] Fix pass's IR changed reporting (authored by jroelofs).
[llvm][examples][SimplifyCFG] Fix pass's IR changed reporting
Jul 27 2020, 12:40 PM
Herald added a project to D84686: [OldPM] Print out a bit more when passes lie about changing IR: Restricted Project.
Jul 27 2020, 11:37 AM · Restricted Project
jroelofs added a comment to D84327: [SCEVExpander] Add helper to clean up instrs inserted while expanding..

LG to me, but probably wait a bit for @jroelofs.

Jul 27 2020, 10:15 AM · Restricted Project