Page MenuHomePhabricator
Feed Advanced Search

Fri, May 22

jroelofs created D80436: [clang][docs] Document additional bits of libc that -ffreestanding envs must provide.
Fri, May 22, 6:23 AM · Restricted Project
jroelofs added a comment to D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

I saw the benefit initially when the proposal was made, but now seeing the consequence in practice in the tools tests at least makes me realise I'm not a fan of the change to make FileCheck error if it sees the string somewhere else in the line. In particular, GNU and LLVM are common prefixes used to distinguish checks for different output modes, but also will often appear in comments to explain the test cases. Similar comments apply to the machine names etc. Needing to add COM is unobvious, and makes the comments messier to read, I found, as soon as I started reading.

Let’s not lose sight of the fact that this whole change is a trade off: we are attempting to trade comment succinctness/obviousness for the ability to diagnose a particularly nasty failure mode of missing colons. This comment thing may not be the right tradeoff, but given how constrained the problem space is, I suspect we will end up sacrificing a bit of intuitiveness somewhere regardless. So long as these new diagnosed-but-unintuitive cases aren’t too frequent/annoying, IMO that’s a better place to be than having room for the other not-diagnosable-and-unintuitive failure mode.

Fri, May 22, 5:51 AM · Restricted Project
jroelofs added a comment to D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

Why was this landed? There was varying degrees of dislike from more than one reviewer (myself, and @MaskRay at least). Please revert pending a conclusion to the discussion. This has hardly reached consensus.

Fri, May 22, 5:18 AM · Restricted Project
jroelofs committed rG5a8db275f8fc: Revert "[llvm][test] Add COM: directives before colon-less non-CHECKs in… (authored by jroelofs).
Revert "[llvm][test] Add COM: directives before colon-less non-CHECKs in…
Fri, May 22, 4:45 AM
jroelofs added a reverting change for rG183d6af08189: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC: rG5a8db275f8fc: Revert "[llvm][test] Add COM: directives before colon-less non-CHECKs in….
Fri, May 22, 4:45 AM

Thu, May 21

jroelofs committed rG5fb979dd0697: [llvm][test] Add missing FileCheck colons. NFC (authored by jroelofs).
[llvm][test] Add missing FileCheck colons. NFC
Thu, May 21, 8:36 AM
jroelofs committed rG183d6af08189: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC (authored by jroelofs).
[llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC
Thu, May 21, 8:36 AM
jroelofs closed D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

183d6af081899973f00fc24aeafcfc32de732f02

Thu, May 21, 8:36 AM · Restricted Project

Wed, May 20

jroelofs added a comment to D77354: [DO NOT MERGE] added FileCheck colons that broke things.

@atanasyan there's one more case of this in llvm/test/CodeGen/Mips/ci2.ll. Looks like the constant has been de-duplicated since that test was written. Mind checking whether that's correct behavior for your target? (it does seem better, but I don't want to assume).

Wed, May 20, 1:11 PM · Restricted Project

Fri, May 15

jroelofs added a comment to D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

The first patch seemed fine and pretty useful. I'm not certain that this is a particularly fun idea as far as having to redo all comments etc.

Fri, May 15, 6:29 PM · Restricted Project
jroelofs added a comment to D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

I saw the benefit initially when the proposal was made, but now seeing the consequence in practice in the tools tests at least makes me realise I'm not a fan of the change to make FileCheck error if it sees the string somewhere else in the line. In particular, GNU and LLVM are common prefixes used to distinguish checks for different output modes, but also will often appear in comments to explain the test cases. Similar comments apply to the machine names etc. Needing to add COM is unobvious, and makes the comments messier to read, I found, as soon as I started reading.

Fri, May 15, 8:07 AM · Restricted Project
jroelofs updated the diff for D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

Implement review feedback

Fri, May 15, 8:06 AM · Restricted Project

Thu, May 14

jroelofs added a comment to D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.

This looks like a move in the right direction to me, but I'm biased.

Thu, May 14, 4:53 PM · Restricted Project
jroelofs added inline comments to D77789: [llvm-dwarfdump][Stats] Clean up.
Thu, May 14, 2:08 PM · Restricted Project, debug-info
jroelofs created D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC.
Thu, May 14, 2:08 PM · Restricted Project

Sat, Apr 25

jroelofs committed rG42bf0756d426: [docs] Fix :option: links (authored by jroelofs).
[docs] Fix :option: links
Sat, Apr 25, 3:24 PM
jroelofs added inline comments to D78656: [MLIR] Add a tests for out of tree dialect example..
Sat, Apr 25, 3:23 PM · Restricted Project

Apr 22 2020

jroelofs committed rGdc5c1fa88279: [docs] Fix :option: links (authored by jroelofs).
[docs] Fix :option: links
Apr 22 2020, 1:04 PM
jroelofs committed rGb3f168274d8f: [docs] Document lit's --timeout=N flag (authored by jroelofs).
[docs] Document lit's --timeout=N flag
Apr 22 2020, 11:58 AM

Apr 15 2020

jroelofs committed rG6c9d52885dea: Add FileCheck colons missed in D76210 (authored by jroelofs).
Add FileCheck colons missed in D76210
Apr 15 2020, 11:32 AM
jroelofs added inline comments to D76210: [Attributor] AAReachability : use isPotentiallyReachable in isKnownReachable.
Apr 15 2020, 11:30 AM · Restricted Project

Apr 14 2020

jroelofs committed rG38b39c34ab0c: [clang] Add missing FileCheck colons (authored by jroelofs).
[clang] Add missing FileCheck colons
Apr 14 2020, 11:51 AM

Apr 13 2020

jroelofs committed rG0b0bb1969fa0: [llvm] Fix yet more missing FileCheck colons (authored by jroelofs).
[llvm] Fix yet more missing FileCheck colons
Apr 13 2020, 10:12 AM
jroelofs committed rG17bc995388f4: [llvm] Fix more missing FileCheck directive colons (authored by jroelofs).
[llvm] Fix more missing FileCheck directive colons
Apr 13 2020, 9:40 AM
jroelofs committed rG8c0f1cf98d80: [llvm] Fix another missing FileCheck colon (authored by jroelofs).
[llvm] Fix another missing FileCheck colon
Apr 13 2020, 9:40 AM
jroelofs added inline comments to D76210: [Attributor] AAReachability : use isPotentiallyReachable in isKnownReachable.
Apr 13 2020, 9:39 AM · Restricted Project

Apr 12 2020

jroelofs committed rG41f13f1f64d2: reland: [DAG] Fix PR45049: LegalizeTypes crash (authored by jroelofs).
reland: [DAG] Fix PR45049: LegalizeTypes crash
Apr 12 2020, 9:05 AM
jroelofs closed D76994: [DAG] Fix PR45049: LegalizeTypes crash.

re-landed in 41f13f1f64d2074ae7512fb23656c22585e912bd

Apr 12 2020, 9:04 AM · Restricted Project

Apr 11 2020

jroelofs committed rG0dbaafaa3a6a: [mlir][docs] Explain the EDSC acronym. NFC (authored by jroelofs).
[mlir][docs] Explain the EDSC acronym. NFC
Apr 11 2020, 8:31 AM
jroelofs committed rG015ebd2930bd: [mlir][toy] Fix comment typo. NFC (authored by jroelofs).
[mlir][toy] Fix comment typo. NFC
Apr 11 2020, 8:31 AM
jroelofs committed rG2f7707db0255: [mlir][toy][docs] Reword for better sentence flow. NFC (authored by jroelofs).
[mlir][toy][docs] Reword for better sentence flow. NFC
Apr 11 2020, 8:31 AM
jroelofs committed rG3737be8902b2: [mlir][toy][docs] Fix reference to generated ToyCombine.inc. NFC (authored by jroelofs).
[mlir][toy][docs] Fix reference to generated ToyCombine.inc. NFC
Apr 11 2020, 8:31 AM
jroelofs closed D77921: [mlir][toy][docs] Reword for better sentence flow. NFC.

2f7707db025547737314f60f937d885629b13bc5

Apr 11 2020, 8:31 AM · Restricted Project
jroelofs closed D77916: [mlir][toy][docs] Fix reference to generated ToyCombine.inc. NFC.

3737be8902b2c9174f253dfab6da0bb051ee259f

Apr 11 2020, 8:31 AM · Restricted Project
jroelofs closed D77917: [mlir][toy] Fix comment typo. NFC.

(Feel free to skip pre-commit review for this)

Apr 11 2020, 8:31 AM · Restricted Project
jroelofs updated the diff for D77914: [mlir][docs] Explain the EDSC acronym. NFC.

Move LLVM Lexicon entry out to MLIR Glossary

Apr 11 2020, 8:31 AM · Restricted Project
jroelofs closed D77914: [mlir][docs] Explain the EDSC acronym. NFC.

0dbaafaa3a6ac81b1e117972ecda7cbb7424039e

Apr 11 2020, 8:31 AM · Restricted Project
jroelofs added inline comments to D77914: [mlir][docs] Explain the EDSC acronym. NFC.
Apr 11 2020, 8:31 AM · Restricted Project

Apr 10 2020

jroelofs added a comment to D76994: [DAG] Fix PR45049: LegalizeTypes crash.

@bjope are you happy with me re-landing this with that new assert dropped? Looks like that case is properly covered earlier in PerformExpensiveChecks() anyway.

Apr 10 2020, 4:42 PM · Restricted Project
jroelofs updated the diff for D77914: [mlir][docs] Explain the EDSC acronym. NFC.

s/Compiler/Constructs/

Apr 10 2020, 4:41 PM · Restricted Project
jroelofs created D77921: [mlir][toy][docs] Reword for better sentence flow. NFC.
Apr 10 2020, 4:09 PM · Restricted Project
jroelofs added a reviewer for D77914: [mlir][docs] Explain the EDSC acronym. NFC: rriddle.
Apr 10 2020, 4:09 PM · Restricted Project
jroelofs updated the diff for D77914: [mlir][docs] Explain the EDSC acronym. NFC.

(sorry for the noise, I'm learning how to use arcanist)

Apr 10 2020, 4:09 PM · Restricted Project
jroelofs created D77917: [mlir][toy] Fix comment typo. NFC.
Apr 10 2020, 4:09 PM · Restricted Project
jroelofs created D77916: [mlir][toy][docs] Fix reference to generated ToyCombine.inc. NFC.
Apr 10 2020, 4:09 PM · Restricted Project
jroelofs updated the diff for D77914: [mlir][docs] Explain the EDSC acronym. NFC.

re-submitting

Apr 10 2020, 4:09 PM · Restricted Project
jroelofs abandoned D77914: [mlir][docs] Explain the EDSC acronym. NFC.

Arc didn't do what I wanted here. I'll re-submit.

Apr 10 2020, 4:09 PM · Restricted Project
jroelofs created D77914: [mlir][docs] Explain the EDSC acronym. NFC.
Apr 10 2020, 4:09 PM · Restricted Project
jroelofs updated the diff for D77354: [DO NOT MERGE] added FileCheck colons that broke things.

Thanks for all the fixes everyone!

Apr 10 2020, 10:56 AM · Restricted Project

Apr 8 2020

jroelofs accepted D77764: [mlir] Mark ClassID::getID as LLVM_EXTERNAL_VISIBILITY to ensure only one version exists.

LGTM

Apr 8 2020, 5:24 PM · Restricted Project
jroelofs committed rG223154d267e2: [mlir] Remove need for static global ctors from mlir-translate (authored by jroelofs).
[mlir] Remove need for static global ctors from mlir-translate
Apr 8 2020, 4:20 PM
jroelofs closed D77515: [mlir] Remove need for static global ctors from mlir-translate.

223154d267e2e935d1bbcba77fe222c8ef96e789

Apr 8 2020, 4:18 PM · Restricted Project
jroelofs added a comment to D77515: [mlir] Remove need for static global ctors from mlir-translate.

I tried this out with BUILD_SHARED_LIBS=ON, and unfortunately ran into a problem with the way this custom rtti behaves

Apr 8 2020, 4:18 PM · Restricted Project

Apr 7 2020

jroelofs updated the diff for D77515: [mlir] Remove need for static global ctors from mlir-translate.

test update: trying out arcanist

Apr 7 2020, 8:39 AM · Restricted Project
jroelofs updated the diff for D77515: [mlir] Remove need for static global ctors from mlir-translate.

review feedback: drop semicolon

Apr 7 2020, 8:39 AM · Restricted Project

Apr 6 2020

jroelofs reopened D76994: [DAG] Fix PR45049: LegalizeTypes crash.
Apr 6 2020, 4:54 PM · Restricted Project
jroelofs updated the diff for D76994: [DAG] Fix PR45049: LegalizeTypes crash.

Reverted this in 3ce77142a6452d76d6f97c9a6c2da193e78841ba because one of the new assertions failed in the expensive-checks bots: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-debian/builds/4971/steps/test-check-all/logs/FAIL%3A%20LLVM%3A%3A2008-12-02-IllegalResultType.ll

Apr 6 2020, 3:49 PM · Restricted Project
jroelofs added a comment to D77515: [mlir] Remove need for static global ctors from mlir-translate.

I tried this out with BUILD_SHARED_LIBS=ON, and unfortunately ran into a problem with the way this custom rtti behaves across dso's:

Apr 6 2020, 2:10 PM · Restricted Project
jroelofs updated the diff for D77515: [mlir] Remove need for static global ctors from mlir-translate.

rebased on top of 4faf05e5a3fcef2b2515270c35fe7692f57c55ca

Apr 6 2020, 1:37 PM · Restricted Project
jroelofs committed rG4faf05e5a3fc: [llvm-objdump] Fix case of -Wmismatched-tags (authored by jroelofs).
[llvm-objdump] Fix case of -Wmismatched-tags
Apr 6 2020, 9:13 AM
jroelofs committed rG7c5d2bec7625: [llvm] Fix missing FileCheck directive colons (authored by jroelofs).
[llvm] Fix missing FileCheck directive colons
Apr 6 2020, 9:13 AM
jroelofs closed D77352: [llvm] Fix missing FileCheck directive colons.
Apr 6 2020, 9:11 AM · Restricted Project
jroelofs added a comment to D77352: [llvm] Fix missing FileCheck directive colons.

7c5d2bec762550d305018de4292470c12015ecb5

Apr 6 2020, 9:11 AM · Restricted Project
jroelofs added a comment to D77352: [llvm] Fix missing FileCheck directive colons.

I'm not sure if it was intended, but the addition of colons in the original version of the patch to llvm/test/Transforms/LoopStrengthReduce/X86/lsr-insns-2.ll seem to have disappeared in the rebase. Otherwise, looks good to me.

Apr 6 2020, 8:06 AM · Restricted Project

Apr 5 2020

jroelofs added inline comments to D77515: [mlir] Remove need for static global ctors from mlir-translate.
Apr 5 2020, 2:57 PM · Restricted Project
jroelofs added inline comments to D77515: [mlir] Remove need for static global ctors from mlir-translate.
Apr 5 2020, 2:57 PM · Restricted Project
jroelofs updated the diff for D77515: [mlir] Remove need for static global ctors from mlir-translate.

clang-format

Apr 5 2020, 2:25 PM · Restricted Project
jroelofs created D77515: [mlir] Remove need for static global ctors from mlir-translate.
Apr 5 2020, 1:55 PM · Restricted Project
jroelofs abandoned D77504: [mlir][toy] hasOperand() const correctness.

Did you it a case where this is useful/needed? See also: https://mlir.llvm.org/docs/UsageOfConst/

Apr 5 2020, 10:40 AM · Restricted Project
jroelofs created D77504: [mlir][toy] hasOperand() const correctness.
Apr 5 2020, 10:08 AM · Restricted Project

Apr 4 2020

jroelofs committed rG3ce77142a645: Revert "[DAG] Fix PR45049: LegalizeTypes crash" (authored by jroelofs).
Revert "[DAG] Fix PR45049: LegalizeTypes crash"
Apr 4 2020, 1:18 PM
jroelofs added a reverting change for rG17673ae0b2cb: [DAG] Fix PR45049: LegalizeTypes crash: rG3ce77142a645: Revert "[DAG] Fix PR45049: LegalizeTypes crash".
Apr 4 2020, 1:18 PM
jroelofs accepted D77466: libcxx 'LLVM_USE_SANITIZER=Address;Undefined'.

LGTM

Apr 4 2020, 1:17 PM · Restricted Project
jroelofs committed rG17673ae0b2cb: [DAG] Fix PR45049: LegalizeTypes crash (authored by jroelofs).
[DAG] Fix PR45049: LegalizeTypes crash
Apr 4 2020, 12:46 PM
jroelofs closed D76994: [DAG] Fix PR45049: LegalizeTypes crash.

https://github.com/llvm/llvm-project/commit/17673ae0b2cbf8d48973b673d413fb8591d8aae7

Apr 4 2020, 12:45 PM · Restricted Project
jroelofs added inline comments to D76994: [DAG] Fix PR45049: LegalizeTypes crash.
Apr 4 2020, 9:32 AM · Restricted Project
jroelofs updated the diff for D76994: [DAG] Fix PR45049: LegalizeTypes crash.

Fix NDEBUG build.

Apr 4 2020, 9:32 AM · Restricted Project
jroelofs updated the diff for D77352: [llvm] Fix missing FileCheck directive colons.

Rebased

Apr 4 2020, 9:00 AM · Restricted Project
jroelofs updated the diff for D77354: [DO NOT MERGE] added FileCheck colons that broke things.

Rebased

Apr 4 2020, 9:00 AM · Restricted Project

Apr 3 2020

jroelofs added a comment to D77227: [RFC][FileCheck] Require colon immediately after CHECK directives.

But there's a deeper point here, the debate should take place on llvm-dev and not in a review.

Good point. I'll try to summarize our observations / hypotheses so far & start a thread there.

Apr 3 2020, 10:15 AM · Restricted Project
jroelofs added a comment to D77227: [RFC][FileCheck] Require colon immediately after CHECK directives.

Chiming in late, as I only just saw this discussion. I'll be honest, I don't fully follow the explanations. Would it be possible to write up the policy in FileCheck's documentation somewhere?

After we figure out what it should be. :-) But there's a deeper point here, the debate should take place on llvm-dev and not in a review.

Apr 3 2020, 8:35 AM · Restricted Project
jroelofs added a comment to D77354: [DO NOT MERGE] added FileCheck colons that broke things.

I have fixed some of the obvious mistakes in CodeGen/AMDGPU.

Apr 3 2020, 8:02 AM · Restricted Project
jroelofs added a comment to D77352: [llvm] Fix missing FileCheck directive colons.

I suppose I should have separated out the trivial ones from these that took a bit more reasoning to confirm.

Apr 3 2020, 8:02 AM · Restricted Project

Apr 2 2020

jroelofs added a child revision for D77354: [DO NOT MERGE] added FileCheck colons that broke things: D77227: [RFC][FileCheck] Require colon immediately after CHECK directives.
Apr 2 2020, 5:54 PM · Restricted Project
jroelofs added a parent revision for D77227: [RFC][FileCheck] Require colon immediately after CHECK directives: D77354: [DO NOT MERGE] added FileCheck colons that broke things.
Apr 2 2020, 5:54 PM · Restricted Project
jroelofs created D77354: [DO NOT MERGE] added FileCheck colons that broke things.
Apr 2 2020, 5:54 PM · Restricted Project
jroelofs added a parent revision for D77227: [RFC][FileCheck] Require colon immediately after CHECK directives: D77352: [llvm] Fix missing FileCheck directive colons.
Apr 2 2020, 5:54 PM · Restricted Project
jroelofs added a child revision for D77352: [llvm] Fix missing FileCheck directive colons: D77227: [RFC][FileCheck] Require colon immediately after CHECK directives.
Apr 2 2020, 5:54 PM · Restricted Project
jroelofs created D77352: [llvm] Fix missing FileCheck directive colons.
Apr 2 2020, 5:54 PM · Restricted Project
jroelofs added a comment to D77227: [RFC][FileCheck] Require colon immediately after CHECK directives.

The diagnostic in this patch triggers 186 times in the suite of 36125 tests in llvm/test. Most of them are true positives, though there are ~45 false-positives that seem easy to work around by rewording the comments:

So 1/4 of positives are false positives? Am I reading those numbers correctly?

Yes, that's correct.

Apr 2 2020, 3:11 PM · Restricted Project
jroelofs added a comment to D77227: [RFC][FileCheck] Require colon immediately after CHECK directives.

Here's an example that justifies all of this for me:

Apr 2 2020, 2:06 PM · Restricted Project
jroelofs added a comment to D77227: [RFC][FileCheck] Require colon immediately after CHECK directives.

The diagnostic in this patch triggers 186 times in the suite of 36125 tests in llvm/test. Most of them are true positives, though there are ~45 false-positives that seem easy to work around by rewording the comments:

So 1/4 of positives are false positives? Am I reading those numbers correctly?

Apr 2 2020, 2:06 PM · Restricted Project
jroelofs updated the diff for D77227: [RFC][FileCheck] Require colon immediately after CHECK directives.

Draft of paulr/jdenny's fuzzy-comment-prefix filter idea.

Apr 2 2020, 11:55 AM · Restricted Project

Apr 1 2020

jroelofs added a comment to D77227: [RFC][FileCheck] Require colon immediately after CHECK directives.

but is also missing the colon?

That still bugs me because prefixes mentioned in English sentences in comments can easily wrap to the start of a comment line.

Apr 1 2020, 3:45 PM · Restricted Project
jroelofs added a comment to D77227: [RFC][FileCheck] Require colon immediately after CHECK directives.

Okay, 1500+ tests to fix seems excessive. Requiring CHECK directives to be on lines by themselves (with optional comment) is more restrictive than the LLVM test suite can tolerate.

Maybe the right rule should be that it *either* appears on a line by itself *or* at the beginning of some single-line comment style (which might not be at the beginning of a line).

Apr 1 2020, 3:12 PM · Restricted Project
jroelofs added a comment to D77227: [RFC][FileCheck] Require colon immediately after CHECK directives.

Maybe FileCheck should say, that's where directives *have* to be. Are there real tests where that would be a problem?

Apr 1 2020, 12:22 PM · Restricted Project
jroelofs added a comment to D77227: [RFC][FileCheck] Require colon immediately after CHECK directives.

Thanks for working on this.

CHECK           gotcha 1

This case seems like it would trigger too many false positives. Do you have numbers on how many true positives that this case alone catches and that are not caught by the other cases?

Apr 1 2020, 12:04 PM · Restricted Project
jroelofs committed rG1148f004fa35: Fix PR45371: SeparateConstOffsetFromGEP clean up bookkeeping (authored by jroelofs).
Fix PR45371: SeparateConstOffsetFromGEP clean up bookkeeping
Apr 1 2020, 11:49 AM
jroelofs closed D77160: Fix PR45371: SeparateConstOffsetFromGEP clean up bookkeeping.

https://github.com/llvm/llvm-project/commit/1148f004fa35f1b74942bb1f578763d9dd79aa4a

Apr 1 2020, 11:49 AM · Restricted Project
jroelofs abandoned D40734: New users should be using the runtimes dir, not projects.
Apr 1 2020, 10:41 AM