Page MenuHomePhabricator
Feed Advanced Search

Today

bondhugula added inline comments to D76974: [Attributor] Make attributor aware of aligned_alloc for heap to stack conversion.
Tue, Mar 31, 12:33 PM · Restricted Project
bondhugula added inline comments to D76974: [Attributor] Make attributor aware of aligned_alloc for heap to stack conversion.
Tue, Mar 31, 11:58 AM · Restricted Project
bondhugula committed rG5f9bf3f65614: [MLIR][NFC] Move test/Transforms/lower-affine.mlir -> test/Conversion (authored by bondhugula).
[MLIR][NFC] Move test/Transforms/lower-affine.mlir -> test/Conversion
Tue, Mar 31, 11:28 AM
bondhugula closed D77008: [MLIR][NFC] Move test/Transforms/lower-affine.mlir -> test/Conversion.
Tue, Mar 31, 11:28 AM · Restricted Project
bondhugula added inline comments to D77008: [MLIR][NFC] Move test/Transforms/lower-affine.mlir -> test/Conversion.
Tue, Mar 31, 11:26 AM · Restricted Project
bondhugula updated the diff for D77008: [MLIR][NFC] Move test/Transforms/lower-affine.mlir -> test/Conversion.

Address review comment

Tue, Mar 31, 11:26 AM · Restricted Project
bondhugula committed rGdc817b2dea9f: [InstCombine] Deduce attributes for aligned_alloc in InstCombine (authored by bondhugula).
[InstCombine] Deduce attributes for aligned_alloc in InstCombine
Tue, Mar 31, 10:53 AM
bondhugula committed rG7fca0e9797dc: [MLIR] Add simple runner utilities for timing (authored by bondhugula).
[MLIR] Add simple runner utilities for timing
Tue, Mar 31, 10:53 AM
bondhugula closed D76971: [InstCombine] Deduce attributes for aligned_alloc in InstCombine.
Tue, Mar 31, 10:53 AM · Restricted Project
bondhugula closed D76912: [MLIR] Add simple runner utilities for timing.
Tue, Mar 31, 10:53 AM · Restricted Project
bondhugula added a comment to D76974: [Attributor] Make attributor aware of aligned_alloc for heap to stack conversion.

Ping reviewers - @jdoerfert - thanks!

Tue, Mar 31, 10:52 AM · Restricted Project
bondhugula retitled D76976: [NewGVN] Make NewGVN aware of aligned_alloc from Make NewGVN aware of aligned_alloc to [NewGVN] Make NewGVN aware of aligned_alloc.
Tue, Mar 31, 10:52 AM · Restricted Project
bondhugula retitled D76971: [InstCombine] Deduce attributes for aligned_alloc in InstCombine from Deduce attributes for aligned_alloc in InstCombine to [InstCombine] Deduce attributes for aligned_alloc in InstCombine.
Tue, Mar 31, 10:52 AM · Restricted Project
bondhugula retitled D76974: [Attributor] Make attributor aware of aligned_alloc for heap to stack conversion from Make attributor aware of aligned_alloc for heap to stack conversion to [Attributor] Make attributor aware of aligned_alloc for heap to stack conversion.
Tue, Mar 31, 10:52 AM · Restricted Project
bondhugula retitled D76975: [GVN] Make GVN aware of aligned_alloc from Make GVN aware of aligned_alloc to [GVN] Make GVN aware of aligned_alloc.
Tue, Mar 31, 10:52 AM · Restricted Project
bondhugula requested changes to D77128: [MLIR] Implement LoopLikeInterface for loop.parallel.
Tue, Mar 31, 3:18 AM · Restricted Project
bondhugula added inline comments to D77128: [MLIR] Implement LoopLikeInterface for loop.parallel.
Tue, Mar 31, 3:18 AM · Restricted Project
bondhugula accepted D77126: Add a method to build affine maps with zero or more results..

Thanks for fixing this. In fact, I had review comments along the lines you address on an earlier patch that introduced these but looks like they didn't get in. (For consistency, we do need the ability to create 0 result maps that have an arbitrary number of dimensions and symbols, which your patch addresses.)

Tue, Mar 31, 3:18 AM · Restricted Project
bondhugula added a comment to D76912: [MLIR] Add simple runner utilities for timing.

Thanks for the review.

Tue, Mar 31, 2:42 AM · Restricted Project
bondhugula updated the diff for D71961: [MLIR] Free ReturnOp from being restricted to a FuncOp.

Update op documentation.

Tue, Mar 31, 1:37 AM · Restricted Project
bondhugula added a comment to D71961: [MLIR] Free ReturnOp from being restricted to a FuncOp.

FYI I still believe that a good first step her would be to use something like the FunctionLike trait to constraint the parent of the return op.

Tue, Mar 31, 1:37 AM · Restricted Project
bondhugula removed a reviewer for D76637: [mlir][Linalg] Allow tiling of batch dimension for convolution ops with padding.: bondhugula.

@bondhugula : Gentle ping on this patch. I think it is ready to land now. PTAL.

Tue, Mar 31, 12:30 AM · Restricted Project

Yesterday

bondhugula added a comment to D76975: [GVN] Make GVN aware of aligned_alloc.

Prefix patch with [GVN] please.

OK.

Mon, Mar 30, 4:57 PM · Restricted Project
bondhugula added inline comments to D77004: [MLIR] Fix permuteLoops utility.
Mon, Mar 30, 3:17 PM · Restricted Project
bondhugula updated the diff for D72223: [MLIR] Introduce affine graybox op.

changes after rebase - unregistered ops

Mon, Mar 30, 2:44 PM · Restricted Project
bondhugula updated the diff for D72223: [MLIR] Introduce affine graybox op.

Rebase.

Mon, Mar 30, 2:44 PM · Restricted Project
bondhugula added a comment to D76912: [MLIR] Add simple runner utilities for timing.

Ping reviewers @herhut @ftynse - thanks.

Mon, Mar 30, 2:44 PM · Restricted Project
bondhugula added inline comments to D77083: [MLIR] Add pattern rewriter util to erase block; add affine.if pattern to remove dead else blocks.
Mon, Mar 30, 2:11 PM · Restricted Project
bondhugula updated the diff for D77083: [MLIR] Add pattern rewriter util to erase block; add affine.if pattern to remove dead else blocks.

fix eraseBlock iteration order

Mon, Mar 30, 1:37 PM · Restricted Project
bondhugula added inline comments to D77083: [MLIR] Add pattern rewriter util to erase block; add affine.if pattern to remove dead else blocks.
Mon, Mar 30, 1:37 PM · Restricted Project
bondhugula updated the diff for D77083: [MLIR] Add pattern rewriter util to erase block; add affine.if pattern to remove dead else blocks.

Address review comments.

Mon, Mar 30, 1:37 PM · Restricted Project
bondhugula added inline comments to D77083: [MLIR] Add pattern rewriter util to erase block; add affine.if pattern to remove dead else blocks.
Mon, Mar 30, 1:37 PM · Restricted Project
bondhugula retitled D77083: [MLIR] Add pattern rewriter util to erase block; add affine.if pattern to remove dead else blocks from [MLIR] Add pattern rewriter util to erase block; remove dead else to [MLIR] Add pattern rewriter util to erase block; add affine.if pattern to remove dead else blocks.
Mon, Mar 30, 1:04 PM · Restricted Project
bondhugula created D77083: [MLIR] Add pattern rewriter util to erase block; add affine.if pattern to remove dead else blocks.
Mon, Mar 30, 1:04 PM · Restricted Project
bondhugula updated the diff for D76971: [InstCombine] Deduce attributes for aligned_alloc in InstCombine.

More test cases.

Mon, Mar 30, 12:30 PM · Restricted Project
bondhugula added inline comments to D76971: [InstCombine] Deduce attributes for aligned_alloc in InstCombine.
Mon, Mar 30, 12:30 PM · Restricted Project
bondhugula committed rGf273e5c50745: [MLIR] Fix permuteLoops utility (authored by bondhugula).
[MLIR] Fix permuteLoops utility
Mon, Mar 30, 11:25 AM
bondhugula closed D77004: [MLIR] Fix permuteLoops utility.
Mon, Mar 30, 11:24 AM · Restricted Project
bondhugula updated the diff for D77004: [MLIR] Fix permuteLoops utility.

Address review comment - add comment.

Mon, Mar 30, 11:24 AM · Restricted Project
bondhugula updated the diff for D76971: [InstCombine] Deduce attributes for aligned_alloc in InstCombine.

add attribute only if the alignment is a power of two

Mon, Mar 30, 11:24 AM · Restricted Project
bondhugula added a comment to D76971: [InstCombine] Deduce attributes for aligned_alloc in InstCombine.

Thanks for the review, @jdoerfert Done.

Mon, Mar 30, 10:49 AM · Restricted Project
bondhugula updated the diff for D76971: [InstCombine] Deduce attributes for aligned_alloc in InstCombine.

Address review comments; add alignment attribute to aligned_alloc sites

Mon, Mar 30, 10:49 AM · Restricted Project
bondhugula accepted D77052: [MLIR] Rename collapsePLoops -> collapseParallelLoops.
Mon, Mar 30, 9:43 AM · Restricted Project
bondhugula added inline comments to D76971: [InstCombine] Deduce attributes for aligned_alloc in InstCombine.
Mon, Mar 30, 9:10 AM · Restricted Project

Sun, Mar 29

bondhugula added a comment to D76734: [mlir][NFC] Update dialect/op documentation to be consistent.

Thanks very much for fixing all these!

Sun, Mar 29, 11:57 PM · Restricted Project
bondhugula abandoned D71521: Introduce support for lib function aligned_alloc.

This has been split into five patches ending with D76976.

Sun, Mar 29, 10:29 PM · Restricted Project
bondhugula added inline comments to D76903: Add a flag on the context to protect against creation of operations in unregistered dialects.
Sun, Mar 29, 4:36 PM · Restricted Project
bondhugula added a comment to D76903: Add a flag on the context to protect against creation of operations in unregistered dialects.

The commit summary opening "By default, the verifier won't allow operations with unregistered dialect. " reads as if this was the situation before.

I used the future tense here to indicate the change.

Besides "operations with unregistered dialect", what about unregistered operations, i.e., operations that aren't part of any registered dialect?

To me “operations with unregistered dialect” is the same as “ operations that aren't part of any registered dialect”.

But the two are clearly different. There could be an operation that is part of a dialect that is not registered, and you then could have operations that aren't part of any dialect like "foo"() : () -> () -- the latter isn't part of say any dialect.

OK I see what you mean, I'll write “operations that aren't part of any registered dialect” which covers both f.oo which if part of the unregistered dialect f and foo which is not part of any dialect. The verifier is covering both here.

(I don't even know why we allow such operation name in the first place to be honest, other than saving a few chars when writing tests there isn't much interest)

This is wrong. Operations are always part of a dialect. "foo" would be considered to be part of the builtin dialect, which currently has no namespace. IMO we should set the namespace of the builtin dialect to "mlir" and the assert that operation names
always have a dialect prefix.

Sun, Mar 29, 4:36 PM · Restricted Project
bondhugula added a comment to D76903: Add a flag on the context to protect against creation of operations in unregistered dialects.

The commit summary opening "By default, the verifier won't allow operations with unregistered dialect. " reads as if this was the situation before.

I used the future tense here to indicate the change.

Besides "operations with unregistered dialect", what about unregistered operations, i.e., operations that aren't part of any registered dialect?

To me “operations with unregistered dialect” is the same as “ operations that aren't part of any registered dialect”.

Sun, Mar 29, 3:00 PM · Restricted Project
bondhugula added inline comments to D76903: Add a flag on the context to protect against creation of operations in unregistered dialects.
Sun, Mar 29, 3:00 PM · Restricted Project
bondhugula requested changes to D76903: Add a flag on the context to protect against creation of operations in unregistered dialects.

The commit summary opening "By default, the verifier won't allow operations with unregistered dialect. " reads as if this was the situation before. Consider rephrasing please. "Change the verifier to disallow ..."? Besides "operations with unregistered dialect", what about unregistered operations, i.e., operations that aren't part of any registered dialect? It looks like you are equating the two, and did you mean to use the latter for this patch?

Sun, Mar 29, 1:23 PM · Restricted Project
bondhugula committed rG4e4ea2cde44d: [MLIR] Add missing asserts in interchangeLoops util, doc comment update (authored by bondhugula).
[MLIR] Add missing asserts in interchangeLoops util, doc comment update
Sun, Mar 29, 11:46 AM
bondhugula closed D77003: [MLIR] Add missing asserts in interchangeLoops util, doc comment update.
Sun, Mar 29, 11:46 AM · Restricted Project
bondhugula committed rGc0955edfd6ec: Introduce support for lib function aligned_alloc in TLI / memory builtins (authored by bondhugula).
Introduce support for lib function aligned_alloc in TLI / memory builtins
Sun, Mar 29, 11:13 AM
bondhugula closed D76970: Support for library function aligned_alloc in TLI / memory builtins.
Sun, Mar 29, 11:13 AM · Restricted Project
bondhugula added a comment to D76976: [NewGVN] Make NewGVN aware of aligned_alloc.

Please prefix the commit message with something like [NewGVN]

Sun, Mar 29, 11:13 AM · Restricted Project
bondhugula created D77008: [MLIR][NFC] Move test/Transforms/lower-affine.mlir -> test/Conversion.
Sun, Mar 29, 12:30 AM · Restricted Project

Sat, Mar 28

bondhugula updated the diff for D77003: [MLIR] Add missing asserts in interchangeLoops util, doc comment update.

perfect nest check

Sat, Mar 28, 11:04 PM · Restricted Project
bondhugula added inline comments to D77003: [MLIR] Add missing asserts in interchangeLoops util, doc comment update.
Sat, Mar 28, 11:04 PM · Restricted Project
bondhugula updated the summary of D75837: [MLIR] Introduce std.execute_region op.
Sat, Mar 28, 10:32 PM · Restricted Project
bondhugula added a child revision for D71961: [MLIR] Free ReturnOp from being restricted to a FuncOp: D75837: [MLIR] Introduce std.execute_region op.
Sat, Mar 28, 10:32 PM · Restricted Project
bondhugula added a parent revision for D75837: [MLIR] Introduce std.execute_region op: D71961: [MLIR] Free ReturnOp from being restricted to a FuncOp.
Sat, Mar 28, 10:32 PM · Restricted Project
bondhugula updated the diff for D75837: [MLIR] Introduce std.execute_region op.

Take out any yield op changes. Rebase.

Sat, Mar 28, 9:28 PM · Restricted Project
bondhugula updated the diff for D71961: [MLIR] Free ReturnOp from being restricted to a FuncOp.

Rebase

Sat, Mar 28, 9:28 PM · Restricted Project
bondhugula created D77003: [MLIR] Add missing asserts in interchangeLoops util, doc comment update.
Sat, Mar 28, 7:20 PM · Restricted Project
bondhugula updated the summary of D77004: [MLIR] Fix permuteLoops utility.
Sat, Mar 28, 7:20 PM · Restricted Project
bondhugula added a parent revision for D77004: [MLIR] Fix permuteLoops utility: D77003: [MLIR] Add missing asserts in interchangeLoops util, doc comment update.
Sat, Mar 28, 7:20 PM · Restricted Project
bondhugula added a child revision for D77003: [MLIR] Add missing asserts in interchangeLoops util, doc comment update: D77004: [MLIR] Fix permuteLoops utility.
Sat, Mar 28, 7:20 PM · Restricted Project
bondhugula updated the diff for D77004: [MLIR] Fix permuteLoops utility.

Update child revision

Sat, Mar 28, 7:20 PM · Restricted Project
bondhugula created D77004: [MLIR] Fix permuteLoops utility.
Sat, Mar 28, 7:20 PM · Restricted Project
bondhugula accepted D76993: [mlir] NFC: fix trivial typo in documents.

Thanks!

Sat, Mar 28, 12:22 PM · Restricted Project
bondhugula added a comment to D75837: [MLIR] Introduce std.execute_region op.

Presumably yield should replace the linalg and loop yields? I would add std.yield in a separate patch that refactors the other dialects to use it as well.

Sat, Mar 28, 9:40 AM · Restricted Project
bondhugula added inline comments to D76971: [InstCombine] Deduce attributes for aligned_alloc in InstCombine.
Sat, Mar 28, 2:10 AM · Restricted Project
bondhugula committed rG06066c400353: [NFC] Attributor comment updates / cast cleanup (authored by bondhugula).
[NFC] Attributor comment updates / cast cleanup
Sat, Mar 28, 1:37 AM
bondhugula closed D76972: [NFC] Attributor comment updates / cast cleanup.
Sat, Mar 28, 1:37 AM · Restricted Project
bondhugula updated the diff for D76976: [NewGVN] Make NewGVN aware of aligned_alloc.

Add test case

Sat, Mar 28, 1:35 AM · Restricted Project
bondhugula updated the diff for D76975: [GVN] Make GVN aware of aligned_alloc.

Add test case (commit id change on rebase)

Sat, Mar 28, 1:35 AM · Restricted Project
bondhugula updated the diff for D76975: [GVN] Make GVN aware of aligned_alloc.

Add test case

Sat, Mar 28, 1:35 AM · Restricted Project
bondhugula updated the diff for D76974: [Attributor] Make attributor aware of aligned_alloc for heap to stack conversion.

Address review comments.

Sat, Mar 28, 1:35 AM · Restricted Project
bondhugula updated the summary of D76975: [GVN] Make GVN aware of aligned_alloc.
Sat, Mar 28, 1:35 AM · Restricted Project
bondhugula added inline comments to D76974: [Attributor] Make attributor aware of aligned_alloc for heap to stack conversion.
Sat, Mar 28, 1:35 AM · Restricted Project
bondhugula created D76976: [NewGVN] Make NewGVN aware of aligned_alloc.
Sat, Mar 28, 1:02 AM · Restricted Project
bondhugula added a child revision for D76975: [GVN] Make GVN aware of aligned_alloc: D76976: [NewGVN] Make NewGVN aware of aligned_alloc.
Sat, Mar 28, 1:02 AM · Restricted Project
bondhugula added reviewers for D76975: [GVN] Make GVN aware of aligned_alloc: jdoerfert, xbolva00.
Sat, Mar 28, 12:32 AM · Restricted Project
bondhugula created D76975: [GVN] Make GVN aware of aligned_alloc.
Sat, Mar 28, 12:30 AM · Restricted Project
bondhugula created D76974: [Attributor] Make attributor aware of aligned_alloc for heap to stack conversion.
Sat, Mar 28, 12:30 AM · Restricted Project
bondhugula added a child revision for D76971: [InstCombine] Deduce attributes for aligned_alloc in InstCombine: D76974: [Attributor] Make attributor aware of aligned_alloc for heap to stack conversion.
Sat, Mar 28, 12:30 AM · Restricted Project
bondhugula added inline comments to D76971: [InstCombine] Deduce attributes for aligned_alloc in InstCombine.
Sat, Mar 28, 12:30 AM · Restricted Project

Fri, Mar 27

bondhugula updated the diff for D76972: [NFC] Attributor comment updates / cast cleanup.

Minor comment fix.

Fri, Mar 27, 11:57 PM · Restricted Project
Herald added a reviewer for D76972: [NFC] Attributor comment updates / cast cleanup: sstefan1.
Fri, Mar 27, 11:57 PM · Restricted Project
bondhugula created D76971: [InstCombine] Deduce attributes for aligned_alloc in InstCombine.
Fri, Mar 27, 11:57 PM · Restricted Project
bondhugula added a child revision for D76970: Support for library function aligned_alloc in TLI / memory builtins: D76971: [InstCombine] Deduce attributes for aligned_alloc in InstCombine.
Fri, Mar 27, 11:57 PM · Restricted Project
bondhugula retitled D71521: Introduce support for lib function aligned_alloc from Support for library function aligned_alloc to Introduce support for lib function aligned_alloc.
Fri, Mar 27, 11:57 PM · Restricted Project
bondhugula updated the diff for D76970: Support for library function aligned_alloc in TLI / memory builtins.

clang-format missed changes

Fri, Mar 27, 11:25 PM · Restricted Project
bondhugula updated the diff for D76970: Support for library function aligned_alloc in TLI / memory builtins.

Fix inadvertent format changes

Fri, Mar 27, 11:25 PM · Restricted Project
Herald added a reviewer for D71521: Introduce support for lib function aligned_alloc: sstefan1.

This has been split - first patch is D76970.

Fri, Mar 27, 11:25 PM · Restricted Project
bondhugula created D76970: Support for library function aligned_alloc in TLI / memory builtins.
Fri, Mar 27, 11:25 PM · Restricted Project
bondhugula added inline comments to D76912: [MLIR] Add simple runner utilities for timing.
Fri, Mar 27, 10:32 PM · Restricted Project
bondhugula updated the diff for D76912: [MLIR] Add simple runner utilities for timing.

Emit error message for the timer util on Win32

Fri, Mar 27, 10:32 PM · Restricted Project
bondhugula committed rGfec6c5ac5e57: [MLIR][NFC] Move TestDialect -> Dialect/Test (authored by bondhugula).
[MLIR][NFC] Move TestDialect -> Dialect/Test
Fri, Mar 27, 7:19 PM