Page MenuHomePhabricator
Feed Advanced Search

May 13 2020

miscco added a comment to D74350: [libcxx][type_traits] Add C++20 changes to common_type.

Thanks for the review, could somebody commit it as I do not have the rights

May 13 2020, 10:50 AM · Restricted Project
miscco added a comment to D75642: [libcxx][span] Remove const_iterator from std::span.

Thanks for the review, could somebody commit it as I do not have the rights

May 13 2020, 10:50 AM · Restricted Project
miscco added a comment to D75706: [libcxx][span] Implement solution to LWG-3255.

Thanks for the review, could somebody commit it as I do not have the rights

May 13 2020, 10:50 AM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

Thanks for the review. I do not have commit rights though.

May 13 2020, 6:27 AM · Restricted Project

May 12 2020

miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

Only update spans feature test macro

May 12 2020, 10:05 PM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

It seems it finally worked. No idea what went wrong as the changes were still in there

May 12 2020, 10:43 AM · Restricted Project
miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

second try

May 12 2020, 10:43 AM · Restricted Project
miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

Add changes?!

May 12 2020, 10:43 AM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

That is unfortunate, i will restore them later in the evening

May 12 2020, 10:11 AM · Restricted Project
miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

Rebase on master

May 12 2020, 6:57 AM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

@ldionne Thanks a lot for the hint. I updated the generate_feature_test_macro_components.py script and also fixed the incorrect value provided to __cpp_lib_to_array

May 12 2020, 2:07 AM · Restricted Project
miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.
  • [libcxx][span] Update synopsis
  • Update feature test macro
May 12 2020, 2:07 AM · Restricted Project

May 8 2020

miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.
  • [libcxx][span] Update synopsis
May 8 2020, 12:52 PM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

@ldionne Thanks a lot for the review. I have added the feature test macro as I did not find it anywhere else.

May 8 2020, 12:52 PM · Restricted Project

May 4 2020

miscco added a comment to D74351: [libcxx][type_traits] Implement C++20 common_ref.

ping

May 4 2020, 11:57 PM · Restricted Project
miscco added a comment to D74350: [libcxx][type_traits] Add C++20 changes to common_type.

ping

May 4 2020, 11:57 PM · Restricted Project

Apr 27 2020

miscco added a comment to D75706: [libcxx][span] Implement solution to LWG-3255.

ping

Apr 27 2020, 2:01 PM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

ping

Apr 27 2020, 2:01 PM · Restricted Project

Apr 22 2020

miscco added a comment to D75640: [libcxx][span] Remove tuple interface.

Ping

Apr 22 2020, 1:35 AM · Restricted Project

Apr 21 2020

miscco added a comment to D75642: [libcxx][span] Remove const_iterator from std::span.

Looks like there are still white-space changes in the tests. And there are warning from the CI? Are those formatting warnings or "real" warnings?

Apr 21 2020, 2:06 PM · Restricted Project

Apr 20 2020

miscco added a comment to D75642: [libcxx][span] Remove const_iterator from std::span.

ping, this is now without whitespace changes so I would guess it is ready to go?

Apr 20 2020, 4:16 AM · Restricted Project
miscco added inline comments to D77961: [libcxx] adds concept `std::convertible_to`.
Apr 20 2020, 4:16 AM · Restricted Project

Apr 17 2020

miscco added inline comments to D67052: Add reference type transformation builtins.
Apr 17 2020, 6:59 AM · Restricted Project, Restricted Project

Apr 12 2020

miscco added a comment to D77961: [libcxx] adds concept `std::convertible_to`.

I left mostly some nits with respect to readability. Great job

Apr 12 2020, 3:43 AM · Restricted Project

Apr 9 2020

miscco added a comment to D74350: [libcxx][type_traits] Add C++20 changes to common_type.

Thanks to @CaseyCarter for the example

Apr 9 2020, 1:32 PM · Restricted Project
miscco updated the diff for D74350: [libcxx][type_traits] Add C++20 changes to common_type.

Add test for a reference wrapper type

Apr 9 2020, 1:31 PM · Restricted Project

Apr 8 2020

miscco added a comment to D74350: [libcxx][type_traits] Add C++20 changes to common_type.

Actually I was having trouble comming up with a test case for bullet 4.

Apr 8 2020, 11:12 PM · Restricted Project
Herald added a reviewer for D75706: [libcxx][span] Implement solution to LWG-3255: Restricted Project.

ping

Apr 8 2020, 11:57 AM · Restricted Project
Herald added a reviewer for D74351: [libcxx][type_traits] Implement C++20 common_ref: Restricted Project.

ping

Apr 8 2020, 11:57 AM · Restricted Project
Herald added a reviewer for D74350: [libcxx][type_traits] Add C++20 changes to common_type: Restricted Project.

ping

Apr 8 2020, 11:57 AM · Restricted Project

Apr 2 2020

miscco added inline comments to D77281: [libc] Add libc-tidy..
Apr 2 2020, 4:18 AM · Restricted Project

Mar 29 2020

miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

@ldionne do you require any changes here (especially regarding the feature test macro)

Mar 29 2020, 12:17 PM · Restricted Project
miscco added a comment to D75640: [libcxx][span] Remove tuple interface.

Ping, this is also all red

Mar 29 2020, 11:45 AM · Restricted Project
miscco added a comment to D75642: [libcxx][span] Remove const_iterator from std::span.

Ping, this is all red so...

Mar 29 2020, 11:45 AM · Restricted Project
miscco added a comment to D71994: SFINAE span default constructor on Extent == 0.

Ping, I guess the clang format should not be applied?

Mar 29 2020, 11:45 AM · Restricted Project

Mar 17 2020

miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

[libcxx][span] Update synopsis

Mar 17 2020, 3:07 PM · Restricted Project
miscco added a comment to D74577: [libcxx][span] Implement P1976R2.

Thanks for the review, I am unsure whether one should really update the feature test macro without the other changes in place (tuple interface, relaxed array constructors etc)

Mar 17 2020, 2:36 PM · Restricted Project
Herald added a reviewer for D75642: [libcxx][span] Remove const_iterator from std::span: Restricted Project.

span-ing more pings

Mar 17 2020, 11:49 AM · Restricted Project
Herald added a reviewer for D75640: [libcxx][span] Remove tuple interface: Restricted Project.

ping

Mar 17 2020, 11:49 AM · Restricted Project
Herald added a reviewer for D74577: [libcxx][span] Implement P1976R2: Restricted Project.

gentle ping

Mar 17 2020, 11:49 AM · Restricted Project

Mar 12 2020

miscco updated the diff for D71994: SFINAE span default constructor on Extent == 0.

Do not require concepts

Mar 12 2020, 12:28 PM · Restricted Project

Mar 11 2020

miscco added a comment to D71994: SFINAE span default constructor on Extent == 0.

You are absolutely right.

Mar 11 2020, 10:33 PM · Restricted Project

Mar 10 2020

miscco added a comment to D71994: SFINAE span default constructor on Extent == 0.

gentle ping

Mar 10 2020, 1:06 PM · Restricted Project

Mar 5 2020

miscco created D75706: [libcxx][span] Implement solution to LWG-3255.
Mar 5 2020, 12:39 PM · Restricted Project
miscco updated the diff for D75642: [libcxx][span] Remove const_iterator from std::span.

Do not clang-format the code

Mar 5 2020, 9:50 AM · Restricted Project
miscco added a comment to D75642: [libcxx][span] Remove const_iterator from std::span.

My hope was that it would fix the complaints from the Harbormaster. But that doesnt seem to be the case

Mar 5 2020, 9:18 AM · Restricted Project

Mar 4 2020

miscco updated the diff for D75642: [libcxx][span] Remove const_iterator from std::span.

clang-format all the files

Mar 4 2020, 10:58 PM · Restricted Project
miscco updated the diff for D75642: [libcxx][span] Remove const_iterator from std::span.

Fix whitespaces

Mar 4 2020, 1:29 PM · Restricted Project
miscco created D75642: [libcxx][span] Remove const_iterator from std::span.
Mar 4 2020, 1:29 PM · Restricted Project
miscco created D75640: [libcxx][span] Remove tuple interface.
Mar 4 2020, 12:57 PM · Restricted Project

Feb 19 2020

miscco added a comment to D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent.

Ah sorry about that, I overlooked that we had special cased tests without count.

Feb 19 2020, 12:31 AM · Restricted Project

Feb 16 2020

miscco added a comment to D69827: [libcxx] Remove swap for std::span.

That is indeed the correct thing to do +1

Feb 16 2020, 10:18 AM · Restricted Project
miscco added a comment to D69520: [libc++] Disallow dynamic -> static span conversions.

I believe this is superseded by the implementation of P1976R2 in D74577

Feb 16 2020, 10:18 AM

Feb 14 2020

miscco added inline comments to D74291: [libcxx] Adds [concept.same].
Feb 14 2020, 2:39 AM
miscco retitled D74577: [libcxx][span] Implement P1976R2 from [libcxx][span] Implement P1976R1 to [libcxx][span] Implement P1976R2.
Feb 14 2020, 1:45 AM · Restricted Project

Feb 13 2020

miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

Add failing tests for explicit constructors

Feb 13 2020, 1:11 PM · Restricted Project
miscco updated the diff for D74577: [libcxx][span] Implement P1976R2.

Forgot the explicit for the container constructors

Feb 13 2020, 1:01 PM · Restricted Project
miscco created D74577: [libcxx][span] Implement P1976R2.
Feb 13 2020, 1:01 PM · Restricted Project

Feb 12 2020

miscco added inline comments to D74351: [libcxx][type_traits] Implement C++20 common_ref.
Feb 12 2020, 12:06 PM · Restricted Project

Feb 11 2020

miscco updated the diff for D71994: SFINAE span default constructor on Extent == 0.

[libcxx][span] Use requires clause for default constructor

Feb 11 2020, 11:56 AM · Restricted Project
miscco updated subscribers of D67052: Add reference type transformation builtins.

Some nits, looks great, especially for library concepts. Pinging @cjdb

Feb 11 2020, 6:01 AM · Restricted Project, Restricted Project
miscco updated the diff for D71994: SFINAE span default constructor on Extent == 0.

rebased

Feb 11 2020, 5:07 AM · Restricted Project
miscco updated the diff for D71998: [libcxx] span: Guard against overflow in span::subspan.

rebased

Feb 11 2020, 4:50 AM · Restricted Project
miscco updated the diff for D71995: [libcxx] span: Fix incorrect static asserts.

Make STL happy, as they apply [[nodiscard]] everywhere

Feb 11 2020, 4:30 AM · Restricted Project
miscco updated the diff for D71995: [libcxx] span: Fix incorrect static asserts.

Remove superfluous newlines

Feb 11 2020, 3:54 AM · Restricted Project
miscco added a reviewer for D74351: [libcxx][type_traits] Implement C++20 common_ref: ldionne.
Feb 11 2020, 3:54 AM · Restricted Project
miscco updated the diff for D71995: [libcxx] span: Fix incorrect static asserts.

Add tests

Feb 11 2020, 3:53 AM · Restricted Project
miscco added a comment to D71995: [libcxx] span: Fix incorrect static asserts.

@ldionne I aggree with your sentiment and I only discovered this when I implemented span for MSVC STL and added the same static assert to operator[]

Feb 11 2020, 3:53 AM · Restricted Project
miscco added inline comments to D74351: [libcxx][type_traits] Implement C++20 common_ref.
Feb 11 2020, 3:25 AM · Restricted Project
miscco updated the diff for D74351: [libcxx][type_traits] Implement C++20 common_ref.

Simplified code and improved comments

Feb 11 2020, 3:25 AM · Restricted Project
miscco added inline comments to D74351: [libcxx][type_traits] Implement C++20 common_ref.
Feb 11 2020, 12:12 AM · Restricted Project
miscco added a comment to D74351: [libcxx][type_traits] Implement C++20 common_ref.

@cjdb I have to disagree. That would create a ciruclar dependency between concepts and type_traits, which is in my opinion not worth it.

Feb 11 2020, 12:00 AM · Restricted Project

Feb 10 2020

miscco created D74351: [libcxx][type_traits] Implement C++20 common_ref.
Feb 10 2020, 11:23 AM · Restricted Project
miscco created D74350: [libcxx][type_traits] Add C++20 changes to common_type.
Feb 10 2020, 11:23 AM · Restricted Project

Feb 9 2020

miscco added a comment to D74291: [libcxx] Adds [concept.same].

For what its worth, I found some time today to cleanup what I had already done with @CaseyCarter old implementation D49118 (common_type and common_reference were missing).

Feb 9 2020, 1:08 PM
miscco added inline comments to D74292: [libcxx] adds concept std::derived_from.
Feb 9 2020, 12:03 AM · Restricted Project

Feb 8 2020

miscco added inline comments to D74291: [libcxx] Adds [concept.same].
Feb 8 2020, 11:45 PM
miscco added a comment to D74291: [libcxx] Adds [concept.same].

This looks already quite good.

Feb 8 2020, 11:36 PM
miscco added inline comments to D74291: [libcxx] Adds [concept.same].
Feb 8 2020, 11:36 PM

Jan 29 2020

miscco added inline comments to D73530: [libc] Add a library of standalone C++ utilities..
Jan 29 2020, 2:03 AM · Restricted Project
miscco added a comment to D73530: [libc] Add a library of standalone C++ utilities..

Comment about empty arrays

Jan 29 2020, 1:54 AM · Restricted Project

Jan 20 2020

miscco added a comment to D71997: [libcxx] span: Fix incorrect return type of span::subspan.

Ping as this is an actual bugfix

Jan 20 2020, 12:27 PM · Restricted Project
miscco added a comment to D71998: [libcxx] span: Guard against overflow in span::subspan.

Gentle Ping

Jan 20 2020, 12:27 PM · Restricted Project
miscco added a comment to D71994: SFINAE span default constructor on Extent == 0.

Gentle Ping

Jan 20 2020, 12:27 PM · Restricted Project

Jan 7 2020

miscco added a comment to D71996: [libcxx] span: Remove unneeded comparison.

Ping trivially correct change

Jan 7 2020, 11:41 AM · Restricted Project
miscco added a comment to D71997: [libcxx] span: Fix incorrect return type of span::subspan.

Gentle ping with the relevant quote from the standard

Jan 7 2020, 9:37 AM · Restricted Project
miscco added inline comments to D71994: SFINAE span default constructor on Extent == 0.
Jan 7 2020, 9:37 AM · Restricted Project
miscco updated the diff for D71994: SFINAE span default constructor on Extent == 0.
  • [libcxx] span: Check default constructible
Jan 7 2020, 9:37 AM · Restricted Project
miscco added a comment to D71994: SFINAE span default constructor on Extent == 0.

Added missing include of <version>

Jan 7 2020, 9:37 AM · Restricted Project
miscco added a comment to D71994: SFINAE span default constructor on Extent == 0.

Added type_traits and concepts check for the different spans

Jan 7 2020, 9:18 AM · Restricted Project
miscco updated the diff for D71994: SFINAE span default constructor on Extent == 0.
  • [libcxx] span: Check default constructible
Jan 7 2020, 9:09 AM · Restricted Project

Jan 6 2020

miscco added a comment to D72102: [libc] Add __attribute__((always_inline)) to x86_64 syscall functions..

clang-format comment

Jan 6 2020, 10:04 PM · Restricted Project

Jan 5 2020

miscco added a comment to D71994: SFINAE span default constructor on Extent == 0.

Library concepts are not yet implemented.

Jan 5 2020, 9:48 PM · Restricted Project

Jan 3 2020

miscco added a comment to D72036: [libcxx] span: Cleanup includes.

Removed the forward declaration of array as that would be far more involved.

Jan 3 2020, 1:34 AM · Restricted Project
miscco updated the diff for D72036: [libcxx] span: Cleanup includes.

Do not forward declare array

Jan 3 2020, 1:34 AM · Restricted Project
miscco added a comment to D71994: SFINAE span default constructor on Extent == 0.

Hm, this fixes a todo that was written by you..

Jan 3 2020, 12:17 AM · Restricted Project

Jan 1 2020

miscco added a comment to D72036: [libcxx] span: Cleanup includes.

Some comments

Jan 1 2020, 8:34 AM · Restricted Project

Dec 31 2019

miscco created D72036: [libcxx] span: Cleanup includes.
Dec 31 2019, 4:52 AM · Restricted Project

Dec 30 2019

miscco updated the diff for D71999: [libcxx][tests] span: Add failing tests for span::first and span::last.

Updating D71999: [libcxx][tests] span: Add failing tests for span::first and span::last

Dec 30 2019, 5:51 AM · Restricted Project
miscco updated the diff for D71999: [libcxx][tests] span: Add failing tests for span::first and span::last.

Updating D71999: [libcxx][tests] span: Add failing tests for span::first and span::last

Dec 30 2019, 5:51 AM · Restricted Project