Page MenuHomePhabricator
Feed Advanced Search

Fri, Oct 25

inglorion accepted D69450: Migrate the annotated buildbots to github.

I'm assuming that addGetSourcecodeSteps takes care of checking out the correct revision. From a cursory look at LLVMBuildFactory and the Buildbot documentation, this appears to be the case.

Fri, Oct 25, 3:43 PM

Sep 26 2019

inglorion committed rG4061a9b63a42: [NFC][emacs] remove out-of-date comment from tablegen-mode.el (authored by inglorion).
[NFC][emacs] remove out-of-date comment from tablegen-mode.el
Sep 26 2019, 12:37 PM
inglorion committed rL373008: [NFC][emacs] remove out-of-date comment from tablegen-mode.el.
[NFC][emacs] remove out-of-date comment from tablegen-mode.el
Sep 26 2019, 12:34 PM
inglorion closed D68042: [NFC][emacs] remove out-of-date comment from tablegen-mode.el.
Sep 26 2019, 12:34 PM · Restricted Project

Sep 25 2019

inglorion created D68042: [NFC][emacs] remove out-of-date comment from tablegen-mode.el.
Sep 25 2019, 11:38 AM · Restricted Project
inglorion committed rG75c689f7c825: [emacs] simplify and improve keyword highlighting in tablegen-mode.el (authored by inglorion).
[emacs] simplify and improve keyword highlighting in tablegen-mode.el
Sep 25 2019, 11:16 AM
inglorion committed rL372904: [emacs] simplify and improve keyword highlighting in tablegen-mode.el.
[emacs] simplify and improve keyword highlighting in tablegen-mode.el
Sep 25 2019, 11:14 AM
inglorion closed D68002: [emacs] simplify and improve keyword highlighting in tablegen-mode.el.
Sep 25 2019, 11:14 AM · Restricted Project

Sep 24 2019

inglorion committed rG9f0f36e02231: [ELF] accept thinlto options without --plugin-opt= prefix (authored by inglorion).
[ELF] accept thinlto options without --plugin-opt= prefix
Sep 24 2019, 6:20 PM
inglorion committed rL372798: [ELF] accept thinlto options without --plugin-opt= prefix.
[ELF] accept thinlto options without --plugin-opt= prefix
Sep 24 2019, 6:18 PM
inglorion closed D67782: [ELF] accept thinlto options without --plugin-opt= prefix.
Sep 24 2019, 6:17 PM · Restricted Project
inglorion added a comment to D67782: [ELF] accept thinlto options without --plugin-opt= prefix.

Thanks! Removing unnecessary llvm:: prefix before commit.

Sep 24 2019, 6:17 PM · Restricted Project
inglorion created D68002: [emacs] simplify and improve keyword highlighting in tablegen-mode.el.
Sep 24 2019, 6:15 PM · Restricted Project
inglorion updated the diff for D67782: [ELF] accept thinlto options without --plugin-opt= prefix.

@ruiu's comments (thanks!)

Sep 24 2019, 5:36 PM · Restricted Project
inglorion committed rG19712415a575: [NFC][COFF] fix typo in comment ("algortihm" -> "algorithm") (authored by inglorion).
[NFC][COFF] fix typo in comment ("algortihm" -> "algorithm")
Sep 24 2019, 1:20 PM
inglorion committed rL372776: [NFC][COFF] fix typo in comment ("algortihm" -> "algorithm").
[NFC][COFF] fix typo in comment ("algortihm" -> "algorithm")
Sep 24 2019, 1:16 PM

Sep 20 2019

inglorion updated the diff for D67782: [ELF] accept thinlto options without --plugin-opt= prefix.

@MaskRay's comments. Thanks! I've changed the original code to match.

Sep 20 2019, 1:44 PM · Restricted Project

Sep 19 2019

inglorion created D67782: [ELF] accept thinlto options without --plugin-opt= prefix.
Sep 19 2019, 6:14 PM · Restricted Project

Sep 13 2019

inglorion accepted D67457: lld-link: Make Options.td formatting more self-consistent..

I don't think we should keep flag help texts in sync where it doesn't make sense. "Archive" is posix terminology. It's true that "wholearchive" has "archive" in it, but its help text on msdn is "Include All Library Object Files" :)

Sep 13 2019, 1:42 PM · Restricted Project

Sep 12 2019

inglorion accepted D67295: [COFF] Fix to not add archive name to buffer identifiers when they come from thin archives..

lgtm, thanks!

Sep 12 2019, 1:07 PM · Restricted Project
inglorion updated subscribers of D67457: lld-link: Make Options.td formatting more self-consistent..

The help text for -start-lib and -end-lib matches that in the ELF linker. Please keep those matching by changing it there, too. Also, I think s/library/archive/, so that it matches the naming of -wholearchive.

Sep 12 2019, 11:44 AM · Restricted Project

Sep 3 2019

inglorion committed rG7dc5e7a0a4f4: reland "[lld-link] implement -start-lib and -end-lib" (authored by inglorion).
reland "[lld-link] implement -start-lib and -end-lib"
Sep 3 2019, 1:35 PM
inglorion committed rL370816: reland "[lld-link] implement -start-lib and -end-lib".
reland "[lld-link] implement -start-lib and -end-lib"
Sep 3 2019, 1:34 PM

Aug 30 2019

inglorion committed rGfd7569c8e366: [lld-link] implement -start-lib and -end-lib (authored by inglorion).
[lld-link] implement -start-lib and -end-lib
Aug 30 2019, 9:55 AM
inglorion added a comment to D66848: [lld-link] implement -start-lib and -end-lib.

Implemented ruiu's requests before committing. Thanks for reviewing!

Aug 30 2019, 9:55 AM · Restricted Project
inglorion committed rL370487: [lld-link] implement -start-lib and -end-lib.
[lld-link] implement -start-lib and -end-lib
Aug 30 2019, 9:49 AM
inglorion closed D66848: [lld-link] implement -start-lib and -end-lib.
Aug 30 2019, 9:49 AM · Restricted Project

Aug 29 2019

inglorion updated the diff for D66848: [lld-link] implement -start-lib and -end-lib.
  • allow mixing -start-lib and -wholearchive:
Aug 29 2019, 11:17 AM · Restricted Project

Aug 28 2019

inglorion added inline comments to D66848: [lld-link] implement -start-lib and -end-lib.
Aug 28 2019, 1:32 PM · Restricted Project
inglorion updated the diff for D66848: [lld-link] implement -start-lib and -end-lib.

comments by @ruiu and @MaskRay (thanks!)

  • made AddMode an enum class
  • simplified AddMode computation in OPT_INPUT case
  • added missing std::moves
  • use auto instead of explicitly naming LazyArchive
Aug 28 2019, 1:32 PM · Restricted Project

Aug 27 2019

inglorion added a comment to D66848: [lld-link] implement -start-lib and -end-lib.

Primarily, this change adds a LazyObject Symbol kind, and a LazyObjFile InputFile kind. A LazyObject represents a symbol defined in a LazyObjFile, and a LazyObjFile is either a native object file or a bitcode file that we know of, but have not yet decided to link in. As with the LazyArchive symbols we already had, when we encounter both a lazy symbol and an Undefined symbol, we resolve this by linking in the file that defines the symbol, so the result is a Defined symbol.

Aug 27 2019, 6:11 PM · Restricted Project
inglorion updated the diff for D66848: [lld-link] implement -start-lib and -end-lib.

fix places where I needed to add handling of LazyObject symbols

Aug 27 2019, 6:04 PM · Restricted Project
inglorion planned changes to D66848: [lld-link] implement -start-lib and -end-lib.

Seeing the code here, I see I still need to handle LazyObject in symbol resolution.

Aug 27 2019, 5:17 PM · Restricted Project
inglorion created D66848: [lld-link] implement -start-lib and -end-lib.
Aug 27 2019, 5:17 PM · Restricted Project

Aug 26 2019

inglorion added a reviewer for D66767: Add binary filename to the bitcode filename when using -thinlto-index-only: ruiu.

@ruiu, I'd like your opinion on this.

Aug 26 2019, 4:18 PM · Restricted Project
inglorion added a comment to D66767: Add binary filename to the bitcode filename when using -thinlto-index-only.

Related bug: https://bugs.llvm.org/show_bug.cgi?id=42717

Aug 26 2019, 4:09 PM · Restricted Project

Aug 21 2019

inglorion committed rG5375b94e36b7: [lld-link] implement -lto-obj-path (authored by inglorion).
[lld-link] implement -lto-obj-path
Aug 21 2019, 11:25 AM
inglorion committed rL369559: [lld-link] implement -lto-obj-path.
[lld-link] implement -lto-obj-path
Aug 21 2019, 11:24 AM
inglorion closed D65964: [lld-link] implement -lto-obj-path.
Aug 21 2019, 11:24 AM · Restricted Project

Aug 16 2019

inglorion updated the diff for D65964: [lld-link] implement -lto-obj-path.

changed flag name to -lto-obj-path:

Aug 16 2019, 4:22 PM · Restricted Project

Aug 12 2019

inglorion closed D66037: Remove builder clang-with-thin-lto-windows.

Landed in r368612 / d47622.

Aug 12 2019, 6:07 PM
inglorion committed rG6e18c7f8d4b5: [lld] Remove unnecessary "class Lazy" (authored by inglorion).
[lld] Remove unnecessary "class Lazy"
Aug 12 2019, 6:03 PM
inglorion committed rL368644: [lld] Remove unnecessary "class Lazy".
[lld] Remove unnecessary "class Lazy"
Aug 12 2019, 6:03 PM
inglorion added a comment to D65964: [lld-link] implement -lto-obj-path.

'll call the Config field ltoObjPath, same as in the ELF linker.

Aug 12 2019, 4:50 PM · Restricted Project
inglorion added a comment to D65964: [lld-link] implement -lto-obj-path.

After discussion in person, we decided on -lto-obj-path: similar to the naming in the ELF linker, and we'

Aug 12 2019, 4:50 PM · Restricted Project
inglorion committed rL368612: Remove builder clang-with-thin-lto-windows.
Remove builder clang-with-thin-lto-windows
Aug 12 2019, 12:55 PM
inglorion added a comment to D65964: [lld-link] implement -lto-obj-path.

@rnk, what do you think of the name I proposed?

Aug 12 2019, 11:38 AM · Restricted Project

Aug 9 2019

inglorion created D66037: Remove builder clang-with-thin-lto-windows.
Aug 9 2019, 3:49 PM

Aug 8 2019

inglorion added a comment to D65964: [lld-link] implement -lto-obj-path.

In ELF, the config name is ltoObjPath, and the flag is -plugin-opt=obj-path=

Aug 8 2019, 4:09 PM · Restricted Project
inglorion created D65964: [lld-link] implement -lto-obj-path.
Aug 8 2019, 11:33 AM · Restricted Project

Aug 7 2019

inglorion committed rG885fa02da97a: Revert r367501 "Create unique, but identically-named ELF sections..." (authored by inglorion).
Revert r367501 "Create unique, but identically-named ELF sections..."
Aug 7 2019, 1:46 PM
inglorion added a reverting change for rGfbc563e2cb6c: Create unique, but identically-named ELF sections for explicitly-sectioned…: rG885fa02da97a: Revert r367501 "Create unique, but identically-named ELF sections...".
Aug 7 2019, 1:46 PM
inglorion committed rL368204: Revert r367501 "Create unique, but identically-named ELF sections...".
Revert r367501 "Create unique, but identically-named ELF sections..."
Aug 7 2019, 1:44 PM
inglorion added a comment to D65478: Create unique, but identically-named ELF sections for explicitly-sectioned functions and globals when using -function-sections and -data-sections..

Unfortunately, this causes some problems. It looks like the sections are created with different attributes than the original. This causes problems such as sections being writable when the original was read-only, including https://crbug.com/990942 where that causes program crashes. There is some more discussion on that bug report.

Aug 7 2019, 1:30 PM · Restricted Project

Aug 1 2019

inglorion abandoned D65619: [lit] use built-in clear_environment instead of external env command.

Heh, I just missed the revert. @jdenny, feel free to use this as inspiration.

Aug 1 2019, 4:43 PM · Restricted Project
inglorion created D65619: [lit] use built-in clear_environment instead of external env command.
Aug 1 2019, 4:31 PM · Restricted Project

Jul 26 2019

inglorion committed rG6baac18a760d: add 'a' to chmod in llvm-lipo executability tests (authored by inglorion).
add 'a' to chmod in llvm-lipo executability tests
Jul 26 2019, 11:47 AM
inglorion committed rL367142: add 'a' to chmod in llvm-lipo executability tests.
add 'a' to chmod in llvm-lipo executability tests
Jul 26 2019, 11:43 AM
inglorion closed D65342: add 'a' to chmod in llvm-lipo executability tests.
Jul 26 2019, 11:43 AM · Restricted Project
inglorion created D65342: add 'a' to chmod in llvm-lipo executability tests.
Jul 26 2019, 11:40 AM · Restricted Project
inglorion committed rG51dcb292cc00: [lld-link] diagnose undefined symbols before LTO when possible (authored by inglorion).
[lld-link] diagnose undefined symbols before LTO when possible
Jul 26 2019, 10:57 AM
inglorion committed rL367136: [lld-link] diagnose undefined symbols before LTO when possible.
[lld-link] diagnose undefined symbols before LTO when possible
Jul 26 2019, 10:57 AM
inglorion closed D62434: [lld-link] diagnose undefined symbols before LTO when possible.
Jul 26 2019, 10:57 AM · Restricted Project

Jul 25 2019

inglorion added inline comments to D62434: [lld-link] diagnose undefined symbols before LTO when possible.
Jul 25 2019, 8:55 AM · Restricted Project

Jul 19 2019

inglorion updated the diff for D62434: [lld-link] diagnose undefined symbols before LTO when possible.

replaced assert with llvm_unreachable

Jul 19 2019, 2:53 PM · Restricted Project

Jul 18 2019

inglorion added a comment to D62434: [lld-link] diagnose undefined symbols before LTO when possible.

Linking ThinLTO chrome.dll with an undefined symbol:

Jul 18 2019, 2:30 PM · Restricted Project
inglorion updated the diff for D62434: [lld-link] diagnose undefined symbols before LTO when possible.

added comment explaining BitcodeFiles::instances.empty() check

Jul 18 2019, 10:59 AM · Restricted Project
inglorion added inline comments to D62434: [lld-link] diagnose undefined symbols before LTO when possible.
Jul 18 2019, 10:53 AM · Restricted Project
inglorion updated the diff for D62434: [lld-link] diagnose undefined symbols before LTO when possible.

addressed @ruiu's comments

Jul 18 2019, 10:52 AM · Restricted Project

Jul 17 2019

inglorion added a comment to D62434: [lld-link] diagnose undefined symbols before LTO when possible.

The basic idea here is:

Jul 17 2019, 6:27 PM · Restricted Project
inglorion updated the diff for D62434: [lld-link] diagnose undefined symbols before LTO when possible.

don't process bitcode files in resolveRemainindUndefines

Jul 17 2019, 6:27 PM · Restricted Project
inglorion updated the diff for D62434: [lld-link] diagnose undefined symbols before LTO when possible.

removed redundant check

Jul 17 2019, 6:13 PM · Restricted Project
inglorion updated the diff for D62434: [lld-link] diagnose undefined symbols before LTO when possible.

Ready for review now.

Jul 17 2019, 6:05 PM · Restricted Project
inglorion updated the diff for D62434: [lld-link] diagnose undefined symbols before LTO when possible.

rebase

Jul 17 2019, 3:51 PM · Restricted Project

Jul 15 2019

inglorion committed rG492ce8cc8b08: reland "add -fthinlto-index= option to clang-cl" (authored by inglorion).
reland "add -fthinlto-index= option to clang-cl"
Jul 15 2019, 6:37 PM
inglorion committed rL366165: reland "add -fthinlto-index= option to clang-cl".
reland "add -fthinlto-index= option to clang-cl"
Jul 15 2019, 6:36 PM
inglorion committed rG199f8721e6a1: add -fthinlto-index= option to clang-cl (authored by inglorion).
add -fthinlto-index= option to clang-cl
Jul 15 2019, 3:54 PM
inglorion committed rL366146: add -fthinlto-index= option to clang-cl.
add -fthinlto-index= option to clang-cl
Jul 15 2019, 3:50 PM
inglorion closed D64458: add -fthinlto-index= option to clang-cl.
Jul 15 2019, 3:50 PM · Restricted Project, Restricted Project
inglorion updated the diff for D64458: add -fthinlto-index= option to clang-cl.

Simplified after rebasing on top of r366127.

Jul 15 2019, 2:10 PM · Restricted Project, Restricted Project
inglorion committed rG794346460afa: [clang] allow -fthinlto-index= without -x ir (authored by inglorion).
[clang] allow -fthinlto-index= without -x ir
Jul 15 2019, 1:54 PM
inglorion committed rL366127: [clang] allow -fthinlto-index= without -x ir.
[clang] allow -fthinlto-index= without -x ir
Jul 15 2019, 1:53 PM
inglorion closed D64610: [clang] allow -fthinlto-index= without -x ir.
Jul 15 2019, 1:53 PM · Restricted Project, Restricted Project
inglorion updated the diff for D64610: [clang] allow -fthinlto-index= without -x ir.

Fix typo pointed out by MaskRay (thanks!)

Jul 15 2019, 1:47 PM · Restricted Project, Restricted Project

Jul 11 2019

inglorion added a comment to D64610: [clang] allow -fthinlto-index= without -x ir.

This was suggested on D64458.

Jul 11 2019, 6:04 PM · Restricted Project, Restricted Project
inglorion created D64610: [clang] allow -fthinlto-index= without -x ir.
Jul 11 2019, 5:58 PM · Restricted Project, Restricted Project
inglorion committed rG5011b832373f: [lld-link] implement -thinlto-{prefix,object-suffix}-replace (authored by inglorion).
[lld-link] implement -thinlto-{prefix,object-suffix}-replace
Jul 11 2019, 11:51 AM
inglorion committed rL365807: [lld-link] implement -thinlto-{prefix,object-suffix}-replace.
[lld-link] implement -thinlto-{prefix,object-suffix}-replace
Jul 11 2019, 11:51 AM
inglorion closed D64542: [lld-link] implement -thinlto-{prefix,object-suffix}-replace.
Jul 11 2019, 11:51 AM · Restricted Project
inglorion updated the diff for D64542: [lld-link] implement -thinlto-{prefix,object-suffix}-replace.

rebased and updated variable naming convention

Jul 11 2019, 11:47 AM · Restricted Project
inglorion added a comment to D64121: Rename variables so that they start with a lowercase letter..

Just chiming in to say this change makes me very happy. I'm pleasantly surprised by how much easier to read I'm finding the code. Thanks for doing this!

Jul 11 2019, 11:35 AM · Restricted Project
inglorion committed rG63efb28f4761: [lld-link] implement -thinlto-index-only (authored by inglorion).
[lld-link] implement -thinlto-index-only
Jul 11 2019, 11:04 AM
inglorion committed rL365800: [lld-link] implement -thinlto-index-only.
[lld-link] implement -thinlto-index-only
Jul 11 2019, 11:03 AM
inglorion closed D64461: [lld-link] implement -thinlto-index-only.
Jul 11 2019, 11:03 AM · Restricted Project
inglorion updated the diff for D64461: [lld-link] implement -thinlto-index-only.

new variable naming style

Jul 11 2019, 11:03 AM · Restricted Project
inglorion updated the diff for D64461: [lld-link] implement -thinlto-index-only.

removed getThinLTOOutputFile identity function

Jul 11 2019, 10:27 AM · Restricted Project

Jul 10 2019

inglorion added a parent revision for D64542: [lld-link] implement -thinlto-{prefix,object-suffix}-replace: D64461: [lld-link] implement -thinlto-index-only.
Jul 10 2019, 5:17 PM · Restricted Project
inglorion added a child revision for D64461: [lld-link] implement -thinlto-index-only: D64542: [lld-link] implement -thinlto-{prefix,object-suffix}-replace.
Jul 10 2019, 5:17 PM · Restricted Project
inglorion created D64542: [lld-link] implement -thinlto-{prefix,object-suffix}-replace.
Jul 10 2019, 5:17 PM · Restricted Project
inglorion added inline comments to D64461: [lld-link] implement -thinlto-index-only.
Jul 10 2019, 3:42 PM · Restricted Project