Page MenuHomePhabricator
Feed Advanced Search

Jun 24 2021

inglorion added a comment to D104061: [LangRef] clarify the meaning of noimplicitfloat.

Thanks, everyone!

Jun 24 2021, 1:59 PM · Restricted Project
inglorion committed rG29774016d421: [LangRef] clarify the meaning of noimplicitfloat (authored by inglorion).
[LangRef] clarify the meaning of noimplicitfloat
Jun 24 2021, 1:58 PM
inglorion closed D104061: [LangRef] clarify the meaning of noimplicitfloat.
Jun 24 2021, 1:58 PM · Restricted Project
inglorion added a comment to D104061: [LangRef] clarify the meaning of noimplicitfloat.

I avoided enumerating the cases to save space and to avoid pinning this down too much. My intention was to clarify that noimplicitfloat does not mean that no floating-point code will be generated under any circumstances, not necessarily to clarify exactly in which situations such code will or will not be generated. I'm happy to add the extra text, but before I do, I would like to get a second vote in favor of doing so vs. using the shorter text that I had written. @rnk, @craig.topper: What are your opinions?

Jun 24 2021, 9:31 AM · Restricted Project

Jun 15 2021

inglorion committed rG3bc899b4de74: [X86] avoid assert with varargs, soft float, and no-implicit-float (authored by inglorion).
[X86] avoid assert with varargs, soft float, and no-implicit-float
Jun 15 2021, 11:28 AM
inglorion closed D104001: [X86] avoid assert with varargs, soft float, and no-implicit-float.
Jun 15 2021, 11:27 AM · Restricted Project

Jun 11 2021

inglorion updated the diff for D104061: [LangRef] clarify the meaning of noimplicitfloat.

Also specified that this inhibits the use of SIMD/vector registers
(which is true at least of x86_64 and armv8).

Jun 11 2021, 5:01 PM · Restricted Project

Jun 10 2021

inglorion requested review of D104061: [LangRef] clarify the meaning of noimplicitfloat.
Jun 10 2021, 2:21 PM · Restricted Project

Jun 9 2021

inglorion added a comment to D62639: Fix ABI breakage with noimplicitfloat and varargs functions.

I just uploaded D104001, which makes essentially the same change to the code, but adds some additional rationale and test coverage. I would be happy to have either change move forward. I've added everyone who has commented on this diff to D104001 as well.

Jun 9 2021, 6:16 PM · Restricted Project
inglorion requested review of D104001: [X86] avoid assert with varargs, soft float, and no-implicit-float.
Jun 9 2021, 6:06 PM · Restricted Project

Jan 21 2021

inglorion committed rG8e0b17931530: [ELF] report section sizes when output file too large (authored by inglorion).
[ELF] report section sizes when output file too large
Jan 21 2021, 11:47 AM
inglorion added a comment to D94560: [ELF] report section sizes when output file too large.

Thanks, everyone!

Jan 21 2021, 11:47 AM · Restricted Project
inglorion closed D94560: [ELF] report section sizes when output file too large.
Jan 21 2021, 11:47 AM · Restricted Project

Jan 20 2021

inglorion updated the diff for D94560: [ELF] report section sizes when output file too large.

Thanks again for the comments. I've modified the test to use -NEXT as
requested.

Jan 20 2021, 5:16 PM · Restricted Project

Jan 19 2021

inglorion abandoned D51006: LTO: make tempfiles in LTO cache subject to pruning.

Since D94962 was landed, we don't need this one anymore.

Jan 19 2021, 11:17 AM · Restricted Project

Jan 15 2021

inglorion added a comment to D94560: [ELF] report section sizes when output file too large.

Thanks again.

Jan 15 2021, 4:46 PM · Restricted Project
inglorion updated the diff for D94560: [ELF] report section sizes when output file too large.

implemented MaskRay's suggestions, added tests

Jan 15 2021, 4:16 PM · Restricted Project
inglorion updated the diff for D94560: [ELF] report section sizes when output file too large.

also removed unused Format.h include

Jan 15 2021, 2:11 PM · Restricted Project
inglorion updated the diff for D94560: [ELF] report section sizes when output file too large.

removed now unused <algorithm>

Jan 15 2021, 2:09 PM · Restricted Project
inglorion updated the diff for D94560: [ELF] report section sizes when output file too large.

Indeed, there are not that many output sections. I simplified the code
by removing the sorting and formatting.

Jan 15 2021, 1:05 PM · Restricted Project

Jan 14 2021

inglorion added inline comments to D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for -fthinlto-index=.
Jan 14 2021, 12:35 PM · Restricted Project
inglorion added a comment to D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for -fthinlto-index=.

Can we not just make -gsplit-dwarf set the DwarfFissionKind without also looking at other things? That way, we don't have to worry about detecting the right mix of -g, -g2, -fthinlto-index, -x ir, bitcode input, etc. If there is some reason why this doesn't work, I would also like it to be expressed in a comment in the code so that someone doesn't come along and simplify/break the code later on.

Jan 14 2021, 12:19 PM · Restricted Project
inglorion added a comment to D94560: [ELF] report section sizes when output file too large.

I wonder whether the issue could be better solved by adding something (probably output section sizes as @grimar suggests) to the verbose output?

Jan 14 2021, 12:11 PM · Restricted Project
inglorion added a comment to D94560: [ELF] report section sizes when output file too large.

Thanks for the comments!

Jan 14 2021, 12:05 PM · Restricted Project

Jan 13 2021

inglorion added a comment to D80391: [Driver] Don't make -gsplit-dwarf imply -g2.

For Chrome on Chrome OS, this is https://crbug.com/1158215

Jan 13 2021, 5:45 PM · Restricted Project
inglorion added a comment to D94560: [ELF] report section sizes when output file too large.

As for the specific alternatives you suggested:

Jan 13 2021, 1:45 PM · Restricted Project
inglorion added a comment to D94560: [ELF] report section sizes when output file too large.

My feeling is similar to D94141: use either -M or --noinhibit-exec to get an output.

Jan 13 2021, 1:28 PM · Restricted Project

Jan 12 2021

inglorion requested review of D94560: [ELF] report section sizes when output file too large.
Jan 12 2021, 3:34 PM · Restricted Project
inglorion committed rG6166b91e8371: [ELF][NFCI] small cleanup to OutputSections.h (authored by inglorion).
[ELF][NFCI] small cleanup to OutputSections.h
Jan 12 2021, 3:10 PM
inglorion closed D94538: [ELF][NFCI] small cleanup to OutputSections.h.
Jan 12 2021, 3:10 PM · Restricted Project
inglorion requested review of D94538: [ELF][NFCI] small cleanup to OutputSections.h.
Jan 12 2021, 11:40 AM · Restricted Project

Jun 5 2020

inglorion abandoned D81203: clang-cl: accept -f[no-]data-sections and -f[no-]function-sections.

Ok, thanks for clarifying.

Jun 5 2020, 3:43 PM · Restricted Project

Jun 4 2020

inglorion created D81203: clang-cl: accept -f[no-]data-sections and -f[no-]function-sections.
Jun 4 2020, 4:36 PM · Restricted Project

Apr 16 2020

inglorion committed rGcc5c58889ec6: [WPD] Avoid noalias assumptions in unique return value optimization (authored by inglorion).
[WPD] Avoid noalias assumptions in unique return value optimization
Apr 16 2020, 3:05 PM
inglorion closed D77421: [WPD] Avoid noalias assumptions in unique return value optimization.
Apr 16 2020, 3:05 PM · Restricted Project
inglorion added a comment to D77421: [WPD] Avoid noalias assumptions in unique return value optimization.

Thanks!

Apr 16 2020, 3:04 PM · Restricted Project

Apr 13 2020

inglorion added a comment to D77421: [WPD] Avoid noalias assumptions in unique return value optimization.

@pcc, do you have time for another look?

Apr 13 2020, 12:25 PM · Restricted Project

Apr 8 2020

inglorion added inline comments to D77421: [WPD] Avoid noalias assumptions in unique return value optimization.
Apr 8 2020, 11:57 PM · Restricted Project
inglorion updated the diff for D77421: [WPD] Avoid noalias assumptions in unique return value optimization.

Thanks, Peter! I've implemented your suggestions.

Apr 8 2020, 11:57 PM · Restricted Project
inglorion added a comment to D77421: [WPD] Avoid noalias assumptions in unique return value optimization.

@pcc, do you have time to take a look?

Apr 8 2020, 11:24 AM · Restricted Project

Apr 6 2020

inglorion added a comment to D77421: [WPD] Avoid noalias assumptions in unique return value optimization.

@tejohnson: The defs look like

Apr 6 2020, 11:25 AM · Restricted Project

Apr 3 2020

inglorion updated the diff for D77421: [WPD] Avoid noalias assumptions in unique return value optimization.

Added a comment to (hopefully) better explain what the test does.

Apr 3 2020, 4:49 PM · Restricted Project
inglorion added a comment to D77421: [WPD] Avoid noalias assumptions in unique return value optimization.

@dblaikie: My understanding is that LLVM reserves the right to assume that distinct globals never alias and optimize based on that (e.g. as mentioned under https://releases.llvm.org/10.0.0/docs/AliasAnalysis.html#the-basicaa-pass), and that declaring globals as zero-sized is the accepted way to avoid that (e.g. as mentioned in https://bugs.llvm.org/show_bug.cgi?id=31675#c5).

Apr 3 2020, 4:49 PM · Restricted Project
inglorion created D77421: [WPD] Avoid noalias assumptions in unique return value optimization.
Apr 3 2020, 11:53 AM · Restricted Project

Dec 5 2019

inglorion committed rG055779a9ac11: Revert "[InstCombine] keep assumption before sinking calls" (authored by inglorion).
Revert "[InstCombine] keep assumption before sinking calls"
Dec 5 2019, 10:53 AM
inglorion added a reverting change for rGc3b06d0c393e: [InstCombine] keep assumption before sinking calls: rG055779a9ac11: Revert "[InstCombine] keep assumption before sinking calls".
Dec 5 2019, 10:53 AM
inglorion closed D70933: Revert "[InstCombine] keep assumption before sinking calls".
Dec 5 2019, 10:52 AM · Restricted Project

Dec 3 2019

inglorion updated subscribers of D70933: Revert "[InstCombine] keep assumption before sinking calls".
Dec 3 2019, 3:42 PM · Restricted Project
inglorion updated the diff for D70933: Revert "[InstCombine] keep assumption before sinking calls".

added test that fails without the revert

Dec 3 2019, 3:33 PM · Restricted Project

Dec 2 2019

inglorion added a comment to D70933: Revert "[InstCombine] keep assumption before sinking calls".

@rnk suggested on D70749 to do a simple revert of D69477. That's what this is.

Dec 2 2019, 5:38 PM · Restricted Project
inglorion created D70933: Revert "[InstCombine] keep assumption before sinking calls".
Dec 2 2019, 5:38 PM · Restricted Project
inglorion added a reverting change for rGc3b06d0c393e: [InstCombine] keep assumption before sinking calls: D70933: Revert "[InstCombine] keep assumption before sinking calls".
Dec 2 2019, 5:38 PM
inglorion added a comment to D70749: [InstCombine] do not insert nonnull assumption for undef.

Or just avoid sinking for these cases and do not generate llvm.assume calls.

Dec 2 2019, 2:38 PM · Restricted Project
inglorion added a comment to D70749: [InstCombine] do not insert nonnull assumption for undef.

It seems we have a variety of opinions on the right way to avoid the problem here, and many of them seem to require a fair bit of work. I'm all for getting to better semantics that avoid the problem we're seeing, but agreeing on a course of action, making the changes, testing it, and reviewing it seems like it would take a while. Meanwhile, we have a compiler that miscompiles cout << -10.0; Any chance we can get this change in to stop that from happening while we work on a better fix?

Dec 2 2019, 1:52 PM · Restricted Project

Nov 27 2019

inglorion added a comment to D70749: [InstCombine] do not insert nonnull assumption for undef.

How was DAE able to replace an argument with undef which was fed to strlen? Is that the real bug?

Nov 27 2019, 2:00 PM · Restricted Project
inglorion added a comment to D70749: [InstCombine] do not insert nonnull assumption for undef.

Responding to @jdoerfert's comments:

Nov 27 2019, 7:59 AM · Restricted Project

Nov 26 2019

inglorion added inline comments to D70749: [InstCombine] do not insert nonnull assumption for undef.
Nov 26 2019, 5:39 PM · Restricted Project
inglorion updated the diff for D70749: [InstCombine] do not insert nonnull assumption for undef.

moved undef check above other if statement

Nov 26 2019, 4:52 PM · Restricted Project
inglorion created D70749: [InstCombine] do not insert nonnull assumption for undef.
Nov 26 2019, 4:00 PM · Restricted Project

Oct 25 2019

inglorion accepted D69450: Migrate the annotated buildbots to github.

I'm assuming that addGetSourcecodeSteps takes care of checking out the correct revision. From a cursory look at LLVMBuildFactory and the Buildbot documentation, this appears to be the case.

Oct 25 2019, 3:43 PM

Sep 26 2019

inglorion committed rG4061a9b63a42: [NFC][emacs] remove out-of-date comment from tablegen-mode.el (authored by inglorion).
[NFC][emacs] remove out-of-date comment from tablegen-mode.el
Sep 26 2019, 12:37 PM
inglorion committed rL373008: [NFC][emacs] remove out-of-date comment from tablegen-mode.el.
[NFC][emacs] remove out-of-date comment from tablegen-mode.el
Sep 26 2019, 12:34 PM
inglorion closed D68042: [NFC][emacs] remove out-of-date comment from tablegen-mode.el.
Sep 26 2019, 12:34 PM · Restricted Project

Sep 25 2019

inglorion created D68042: [NFC][emacs] remove out-of-date comment from tablegen-mode.el.
Sep 25 2019, 11:38 AM · Restricted Project
inglorion committed rG75c689f7c825: [emacs] simplify and improve keyword highlighting in tablegen-mode.el (authored by inglorion).
[emacs] simplify and improve keyword highlighting in tablegen-mode.el
Sep 25 2019, 11:16 AM
inglorion committed rL372904: [emacs] simplify and improve keyword highlighting in tablegen-mode.el.
[emacs] simplify and improve keyword highlighting in tablegen-mode.el
Sep 25 2019, 11:14 AM
inglorion closed D68002: [emacs] simplify and improve keyword highlighting in tablegen-mode.el.
Sep 25 2019, 11:14 AM · Restricted Project

Sep 24 2019

inglorion committed rG9f0f36e02231: [ELF] accept thinlto options without --plugin-opt= prefix (authored by inglorion).
[ELF] accept thinlto options without --plugin-opt= prefix
Sep 24 2019, 6:20 PM
inglorion committed rL372798: [ELF] accept thinlto options without --plugin-opt= prefix.
[ELF] accept thinlto options without --plugin-opt= prefix
Sep 24 2019, 6:18 PM
inglorion closed D67782: [ELF] accept thinlto options without --plugin-opt= prefix.
Sep 24 2019, 6:17 PM · Restricted Project
inglorion added a comment to D67782: [ELF] accept thinlto options without --plugin-opt= prefix.

Thanks! Removing unnecessary llvm:: prefix before commit.

Sep 24 2019, 6:17 PM · Restricted Project
inglorion created D68002: [emacs] simplify and improve keyword highlighting in tablegen-mode.el.
Sep 24 2019, 6:15 PM · Restricted Project
inglorion updated the diff for D67782: [ELF] accept thinlto options without --plugin-opt= prefix.

@ruiu's comments (thanks!)

Sep 24 2019, 5:36 PM · Restricted Project
inglorion committed rG19712415a575: [NFC][COFF] fix typo in comment ("algortihm" -> "algorithm") (authored by inglorion).
[NFC][COFF] fix typo in comment ("algortihm" -> "algorithm")
Sep 24 2019, 1:20 PM
inglorion committed rL372776: [NFC][COFF] fix typo in comment ("algortihm" -> "algorithm").
[NFC][COFF] fix typo in comment ("algortihm" -> "algorithm")
Sep 24 2019, 1:16 PM

Sep 20 2019

inglorion updated the diff for D67782: [ELF] accept thinlto options without --plugin-opt= prefix.

@MaskRay's comments. Thanks! I've changed the original code to match.

Sep 20 2019, 1:44 PM · Restricted Project

Sep 19 2019

inglorion created D67782: [ELF] accept thinlto options without --plugin-opt= prefix.
Sep 19 2019, 6:14 PM · Restricted Project

Sep 13 2019

inglorion accepted D67457: lld-link: Make Options.td formatting more self-consistent..

I don't think we should keep flag help texts in sync where it doesn't make sense. "Archive" is posix terminology. It's true that "wholearchive" has "archive" in it, but its help text on msdn is "Include All Library Object Files" :)

Sep 13 2019, 1:42 PM · Restricted Project

Sep 12 2019

inglorion accepted D67295: [COFF] Fix to not add archive name to buffer identifiers when they come from thin archives..

lgtm, thanks!

Sep 12 2019, 1:07 PM · Restricted Project
inglorion updated subscribers of D67457: lld-link: Make Options.td formatting more self-consistent..

The help text for -start-lib and -end-lib matches that in the ELF linker. Please keep those matching by changing it there, too. Also, I think s/library/archive/, so that it matches the naming of -wholearchive.

Sep 12 2019, 11:44 AM · Restricted Project

Sep 3 2019

inglorion committed rG7dc5e7a0a4f4: reland "[lld-link] implement -start-lib and -end-lib" (authored by inglorion).
reland "[lld-link] implement -start-lib and -end-lib"
Sep 3 2019, 1:35 PM
inglorion committed rL370816: reland "[lld-link] implement -start-lib and -end-lib".
reland "[lld-link] implement -start-lib and -end-lib"
Sep 3 2019, 1:34 PM

Aug 30 2019

inglorion committed rGfd7569c8e366: [lld-link] implement -start-lib and -end-lib (authored by inglorion).
[lld-link] implement -start-lib and -end-lib
Aug 30 2019, 9:55 AM
inglorion added a comment to D66848: [lld-link] implement -start-lib and -end-lib.

Implemented ruiu's requests before committing. Thanks for reviewing!

Aug 30 2019, 9:55 AM · Restricted Project
inglorion committed rL370487: [lld-link] implement -start-lib and -end-lib.
[lld-link] implement -start-lib and -end-lib
Aug 30 2019, 9:49 AM
inglorion closed D66848: [lld-link] implement -start-lib and -end-lib.
Aug 30 2019, 9:49 AM · Restricted Project

Aug 29 2019

inglorion updated the diff for D66848: [lld-link] implement -start-lib and -end-lib.
  • allow mixing -start-lib and -wholearchive:
Aug 29 2019, 11:17 AM · Restricted Project

Aug 28 2019

inglorion added inline comments to D66848: [lld-link] implement -start-lib and -end-lib.
Aug 28 2019, 1:32 PM · Restricted Project
inglorion updated the diff for D66848: [lld-link] implement -start-lib and -end-lib.

comments by @ruiu and @MaskRay (thanks!)

  • made AddMode an enum class
  • simplified AddMode computation in OPT_INPUT case
  • added missing std::moves
  • use auto instead of explicitly naming LazyArchive
Aug 28 2019, 1:32 PM · Restricted Project

Aug 27 2019

inglorion added a comment to D66848: [lld-link] implement -start-lib and -end-lib.

Primarily, this change adds a LazyObject Symbol kind, and a LazyObjFile InputFile kind. A LazyObject represents a symbol defined in a LazyObjFile, and a LazyObjFile is either a native object file or a bitcode file that we know of, but have not yet decided to link in. As with the LazyArchive symbols we already had, when we encounter both a lazy symbol and an Undefined symbol, we resolve this by linking in the file that defines the symbol, so the result is a Defined symbol.

Aug 27 2019, 6:11 PM · Restricted Project
inglorion updated the diff for D66848: [lld-link] implement -start-lib and -end-lib.

fix places where I needed to add handling of LazyObject symbols

Aug 27 2019, 6:04 PM · Restricted Project
inglorion planned changes to D66848: [lld-link] implement -start-lib and -end-lib.

Seeing the code here, I see I still need to handle LazyObject in symbol resolution.

Aug 27 2019, 5:17 PM · Restricted Project
inglorion created D66848: [lld-link] implement -start-lib and -end-lib.
Aug 27 2019, 5:17 PM · Restricted Project

Aug 26 2019

inglorion added a reviewer for D66767: Add binary filename to the bitcode filename when using -thinlto-index-only: ruiu.

@ruiu, I'd like your opinion on this.

Aug 26 2019, 4:18 PM · Restricted Project
inglorion added a comment to D66767: Add binary filename to the bitcode filename when using -thinlto-index-only.

Related bug: https://bugs.llvm.org/show_bug.cgi?id=42717

Aug 26 2019, 4:09 PM · Restricted Project

Aug 21 2019

inglorion committed rG5375b94e36b7: [lld-link] implement -lto-obj-path (authored by inglorion).
[lld-link] implement -lto-obj-path
Aug 21 2019, 11:25 AM
inglorion committed rL369559: [lld-link] implement -lto-obj-path.
[lld-link] implement -lto-obj-path
Aug 21 2019, 11:24 AM
inglorion closed D65964: [lld-link] implement -lto-obj-path.
Aug 21 2019, 11:24 AM · Restricted Project

Aug 16 2019

inglorion updated the diff for D65964: [lld-link] implement -lto-obj-path.

changed flag name to -lto-obj-path:

Aug 16 2019, 4:22 PM · Restricted Project

Aug 12 2019

inglorion closed D66037: Remove builder clang-with-thin-lto-windows.

Landed in r368612 / d47622.

Aug 12 2019, 6:07 PM