Page MenuHomePhabricator
Feed Advanced Search

Dec 1 2021

OmerAviram added a comment to D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..

LGTM - will wait at least a day to commit in case there's any other feedback.

Dec 1 2021, 7:24 AM · Restricted Project

Nov 30 2021

OmerAviram updated the diff for D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..
Nov 30 2021, 2:07 AM · Restricted Project

Nov 29 2021

OmerAviram updated the diff for D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..
Nov 29 2021, 8:03 AM · Restricted Project
OmerAviram added a comment to D114575: [X86] Add vector test coverage for or with no common bits tests.

LGTM

Nov 29 2021, 6:41 AM · Restricted Project

Nov 25 2021

OmerAviram updated the diff for D114575: [X86] Add vector test coverage for or with no common bits tests.
Nov 25 2021, 6:46 AM · Restricted Project
OmerAviram updated the diff for D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..
Nov 25 2021, 6:11 AM · Restricted Project
OmerAviram updated the diff for D114575: [X86] Add vector test coverage for or with no common bits tests.
Nov 25 2021, 6:10 AM · Restricted Project
OmerAviram updated the summary of D114575: [X86] Add vector test coverage for or with no common bits tests.
Nov 25 2021, 1:56 AM · Restricted Project
OmerAviram updated the diff for D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..

Added tests for vector types.

Nov 25 2021, 1:55 AM · Restricted Project
OmerAviram requested review of D114575: [X86] Add vector test coverage for or with no common bits tests.
Nov 25 2021, 1:47 AM · Restricted Project

Nov 24 2021

OmerAviram added a comment to D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..

Do we expect all vector types/targets to bypass this in some way? If yes, it's worth adding a comment to the patch description and/or code. If no, can we find a test that shows an asm difference?

Nov 24 2021, 8:01 AM · Restricted Project
OmerAviram added a comment to D114078: [X86] Add tests cases for or-lea with no common bits..

@OmerAviram Do you have commit access?

Nov 24 2021, 4:05 AM · Restricted Project
OmerAviram updated the diff for D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..

Updated diff with i32 and i64 tests.

Nov 24 2021, 1:11 AM · Restricted Project
OmerAviram updated the diff for D114078: [X86] Add tests cases for or-lea with no common bits..
Nov 24 2021, 12:47 AM · Restricted Project

Nov 22 2021

OmerAviram added inline comments to D114078: [X86] Add tests cases for or-lea with no common bits..
Nov 22 2021, 7:05 AM · Restricted Project

Nov 17 2021

OmerAviram updated the diff for D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..

Added tests for the different pattern permutations as a separate patch (https://reviews.llvm.org/D114078) and rebased on it.

Nov 17 2021, 4:59 AM · Restricted Project
OmerAviram requested review of D114078: [X86] Add tests cases for or-lea with no common bits..
Nov 17 2021, 4:50 AM · Restricted Project

Nov 16 2021

OmerAviram updated the diff for D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..

Added ll test for X86 Target.
prior to the patch, the ir included an or instruction:

Nov 16 2021, 6:59 AM · Restricted Project
OmerAviram added reviewers for D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet.: guyblank, alonkom.
Nov 16 2021, 2:34 AM · Restricted Project
OmerAviram requested review of D113970: [SelectionDAG] Add pattern to haveNoCommonBitsSet..
Nov 16 2021, 12:54 AM · Restricted Project