Good catch @jmorse
Jul 24 2018
Jul 23 2018
Added back changes (were lost from commit)
It seems like I have committed the changes to the wrong directory accidentally -- making the build bot fail.
@dberris Could you commit this revision? I'm having some trouble trying to commit the revision
Jul 19 2018
There is an ordering currently (There shouldn't have been)
Sorry for responding so late -- I noticed that this was happening too.
Jul 16 2018
Jul 12 2018
LGTM -- Thanks, @Maknee!
One style comment, and I'm happy to land after that.
You might also want to consider applying for commit access if you would like to continue working on parts of XRay moving forward.
Fixed one liner if statement to not include curly braces
- convert mode checks for differences in header version numbers when parsing/outputting values (to make sure older traces won't generate errors)
Jul 11 2018
Thanks @Maknee -- now if you look in llvm/test/tools/llvm-xray/X86 you'll find some tests for the llvm-xray tool. Also, in the Inputs sub-directory, you'll find sample XRay traces of the old versions. It would be great if you can add version 3 sample binary traces there and add more tests to ensure that we are getting the expected data from the tools handling the newer version(s) of the traces.
Addressed the changes to return statement and curly braces for one liner if statements
- Updated header version 2 -> 3
Jul 10 2018
Ready to land
Changed Pid to PId in XRayRecord
Jul 9 2018
Replaced getpid() with internal_getpid(). Removed TID field from TLD and removed references to the TID field.
- Updating D49025: [XRay] basic mode PID and TID always fetch
- Merge branch 'master' of https://github.com/llvm-project/llvm-project-20170507 into UpdateBasicLoggingPidAndTid