Page MenuHomePhabricator
Feed Advanced Search

Yesterday

stephenneuendorffer accepted D83279: Initial boiler-plate for python bindings..
Wed, Jul 8, 5:30 PM · Restricted Project
stephenneuendorffer accepted D83422: Create TestReducer pass.
Wed, Jul 8, 2:32 PM · Restricted Project

Mon, Jul 6

stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Mon, Jul 6, 11:27 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Mon, Jul 6, 11:07 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D82159: Add a cmake warning when someone tries to configure clang-tools-extra without clang.

I'd advocate for issuing a message (along the lines of "clang-tools-extra is enabled, which depends on 'clang'. Automatically enabling 'clang'." and 'doing the right thing' by enabling clang.
In fact, this seems to be a common enough paradigm that it should be handled in the cmake infrastructure.

Mon, Jul 6, 12:59 PM · Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Mon, Jul 6, 9:59 AM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D80358: [MLIR] Add RegionKindInterface.
Mon, Jul 6, 9:58 AM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D83182: Expand the LLVM Developer Policy to include new sections on adding a project to the LLVM Monorepo, and a second about the LLVM Incubator projects..
Mon, Jul 6, 9:00 AM · Restricted Project

Sun, Jul 5

stephenneuendorffer accepted D83182: Expand the LLVM Developer Policy to include new sections on adding a project to the LLVM Monorepo, and a second about the LLVM Incubator projects..

I suggested a few minor rewrites that bugged me more on a second reading.

Sun, Jul 5, 2:24 PM · Restricted Project

Wed, Jul 1

stephenneuendorffer accepted D83011: [mlir][OpFormatGen] Add support for resolving variadic types from non-variadic.

I don't see anything else obviously wrong, but I don't particularly grok what the code is doing either.

Wed, Jul 1, 9:39 PM · Restricted Project

Mon, Jun 29

stephenneuendorffer added inline comments to D80358: [MLIR] Add RegionKindInterface.
Mon, Jun 29, 11:04 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Mon, Jun 29, 11:04 PM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D80358: [MLIR] Add RegionKindInterface.
Mon, Jun 29, 5:48 PM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D80358: [MLIR] Add RegionKindInterface.
Mon, Jun 29, 4:39 PM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D82803: Create the MLIR Reduce framework.
Mon, Jun 29, 4:39 PM · Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Mon, Jun 29, 4:22 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Mon, Jun 29, 4:22 PM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D80358: [MLIR] Add RegionKindInterface.
Mon, Jun 29, 4:22 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Mon, Jun 29, 4:06 PM · Restricted Project, Restricted Project

Fri, Jun 26

stephenneuendorffer accepted D82666: [mlir] do not hardcode the name of the undefined function in the error message.
Fri, Jun 26, 11:29 AM · Restricted Project

Tue, Jun 23

stephenneuendorffer added a comment to D82371: [mlir] Avoid pontentially ambiguous class name.

Thanks.. I actually just ran into this the other day. I wonder if the standalone dialect example needs to get pushed into a separate namespace (I think it's still in mlir?) to find other places where there is an assumed namespace? I think all tablegen'd code would be alot safer if it always explicitly referred to MLIR classes through ::mlir.

Tue, Jun 23, 12:21 PM · Restricted Project

Thu, Jun 18

stephenneuendorffer added inline comments to D80358: [MLIR] Add RegionKindInterface.
Thu, Jun 18, 8:40 AM · Restricted Project, Restricted Project

Wed, Jun 17

stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Wed, Jun 17, 3:06 PM · Restricted Project, Restricted Project

Tue, Jun 16

stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Tue, Jun 16, 7:11 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D80358: [MLIR] Add RegionKindInterface.

Update after review changes

Tue, Jun 16, 7:10 PM · Restricted Project, Restricted Project

Mon, Jun 15

stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Mon, Jun 15, 11:04 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D80358: [MLIR] Add RegionKindInterface.

Thanks for the careful reviews. It resulted in many updates in the documentation.

Mon, Jun 15, 11:04 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Mon, Jun 15, 11:04 PM · Restricted Project, Restricted Project
stephenneuendorffer accepted D81626: [mlir] [integration-test] [VectorOps] Start an integration test directory for MLIR.

Thanks for this!

Mon, Jun 15, 9:46 AM · Restricted Project

Fri, Jun 12

stephenneuendorffer committed rG8dcf89c3a7ce: [MLIR][cmake] use add_mlir_interface() wherever possible (authored by stephenneuendorffer).
[MLIR][cmake] use add_mlir_interface() wherever possible
Fri, Jun 12, 9:46 AM
stephenneuendorffer closed D81715: [MLIR][cmake] use add_mlir_interface() wherever possible.
Fri, Jun 12, 9:46 AM · Restricted Project

Thu, Jun 11

stephenneuendorffer created D81715: [MLIR][cmake] use add_mlir_interface() wherever possible.
Thu, Jun 11, 11:25 PM · Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Thu, Jun 11, 11:01 PM · Restricted Project, Restricted Project
stephenneuendorffer accepted D81693: Install the MLIRTableGen static library..
Thu, Jun 11, 3:59 PM · Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Thu, Jun 11, 3:59 PM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D81626: [mlir] [integration-test] [VectorOps] Start an integration test directory for MLIR.
Thu, Jun 11, 10:27 AM · Restricted Project
stephenneuendorffer accepted D81545: [cmake] Don't pass -z discard-unused to Illumos ld.

Seems reasonable to me.

Thu, Jun 11, 10:27 AM · Restricted Project
stephenneuendorffer added a comment to D81626: [mlir] [integration-test] [VectorOps] Start an integration test directory for MLIR.

LGTM. My main comment is that I don't know if I see the value of *LOTS* of integration tests. I'm used to using tests like this for design drivers, but it seems like you've tried to get some coverage of the vector dialect here?

Thu, Jun 11, 12:01 AM · Restricted Project

Tue, Jun 9

stephenneuendorffer abandoned D80760: [JitRunner] add support for i32 output.

Changes were merged in a separate diff.

Tue, Jun 9, 11:05 PM · Restricted Project, Restricted Project
stephenneuendorffer committed rGd3ead060befa: [JitRunner] add support for i32 and i64 output (authored by stephenneuendorffer).
[JitRunner] add support for i32 and i64 output
Tue, Jun 9, 10:34 PM
stephenneuendorffer committed rG698462336abb: [MLIR] expose applyCmpPredicate (authored by stephenneuendorffer).
[MLIR] expose applyCmpPredicate
Tue, Jun 9, 10:34 PM
stephenneuendorffer closed D80675: [JitRunner] add support for i32 and i64 output.
Tue, Jun 9, 10:34 PM · Restricted Project, Restricted Project
stephenneuendorffer closed D80609: [MLIR] expose applyCmpPredicate.
Tue, Jun 9, 10:34 PM · Restricted Project, Restricted Project
stephenneuendorffer requested changes to D81526: [mlir] Build a native mlir-linalg-ods-gen when cross-compiling.

My sense is that this could be done more simply? Seems like complex code that shouldn't be proliferated in other places if we can avoid it.

Tue, Jun 9, 9:29 PM · Restricted Project

May 28 2020

stephenneuendorffer updated the diff for D80675: [JitRunner] add support for i32 and i64 output.
May 28 2020, 5:05 PM · Restricted Project, Restricted Project
stephenneuendorffer added a reviewer for D80675: [JitRunner] add support for i32 and i64 output: ftynse.
May 28 2020, 2:52 PM · Restricted Project, Restricted Project
stephenneuendorffer committed rG3bff62d45f83: [mlir] Extend standalone example by standalone-translate (authored by marbre).
[mlir] Extend standalone example by standalone-translate
May 28 2020, 2:20 PM
stephenneuendorffer committed rG8b3155829a99: [MLIR] Fix build when NVPTX is not enabled (authored by stephenneuendorffer).
[MLIR] Fix build when NVPTX is not enabled
May 28 2020, 2:20 PM
stephenneuendorffer closed D80737: [mlir] Extend standalone example by standalone-translate.
May 28 2020, 2:20 PM · Restricted Project
stephenneuendorffer created D80760: [JitRunner] add support for i32 output.
May 28 2020, 2:20 PM · Restricted Project, Restricted Project
stephenneuendorffer added a child revision for D80609: [MLIR] expose applyCmpPredicate: D80760: [JitRunner] add support for i32 output.
May 28 2020, 2:19 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80609: [MLIR] expose applyCmpPredicate.
May 28 2020, 2:19 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D80609: [MLIR] expose applyCmpPredicate.

Would it make sense to put them in the relevant Ops so as not to pollute the mlir:: namespace?

May 28 2020, 2:18 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D80737: [mlir] Extend standalone example by standalone-translate.

Would that be suitable?

May 28 2020, 12:05 PM · Restricted Project
stephenneuendorffer accepted D80737: [mlir] Extend standalone example by standalone-translate.
May 28 2020, 12:05 PM · Restricted Project
stephenneuendorffer added a comment to D80737: [mlir] Extend standalone example by standalone-translate.

Needs a test?

May 28 2020, 9:54 AM · Restricted Project

May 27 2020

stephenneuendorffer added a comment to D79890: [MLIR] Continue renaming of "SideEffects".

@mehdi_amini @rriddle There were multiple commenters who thought it was better to be consistent even if there was further mass renaming involved:
see https://reviews.llvm.org/D79517

May 27 2020, 9:48 PM · Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
May 27 2020, 4:56 PM · Restricted Project, Restricted Project
stephenneuendorffer added a child revision for D80609: [MLIR] expose applyCmpPredicate: D80675: [JitRunner] add support for i32 and i64 output.
May 27 2020, 4:56 PM · Restricted Project, Restricted Project
stephenneuendorffer created D80675: [JitRunner] add support for i32 and i64 output.
May 27 2020, 4:56 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80609: [MLIR] expose applyCmpPredicate.
May 27 2020, 4:56 PM · Restricted Project, Restricted Project

May 26 2020

stephenneuendorffer updated the diff for D80609: [MLIR] expose applyCmpPredicate.
May 26 2020, 11:57 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80609: [MLIR] expose applyCmpPredicate.
May 26 2020, 10:18 PM · Restricted Project, Restricted Project
stephenneuendorffer created D80609: [MLIR] expose applyCmpPredicate.
May 26 2020, 9:15 PM · Restricted Project, Restricted Project

May 22 2020

stephenneuendorffer committed rG0231227e5d8a: Reapply "[lit] GoogleTest framework should report failures if test binary… (authored by stephenneuendorffer).
Reapply "[lit] GoogleTest framework should report failures if test binary…
May 22 2020, 2:30 PM
stephenneuendorffer added a reverting change for rG78dea0e8fb6c: Revert "[lit] GoogleTest framework should report failures if test binary…: rG0231227e5d8a: Reapply "[lit] GoogleTest framework should report failures if test binary….
May 22 2020, 2:30 PM
stephenneuendorffer closed D80389: Revert "Revert "[lit] GoogleTest framework should report failures if test binary crashes"".
May 22 2020, 2:30 PM · Restricted Project

May 21 2020

stephenneuendorffer added a reverting change for rG78dea0e8fb6c: Revert "[lit] GoogleTest framework should report failures if test binary…: D80389: Revert "Revert "[lit] GoogleTest framework should report failures if test binary crashes"".
May 21 2020, 11:21 AM
stephenneuendorffer created D80389: Revert "Revert "[lit] GoogleTest framework should report failures if test binary crashes"".
May 21 2020, 11:21 AM · Restricted Project

May 20 2020

stephenneuendorffer added a comment to D80359: Add a CMake fatal error when someone tries to configure flang without MLIR.

Maybe just add mlir to the list of enabled projects automatically?

May 20 2020, 11:05 PM · Restricted Project
stephenneuendorffer added a reviewer for D80358: [MLIR] Add RegionKindInterface: lattner.
May 20 2020, 10:35 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
May 20 2020, 10:33 PM · Restricted Project, Restricted Project
stephenneuendorffer created D80358: [MLIR] Add RegionKindInterface.
May 20 2020, 10:33 PM · Restricted Project, Restricted Project
stephenneuendorffer committed rGef2103182244: [lit] GoogleTest framework should report failures if test binary crashes (authored by stephenneuendorffer).
[lit] GoogleTest framework should report failures if test binary crashes
May 20 2020, 1:45 PM
stephenneuendorffer closed D80096: [lit] GoogleTest framework should report failures if test binary crashes.
May 20 2020, 1:44 PM · Restricted Project
stephenneuendorffer updated the diff for D80096: [lit] GoogleTest framework should report failures if test binary crashes.
May 20 2020, 1:44 PM · Restricted Project

May 19 2020

stephenneuendorffer added a comment to D80096: [lit] GoogleTest framework should report failures if test binary crashes.
In D80096#2042190, @yln wrote:

The commit message and comment sound reasonable, but I have not further insights. Is it possible to capture the improved behavior with a test?

May 19 2020, 3:27 PM · Restricted Project
stephenneuendorffer updated the diff for D80096: [lit] GoogleTest framework should report failures if test binary crashes.
May 19 2020, 3:27 PM · Restricted Project
stephenneuendorffer committed rG0368c1de9cda: [MLIR][cmake][NFC] Check for incorrect usage of LLVM components in LINK_LIBS (authored by stephenneuendorffer).
[MLIR][cmake][NFC] Check for incorrect usage of LLVM components in LINK_LIBS
May 19 2020, 2:55 PM
stephenneuendorffer committed rGb54635e0ec3d: [MLIR] LLVMMLIRTableGen -> MLIRTableGen (authored by stephenneuendorffer).
[MLIR] LLVMMLIRTableGen -> MLIRTableGen
May 19 2020, 2:55 PM
stephenneuendorffer closed D80103: [cmake][NFC] Check for incorrect usage of LLVM components in LINK_LIBS.
May 19 2020, 2:55 PM · Restricted Project
stephenneuendorffer closed D80102: [MLIR] LLVMMLIRTableGen -> MLIRTableGen.
May 19 2020, 2:55 PM · Restricted Project
stephenneuendorffer added inline comments to D80103: [cmake][NFC] Check for incorrect usage of LLVM components in LINK_LIBS.
May 19 2020, 2:53 PM · Restricted Project

May 18 2020

stephenneuendorffer updated the diff for D80102: [MLIR] LLVMMLIRTableGen -> MLIRTableGen.
May 18 2020, 3:12 PM · Restricted Project
stephenneuendorffer updated the diff for D80103: [cmake][NFC] Check for incorrect usage of LLVM components in LINK_LIBS.
May 18 2020, 3:12 PM · Restricted Project
stephenneuendorffer added a comment to D80141: [IR] Simplify BasicBlock::removePredecessor. NFCI..

This is less clear to me, since it's not clear to me what the original code is trying to do with all the special cases. LGTM, but I'm not an expert in this code.

May 18 2020, 2:39 PM · Restricted Project
stephenneuendorffer added a reviewer for D80103: [cmake][NFC] Check for incorrect usage of LLVM components in LINK_LIBS: beanz.
May 18 2020, 10:47 AM · Restricted Project
stephenneuendorffer accepted D80128: [IR] Revert r2694 in BasicBlock::removePredecessor.

Huzzah! Code simplification!

May 18 2020, 10:13 AM · Restricted Project

May 17 2020

stephenneuendorffer created D80103: [cmake][NFC] Check for incorrect usage of LLVM components in LINK_LIBS.
May 17 2020, 11:24 PM · Restricted Project
stephenneuendorffer added reviewers for D80103: [cmake][NFC] Check for incorrect usage of LLVM components in LINK_LIBS: mehdi_amini, tstellar.
May 17 2020, 11:24 PM · Restricted Project
stephenneuendorffer added a child revision for D80102: [MLIR] LLVMMLIRTableGen -> MLIRTableGen: D80103: [cmake][NFC] Check for incorrect usage of LLVM components in LINK_LIBS.
May 17 2020, 11:24 PM · Restricted Project
stephenneuendorffer created D80102: [MLIR] LLVMMLIRTableGen -> MLIRTableGen.
May 17 2020, 11:24 PM · Restricted Project
stephenneuendorffer committed rGd6b3b8a1a3c1: [MLIR][cmake] Fix unittest/Tablegen by special casing LLVMMLIRTableGen (authored by stephenneuendorffer).
[MLIR][cmake] Fix unittest/Tablegen by special casing LLVMMLIRTableGen
May 17 2020, 6:06 PM
stephenneuendorffer closed D80093: [MLIR][cmake] Fix unittest/Tablegen by special casing LLVMMLIRTableGen.
May 17 2020, 6:06 PM · Restricted Project
stephenneuendorffer added a reviewer for D80096: [lit] GoogleTest framework should report failures if test binary crashes: mehdi_amini.
May 17 2020, 6:05 PM · Restricted Project
stephenneuendorffer created D80096: [lit] GoogleTest framework should report failures if test binary crashes.
May 17 2020, 6:05 PM · Restricted Project
stephenneuendorffer created D80093: [MLIR][cmake] Fix unittest/Tablegen by special casing LLVMMLIRTableGen.
May 17 2020, 3:58 PM · Restricted Project
stephenneuendorffer committed rGf88c7fe46b37: [MLIR][cmake][NFC] Update linkage checker for mlir-opt (authored by stephenneuendorffer).
[MLIR][cmake][NFC] Update linkage checker for mlir-opt
May 17 2020, 2:23 PM
stephenneuendorffer committed rG37ce8d6ade24: [MLIR] Fix linkage for libMLIR.so (authored by stephenneuendorffer).
[MLIR] Fix linkage for libMLIR.so
May 17 2020, 2:23 PM
stephenneuendorffer closed D80076: [MLIR] Fix linkage for libMLIR.so.
May 17 2020, 2:23 PM · Restricted Project