Sep 4 2019
Jul 30 2019
Thanks for working on this! 😁
Jul 29 2019
Current version looks great to me! 😁
Jul 26 2019
I added a few links to LLVM documentation here and wondered what to do with them, if this gets cherry-picked to release/9.x, e.g. https://llvm.org/docs/CMake.html Ideally they would point to their 9.x counterparts, e.g. https://releases.llvm.org/9.0.0/docs/CMake.html and with 9.0.1 it should become https://releases.llvm.org/9.0.1/docs/CMake.html
llvm/docs/AdvancedBuilds.rst links within one build directory using ":doc:CMake", but apparently this doesn't work cross-project?
I could imaging to patch it once for the release and use configure_file from CMake to import the current version, but I am no sure if it's worth the effort =)
Is there a simple way to do this in Sphinx? Ideas / opinions?
Cool, patch Diff 211951 has the change. Here's the difference in generated output:
Since Visual Studio is the only section in Building LLDB with CMake and Other Generators now, I would like to:
- move it merge it with another one, preferably Common CMake options > Windows
- rename Building LLDB with CMake & Ninja into Building LLDB with CMake (analog and with a link to http://llvm.org/docs/CMake.html)
Would that be acceptable?
Great! 😁 Thanks for working on this!
In general, this looks great overall! I added few comments on things that would be good to clarify.
May 30 2019
May 23 2019
May 20 2019
I don't currently have commit access, so I would need someone to land this for me assuming it's approved. If it would be easier for me to submit separate patches for the llvm and clang changes, please let me know! 😄
May 17 2019
Thanks for the review @JDevlieghere! 😄 This should be ready for another look. I don't have commit access yet, so assuming it's approved, please commit when you have time.
Updated to remove the whole section
May 16 2019
May 15 2019
May 14 2019
Thanks for the review! 😄 I don't have commit access yet, so could you please commit this for me?
Thanks all for the review! 😄
Updated to support old project layout as well