Page MenuHomePhabricator
Feed Advanced Search

Sep 4 2019

jryans committed rL370993: Request commit access for jryans.
Request commit access for jryans
Sep 4 2019, 3:36 PM

Jul 30 2019

jryans accepted D65437: [lldb][docs] Update landing page for monorepo.

Thanks for working on this! 馃榿

Jul 30 2019, 6:34 AMRestricted Project, Restricted Project

Jul 29 2019

jryans accepted D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Current version looks great to me! 馃榿

Jul 29 2019, 7:36 AMRestricted Project, Restricted Project

Jul 26 2019

jryans added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Where did you find the sub-project list of versioned docs?

Jul 26 2019, 10:06 AMRestricted Project, Restricted Project
jryans accepted D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

I added a few links to LLVM documentation here and wondered what to do with them, if this gets cherry-picked to release/9.x, e.g. https://llvm.org/docs/CMake.html Ideally they would point to their 9.x counterparts, e.g. https://releases.llvm.org/9.0.0/docs/CMake.html and with 9.0.1 it should become https://releases.llvm.org/9.0.1/docs/CMake.html

llvm/docs/AdvancedBuilds.rst links within one build directory using ":doc:CMake", but apparently this doesn't work cross-project?

I could imaging to patch it once for the release and use configure_file from CMake to import the current version, but I am no sure if it's worth the effort =)

Is there a simple way to do this in Sphinx? Ideas / opinions?

Jul 26 2019, 9:42 AMRestricted Project, Restricted Project
jryans added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.
Jul 26 2019, 9:36 AMRestricted Project, Restricted Project
jryans added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Since Visual Studio is the only section in Building LLDB with CMake and Other Generators now, I would like to:

  • move it merge it with another one, preferably Common CMake options > Windows
  • rename Building LLDB with CMake & Ninja into Building LLDB with CMake (analog and with a link to http://llvm.org/docs/CMake.html)

    Would that be acceptable?
Jul 26 2019, 7:11 AMRestricted Project, Restricted Project
jryans accepted D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Great! 馃榿 Thanks for working on this!

Jul 26 2019, 6:44 AMRestricted Project, Restricted Project
jryans added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

In general, this looks great overall! I added few comments on things that would be good to clarify.

Jul 26 2019, 6:07 AMRestricted Project, Restricted Project

May 30 2019

jryans committed rGd45eaf9405c8: [Docs] Modernize references to macOS (authored by jryans).
[Docs] Modernize references to macOS
May 30 2019, 11:13 AM
jryans committed rUNW362113: [Docs] Modernize references to macOS.
[Docs] Modernize references to macOS
May 30 2019, 11:13 AM
jryans committed rCXX362113: [Docs] Modernize references to macOS.
[Docs] Modernize references to macOS
May 30 2019, 11:13 AM
jryans committed rLLD362113: [Docs] Modernize references to macOS.
[Docs] Modernize references to macOS
May 30 2019, 11:13 AM
jryans committed rL362113: [Docs] Modernize references to macOS.
[Docs] Modernize references to macOS
May 30 2019, 11:12 AM
jryans committed rLLDB362113: [Docs] Modernize references to macOS.
[Docs] Modernize references to macOS
May 30 2019, 11:12 AM
jryans committed rC362113: [Docs] Modernize references to macOS.
[Docs] Modernize references to macOS
May 30 2019, 11:12 AM
jryans closed D62654: [Docs] Modernize references to macOS.
May 30 2019, 11:12 AMRestricted Project, Restricted Project, Restricted Project, Restricted Project
jryans created D62654: [Docs] Modernize references to macOS.
May 30 2019, 5:22 AMRestricted Project, Restricted Project, Restricted Project, Restricted Project

May 23 2019

jryans committed rGb4cb7d8045e3: [NFC] Add blank line (test commit) (authored by jryans).
[NFC] Add blank line (test commit)
May 23 2019, 2:14 PM
jryans committed rL361555: [NFC] Add blank line (test commit).
[NFC] Add blank line (test commit)
May 23 2019, 2:14 PM
jryans committed rLLDB361555: [NFC] Add blank line (test commit).
[NFC] Add blank line (test commit)
May 23 2019, 2:14 PM

May 20 2019

jryans added a comment to D62138: [Docs] Increase Doxygen cache size.

I don't currently have commit access, so I would need someone to land this for me assuming it's approved. If it would be easier for me to submit separate patches for the llvm and clang changes, please let me know! 馃槃

May 20 2019, 6:37 AMRestricted Project, Restricted Project
jryans added reviewers for D62138: [Docs] Increase Doxygen cache size: hintonda, jmorse.
May 20 2019, 6:07 AMRestricted Project, Restricted Project
jryans created D62138: [Docs] Increase Doxygen cache size.
May 20 2019, 5:59 AMRestricted Project, Restricted Project

May 17 2019

jryans added a comment to D62041: [Docs] Remove SVN checkout from LLDB build steps.

Thanks for the review @JDevlieghere! 馃槃 This should be ready for another look. I don't have commit access yet, so assuming it's approved, please commit when you have time.

May 17 2019, 1:58 AMRestricted Project, Restricted Project
jryans updated the diff for D62041: [Docs] Remove SVN checkout from LLDB build steps.

Updated to remove the whole section

May 17 2019, 1:55 AMRestricted Project, Restricted Project

May 16 2019

jryans created D62041: [Docs] Remove SVN checkout from LLDB build steps.
May 16 2019, 3:38 PMRestricted Project, Restricted Project

May 15 2019

jryans added a comment to D61877: [CMake] Add error to clarify that lldb requires libcxx.

@sgraenitz Thanks for committing! 馃槃 I guess the original author info is lost for this one, but consider adding a "Patch by" line for future commits from those without access.

May 15 2019, 4:49 AMRestricted Project, Restricted Project

May 14 2019

jryans added a comment to D61877: [CMake] Add error to clarify that lldb requires libcxx.

Thanks for the review! 馃槃 I don't have commit access yet, so could you please commit this for me?

May 14 2019, 9:26 AMRestricted Project, Restricted Project
jryans added a comment to D61877: [CMake] Add error to clarify that lldb requires libcxx.

Thanks all for the review! 馃槃

May 14 2019, 4:00 AMRestricted Project, Restricted Project
jryans updated the diff for D61877: [CMake] Add error to clarify that lldb requires libcxx.

Updated to support old project layout as well

May 14 2019, 3:50 AMRestricted Project, Restricted Project

May 13 2019

jryans created D61877: [CMake] Add error to clarify that lldb requires libcxx.
May 13 2019, 4:23 PMRestricted Project, Restricted Project