Page MenuHomePhabricator
Feed Advanced Search

Yesterday

wallace updated the diff for D100740: [trace] Dedup different source lines when dumping instructions + refactor.

address comments

Tue, May 4, 9:16 AM · Restricted Project
wallace added inline comments to D100740: [trace] Dedup different source lines when dumping instructions + refactor.
Tue, May 4, 9:15 AM · Restricted Project
wallace updated the diff for D101128: [lldb-vscode] only report long running progress events.

nits

Tue, May 4, 8:35 AM · Restricted Project

Mon, May 3

wallace updated the diff for D101128: [lldb-vscode] only report long running progress events.

Address all comments

Mon, May 3, 10:55 PM · Restricted Project
wallace updated the diff for D100740: [trace] Dedup different source lines when dumping instructions + refactor.

nit

Mon, May 3, 10:32 AM · Restricted Project
wallace updated the diff for D100740: [trace] Dedup different source lines when dumping instructions + refactor.

Address all comments

Mon, May 3, 10:30 AM · Restricted Project
wallace abandoned D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.
Mon, May 3, 7:55 AM · Restricted Project
wallace accepted D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.
Mon, May 3, 7:54 AM · Restricted Project
wallace updated the diff for D101128: [lldb-vscode] only report long running progress events.

Address all comments

Mon, May 3, 7:46 AM · Restricted Project

Thu, Apr 29

wallace added inline comments to D101128: [lldb-vscode] only report long running progress events.
Thu, Apr 29, 9:32 PM · Restricted Project
wallace closed D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely.
Thu, Apr 29, 6:46 PM · Restricted Project

Wed, Apr 28

wallace abandoned D101198: [lldb-vscode] Read requests asynchronously.

i'll rather focus on parallelizing symbol preloading

Wed, Apr 28, 3:29 PM · Restricted Project

Tue, Apr 27

wallace added inline comments to D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely.
Tue, Apr 27, 8:51 PM · Restricted Project
wallace updated the diff for D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely.

now checking if the strings gotten from the API are null or not

Tue, Apr 27, 4:06 PM · Restricted Project

Fri, Apr 23

wallace requested review of D101198: [lldb-vscode] Read requests asynchronously.
Fri, Apr 23, 1:36 PM · Restricted Project
wallace added inline comments to D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely.
Fri, Apr 23, 10:28 AM · Restricted Project
wallace added a comment to D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely.

TIL. I'll give it a try

Fri, Apr 23, 9:09 AM · Restricted Project

Thu, Apr 22

wallace added inline comments to D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console.
Thu, Apr 22, 9:30 PM · Restricted Project
wallace requested review of D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely.
Thu, Apr 22, 9:27 PM · Restricted Project
wallace retitled D100740: [trace] Dedup different source lines when dumping instructions + refactor from json to [trace] Dedup different source lines when dumping instructions + refactor.
Thu, Apr 22, 9:20 PM · Restricted Project
wallace abandoned D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message.

not needed anymore because of D99974

Thu, Apr 22, 9:18 PM · Restricted Project
wallace commandeered D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message.
Thu, Apr 22, 9:18 PM · Restricted Project
wallace abandoned D70882: Add environment var LLDBVSCODE_SKIP_INIT_FILES to lldb-vscode.

not needed anymore because of D99974

Thu, Apr 22, 9:17 PM · Restricted Project
wallace commandeered D70882: Add environment var LLDBVSCODE_SKIP_INIT_FILES to lldb-vscode.
Thu, Apr 22, 9:17 PM · Restricted Project
wallace added reviewers for D101128: [lldb-vscode] only report long running progress events: clayborg, kusmour.
Thu, Apr 22, 8:04 PM · Restricted Project
wallace requested review of D101128: [lldb-vscode] only report long running progress events.
Thu, Apr 22, 8:04 PM · Restricted Project
wallace added inline comments to D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.
Thu, Apr 22, 7:54 PM · Restricted Project
wallace added a comment to rG18a85276426b: [trace][intel-pt] Fix a crash on unconsumed Expected's Error.

Thanks!! Let me know if you have any other issues with the existing code.

Thu, Apr 22, 7:44 PM

Wed, Apr 21

wallace committed rG875654f897ac: Fix VSCode/TestOptions.test (authored by wallace).
Fix VSCode/TestOptions.test
Wed, Apr 21, 3:46 PM
wallace committed rGc4a83c4e69f1: Fix TestVSCode_runInTerminal (authored by wallace).
Fix TestVSCode_runInTerminal
Wed, Apr 21, 3:22 PM
wallace committed rGc9a0754b443b: [lldb-vscode] Distinguish shadowed variables in the scopes request (authored by wallace).
[lldb-vscode] Distinguish shadowed variables in the scopes request
Wed, Apr 21, 3:10 PM
wallace closed D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.
Wed, Apr 21, 3:09 PM · Restricted Project
wallace closed D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console.
Wed, Apr 21, 3:06 PM · Restricted Project
wallace committed rG64f47c1e58a1: [lldb-vscode] redirect stderr/stdout to the IDE's console (authored by wallace).
[lldb-vscode] redirect stderr/stdout to the IDE's console
Wed, Apr 21, 2:49 PM
wallace committed rG12a25076463d: Fix TestVSCode_launch test (authored by wallace).
Fix TestVSCode_launch test
Wed, Apr 21, 2:34 PM
wallace updated the diff for D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console.

rebase

Wed, Apr 21, 2:24 PM · Restricted Project
wallace committed rG79fbbeb41280: [lldb-vscode] Add postRunCommands (authored by wallace).
[lldb-vscode] Add postRunCommands
Wed, Apr 21, 1:51 PM
wallace closed D100340: [lldb-vscode] Add postRunCommands.
Wed, Apr 21, 1:51 PM · Restricted Project

Tue, Apr 20

wallace updated the diff for D100740: [trace] Dedup different source lines when dumping instructions + refactor.

ready for review

Tue, Apr 20, 4:32 PM · Restricted Project
wallace retitled D100740: [trace] Dedup different source lines when dumping instructions + refactor from json to [trace] Dedup different source lines when dumping instructions + refactor.
Tue, Apr 20, 4:32 PM · Restricted Project

Sun, Apr 18

wallace planned changes to D100740: [trace] Dedup different source lines when dumping instructions + refactor.
Sun, Apr 18, 11:51 PM · Restricted Project
wallace updated the diff for D100740: [trace] Dedup different source lines when dumping instructions + refactor.
Sun, Apr 18, 11:51 PM · Restricted Project
wallace planned changes to D100740: [trace] Dedup different source lines when dumping instructions + refactor.
Sun, Apr 18, 11:09 PM · Restricted Project
wallace requested review of D100740: [trace] Dedup different source lines when dumping instructions + refactor.
Sun, Apr 18, 11:09 PM · Restricted Project

Wed, Apr 14

wallace committed rGcc88d301a0bc: [lldb-vscode] Reduce chattiness of progress events (authored by wallace).
[lldb-vscode] Reduce chattiness of progress events
Wed, Apr 14, 1:00 PM
wallace closed D100443: [lldb-vscode] Reduce chattiness of progress events.
Wed, Apr 14, 1:00 PM · Restricted Project

Tue, Apr 13

wallace added inline comments to D100443: [lldb-vscode] Reduce chattiness of progress events.
Tue, Apr 13, 10:01 PM · Restricted Project
wallace updated the summary of D100443: [lldb-vscode] Reduce chattiness of progress events.
Tue, Apr 13, 9:52 PM · Restricted Project
wallace requested review of D100443: [lldb-vscode] Reduce chattiness of progress events.
Tue, Apr 13, 9:50 PM · Restricted Project

Mon, Apr 12

wallace updated the diff for D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console.

updated minor python detail

Mon, Apr 12, 1:29 PM · Restricted Project
wallace updated the diff for D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.

Address comments

Mon, Apr 12, 1:26 PM · Restricted Project
wallace added a reviewer for D100340: [lldb-vscode] Add postRunCommands: kusmour.
Mon, Apr 12, 1:09 PM · Restricted Project
wallace requested review of D100340: [lldb-vscode] Add postRunCommands.
Mon, Apr 12, 1:05 PM · Restricted Project

Wed, Apr 7

wallace updated the summary of D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.
Wed, Apr 7, 11:36 AM · Restricted Project
wallace updated the diff for D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.

Some changes:

Wed, Apr 7, 11:35 AM · Restricted Project
wallace updated the diff for D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console.

Address comments

Wed, Apr 7, 10:00 AM · Restricted Project

Tue, Apr 6

wallace updated the summary of D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.
Tue, Apr 6, 1:32 PM · Restricted Project
wallace requested review of D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request.
Tue, Apr 6, 1:30 PM · Restricted Project
wallace updated the summary of D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console.
Tue, Apr 6, 10:49 AM · Restricted Project
wallace updated the summary of D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console.
Tue, Apr 6, 10:49 AM · Restricted Project
wallace updated the summary of D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console.
Tue, Apr 6, 10:42 AM · Restricted Project
wallace requested review of D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console.
Tue, Apr 6, 10:29 AM · Restricted Project

Mar 31 2021

wallace accepted D99701: [lldb-vscode] Consistently use return EXIT_SUCCESS and EXIT_FAILURE (NFC).
Mar 31 2021, 9:33 PM · Restricted Project
wallace accepted D99702: [lldb-vscode] Use LLVM's ScopeExit to ensure we always terminate the debugger.
Mar 31 2021, 9:32 PM · Restricted Project

Mar 30 2021

wallace committed rGa4ee79c8ae5c: Fix errors in 0b69756110db444282c40ea16929186b2910c3b1 (authored by wallace).
Fix errors in 0b69756110db444282c40ea16929186b2910c3b1
Mar 30 2021, 6:03 PM
wallace committed rG0b69756110db: [trace][intel-pt] Implement trace start and trace stop (authored by wallace).
[trace][intel-pt] Implement trace start and trace stop
Mar 30 2021, 5:32 PM
wallace closed D91679: [trace][intel-pt] Implement trace start and trace stop.
Mar 30 2021, 5:31 PM · Restricted Project
wallace added a comment to D91679: [trace][intel-pt] Implement trace start and trace stop.

I like that idea, but i'd rather do it in a different patch once we have a second stop event, so that I make sure the entire thing makes sense.

Mar 30 2021, 5:06 PM · Restricted Project
wallace updated the diff for D91679: [trace][intel-pt] Implement trace start and trace stop.

Addresses all issues, following our offline discussion.

Mar 30 2021, 2:50 PM · Restricted Project

Mar 29 2021

wallace accepted D99535: [lldb] Print stack trace when lldb-vscode crashes.
Mar 29 2021, 2:18 PM · Restricted Project

Mar 25 2021

wallace updated the summary of D91679: [trace][intel-pt] Implement trace start and trace stop.
Mar 25 2021, 9:57 PM · Restricted Project
wallace updated the summary of D91679: [trace][intel-pt] Implement trace start and trace stop.
Mar 25 2021, 9:55 PM · Restricted Project
wallace updated the diff for D91679: [trace][intel-pt] Implement trace start and trace stop.

Updates in the diff description

Mar 25 2021, 9:53 PM · Restricted Project

Mar 18 2021

wallace reclaimed D91679: [trace][intel-pt] Implement trace start and trace stop.

Changed my mind :)

Mar 18 2021, 12:21 PM · Restricted Project
wallace abandoned D91679: [trace][intel-pt] Implement trace start and trace stop.

I'll redo this diff in smaller diffs

Mar 18 2021, 11:17 AM · Restricted Project

Mar 15 2021

wallace updated the diff for D98656: [lldb-vscode] Handle request_evaluate's context attribute.

address comment

Mar 15 2021, 3:05 PM · Restricted Project
wallace requested review of D98656: [lldb-vscode] Handle request_evaluate's context attribute.
Mar 15 2021, 1:08 PM · Restricted Project

Mar 5 2021

wallace added a comment to D97739: Add a progress class that can track and report long running operations that happen in LLDB..

I think that the mechanism used to show progress should be lock-free and mostly unblocked, as it's merely an observer without side effects within LLDB. So from the last thing you said it seems that SBEvent doesn't like a good solution.

Mar 5 2021, 3:07 PM · Restricted Project
wallace added a comment to D97739: Add a progress class that can track and report long running operations that happen in LLDB..

I'm quite happy with it besides the multiple callback thing.

Mar 5 2021, 11:01 AM · Restricted Project

Mar 4 2021

wallace added a comment to D97739: Add a progress class that can track and report long running operations that happen in LLDB..

This looks really nice. The only thought I have is that you should accept multiple callbacks instead of only one, as the current implementation discards any existing callback if SetProgressCallback is called twice. I know that it'd be rare that two or more callbacks are registered simultaneously, but it might happen in the future and you could save someone's time by making this a little bit more flexible.

Mar 4 2021, 1:43 PM · Restricted Project

Feb 4 2021

wallace updated subscribers of D96060: [lldb-vscode] correctly use Windows macros.

I don't feel knowledgeable enough to backport the commit, so if you can do
it, it would be great :)

Feb 4 2021, 4:11 PM · Restricted Project
wallace committed rG36496cc2992d: [lldb-vscode] correctly use Windows macros (authored by wallace).
[lldb-vscode] correctly use Windows macros
Feb 4 2021, 11:04 AM
wallace closed D96060: [lldb-vscode] correctly use Windows macros.
Feb 4 2021, 11:03 AM · Restricted Project
wallace requested review of D96060: [lldb-vscode] correctly use Windows macros.
Feb 4 2021, 10:09 AM · Restricted Project

Jan 28 2021

wallace committed rG0bca9a7ce2ee: Fix lldb-vscode builds on Windows targeting POSIX (authored by wallace).
Fix lldb-vscode builds on Windows targeting POSIX
Jan 28 2021, 9:36 AM

Jan 27 2021

wallace added a comment to rGab5591e1d8f5: Fix runInTerminal failures on Windows.

Damn, I gotta fix that

Jan 27 2021, 3:29 PM
wallace added a comment to rGab5591e1d8f5: Fix runInTerminal failures on Windows.

I think that's because I'm not running all the tests for Debug builds, as they would timeout. I've noticed that an error is due to the use of capture_output when doing Popen, but I use subprocess in other places as well for this feature, so I want to first set up my environment for using python3.6 and making sure everything works well.

Jan 27 2021, 1:29 PM
wallace added a comment to D93951: [vscode] Improve runInTerminal and support linux.

@stella.stamenova , I've just pushed a fix. Let me know if it actually works.

Jan 27 2021, 1:17 PM · Restricted Project
wallace committed rGab5591e1d8f5: Fix runInTerminal failures on Windows (authored by wallace).
Fix runInTerminal failures on Windows
Jan 27 2021, 1:17 PM
wallace added a comment to D93951: [vscode] Improve runInTerminal and support linux.

Good to know. I'll work on that right now. Thanks!

Jan 27 2021, 11:49 AM · Restricted Project

Jan 26 2021

wallace added inline comments to D91679: [trace][intel-pt] Implement trace start and trace stop.
Jan 26 2021, 6:33 PM · Restricted Project
wallace added a comment to D93951: [vscode] Improve runInTerminal and support linux.

I'll send a diff tomorrow morning

Jan 26 2021, 3:30 PM · Restricted Project
wallace added a comment to D93951: [vscode] Improve runInTerminal and support linux.

@stella.stamenova , is that build a Debug or Release build? I think that will help me determine why it's failing

Jan 26 2021, 2:38 PM · Restricted Project
wallace updated the diff for D91679: [trace][intel-pt] Implement trace start and trace stop.

clang-format

Jan 26 2021, 9:46 AM · Restricted Project
wallace updated the diff for D91679: [trace][intel-pt] Implement trace start and trace stop.

rebase and fix compile error on Darwin

Jan 26 2021, 9:34 AM · Restricted Project

Jan 25 2021

wallace committed rG50337fb933e0: Fix runInTerminal errors on ARM (authored by wallace).
Fix runInTerminal errors on ARM
Jan 25 2021, 2:55 PM
wallace updated subscribers of D93951: [vscode] Improve runInTerminal and support linux.

I've already submitted a fix, let's see if the buildbot gets fixed

Jan 25 2021, 2:30 PM · Restricted Project
wallace closed D93874: [process] fix exec support on Linux.
Jan 25 2021, 2:10 PM · Restricted Project
wallace committed rG1ac36b34db81: Fix 0f0462cacf34aa88ae71a13c4199c1b1e70f3ee6 (authored by wallace).
Fix 0f0462cacf34aa88ae71a13c4199c1b1e70f3ee6
Jan 25 2021, 2:06 PM
wallace committed rG12049d888595: Fix 0f0462cacf34aa88ae71a13c4199c1b1e70f3ee6 (authored by wallace).
Fix 0f0462cacf34aa88ae71a13c4199c1b1e70f3ee6
Jan 25 2021, 1:25 PM