more code review updates. pulled main.

pulled upstream/main

change formatting of enum options

a unit test was failing, so I fixed it.

there were a couple of bugs in the last patch that I missed. format tests all pass again with this one.

changing the added option from a boolean to an enum that takes Leave, Always, and Never.

In D125171#4261301, @MyDeveloperDay wrote:

is it possible to point to a github issue that this related to in the review summary, if not please can you make one so we can track the issue its trying to solve

fix a comment in the documentation

• updated the documentation to show the option works for function declaration and definition

• updated the tests to use long-form
• added new tests to verify the no-parameter cases
• updated the documentation to minimize formatting variables
• ran the style guide generator

In D125171#4230397, @jrmolin wrote:

I think I have hit all the requests now. We're in the middle of building release candidates and testing, so management is taking longer and longer to get back to me about a style guide for my team.

We added it, because it forces a consistent look across all function declarations. I don't know what the next steps are now. I'm stuck; you're stuck. :shrug:

I think I have hit all the requests now. We're in the middle of building release candidates and testing, so management is taking longer and longer to get back to me about a style guide for my team.

ran the formatter, ran the documentation generator.

pulled main, re-generated the docs, then re-generated the diff. Also added a parse test and collapsed some nested if conditions.

In D125171#4215910, @MyDeveloperDay wrote:

if you go ahead an rebase your should get rG7a5b95732ade: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date that will remove the need for the Macro section in the rst

I still don't know what Please write it out long form means for the unit test.

I updated the code comment in Format.h and ran the docs generator. I didn't modify the Macros section, but that got updated when I ran the docs generator.

In D125171#4195298, @owenpan wrote:

In D125171#4193996, @jrmolin wrote:

In D125171#4167866, @owenpan wrote:

Please see https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options.

I am doing this for my team, which writes the security endpoint for Elastic Defend. The code is currently private, though the binaries are free to download and run. The number of contributors is around 30, and the lines of code is in the 100Ks (around 500K). I have not found a way to accomplish what this does with the available options. I am adding tests and am happy to maintain this. It is a rather small addition, so it is quite simple to keep updated.

Do you "have a publicly accessible style guide"?

respond to code review requests/comments

In D125171#4167866, @owenpan wrote:

Please see https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options.

Finally figured out how to run the latest git-clang-format on the code

I finally found the correct CodeOwners.rst file.

Updated the version string in the docs and pulled in main.