Page MenuHomePhabricator
Feed Advanced Search

Aug 20 2019

jlpeyton committed rG57ae6b8e377c: Force honoring nthreads-var and thread-limit-var inside teams construct on host (authored by jlpeyton).
Force honoring nthreads-var and thread-limit-var inside teams construct on host
Aug 20 2019, 12:45 PM
jlpeyton committed rL369430: Force honoring nthreads-var and thread-limit-var inside teams construct on host.
Force honoring nthreads-var and thread-limit-var inside teams construct on host
Aug 20 2019, 12:38 PM
jlpeyton closed D66351: Force runtime to honor nthreads-var and thread-limit-var inside the teams construct on host..
Aug 20 2019, 12:38 PM · Restricted Project, Restricted Project

Aug 13 2019

jlpeyton accepted D65867: [RFC] [OpenMP] Turn on -Wall compiler warnings by default.

LGTM

Aug 13 2019, 11:37 AM · Restricted Project, Restricted Project
jlpeyton added inline comments to D65867: [RFC] [OpenMP] Turn on -Wall compiler warnings by default.
Aug 13 2019, 10:48 AM · Restricted Project, Restricted Project
jlpeyton added inline comments to D65867: [RFC] [OpenMP] Turn on -Wall compiler warnings by default.
Aug 13 2019, 9:00 AM · Restricted Project, Restricted Project

Aug 12 2019

jlpeyton added a comment to D65867: [RFC] [OpenMP] Turn on -Wall compiler warnings by default.

Thanks for this cleanup! Just one comment.

Aug 12 2019, 11:38 AM · Restricted Project, Restricted Project
jlpeyton requested changes to D65868: [OpenMP] Remove workaround for CMPXCHG.

Unfortunately, the Windows atomic code will not compile with this change. See in kmp_atomic.h the different atomic types for Windows. The complaints are regarding assignment operations for the complex types.

../../src/kmp_atomic.cpp(1325): error: class "__kmp_cmplx32_t" has no suitable assignment operator
  ATOMIC_CMPXCHG(cmplx4, add, kmp_cmplx32, 64, +, 8c, 7,
  ^
Aug 12 2019, 11:34 AM · Restricted Project
jlpeyton accepted D65870: [OpenMP] Remove 'unnecessary parentheses'.

LGTM

Aug 12 2019, 10:39 AM · Restricted Project, Restricted Project

Aug 5 2019

jlpeyton committed rG73d5abd8096b: [OpenMP] Add support for GOMP_*_nonmonotonic_* functions (authored by jlpeyton).
[OpenMP] Add support for GOMP_*_nonmonotonic_* functions
Aug 5 2019, 4:24 PM
jlpeyton committed rL367949: [OpenMP] Add support for GOMP_*_nonmonotonic_* functions.
[OpenMP] Add support for GOMP_*_nonmonotonic_* functions
Aug 5 2019, 4:24 PM
jlpeyton closed D65714: Add support for libgomp's GOMP_*_nonmonotonic_* functions.
Aug 5 2019, 4:24 PM · Restricted Project, Restricted Project
jlpeyton added a comment to D65714: Add support for libgomp's GOMP_*_nonmonotonic_* functions.

Isuru, if you do not have commit privilege, I can do it for you. Do you want me to commit for you?

Aug 5 2019, 1:52 PM · Restricted Project, Restricted Project
jlpeyton accepted D65714: Add support for libgomp's GOMP_*_nonmonotonic_* functions.

LGTM. Thanks!

Aug 5 2019, 10:05 AM · Restricted Project, Restricted Project

Jul 17 2019

jlpeyton committed rGaa5cdafa405e: Remove REQUIRES OMP spec version within lit tests (authored by jlpeyton).
Remove REQUIRES OMP spec version within lit tests
Jul 17 2019, 8:44 AM
jlpeyton committed rL366341: Remove REQUIRES OMP spec version within lit tests.
Remove REQUIRES OMP spec version within lit tests
Jul 17 2019, 8:44 AM
jlpeyton added a comment to rL365963: [OpenMP] Remove OMP spec versioning.

I've noticed some tests in libomp still have the REQUIRES: openmp-4.5 or REQUIRES: openmp-4.0 constraints. Given that the REQUIRES: openmp-5.0 have been removed I am wondering whether this may be an oversight. Those tests are currently not run, as lit considers them unsupported.

Jul 17 2019, 8:44 AM

Jul 12 2019

jlpeyton committed rGe4b4f994d2f6: [OpenMP] Remove OMP spec versioning (authored by jlpeyton).
[OpenMP] Remove OMP spec versioning
Jul 12 2019, 2:50 PM
jlpeyton committed rL365963: [OpenMP] Remove OMP spec versioning.
[OpenMP] Remove OMP spec versioning
Jul 12 2019, 2:46 PM
jlpeyton closed D64534: Remove OMP spec versioning.
Jul 12 2019, 2:45 PM · Restricted Project, Restricted Project
jlpeyton accepted D64534: Remove OMP spec versioning.

LGTM

Jul 12 2019, 2:44 PM · Restricted Project, Restricted Project

May 31 2019

jlpeyton added a comment to D62488: Added propagation of not big initial stack size of master thread to workers..

I'm not familiar with the test system here but is it checking the output of the test looking for "passed" or how does it determine if the test succeeded?

May 31 2019, 8:19 AM · Restricted Project, Restricted Project

May 30 2019

Vladimir Lazarev <vladimir.lazarev@intel.com> committed rG4af9b1b10f54: [SYCL] Fix some issues with class atomic (authored by jlpeyton).
[SYCL] Fix some issues with class atomic
May 30 2019, 8:05 AM

May 21 2019

jlpeyton committed rG3057c3a0929f: [OpenMP] Add implementation to two OMPT API routines (authored by jlpeyton).
[OpenMP] Add implementation to two OMPT API routines
May 21 2019, 1:49 PM
jlpeyton committed rL361309: [OpenMP] Add implementation to two OMPT API routines.
[OpenMP] Add implementation to two OMPT API routines
May 21 2019, 1:49 PM
jlpeyton committed rOMP361309: [OpenMP] Add implementation to two OMPT API routines.
[OpenMP] Add implementation to two OMPT API routines
May 21 2019, 1:49 PM
jlpeyton closed D61657: Add implementation to two OMPT API routines.
May 21 2019, 1:48 PM · Restricted Project

May 8 2019

jlpeyton committed rGc10733258315: [OpenMP] Workaround gfortran bugzilla build bug 41755 (authored by jlpeyton).
[OpenMP] Workaround gfortran bugzilla build bug 41755
May 8 2019, 4:11 PM
jlpeyton committed rOMP360299: [OpenMP] Workaround gfortran bugzilla build bug 41755.
[OpenMP] Workaround gfortran bugzilla build bug 41755
May 8 2019, 4:10 PM
jlpeyton committed rL360299: [OpenMP] Workaround gfortran bugzilla build bug 41755.
[OpenMP] Workaround gfortran bugzilla build bug 41755
May 8 2019, 4:10 PM
jlpeyton closed D61603: [OpenMP] Fix gfortran bugzilla build bug 41755.
May 8 2019, 4:10 PM · Restricted Project, Restricted Project
jlpeyton accepted D61673: Fixed creation of aliases in Windows build.

LGTM

May 8 2019, 8:22 AM · Restricted Project, Restricted Project

May 6 2019

jlpeyton updated the diff for D61603: [OpenMP] Fix gfortran bugzilla build bug 41755.

Added comment and removed the variable expansion for CMAKE_Fortran_COMPILER_ID

May 6 2019, 1:36 PM · Restricted Project, Restricted Project
jlpeyton created D61603: [OpenMP] Fix gfortran bugzilla build bug 41755.
May 6 2019, 10:58 AM · Restricted Project, Restricted Project
jlpeyton accepted D60916: Add non-SSE wrapper for __kmp_{load,store}_mxcsr.

LGTM

May 6 2019, 8:25 AM · Restricted Project

May 1 2019

jlpeyton committed rOMP359710: [OpenMP] Implement task modifier for reduction clause.
[OpenMP] Implement task modifier for reduction clause
May 1 2019, 10:53 AM
jlpeyton committed rGa8426ac8c2db: [OpenMP] Implement task modifier for reduction clause (authored by jlpeyton).
[OpenMP] Implement task modifier for reduction clause
May 1 2019, 10:52 AM
jlpeyton committed rL359710: [OpenMP] Implement task modifier for reduction clause.
[OpenMP] Implement task modifier for reduction clause
May 1 2019, 10:51 AM
jlpeyton closed D60976: [OpenMP] Implement task modifier for reduction clause.
May 1 2019, 10:51 AM · Restricted Project, Restricted Project
jlpeyton added inline comments to D60916: Add non-SSE wrapper for __kmp_{load,store}_mxcsr.
May 1 2019, 9:15 AM · Restricted Project

Apr 30 2019

jlpeyton committed rOMP359601: [OpenMP] Add OpenMP 5.0 nonmonotonic code.
[OpenMP] Add OpenMP 5.0 nonmonotonic code
Apr 30 2019, 12:36 PM
jlpeyton accepted D60917: Enable OpenMP build for 32-bit FreeBSD.

LGTM

Apr 30 2019, 12:24 PM · Restricted Project
jlpeyton committed rG71abe28e8152: [OpenMP] Add OpenMP 5.0 nonmonotonic code (authored by jlpeyton).
[OpenMP] Add OpenMP 5.0 nonmonotonic code
Apr 30 2019, 12:19 PM
jlpeyton committed rL359601: [OpenMP] Add OpenMP 5.0 nonmonotonic code.
[OpenMP] Add OpenMP 5.0 nonmonotonic code
Apr 30 2019, 12:18 PM
jlpeyton closed D60979: [OpenMP] Add OpenMP 5.0 nonmonotonic code.
Apr 30 2019, 12:18 PM · Restricted Project, Restricted Project
jlpeyton committed rG1ca746170bb2: [OpenMP] Eliminate some compiler warnings (authored by jlpeyton).
[OpenMP] Eliminate some compiler warnings
Apr 30 2019, 12:12 PM
jlpeyton committed rOMP359599: [OpenMP] Eliminate some compiler warnings.
[OpenMP] Eliminate some compiler warnings
Apr 30 2019, 12:12 PM
jlpeyton committed rL359599: [OpenMP] Eliminate some compiler warnings.
[OpenMP] Eliminate some compiler warnings
Apr 30 2019, 12:12 PM
jlpeyton closed D60983: [OpenMP] Eliminate some compiler warnings.
Apr 30 2019, 12:12 PM · Restricted Project, Restricted Project
jlpeyton updated the diff for D60976: [OpenMP] Implement task modifier for reduction clause.

Fixed spelling errors

Apr 30 2019, 12:02 PM · Restricted Project, Restricted Project

Apr 22 2019

jlpeyton created D60983: [OpenMP] Eliminate some compiler warnings.
Apr 22 2019, 3:11 PM · Restricted Project, Restricted Project
jlpeyton created D60979: [OpenMP] Add OpenMP 5.0 nonmonotonic code.
Apr 22 2019, 2:08 PM · Restricted Project, Restricted Project
jlpeyton created D60976: [OpenMP] Implement task modifier for reduction clause.
Apr 22 2019, 12:00 PM · Restricted Project, Restricted Project

Apr 15 2019

jlpeyton committed rOMP358438: [OpenMP] Exchange code in asm file for inline assembly.
[OpenMP] Exchange code in asm file for inline assembly
Apr 15 2019, 12:41 PM
jlpeyton committed rG4f21f5f5ce6f: [OpenMP] Exchange code in asm file for inline assembly (authored by jlpeyton).
[OpenMP] Exchange code in asm file for inline assembly
Apr 15 2019, 12:20 PM
jlpeyton committed rL358438: [OpenMP] Exchange code in asm file for inline assembly.
[OpenMP] Exchange code in asm file for inline assembly
Apr 15 2019, 12:18 PM
jlpeyton closed D60423: [OpenMP] Exchange code in asm file for inline assembly.
Apr 15 2019, 12:18 PM · Restricted Project, Restricted Project

Apr 8 2019

jlpeyton created D60423: [OpenMP] Exchange code in asm file for inline assembly.
Apr 8 2019, 2:57 PM · Restricted Project, Restricted Project
jlpeyton committed rGebf1830bb1dd: [OpenMP] Implement 5.0 memory management (authored by jlpeyton).
[OpenMP] Implement 5.0 memory management
Apr 8 2019, 10:58 AM
jlpeyton committed rOMP357929: [OpenMP] Implement 5.0 memory management.
[OpenMP] Implement 5.0 memory management
Apr 8 2019, 10:58 AM
jlpeyton committed rL357929: [OpenMP] Implement 5.0 memory management.
[OpenMP] Implement 5.0 memory management
Apr 8 2019, 10:58 AM
jlpeyton closed D59783: [OpenMP] Implement 5.0 memory management.
Apr 8 2019, 10:57 AM · Restricted Project
jlpeyton committed rOMP357927: [OpenMP] Clean up load balancing dynamic mode.
[OpenMP] Clean up load balancing dynamic mode
Apr 8 2019, 10:55 AM
jlpeyton committed rGfeac33ebb01a: [OpenMP] Clean up load balancing dynamic mode (authored by jlpeyton).
[OpenMP] Clean up load balancing dynamic mode
Apr 8 2019, 10:49 AM
jlpeyton committed rL357927: [OpenMP] Clean up load balancing dynamic mode.
[OpenMP] Clean up load balancing dynamic mode
Apr 8 2019, 10:48 AM
jlpeyton closed D59508: Clean up load balancing dynamic mode.
Apr 8 2019, 10:48 AM · Restricted Project, Restricted Project

Apr 4 2019

jlpeyton committed rGb727d384a3ad: [OpenMP] Fix hang on Windows (authored by jlpeyton).
[OpenMP] Fix hang on Windows
Apr 4 2019, 1:38 PM
jlpeyton committed rOMP357722: [OpenMP] Fix hang on Windows.
[OpenMP] Fix hang on Windows
Apr 4 2019, 1:38 PM
jlpeyton committed rL357722: [OpenMP] Fix hang on Windows.
[OpenMP] Fix hang on Windows
Apr 4 2019, 1:38 PM
jlpeyton closed D59793: [OpenMP] Fix hang on Windows.
Apr 4 2019, 1:37 PM · Restricted Project, Restricted Project

Apr 3 2019

jlpeyton committed rOMP357621: [OpenMP][Stats] Fix stats gathering for distribute and team clause.
[OpenMP][Stats] Fix stats gathering for distribute and team clause
Apr 3 2019, 11:54 AM
jlpeyton committed rGd2b53cad1852: [OpenMP][Stats] Fix stats gathering for distribute and team clause (authored by jlpeyton).
[OpenMP][Stats] Fix stats gathering for distribute and team clause
Apr 3 2019, 11:54 AM
jlpeyton committed rL357621: [OpenMP][Stats] Fix stats gathering for distribute and team clause.
[OpenMP][Stats] Fix stats gathering for distribute and team clause
Apr 3 2019, 11:54 AM
jlpeyton closed D59801: [OpenMP][Stats] Fix stats gathering for distribute and team clause.
Apr 3 2019, 11:54 AM · Restricted Project, Restricted Project

Mar 28 2019

jlpeyton updated the diff for D59783: [OpenMP] Implement 5.0 memory management.
  1. Addressed Alexey’s comment on enumeration type in C++11 - added base type under “#if __cplusplus >= 201103”.
  2. Fixed Fortan headers so that they can be built by gfortran – removed bind(c) from omp_init_allocator function declaration (gfortran complained that array of structures is not c-boundable type). Also fixed implementation in kmp_ftn_entry.h – added pointers dereference.
Mar 28 2019, 9:56 AM · Restricted Project

Mar 25 2019

jlpeyton committed rG3bc703d5380c: [OpenMP] Add LLVM license header to file (authored by jlpeyton).
[OpenMP] Add LLVM license header to file
Mar 25 2019, 3:37 PM
jlpeyton committed rL356962: [OpenMP] Add LLVM license header to file.
[OpenMP] Add LLVM license header to file
Mar 25 2019, 3:36 PM
jlpeyton committed rOMP356962: [OpenMP] Add LLVM license header to file.
[OpenMP] Add LLVM license header to file
Mar 25 2019, 3:36 PM
jlpeyton committed rG7ca09056c744: [OpenMP] Add Intel 19.0 to list of compilers in kmp_version.cpp (authored by jlpeyton).
[OpenMP] Add Intel 19.0 to list of compilers in kmp_version.cpp
Mar 25 2019, 3:30 PM
jlpeyton committed rOMP356961: [OpenMP] Add Intel 19.0 to list of compilers in kmp_version.cpp.
[OpenMP] Add Intel 19.0 to list of compilers in kmp_version.cpp
Mar 25 2019, 3:30 PM
jlpeyton committed rL356961: [OpenMP] Add Intel 19.0 to list of compilers in kmp_version.cpp.
[OpenMP] Add Intel 19.0 to list of compilers in kmp_version.cpp
Mar 25 2019, 3:30 PM
jlpeyton created D59801: [OpenMP][Stats] Fix stats gathering for distribute and team clause.
Mar 25 2019, 3:18 PM · Restricted Project, Restricted Project
jlpeyton created D59793: [OpenMP] Fix hang on Windows.
Mar 25 2019, 12:21 PM · Restricted Project, Restricted Project
jlpeyton committed rOMP356933: [OpenMP] Fix pause check with version info.
[OpenMP] Fix pause check with version info
Mar 25 2019, 11:36 AM
jlpeyton committed rG61708b1e946a: [OpenMP] Fix pause check with version info (authored by jlpeyton).
[OpenMP] Fix pause check with version info
Mar 25 2019, 11:19 AM
jlpeyton committed rL356933: [OpenMP] Fix pause check with version info.
[OpenMP] Fix pause check with version info
Mar 25 2019, 11:19 AM
jlpeyton closed D59428: Fix pause check with version info.
Mar 25 2019, 11:19 AM · Restricted Project, Restricted Project
jlpeyton created D59783: [OpenMP] Implement 5.0 memory management.
Mar 25 2019, 10:51 AM · Restricted Project
jlpeyton accepted D59735: Fix gettid warnings on FreeBSD.

LGTM

Mar 25 2019, 10:33 AM · Restricted Project
jlpeyton accepted D59736: Fix interoperability test compilation on FreeBSD.

LGTM

Mar 25 2019, 10:33 AM · Restricted Project

Mar 15 2019

jlpeyton committed rG6622732d9ab1: [OpenMP] Fix OMPT cancellation test for GOMP (authored by jlpeyton).
[OpenMP] Fix OMPT cancellation test for GOMP
Mar 15 2019, 2:27 PM
jlpeyton committed rOMP356302: [OpenMP] Fix OMPT cancellation test for GOMP.
[OpenMP] Fix OMPT cancellation test for GOMP
Mar 15 2019, 2:27 PM
jlpeyton committed rL356302: [OpenMP] Fix OMPT cancellation test for GOMP.
[OpenMP] Fix OMPT cancellation test for GOMP
Mar 15 2019, 2:27 PM
jlpeyton committed rOMP356289: [OpenMP] Add missing parenthesis in Perl module.
[OpenMP] Add missing parenthesis in Perl module
Mar 15 2019, 12:06 PM
jlpeyton committed rG5af1c22d0b35: [OpenMP] Add missing parenthesis in Perl module (authored by jlpeyton).
[OpenMP] Add missing parenthesis in Perl module
Mar 15 2019, 11:31 AM
jlpeyton committed rL356289: [OpenMP] Add missing parenthesis in Perl module.
[OpenMP] Add missing parenthesis in Perl module
Mar 15 2019, 11:26 AM
jlpeyton committed rG44b476c141cd: [OpenMP] Remove deprecated taskq (authored by jlpeyton).
[OpenMP] Remove deprecated taskq
Mar 15 2019, 11:24 AM
jlpeyton committed rOMP356288: [OpenMP] Remove deprecated taskq.
[OpenMP] Remove deprecated taskq
Mar 15 2019, 11:24 AM
jlpeyton committed rL356288: [OpenMP] Remove deprecated taskq.
[OpenMP] Remove deprecated taskq
Mar 15 2019, 11:24 AM
jlpeyton closed D58989: Remove deprecated taskq.
Mar 15 2019, 11:24 AM · Restricted Project, Restricted Project