Page MenuHomePhabricator
Feed Advanced Search

Yesterday

matejam updated the diff for D105347: [AMDGPU][GlobalISel] Legalization of G_ROTL and G_ROTR.

Add tests for non power of 2 types (i15, i31...).

Wed, Jul 28, 4:34 AM · Restricted Project
matejam updated the diff for D105347: [AMDGPU][GlobalISel] Legalization of G_ROTL and G_ROTR.

When rotating left, use the right negated rotation (negate the number of shifts) only in cases when the destination type size is a power of 2.

Wed, Jul 28, 3:44 AM · Restricted Project

Tue, Jul 27

matejam updated the diff for D105347: [AMDGPU][GlobalISel] Legalization of G_ROTL and G_ROTR.
Tue, Jul 27, 9:10 AM · Restricted Project

Fri, Jul 23

matejam requested review of D106672: [AMDGPU][GlobalIsel] Fix unable to legalize G_CONCAT_VECTORS when loading a vector..
Fri, Jul 23, 8:24 AM · Restricted Project

Wed, Jul 7

matejam added inline comments to D105347: [AMDGPU][GlobalISel] Legalization of G_ROTL and G_ROTR.
Wed, Jul 7, 6:37 AM · Restricted Project

Fri, Jul 2

matejam updated the diff for D105347: [AMDGPU][GlobalISel] Legalization of G_ROTL and G_ROTR.

Changes in tests.

Fri, Jul 2, 7:16 AM · Restricted Project
matejam requested review of D105347: [AMDGPU][GlobalISel] Legalization of G_ROTL and G_ROTR.
Fri, Jul 2, 5:36 AM · Restricted Project

Jun 4 2021

matejam updated the diff for D97938: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fmul u, v)), z) -> (fma x, y, (fma u, v, z)).

Typos and refactoring.

Jun 4 2021, 7:44 AM · Restricted Project
matejam updated the diff for D98047: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fpext (fmul u, v))), z) -> (fma x, y, (fma (fpext u), (fpext v), z)).

Typos and refactoring.

Jun 4 2021, 7:43 AM · Restricted Project
matejam updated the diff for D96614: [AMDGPU][GlobalISel] Transform (fsub (fmul x, y), z) -> (fma x, y, -z).

Typos and refactoring.

Jun 4 2021, 7:10 AM · Restricted Project
matejam added a comment to D96614: [AMDGPU][GlobalISel] Transform (fsub (fmul x, y), z) -> (fma x, y, -z).

Does this assume that all targets can do the fneg for free? Or can a target choose to fold only (fadd (fmul x, y), z), not (fsub (fmul x, y), z) ?

Jun 4 2021, 7:09 AM · Restricted Project

May 31 2021

matejam updated the diff for D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).

A few typos.

May 31 2021, 7:09 AM · Restricted Project

May 27 2021

matejam updated the diff for D97937: [AMDGPU][GlobalISel] Transform (fadd (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), z).

A few minor changes (removal of unnecessary comments).

May 27 2021, 4:20 AM · Restricted Project

May 20 2021

matejam updated the diff for D97937: [AMDGPU][GlobalISel] Transform (fadd (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), z).

Use mi_match for comparing instructions instead of comparing the opcodes.

May 20 2021, 10:29 AM · Restricted Project
matejam updated the diff for D97938: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fmul u, v)), z) -> (fma x, y, (fma u, v, z)).

Use mi_match for comparing instructions instead of comparing the opcodes.

May 20 2021, 10:29 AM · Restricted Project
matejam updated the diff for D98047: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fpext (fmul u, v))), z) -> (fma x, y, (fma (fpext u), (fpext v), z)).

Use mi_match for comparing instructions instead of comparing the opcodes.

May 20 2021, 10:27 AM · Restricted Project
matejam updated the diff for D96614: [AMDGPU][GlobalISel] Transform (fsub (fmul x, y), z) -> (fma x, y, -z).

Use mi_match for comparing instructions instead of comparing the opcodes.

May 20 2021, 10:27 AM · Restricted Project
matejam updated the diff for D98048: [AMDGPU][GlobalISel] Transform (fsub (fneg (fmul, x, y)), z) -> (fma (fneg x), y, (fneg z)).

Use mi_match for comparing instructions instead of comparing the opcodes.

May 20 2021, 10:27 AM · Restricted Project
matejam updated the diff for D98049: [AMDGPU][GlobalISel] Transform (fsub (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), (fneg z)).

Use mi_match for comparing instructions instead of comparing the opcodes.

May 20 2021, 10:25 AM · Restricted Project
matejam updated the diff for D98050: [AMDGPU][GlobalISel] Transform (fsub (fpext (fneg (fmul x, y))), z) -> (fneg (fma (fpext x), (fpext y), z)).

Use mi_match for comparing instructions instead of comparing the opcodes.

May 20 2021, 10:25 AM · Restricted Project
matejam updated the diff for D98050: [AMDGPU][GlobalISel] Transform (fsub (fpext (fneg (fmul x, y))), z) -> (fneg (fma (fpext x), (fpext y), z)).

Use mi_match for comparing instructions instead of comparing the opcodes.

May 20 2021, 10:24 AM · Restricted Project
matejam updated the diff for D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).

Use mi_match for comparing instructions instead of comparing the opcodes.

May 20 2021, 10:24 AM · Restricted Project

May 6 2021

matejam updated the diff for D98050: [AMDGPU][GlobalISel] Transform (fsub (fpext (fneg (fmul x, y))), z) -> (fneg (fma (fpext x), (fpext y), z)).

Minor changes in CombinerHelper.cpp and in the tests.

May 6 2021, 5:50 AM · Restricted Project
matejam updated the diff for D98049: [AMDGPU][GlobalISel] Transform (fsub (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), (fneg z)).

Minor changes in CombinerHelper.cpp and in the tests.

May 6 2021, 5:48 AM · Restricted Project
matejam updated the diff for D98048: [AMDGPU][GlobalISel] Transform (fsub (fneg (fmul, x, y)), z) -> (fma (fneg x), y, (fneg z)).

Minor changes in CombinerHelper.cpp and in the tests.

May 6 2021, 5:48 AM · Restricted Project
matejam updated the diff for D96614: [AMDGPU][GlobalISel] Transform (fsub (fmul x, y), z) -> (fma x, y, -z).

Minor changes in CombinerHelper.cpp and in the tests.

May 6 2021, 5:47 AM · Restricted Project
matejam updated the diff for D98047: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fpext (fmul u, v))), z) -> (fma x, y, (fma (fpext u), (fpext v), z)).

Minor changes in CombinerHelper.cpp and in the tests.

May 6 2021, 5:47 AM · Restricted Project
matejam updated the diff for D97938: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fmul u, v)), z) -> (fma x, y, (fma u, v, z)).

Minor changes in CombinerHelper.cpp and in the tests.

May 6 2021, 5:46 AM · Restricted Project
matejam updated the diff for D97937: [AMDGPU][GlobalISel] Transform (fadd (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), z).

Minor changes in CombinerHelper.cpp and in the tests.

May 6 2021, 5:46 AM · Restricted Project
matejam updated the diff for D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).

Minor changes in CombinerHelper.cpp and in the tests.

May 6 2021, 5:45 AM · Restricted Project

Apr 29 2021

matejam updated the diff for D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).

A few minor adjustments in CombinerHelper.cpp.

Apr 29 2021, 7:19 AM · Restricted Project

Apr 22 2021

matejam added inline comments to D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).
Apr 22 2021, 11:17 AM · Restricted Project
matejam added inline comments to D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).
Apr 22 2021, 5:31 AM · Restricted Project

Apr 14 2021

matejam updated the diff for D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).

Adjustments in the tests.

Apr 14 2021, 5:36 AM · Restricted Project

Apr 12 2021

matejam updated the diff for D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).

Code formatting in CombinerHelper.cpp.

Apr 12 2021, 7:58 AM · Restricted Project

Apr 9 2021

matejam updated the diff for D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).

Added two mir tests (prelegalize and postlegalize combiner) and a few adjustments in CombinerHelper.cpp.

Apr 9 2021, 7:57 AM · Restricted Project

Mar 17 2021

matejam requested review of D98784: [AMDGPU][GlobalISel] Fix unable to legalize G_FSHL error.
Mar 17 2021, 8:20 AM · Restricted Project

Mar 9 2021

matejam updated the diff for D98050: [AMDGPU][GlobalISel] Transform (fsub (fpext (fneg (fmul x, y))), z) -> (fneg (fma (fpext x), (fpext y), z)).

Put back the accidentally deleted combiner from the list of combiners (load_or_combine).

Mar 9 2021, 7:19 AM · Restricted Project
matejam updated the diff for D98049: [AMDGPU][GlobalISel] Transform (fsub (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), (fneg z)).

Put back the accidentally deleted combiner from the list of combiners (load_or_combine).

Mar 9 2021, 7:19 AM · Restricted Project
matejam updated the diff for D98048: [AMDGPU][GlobalISel] Transform (fsub (fneg (fmul, x, y)), z) -> (fma (fneg x), y, (fneg z)).

Put back the accidentally deleted combiner from the list of combiners (load_or_combine).

Mar 9 2021, 7:18 AM · Restricted Project
matejam updated the diff for D96614: [AMDGPU][GlobalISel] Transform (fsub (fmul x, y), z) -> (fma x, y, -z).

Put back the accidentally deleted combiner from the list of combiners (load_or_combine).

Mar 9 2021, 7:18 AM · Restricted Project
matejam updated the diff for D98047: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fpext (fmul u, v))), z) -> (fma x, y, (fma (fpext u), (fpext v), z)).

Put back the accidentally deleted combiner from the list of combiners (load_or_combine).

Mar 9 2021, 7:17 AM · Restricted Project
matejam updated the diff for D97938: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fmul u, v)), z) -> (fma x, y, (fma u, v, z)).

Put back the accidentally deleted combiner from the list of combiners (load_or_combine).

Mar 9 2021, 7:16 AM · Restricted Project
matejam updated the diff for D97937: [AMDGPU][GlobalISel] Transform (fadd (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), z).

Put back the accidentally deleted combiner from the list of combiners (load_or_combine).

Mar 9 2021, 7:15 AM · Restricted Project
matejam updated the diff for D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).

Put back the accidentally deleted combiner from the list of combiners (load_or_combine).

Mar 9 2021, 7:14 AM · Restricted Project

Mar 5 2021

matejam requested review of D98050: [AMDGPU][GlobalISel] Transform (fsub (fpext (fneg (fmul x, y))), z) -> (fneg (fma (fpext x), (fpext y), z)).
Mar 5 2021, 7:51 AM · Restricted Project
matejam edited reviewers for D98048: [AMDGPU][GlobalISel] Transform (fsub (fneg (fmul, x, y)), z) -> (fma (fneg x), y, (fneg z)), added: arsenm; removed: arsen.
Mar 5 2021, 7:49 AM · Restricted Project
matejam requested review of D98049: [AMDGPU][GlobalISel] Transform (fsub (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), (fneg z)).
Mar 5 2021, 7:49 AM · Restricted Project
matejam requested review of D98048: [AMDGPU][GlobalISel] Transform (fsub (fneg (fmul, x, y)), z) -> (fma (fneg x), y, (fneg z)).
Mar 5 2021, 7:47 AM · Restricted Project
matejam requested review of D98047: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fpext (fmul u, v))), z) -> (fma x, y, (fma (fpext u), (fpext v), z)).
Mar 5 2021, 7:39 AM · Restricted Project

Mar 4 2021

matejam requested review of D97938: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fmul u, v)), z) -> (fma x, y, (fma u, v, z)).
Mar 4 2021, 5:06 AM · Restricted Project
matejam requested review of D97937: [AMDGPU][GlobalISel] Transform (fadd (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), z).
Mar 4 2021, 5:03 AM · Restricted Project
matejam updated the diff for D96614: [AMDGPU][GlobalISel] Transform (fsub (fmul x, y), z) -> (fma x, y, -z).
Mar 4 2021, 3:45 AM · Restricted Project
matejam updated the diff for D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).

Added support for vector types and some refactoring.

Mar 4 2021, 3:44 AM · Restricted Project

Mar 2 2021

matejam added a comment to D96614: [AMDGPU][GlobalISel] Transform (fsub (fmul x, y), z) -> (fma x, y, -z).

Thanks for the suggestions!

Mar 2 2021, 8:17 AM · Restricted Project
matejam updated the diff for D96614: [AMDGPU][GlobalISel] Transform (fsub (fmul x, y), z) -> (fma x, y, -z).

Added support for vector types and some refactoring.

Mar 2 2021, 8:05 AM · Restricted Project

Feb 12 2021

matejam requested review of D96614: [AMDGPU][GlobalISel] Transform (fsub (fmul x, y), z) -> (fma x, y, -z).
Feb 12 2021, 9:29 AM · Restricted Project
matejam retitled D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z) from [AMDGPU][GlobalISel] Add combiners for v_mad/v_mac/v_fma to [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).
Feb 12 2021, 9:28 AM · Restricted Project
matejam updated the diff for D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).

Instead of add and mul instructions, use v_mad, v_mac or v_fma
if fma instructions are faster and are legal for the given architecture.
Combiner for a simple case that has only one add and one mul instruction
and transforms them into some of the fma instructions depending on the
architecture.

Feb 12 2021, 9:24 AM · Restricted Project

Dec 15 2020

matejam requested review of D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z).
Dec 15 2020, 8:21 AM · Restricted Project

Oct 8 2020

matejam added inline comments to D88667: [GlobalISel] Change asserting conditions when initializing call site info.
Oct 8 2020, 8:13 AM · Restricted Project, debug-info

Oct 1 2020

matejam added a comment to D87902: [GlobalISel] Fix enumeration of entry basic blocks when using GlobalISel.

Alternative:
https://reviews.llvm.org/D88667

Oct 1 2020, 9:02 AM · debug-info, Restricted Project
matejam requested review of D88667: [GlobalISel] Change asserting conditions when initializing call site info.
Oct 1 2020, 8:59 AM · Restricted Project, debug-info
matejam abandoned D87902: [GlobalISel] Fix enumeration of entry basic blocks when using GlobalISel.
Oct 1 2020, 4:45 AM · debug-info, Restricted Project

Sep 18 2020

matejam added inline comments to D87903: [CSInfo][GlobalISel] CallSiteInfo support when using GlobalISel.
Sep 18 2020, 7:10 AM · debug-info, Restricted Project
matejam requested review of D87903: [CSInfo][GlobalISel] CallSiteInfo support when using GlobalISel.
Sep 18 2020, 6:48 AM · debug-info, Restricted Project
matejam requested review of D87902: [GlobalISel] Fix enumeration of entry basic blocks when using GlobalISel.
Sep 18 2020, 6:45 AM · debug-info, Restricted Project

Feb 6 2020

matejam added a watcher for debug-info: matejam.
Feb 6 2020, 6:00 AM