Page MenuHomePhabricator
Feed Advanced Search

Sat, Aug 17

grosser added a comment to D41412: [libcxx] implement <experimental/simd> concat() and split().

@EricWF and @timshen, @maxf and I are indeed very interested in seeing this library upstreamed soon. Over the last weeks, we developed a software prototype based on these bindings and already started to tune performance on clang/LLVM. As part of this, we looked into efficient vector code generation, started to implement where expressions, ... Currently, everything is very much prototype quality, but we would very much prefer to get things integrated into libcxx. For this, it's important to have a working and committed implementation, such that we can start submitting patches ourselves and can obtain feedback on these patches early on. Otherwise, we might take directions that won't really be compatible with libcxx. How can we best help with getting these patches upstream?

Sat, Aug 17, 6:44 AM · Restricted Project

Fri, Aug 9

grosser added a comment to D57504: RFC: Prototype & Roadmap for vector predication in LLVM.

Nice. Btw. another motivation could be std::simd. Here the overflow intrinsics exposed as builtin would allow us to provide a fast implementation of the masked variants of <simd>

Fri, Aug 9, 5:05 AM · Restricted Project

Thu, Jul 25

grosser added a comment to D41412: [libcxx] implement <experimental/simd> concat() and split().

@EricWF thanks again for offering your help here. We are not in a rush here, but I wonder if you happen to have a rough estimate when you might have the time to look into these patches?

Thu, Jul 25, 8:51 PM · Restricted Project

Jul 19 2019

grosser added a comment to D41412: [libcxx] implement <experimental/simd> concat() and split().

Tobias,

I spoke to @EricWF who is willing to take a look at all these patches. However, I don't know when exactly will the review starts.

Jul 19 2019, 2:37 AM · Restricted Project

Jul 18 2019

grosser added a comment to D41412: [libcxx] implement <experimental/simd> concat() and split().

It seems this patch went through at least one review and the only open comment is the discussion if __builtin_shuffle should be placed in the configuration. From my perspective, both solutions are technically feasible. While it seems unlikely that gcc will gain this specific builtin, I can see @mclow.lists preferring to be consistent in keeping compiler-specific stuff in one file rather than having to evaluate for each extension the likeliness of this extension being adopted over time.

Jul 18 2019, 9:55 AM · Restricted Project

Jul 15 2019

Herald updated subscribers of D41756: [libcxx] implement <experimental/simd> simd_mask<> casts and some horizontal operations..
Jul 15 2019, 11:05 PM
Herald updated subscribers of D41747: [libcxx] implement <experimental/simd> simd_mask<> and operators..
Jul 15 2019, 11:05 PM
Herald updated subscribers of D41843: [libcxx] implement <experimental/simd> where expressions..
Jul 15 2019, 11:05 PM
grosser added a comment to D41412: [libcxx] implement <experimental/simd> concat() and split().

I am very interested in these patches. Any chance you can take up the upstreaming process again?

Jul 15 2019, 11:05 PM · Restricted Project
grosser abandoned D64702: [libcxx: experimental::simd] Support binary operations.

Tim's patches look a lot more polished and are better in line with the initial ::simd code he contributed. I feel development should be continued on Tim's patches.

Jul 15 2019, 11:04 PM · Restricted Project
grosser added a comment to D64702: [libcxx: experimental::simd] Support binary operations.

a) tim has already a similar patch in his pipeline

Yes, I had a full stack of patches (using the dependency feature of Phab), starting with D41412, that implements the whole proposal up to some version (and it's not the latest version), but the patches got into both mclow's and my back-burners sooner than expected.

Jul 15 2019, 11:00 PM · Restricted Project

Jul 14 2019

grosser created D64702: [libcxx: experimental::simd] Support binary operations.
Jul 14 2019, 1:04 AM · Restricted Project

May 10 2019

grosser accepted D61807: [Polly] Don't crash on invalid delinearization result..

LGTM elli

May 10 2019, 10:45 PM · Restricted Project

Apr 23 2019

grosser accepted D58202: [Polly][ScheduleOptimizer] Hoist extension nodes after schedule optimization..

Hi Michael,

Apr 23 2019, 10:34 AM · Restricted Project

Feb 1 2019

Herald added a project to D57504: RFC: Prototype & Roadmap for vector predication in LLVM: Restricted Project.
Feb 1 2019, 1:56 AM · Restricted Project

Oct 8 2018

grosser added a comment to D52933: Fix incorrect Twine usage in CFGPrinter.

Marcin, let us know if you agree with the comment fix. I can then commit the patch, when it's ready.

Oct 8 2018, 1:14 AM

Oct 7 2018

grosser accepted D52933: Fix incorrect Twine usage in CFGPrinter.

Thanks Marcin for improving the commit message. We all seem to agree that this is the right correction. Hence, I feel this is ready to upstream from my side. As there have been quite some opinions, it would be great to hear if there are any open concerns that should be adressed or if others also feel this LGT(them). We especially still need feedback from @kristina!

Oct 7 2018, 4:28 AM
grosser added a comment to D52933: Fix incorrect Twine usage in CFGPrinter.

Thank you @kristina for the review. I must admit I do not fully understand in which way this is broken, but the attached test case clearly shows there is some memory issue. My (limited) understanding is that Twine(Weight->getZExtValue()) will be destroyed at the end of line 175 which means that already in line 176 we may potentially reference invalid memory.
http://llvm.org/docs/ProgrammersManual.html#dss-twine has a similar example and explicitly warns of such uses:

Oct 7 2018, 3:31 AM

Sep 13 2018

grosser added a comment to D51984: Fixes for `LLVM_LINK_LLVM_DYLIB` && Polly..

Thank you guys for taking care of some of the cmake system. @Meinersbur, I am fine with renaming Polly modules according to LLVM conventions if this makes things more consistent.

Sep 13 2018, 3:05 PM

Sep 11 2018

grosser accepted D51904: [Polly] Fix the build for non-`MSVC` Windows targets..

This is a good idea.

Sep 11 2018, 9:53 AM
grosser closed D51928: [PerfMonitor] Fix rdtscp callsites.
Sep 11 2018, 7:21 AM

Sep 4 2018

grosser accepted D51634: Define PATH_MAX if missing..

This LGTM.

Sep 4 2018, 9:18 AM

Aug 8 2018

grosser committed rL339312: Update isl-cpp bindings.
Update isl-cpp bindings
Aug 8 2018, 10:08 PM
grosser committed rL339311: Update to isl-0.20-65-gb822a210.
Update to isl-0.20-65-gb822a210
Aug 8 2018, 10:08 PM

Aug 6 2018

grosser committed rL339095: Update isl to isl-0.20-48-g13eba5b5.
Update isl to isl-0.20-48-g13eba5b5
Aug 6 2018, 10:52 PM
grosser committed rL339094: Make update-isl work with latest isl versions.
Make update-isl work with latest isl versions
Aug 6 2018, 10:51 PM

Aug 1 2018

grosser committed rL338512: PPCG codegen.
PPCG codegen
Aug 1 2018, 3:49 AM
grosser committed rL338505: [isl++] drop the isl namespace qualifiers [NFC].
[isl++] drop the isl namespace qualifiers [NFC]
Aug 1 2018, 2:58 AM
grosser committed rL338504: Rebase C++ bindings on top of latest isl bindings.
Rebase C++ bindings on top of latest isl bindings
Aug 1 2018, 2:57 AM
grosser committed rL338501: Update to isl-0.20-35-ge0a98b62.
Update to isl-0.20-35-ge0a98b62
Aug 1 2018, 2:20 AM

Jul 31 2018

grosser added a comment to D49872: [Polly][ScopDetect] Add option -polly-allow-nonaffine-read and enable by default..

Interesting. Any idea what is going wrong here?

Jul 31 2018, 2:35 AM · Restricted Project

Jul 28 2018

grosser accepted D49872: [Polly][ScopDetect] Add option -polly-allow-nonaffine-read and enable by default..

Hi Michael,

Jul 28 2018, 10:43 PM · Restricted Project
grosser added a comment to D49950: [Polly][JSONExporter] Replace bundled Jsoncpp with LLVM's JSON.h. NFC..

If this was not clear. I am very OK with this change.

Jul 28 2018, 10:42 PM · Restricted Project
grosser accepted D49950: [Polly][JSONExporter] Replace bundled Jsoncpp with LLVM's JSON.h. NFC..

This is a straightforward, but very nice infrastructure change. Thank you both for pushing JSON support ahead in LLVM!

Jul 28 2018, 10:41 PM · Restricted Project

Jul 25 2018

grosser added a comment to D49609: [isl] Typesafe user pointers.

http://brotherst-code.blogspot.com/2015/10/how-to-get-typeindex-without-rtti.html

Jul 25 2018, 3:24 AM
grosser added a comment to D49609: [isl] Typesafe user pointers.

I used the std::any variant as an easy way to showcase how the bindings generator could be modified to do what we want (and also to show how an ideal interface could look like). I feel we should bring this up on the isl mailing list first to see what would be a good way to add this feature. We potentially could replace std::any with a simpler C++11 compatible solution:

Jul 25 2018, 2:51 AM
grosser added a comment to D49609: [isl] Typesafe user pointers.

Hi Philip.

Jul 25 2018, 12:25 AM

Jul 20 2018

grosser accepted D49021: [Polly][isl] Simplify iterator implementation by building on top of list accessors.

LGTM

Jul 20 2018, 6:09 AM

Jul 17 2018

grosser abandoned D47604: [Polly] Add isl C++ list iterators.

This has become obsolete, after Philip Pfaffe committed a better variant of this feature.

Jul 17 2018, 9:17 PM
grosser committed rL337248: [DependenceInfo] Use isl++ to replace foreach_set with for loop.
[DependenceInfo] Use isl++ to replace foreach_set with for loop
Jul 17 2018, 12:13 AM
grosser committed rL337247: [IslNodeBuilder] Use isl++ to replace foreach_set with for loop.
[IslNodeBuilder] Use isl++ to replace foreach_set with for loop
Jul 17 2018, 12:13 AM

Jul 16 2018

grosser committed rL337246: [ScopInfo] Replace isl foreach calls with for loops.
[ScopInfo] Replace isl foreach calls with for loops
Jul 16 2018, 11:46 PM
grosser committed rL337245: [ZoneAlgo] Replace isl foreach calls with for loops.
[ZoneAlgo] Replace isl foreach calls with for loops
Jul 16 2018, 11:39 PM
grosser committed rL337244: [FlattenSchedule] Replace isl foreach calls with for loops.
[FlattenSchedule] Replace isl foreach calls with for loops
Jul 16 2018, 11:38 PM
grosser committed rL337243: [MaximalStaticExpansion] Replace isl foreach calls with for loops.
[MaximalStaticExpansion] Replace isl foreach calls with for loops
Jul 16 2018, 11:38 PM
grosser committed rL337242: [ForwardOpTree] Replace isl foreach calls with for loops.
[ForwardOpTree] Replace isl foreach calls with for loops
Jul 16 2018, 11:38 PM
grosser committed rL337241: [Simplify] Replace isl foreach calls with for loops.
[Simplify] Replace isl foreach calls with for loops
Jul 16 2018, 11:38 PM
grosser committed rL337239: [FlattenAlgo] Replace more isl foreach calls with for loops.
[FlattenAlgo] Replace more isl foreach calls with for loops
Jul 16 2018, 11:22 PM
grosser committed rL337238: [FlattenAlgo] Replace some isl foreach calls with for loops.
[FlattenAlgo] Replace some isl foreach calls with for loops
Jul 16 2018, 11:17 PM
grosser committed rL337237: [unittest/DeLICM] Replace isl foreach calls with for loops.
[unittest/DeLICM] Replace isl foreach calls with for loops
Jul 16 2018, 11:13 PM
grosser committed rL337201: [ScopInfo] Replace isl foreach calls with for loops.
[ScopInfo] Replace isl foreach calls with for loops
Jul 16 2018, 12:09 PM

Jul 13 2018

grosser added a comment to D49019: [Polly][isl] Add neutrally-named accessors to isl list elements and sizes.

You can commit this. It will just be covered in the next update.

Jul 13 2018, 6:37 AM

Jul 10 2018

grosser added a comment to D49130: Fix OpenCL Work-Item function arguments in Polly.

Sorry guys. Alain just started to look into this last week and we wanted to get him up-to-speed before getting in touch with you. I should have helped to coordinate better. I asked Alain to discuss with you which / what patches are still needed.

Jul 10 2018, 7:35 AM · Restricted Project
grosser added a comment to D49019: [Polly][isl] Add neutrally-named accessors to isl list elements and sizes.

I have a patched version of the generator (very hacky) on top of the isl bindings. Not sure if this (happens to) be the right one: https://github.com/tobig/isl/tree/polly-bindings-andrei

Jul 10 2018, 7:34 AM
grosser added a comment to D49019: [Polly][isl] Add neutrally-named accessors to isl list elements and sizes.

Right. I am busy today, but can do a normal update thursday afternoon. I will then also push the current generator to github.

Jul 10 2018, 5:50 AM

Jul 6 2018

grosser accepted D49019: [Polly][isl] Add neutrally-named accessors to isl list elements and sizes.

LGTM

Jul 6 2018, 7:27 AM
grosser committed rL336425: Update isl to isl-0.19-224-gce84a511.
Update isl to isl-0.19-224-gce84a511
Jul 6 2018, 2:05 AM

Jul 5 2018

grosser committed rL336362: [ScopInfo] Move foldSizeConstantsToRight() to isl++.
[ScopInfo] Move foldSizeConstantsToRight() to isl++
Jul 5 2018, 8:28 AM
grosser closed D48965: [ScopInfo] Move foldSizeConstantsToRight() to isl++.
Jul 5 2018, 8:28 AM
grosser accepted D48965: [ScopInfo] Move foldSizeConstantsToRight() to isl++.

LGTM.

Jul 5 2018, 8:10 AM

Jul 4 2018

grosser committed rL336281: ScopInfo: simplify equivalence classes before storing them [NFCI].
ScopInfo: simplify equivalence classes before storing them [NFCI]
Jul 4 2018, 7:58 AM

Jul 3 2018

grosser added a comment to D48883: [Polly-ACC] Add isl_space.h to gpu_tree.c.

Yes, raise we should raise the version. Also, please add a propoer commit message explaining what the underlying error was here. We should also make sure that this bug has been fixed in the latest ppcg, such that we do not re-import it again.

Jul 3 2018, 8:56 AM

Jun 29 2018

grosser accepted D48774: [polly-acc] change cl_get_* return types to 32/64bit.

Also looks good from me except the minor changes. Please update the patch if you agree.

Jun 29 2018, 2:20 PM
grosser committed rL335971: Use range for in normalizeValInst [NFCI].
Use range for in normalizeValInst [NFCI]
Jun 29 2018, 6:11 AM
grosser committed rL335970: Translate a couple of foreach callbacks into range-based iterator loops.
Translate a couple of foreach callbacks into range-based iterator loops
Jun 29 2018, 5:28 AM
grosser committed rL335966: Add missing namespace specifier.
Add missing namespace specifier
Jun 29 2018, 4:54 AM

Jun 28 2018

grosser added a comment to D48651: [RFC] Pattern matching on schedule trees..

@ftynse, the source is referenced in the patch summary. If we commit such a patch to Polly, we must make we have your permission to contribute it under the LLVM license and obviously need to acknowledge the source. For now, I asked Lorenzo to push the code as RFC to allow others to see how it would be used. This already sparked a comment from Philip and will likely spark further discussions on how to extend the interface. Thanks for commenting.

Jun 28 2018, 2:33 AM · Restricted Project
grosser committed rL335813: test: use regex matchers to make test-case robust against register renumberings.
test: use regex matchers to make test-case robust against register renumberings
Jun 28 2018, 12:16 AM

Jun 26 2018

grosser accepted D48579: [Polly][ZoneAlgo] Use getDefToTarget in makeValInst. NFC..

Nice!

Jun 26 2018, 4:54 AM · Restricted Project

Jun 19 2018

grosser committed rL335029: Move ScopInfo to isl++.
Move ScopInfo to isl++
Jun 19 2018, 1:18 AM

Jun 18 2018

grosser committed rL334941: Adjust for clang-format changes.
Adjust for clang-format changes
Jun 18 2018, 6:09 AM
grosser committed rL334940: [ScopInfo] Move splitAliasGroupsByDomain and getAccessDomain to isl++ [NFCI].
[ScopInfo] Move splitAliasGroupsByDomain and getAccessDomain to isl++ [NFCI]
Jun 18 2018, 5:57 AM
grosser committed rL334939: [ScopInfo] Move more functions to isl++ [NFCI].
[ScopInfo] Move more functions to isl++ [NFCI]
Jun 18 2018, 5:54 AM
grosser committed rL334938: [ScopInfo] Move addNonEmptyDomainConstraints to isl++ [NFCI].
[ScopInfo] Move addNonEmptyDomainConstraints to isl++ [NFCI]
Jun 18 2018, 5:46 AM
grosser committed rL334937: Move buildConditionSet to C++.
Move buildConditionSet to C++
Jun 18 2018, 5:40 AM

Jun 16 2018

grosser added a comment to D48136: [Polly] Implement an iterator for isl maps, basic_maps, sets, basic_sets.

Thank you Philip. This clearly looks a lot better than my patch. From my perspective this looks good after Michael's comments are addressed. Thanks a lot.

Jun 16 2018, 10:53 AM
grosser committed rL334893: Adjust to recent LLVM changes to fix buildbots.
Adjust to recent LLVM changes to fix buildbots
Jun 16 2018, 10:42 AM

Jun 13 2018

grosser committed rL334661: [test] Fix a typo in a test case [NFCI].
[test] Fix a typo in a test case [NFCI]
Jun 13 2018, 2:50 PM

Jun 11 2018

grosser committed rL334413: Drop unnecessary whitespace [NFCI].
Drop unnecessary whitespace [NFCI]
Jun 11 2018, 8:16 AM
grosser committed rL334412: [ScopBuilder] Slightly improve code structure [NFCI].
[ScopBuilder] Slightly improve code structure [NFCI]
Jun 11 2018, 8:03 AM
grosser committed rL334406: Update isl to isl-0.19-185-g8e9f55ce.
Update isl to isl-0.19-185-g8e9f55ce
Jun 11 2018, 7:30 AM

Jun 6 2018

grosser accepted D47752: [Polly][OpTree] Introduce shortcut for computing the def->target mapping. NFCI..

Cool.

Jun 6 2018, 9:55 AM · Restricted Project
grosser committed rL334092: getDependences to new C++ interface.
getDependences to new C++ interface
Jun 6 2018, 6:15 AM
grosser closed D47786: getDependences to new C++ interface.
Jun 6 2018, 6:14 AM · Restricted Project

Jun 5 2018

grosser accepted D47786: getDependences to new C++ interface.

LGTM.

Jun 5 2018, 8:35 AM · Restricted Project
grosser committed rL333988: Fix formatting.
Fix formatting
Jun 5 2018, 2:08 AM

Jun 1 2018

grosser retitled D47604: [Polly] Add isl C++ list iterators from Add isl C++ list iterators to [Polly] Add isl C++ list iterators.
Jun 1 2018, 12:18 PM
grosser added a comment to D47252: partitionSetParts from C to C++ interface..

Done. Thanks Lorenzo!

Jun 1 2018, 12:16 PM · Restricted Project
grosser committed rL333780: partitionSetParts from C to C++ interface..
partitionSetParts from C to C++ interface.
Jun 1 2018, 12:16 PM
grosser closed D47252: partitionSetParts from C to C++ interface..
Jun 1 2018, 12:16 PM · Restricted Project
grosser accepted D47252: partitionSetParts from C to C++ interface..

LGTM.

Jun 1 2018, 11:33 AM · Restricted Project
grosser abandoned D46227: [islpp] Do not abuse isl::stat::error as early-abort.

Dropping this in favor of D47604. Thanks for the suggestions!

Jun 1 2018, 11:03 AM
grosser added a comment to D47252: partitionSetParts from C to C++ interface..

@chelini : any plans to update this patch?

Jun 1 2018, 11:02 AM · Restricted Project

May 31 2018

grosser added reviewers for D47604: [Polly] Add isl C++ list iterators: philip.pfaffe, alexandre.isoard.
May 31 2018, 1:25 PM
grosser created D47604: [Polly] Add isl C++ list iterators.
May 31 2018, 1:10 PM
grosser committed rL333688: Update isl C++ bindings.
Update isl C++ bindings
May 31 2018, 12:52 PM

May 30 2018

grosser committed rL333621: Update isl to isl-0.19-173-g77fe2538.
Update isl to isl-0.19-173-g77fe2538
May 30 2018, 9:03 PM

May 28 2018

grosser added a comment to D47438: [ScopInfo] Update Scop::addUserContext() to C++ interface.

Committed. These changes are very useful. Thanks!

May 28 2018, 12:51 AM
grosser committed rL333366: [ScopInfo] Update Scop::addUserContext() to C++ interface.
[ScopInfo] Update Scop::addUserContext() to C++ interface
May 28 2018, 12:49 AM
grosser closed D47438: [ScopInfo] Update Scop::addUserContext() to C++ interface.
May 28 2018, 12:49 AM