Page MenuHomePhabricator
Feed Advanced Search

Mon, Aug 12

a_sidorin added inline comments to D65935: [ASTImporter] Import ctor initializers after setting flags..
Mon, Aug 12, 10:07 PM · Restricted Project, Restricted Project
a_sidorin added a comment to D65573: Add User docs for ASTImporter.

That's incredible. Thank you!

Mon, Aug 12, 2:09 PM · Restricted Project, Restricted Project
a_sidorin accepted D65999: [ASTImporter] Import additional flags for functions..

Hi Balazs,
The change looks good. I think it can be committed after an unrelated part is removed.

Mon, Aug 12, 12:24 PM · Restricted Project, Restricted Project

Sun, Aug 11

a_sidorin accepted D65269: [ASTImporter] Fix for import of friend class template with definition..

LGTM, thanks!

Sun, Aug 11, 4:02 PM · Restricted Project, Restricted Project
a_sidorin added a comment to D65999: [ASTImporter] Import additional flags for functions..

Hello Balazs,
The patch looks good in general.

Sun, Aug 11, 3:49 PM · Restricted Project, Restricted Project
a_sidorin added a comment to D65935: [ASTImporter] Import ctor initializers after setting flags..

Hello Balazs,
Do I understand correctly that it was unset ToFunction->setLexicalDeclContext(LexicalDC); that caused lookup problems?

Sun, Aug 11, 2:53 PM · Restricted Project, Restricted Project

Tue, Aug 6

a_sidorin accepted D65203: [ASTImporter] Do not import FunctionTemplateDecl in record twice..

LGTM, thanks!

Tue, Aug 6, 2:46 PM · Restricted Project, Restricted Project

Mon, Aug 5

a_sidorin accepted D65180: [analyzer] VirtualCallChecker: Improve warning messages..

Hi Artem,
The patch looks good to me. I prefer a fully qualified name, however, but it is a matter of taste.

Mon, Aug 5, 2:53 PM · Restricted Project

Mon, Jul 22

a_sidorin accepted D44100: [ASTImporter] Reorder fields after structure import is finished.

Hi Gabor,
Thank you again for working on this patch. I think it can be committed after minor stylish issues are fixed.

Mon, Jul 22, 2:52 PM · Restricted Project, Restricted Project
a_sidorin accepted D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations.

Looks good! Sorry for the delay :(

Mon, Jul 22, 2:43 PM · Restricted Project, Restricted Project

Jul 14 2019

a_sidorin added a comment to D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations.

Hi Gabor,
This looks fine, but could you please add a test showing how decl shadowing is handled? I.e. if we have Arg in one TU and both Arg and N::Arg in another TU.

Jul 14 2019, 11:54 PM · Restricted Project, Restricted Project
a_sidorin accepted D64075: [ASTImporter] Fix structural eq of lambdas.

Hello Gabor,
This patch looks good to me.
Regarding the related patch: can we use getLambdaManglingNumber() for the comparison?

Jul 14 2019, 11:11 AM · Restricted Project, Restricted Project

Jul 7 2019

a_sidorin added a comment to D60461: [ASTImporter] Import TemplateParameterLists in function templates..

Post-LGTM :)

Jul 7 2019, 3:31 PM · Restricted Project
a_sidorin accepted D62484: [ASTImporter] Added visibility context check for EnumDecl..

LGTM!

Jul 7 2019, 3:22 PM · Restricted Project, Restricted Project
a_sidorin added a comment to D64075: [ASTImporter] Fix structural eq of lambdas.

Hi Gabor,
The patch looks good, but it looks to me that it has a relation to https://reviews.llvm.org/D64078 that is kind of questionable to me. Let's delay landing this patch until the fix direction is clear.

Jul 7 2019, 3:17 PM · Restricted Project, Restricted Project
a_sidorin added a comment to D64078: [ASTImporter] Fix structural ineq of lambdas with different sloc.

Hi Gabor,
it is a nice design question if source locations can participate in structural match or not. The comparison tells us that the same code written in different files is not structurally equivalent and I cannot agree with it. They can be not the same, but their structure is the same. The question is: why do we get to this comparison? Do we find a non-equivalent decl by lookup? I guess there can be another way to resolve this issue, and I'll be happy to help if you share what is the problem behind the patch.

Jul 7 2019, 3:10 PM · Restricted Project
a_sidorin accepted D64073: [ASTImporter] Fix import of lambda in function param.
Jul 7 2019, 2:57 PM · Restricted Project, Restricted Project

Jul 2 2019

a_sidorin added a comment to D64073: [ASTImporter] Fix import of lambda in function param.

Hello Gabor,
There is an inline question about tests; other code looks fine.

Jul 2 2019, 3:56 PM · Restricted Project, Restricted Project
a_sidorin added a comment to D64075: [ASTImporter] Fix structural eq of lambdas.

Hello Gabor,
This looks mostly good but I have a question inline.

Jul 2 2019, 3:48 PM · Restricted Project, Restricted Project
a_sidorin added inline comments to D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr.
Jul 2 2019, 3:43 PM · Restricted Project, Restricted Project

Jun 30 2019

a_sidorin added a comment to D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter.

The following happened: During the analysis we compared two Decls which turned out to be inequivalent, so we cached them. Later during the analysis, however, we added a new node to the redecl chain of one of these Decls which we previously compared. Then another structural equivalent check followed for the two Decls. And this time they should have been considered structurally equivalent, but the cache already contained them as nonequivalent. This resulted in a false positive NameConflict error.

Should we reset the non-equivalence relation after a decl is imported for this decl and its redecls?

Jun 30 2019, 10:55 AM · Restricted Project
a_sidorin accepted D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr.

LGTM, thanks for the fixes!

Jun 30 2019, 10:21 AM · Restricted Project, Restricted Project
a_sidorin accepted D63603: [ASTImporter] Propagate error from ImportDeclContext.

Hi Gabor,
The patch looks good. Thanks!

Jun 30 2019, 9:53 AM · Restricted Project, Restricted Project
a_sidorin accepted D62376: [ASTImporter] Mark erroneous nodes in shared st.

Thanks for the explanation!
It will be good if someone else takes a look at this patch.

Jun 30 2019, 4:24 AM · Restricted Project, Restricted Project
a_sidorin added a comment to D62375: [ASTImporter] Mark erroneous nodes in from ctx.

Hello Gabor,
Thank you for the explanation. I got the idea of this patch anyway, but it will be definitely useful for anyone digging into the code. Should we make it a comment for ImportPathTy?

Jun 30 2019, 1:16 AM · Restricted Project, Restricted Project

Jun 23 2019

a_sidorin accepted D62373: [ASTImporter] Store import errors for Decls.
Jun 23 2019, 10:40 PM · Restricted Project, Restricted Project
a_sidorin accepted D62375: [ASTImporter] Mark erroneous nodes in from ctx.

Thanks!

Jun 23 2019, 2:12 PM · Restricted Project, Restricted Project

Jun 3 2019

a_sidorin accepted D62557: [analyzer] Modernize CStringChecker to use CallDescriptions..

LGTM!

Jun 3 2019, 3:01 PM · Restricted Project, Restricted Project
a_sidorin added a comment to D62556: [analyzer] NFC: CallDescription: Implement describing C library functions..

Hi Artem,
Looks mostly good, but I have some comments inline.

Jun 3 2019, 3:00 PM · Restricted Project, Restricted Project

May 26 2019

a_sidorin added a comment to D62376: [ASTImporter] Mark erroneous nodes in shared st.

Hi Gabor!
I haven't find the import sequence examples we try to fix these ways in any of the three patches these change consists of. Could you please provide some (or point if I missed them)?

May 26 2019, 1:55 PM · Restricted Project, Restricted Project
a_sidorin added a comment to D62375: [ASTImporter] Mark erroneous nodes in from ctx.

Hi Gabor,
Could you please provide any test for the import itself?

May 26 2019, 1:05 PM · Restricted Project, Restricted Project
a_sidorin added a comment to D62373: [ASTImporter] Store import errors for Decls.

Hi Gabor,
The idea looks fine to me, but I have some questions inline.

May 26 2019, 12:49 PM · Restricted Project, Restricted Project
a_sidorin accepted D62440: [analyzer] NFC: Change evalCall() to provide a CallEvent..
May 26 2019, 11:13 AM · Restricted Project, Restricted Project
a_sidorin added a comment to D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr.

Hello Gabor,
I have a few questions inline.

May 26 2019, 10:41 AM · Restricted Project, Restricted Project
a_sidorin accepted D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable.
May 26 2019, 10:11 AM · Restricted Project, Restricted Project
a_sidorin added a comment to D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter.

Hi Gabor,
Could you provide an example of an import sequence leading to this behavior? It's hard for me to imagine such a situation.

May 26 2019, 9:46 AM · Restricted Project

May 19 2019

a_sidorin accepted D62066: [ASTImporter] Enable disabled but passing tests.

Cool!

May 19 2019, 3:17 PM · Restricted Project, Restricted Project
a_sidorin added a comment to D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable.

Hi Gabor,
This looks fine, but I have a question inline.

May 19 2019, 3:15 PM · Restricted Project, Restricted Project
a_sidorin added inline comments to D61814: [CFG] NFC: Remove implicit conversion from CFGTerminator to Stmt *, make it a variant class instead..
May 19 2019, 12:48 PM · Restricted Project, Restricted Project

May 11 2019

a_sidorin accepted D61814: [CFG] NFC: Remove implicit conversion from CFGTerminator to Stmt *, make it a variant class instead..

The conversion operator indeed looks non-evident.

May 11 2019, 11:17 AM · Restricted Project, Restricted Project
a_sidorin accepted D61815: [CFG] NFC: Modernize test/Analysis/initializers-cfg-output.cpp..

Wow, this is a cool idea!

May 11 2019, 11:01 AM · Restricted Project
a_sidorin added a comment to D44100: [ASTImporter] Reorder fields after structure import is finished.

Thank you for digging into this! Feel free to ask me if you encounter any problems with the patch.

May 11 2019, 10:58 AM · Restricted Project, Restricted Project
a_sidorin accepted D61786: [ASTImporter] Separate unittest files.

Hi Gabor,
I like this change! LGTM, just a few nits.

May 11 2019, 10:43 AM · Restricted Project

May 4 2019

a_sidorin accepted D61545: [analyzer] Fix a crash in RVO from within blocks..
May 4 2019, 12:23 PM · Restricted Project
a_sidorin accepted D61438: [ASTImporter] Use llvm::Expected and Error in the importer API.

👍

May 4 2019, 4:13 AM · Restricted Project, Restricted Project, Restricted Project
a_sidorin accepted D61424: [ASTImporter] Fix inequivalence of unresolved exception spec.

Looks good!

May 4 2019, 3:11 AM · Restricted Project, Restricted Project
a_sidorin accepted D59692: [ASTImporter] Fix name conflict handling.

LGTM, thanks!

May 4 2019, 2:57 AM · Restricted Project
a_sidorin accepted D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.

Hello Gabor!
This looks good to me, but let's wait for LLDB guys to take a look at the patch. Thanks!

May 4 2019, 2:33 AM · Restricted Project, Restricted Project, Restricted Project

Apr 25 2019

a_sidorin accepted D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition.

Looks good, thanks!

Apr 25 2019, 11:55 PM
a_sidorin added a comment to D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition.

Hello Shafik!
The patch itself is fine, but, as other reviewers pointed, tests are appreciated. I suggest to add a test into ASTImporterTests.cpp - you will find several ways to write tests of different complexity here. I think this change can be tested even with the simplest testImport() facility.

Apr 25 2019, 3:45 PM

Apr 22 2019

a_sidorin added a comment to D60899: [analyzer] Unbreak body farms in presence of multiple declarations..

Mmm, what are the pros and cons?

Apr 22 2019, 4:32 PM · Restricted Project, Restricted Project

Apr 20 2019

a_sidorin accepted D60899: [analyzer] Unbreak body farms in presence of multiple declarations..

Hi Artem,
This looks good to me. However, it seems to me that the correct solution is to synthesize a shining new function and include it into the redeclaration chain. This requires much more work, however.

Apr 20 2019, 3:05 AM · Restricted Project, Restricted Project

Apr 16 2019

a_sidorin added a comment to D60796: [analyzer] PR41269: SmartPtrModeling..

Hi Artem,
There are some comments inline, but looks promising!

Apr 16 2019, 3:03 PM · Restricted Project
a_sidorin accepted D60742: [analyzer] RegionStore: Enable loading default bindings from variables..

I like the test even more than the change itself!

Apr 16 2019, 2:56 AM · Restricted Project
a_sidorin accepted D60739: [analyzer] NFC: Re-use reusable unittest mocks..

LGTM.

Apr 16 2019, 2:48 AM · Restricted Project, Restricted Project

Apr 8 2019

a_sidorin accepted D55049: Changed every use of ASTImporter::Import to Import_New.

LGTM.

Apr 8 2019, 1:42 AM · Restricted Project

Mar 28 2019

a_sidorin accepted D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior..

Hello Raphael,
I think we should accept this change. I don't see an easy way to merge the LLDB stuff into ASTImporter; also, this patch provides a good extension point for ASTImporter since it is designed to be a parent class. @martong @shafik Gabor, Shafik, what do you think?

Mar 28 2019, 4:33 PM · Restricted Project
a_sidorin accepted D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation.

Yes, I think this is fine. Thanks!

Mar 28 2019, 4:29 PM · Restricted Project, Restricted Project
a_sidorin accepted D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName.

Thanks!

Mar 28 2019, 3:53 PM · Restricted Project
a_sidorin accepted D58897: [ASTImporter] Make ODR error handling configurable.
Mar 28 2019, 3:53 PM · Restricted Project
a_sidorin added a comment to D59845: Fix IsStructuralMatch specialization for EnumDecl to prevent re-importing an EnumDecl while trying to complete it.

Post-LGTM with some stylish nits.

Mar 28 2019, 2:52 PM · Restricted Project
a_sidorin added a comment to D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName.

Hi Shafik,
Thank you for the explanation, it is much more clear to me now. But, as I see, D59692 is going to discard the changes this patch introduces. @martong Gabor, do you expect the changes of this patch to be merged into yours, or should this patch be abandoned?

Mar 28 2019, 2:42 PM · Restricted Project
a_sidorin added a comment to D59692: [ASTImporter] Fix name conflict handling.

Thanks for the fixes! I'd like to clarify one moment, however.

Mar 28 2019, 2:29 PM · Restricted Project

Mar 24 2019

a_sidorin added a comment to D55049: Changed every use of ASTImporter::Import to Import_New.

Hi Balazs,

Mar 24 2019, 12:23 PM · Restricted Project
a_sidorin accepted D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter..

Hi Balasz,

Mar 24 2019, 9:53 AM · Restricted Project, Restricted Project
a_sidorin added a comment to D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior..

Hello Raphael,

Mar 24 2019, 9:30 AM · Restricted Project
a_sidorin added a comment to D59692: [ASTImporter] Fix name conflict handling.

Hi Gabor,

Mar 24 2019, 9:13 AM · Restricted Project

Mar 21 2019

a_sidorin updated subscribers of D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName.

Hi Shafik,

Mar 21 2019, 6:42 PM · Restricted Project

Mar 11 2019

a_sidorin added a comment to D58897: [ASTImporter] Make ODR error handling configurable.

Hi Gabor,
This patch LGTM mostly, but there is a comment inline.

Mar 11 2019, 12:34 AM · Restricted Project

Mar 10 2019

a_sidorin accepted D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec.

Thanks!

Mar 10 2019, 10:51 AM · Restricted Project, Restricted Project
a_sidorin accepted D55358: [ASTImporter] Fix import of NestedNameSpecifierLoc..

Looks good!

Mar 10 2019, 8:37 AM · Restricted Project, Restricted Project

Mar 3 2019

a_sidorin accepted D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec.

Hi Gabor,
Thanks for the patch! It looks good to me except some stylish nits.

Mar 3 2019, 11:00 AM · Restricted Project, Restricted Project
a_sidorin added a comment to D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec.

Hi Gabor,
The patch looks almost good bu I have some comments inline.

Mar 3 2019, 10:56 AM · Restricted Project, Restricted Project
a_sidorin accepted D58830: [ASTImporter] Import member expr with explicit template args.
Mar 3 2019, 6:33 AM · Restricted Project, Restricted Project

Feb 26 2019

a_sidorin accepted D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls.

Thanks for the fixes!

Feb 26 2019, 2:02 PM · Restricted Project
a_sidorin added a comment to D57590: [ASTImporter] Improve import of FileID..

Hi Gabor,
Sorry, missed the patch. It looks mostly good, but do we have any test for this?

Feb 26 2019, 1:59 PM · Restricted Project

Feb 24 2019

a_sidorin added a comment to D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls.

Hi Gabor,
The patch looks OK overall but I have some comments inline.

Feb 24 2019, 3:32 PM · Restricted Project
a_sidorin accepted D58502: [ASTImporter] Fix redecl failures of Class and ClassTemplate.

Hi Gabor,
I don't see any problems with the patch. Thanks! I think it will be good to get Shafik's approval as well.

Feb 24 2019, 3:21 PM · Restricted Project, Restricted Project

Feb 23 2019

a_sidorin accepted D58292: Add support for importing ChooseExpr AST nodes..

Hi Tom,
Thanks for the fixes! The patch looks good to me now. I have only a small nit inline.

Feb 23 2019, 1:02 AM · Restricted Project, Restricted Project

Feb 21 2019

a_sidorin added inline comments to D58292: Add support for importing ChooseExpr AST nodes..
Feb 21 2019, 1:46 PM · Restricted Project, Restricted Project

Feb 20 2019

a_sidorin added a comment to D58292: Add support for importing ChooseExpr AST nodes..

Hi Tom,

Feb 20 2019, 4:21 PM · Restricted Project, Restricted Project

Feb 16 2019

a_sidorin requested changes to D58292: Add support for importing ChooseExpr AST nodes..

Hi Tom,
The change looks reasonable but the tests need some improvements.

Feb 16 2019, 2:19 AM · Restricted Project, Restricted Project
a_sidorin accepted D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests.

Thanks for the changes! The patch looks completely fine to me now.

Feb 16 2019, 1:55 AM · Restricted Project, Restricted Project
a_sidorin accepted D57910: [ASTImporter] Find previous friend function template.

Hi Gabor,
This patch LGTM with a minor nit.

Feb 16 2019, 1:48 AM · Restricted Project

Feb 11 2019

a_sidorin added a comment to D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests.

Hi Gabor,

Feb 11 2019, 3:58 PM · Restricted Project, Restricted Project

Feb 10 2019

a_sidorin accepted D57901: [ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces.
Feb 10 2019, 2:34 AM · Restricted Project, Restricted Project

Feb 7 2019

a_sidorin added a comment to D57906: [CTU] Do not allow different CPP dialects in CTU.

Hi Gabor,
Please find my comments inline.

Feb 7 2019, 3:40 PM · Restricted Project
a_sidorin accepted D57905: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators.

LGTM!

Feb 7 2019, 3:35 PM · Restricted Project
a_sidorin accepted D57902: [AST] Fix structural inequivalence of operators.

Looks good, thanks!

Feb 7 2019, 3:25 PM · Restricted Project

Feb 6 2019

a_sidorin accepted D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way.
Feb 6 2019, 10:06 PM · Restricted Project

Jan 27 2019

a_sidorin accepted D57235: [AST] Add structural eq tests for template args.

There are never enough tests :) Thank you!

Jan 27 2019, 5:30 AM

Jan 23 2019

a_sidorin accepted D57062: [analyzer] Re-enable the "System is over constrained" assertion on optimized builds..

Oh, I remember how much pain have debug mode-only assertions caused.

Jan 23 2019, 1:32 PM

Jan 21 2019

a_sidorin accepted D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl.

LGTM, thank you!
I'm sorry if the change I requested doesn't look good, but I think the correctness is our priority.

Jan 21 2019, 2:47 PM

Jan 18 2019

a_sidorin added a comment to D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl.

Hi Shafik,
Please find my answers inline.

Jan 18 2019, 2:58 PM

Jan 14 2019

a_sidorin added a comment to D56632: [analyzer] Track region liveness only through base regions..

Hi Artem,
This looks perfect, just some stylish issues.

Jan 14 2019, 1:23 PM

Jan 13 2019

a_sidorin added a comment to D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl.

Hi Rafael,
The change looks mostly fine but I have some comments inline.

Jan 13 2019, 3:19 PM

Jan 12 2019

a_sidorin added a comment to D56581: [ASTImporter] Set the described template if not set.

Hello Gabor,

Jan 12 2019, 10:23 AM

Dec 23 2018

a_sidorin accepted D55280: [CTU] Make loadExternalAST return with non nullptr on success.

Hi Gabor,
Yes, this looks good. Thanks!

Dec 23 2018, 1:24 AM
a_sidorin added inline comments to D55734: [analyzer] Revise GenericTaintChecker's internal representation.
Dec 23 2018, 1:18 AM
a_sidorin updated subscribers of D55646: [ASTImporter] Make ODR diagnostics warning by default.

Hello Endre.
I agree that it doesn't make sense to have 'errors' in AST merging tools, and the changes for ASTImporter part are welcome. However, I don't feel so positive to modules support changes and I don't think we are allowed to change this. @aaron.ballman, @rsmith what do you think?
@bruno, you're the original author of the related Sema code. What do you think, should this be a warning or an error in Sema?

Dec 23 2018, 12:05 AM · Restricted Project