Page MenuHomePhabricator
Feed Advanced Search

Jul 1 2021

atmnpatel requested review of D105325: [Libomptarget] Experimental Remote Plugin Fixes.
Jul 1 2021, 5:13 PM · Restricted Project

Feb 4 2021

atmnpatel added a comment to D94367: [Clang][Driver] Add -ffinite-loops flags.

Wait actually, we're gonna need D94366 anyways, I'll get address @xbolva00's comments by eod.

Feb 4 2021, 10:53 AM · Restricted Project
atmnpatel abandoned D94367: [Clang][Driver] Add -ffinite-loops flags.
Feb 4 2021, 10:52 AM · Restricted Project
atmnpatel added a comment to D94367: [Clang][Driver] Add -ffinite-loops flags.

@fhahn Sorry for the hold up, I don't think I'll get to this relatively soon, I'll abandon this one and D94366 to sweep the board.

Feb 4 2021, 10:51 AM · Restricted Project

Feb 2 2021

atmnpatel added a comment to D95769: [OpenMP][Libomptarget] Remove possible harmful copy constructor call for RTLsTy.

Sorry I added it to the bug assuming that I couldn't actually push to the 12.x release branch, but I do have permission for that so it should be fixed there now as well.

Feb 2 2021, 9:24 PM · Restricted Project

Jan 31 2021

atmnpatel requested review of D95769: [OpenMP][Libomptarget] Remove possible harmful copy constructor call for RTLsTy.
Jan 31 2021, 4:47 PM · Restricted Project

Jan 27 2021

atmnpatel requested review of D95574: [OpenMP][Libomptarget] Fix conditional in CMake for remote plugin.
Jan 27 2021, 3:53 PM · Restricted Project

Jan 26 2021

atmnpatel requested review of D95474: [OpenMP][Libomptarget] Fix cmake error on remote plugin.
Jan 26 2021, 12:59 PM · Restricted Project
atmnpatel added a comment to D95314: [OpenMP][Libomptarget] Introduce Remote Offloading Plugin.

Most of these clang-tidy errors are from a mismatch between gRPC naming conventions and ours, I'm going to keep it as the gRPC ones because that's what we do elsewhere (in clangd for instance) unless there are any objections.

Jan 26 2021, 12:12 PM · Restricted Project
atmnpatel updated the diff for D95314: [OpenMP][Libomptarget] Introduce Remote Offloading Plugin.

Updates.

Jan 26 2021, 11:14 AM · Restricted Project

Jan 25 2021

atmnpatel added a comment to D95314: [OpenMP][Libomptarget] Introduce Remote Offloading Plugin.

I don't think any of this is thread safe, which is bad as the plugin can definitely be called from multiple threads on the host.

Yep, it is not designed for that and I added a warning in the documentation.

Jan 25 2021, 9:49 PM · Restricted Project
atmnpatel updated the diff for D95314: [OpenMP][Libomptarget] Introduce Remote Offloading Plugin.

Updates.

Jan 25 2021, 9:47 PM · Restricted Project

Jan 24 2021

atmnpatel requested review of D95314: [OpenMP][Libomptarget] Introduce Remote Offloading Plugin.
Jan 24 2021, 10:48 AM · Restricted Project

Jan 23 2021

atmnpatel updated the summary of D93293: [OpenMP][Libomptarget] Introduce changes to support remote plugin.
Jan 23 2021, 9:14 AM · Restricted Project
atmnpatel updated the diff for D93293: [OpenMP][Libomptarget] Introduce changes to support remote plugin.

Removed redundant third function register_requires, it may become necessary later but it isn't now.

Jan 23 2021, 9:13 AM · Restricted Project

Jan 9 2021

atmnpatel updated the diff for D94367: [Clang][Driver] Add -ffinite-loops flags.

Update CommandLineReference.rst to also include -fno-finite-loops

Jan 9 2021, 5:02 PM · Restricted Project
atmnpatel requested review of D94367: [Clang][Driver] Add -ffinite-loops flags.
Jan 9 2021, 5:00 PM · Restricted Project
atmnpatel updated the diff for D94366: [Clang] Emit mustprogress for infinite C++ loops.

while(1) case was mishandled for C++11 onwards, fixed now.

Jan 9 2021, 4:01 PM · Restricted Project
atmnpatel requested review of D94366: [Clang] Emit mustprogress for infinite C++ loops.
Jan 9 2021, 3:17 PM · Restricted Project

Jan 8 2021

atmnpatel accepted D94327: [NFC] Specify C11 in loop-opt-setup.c.

LGTM.

Jan 8 2021, 11:26 AM · Restricted Project

Jan 7 2021

atmnpatel added a comment to D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

I'm happy to add a patch amending this, the reason it wasn't done that way was because at the time and even now, out of icc/clang/msvc/gcc, gcc seems to be the only one that happily removed such loops in C++ (https://godbolt.org/z/W9vj99), and I didn't have a particularly strong opinion on which way we should lean at the time.

Jan 7 2021, 9:16 AM · Restricted Project
atmnpatel added a comment to D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.
int a, b;

int f(void) {
    while (1) {
        if (a != b) return 1;
    }
    return 0;
}

int g(int a, int b) {
    while (1) {
        if (a != b) return 1;
    }
    return 0;
}

LLVM does not catch these cases; gcc does.

https://godbolt.org/z/jW7son

Looks like must progress does not get added? If it gets added to the IR the loops get removed: https://godbolt.org/z/77v17P

Jan 7 2021, 8:56 AM · Restricted Project, Restricted Project

Dec 31 2020

atmnpatel updated the summary of D93952: [Clang][Misc] Fix fragile test.
Dec 31 2020, 10:34 AM · Restricted Project
atmnpatel updated the diff for D93952: [Clang][Misc] Fix fragile test.

Better?

Dec 31 2020, 10:33 AM · Restricted Project
atmnpatel added a comment to D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

Do you plan to implement gcc’s option in Clang as followup?

Dec 31 2020, 10:15 AM · Restricted Project, Restricted Project
atmnpatel updated the diff for D93952: [Clang][Misc] Fix fragile test.

Ah I see, I was never able to find clear documentation on what exactly the -cc1 flag does other than the conceptual description. This should fix it right?

Dec 31 2020, 10:10 AM · Restricted Project

Dec 30 2020

atmnpatel added a comment to D93952: [Clang][Misc] Fix fragile test.

I can't say that I know with any certainty, I'm too inexperienced. This failure was missed by me locally, the pre-merge bot, and by most of the buildbots other than the ones I mentioned above. I have no idea under what configuration of CMake options will clang not emit this particular case of a label for a BB.

Dec 30 2020, 7:53 PM · Restricted Project
atmnpatel requested review of D93952: [Clang][Misc] Fix fragile test.
Dec 30 2020, 7:25 PM · Restricted Project

Dec 23 2020

atmnpatel added a comment to D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

Yep, sorry, I'm just waiting for a final stamp of approval from one of the reviewers.

Dec 23 2020, 6:22 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

As expected, @fhahn was right, adding willreturn to all those tests was an artifact from previous revisions of this patch and it passed the tests so I didn't pay them any mind, but I removed them now.

Dec 23 2020, 12:21 PM · Restricted Project, Restricted Project

Dec 22 2020

atmnpatel added inline comments to D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.
Dec 22 2020, 10:15 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

Addressed comments

Dec 22 2020, 10:12 PM · Restricted Project, Restricted Project

Dec 16 2020

atmnpatel updated the diff for D93293: [OpenMP][Libomptarget] Introduce changes to support remote plugin.

More fixes.

Dec 16 2020, 5:33 PM · Restricted Project
atmnpatel updated the diff for D93293: [OpenMP][Libomptarget] Introduce changes to support remote plugin.

Fixes.

Dec 16 2020, 5:31 PM · Restricted Project
atmnpatel updated the diff for D93290: [OpenMP][NFC] Use CMake Variables.

Updated commit message, sanity ping for pre-merge buildbot.

Dec 16 2020, 2:06 PM · Restricted Project

Dec 15 2020

atmnpatel added inline comments to D93293: [OpenMP][Libomptarget] Introduce changes to support remote plugin.
Dec 15 2020, 5:21 AM · Restricted Project
atmnpatel updated the diff for D93293: [OpenMP][Libomptarget] Introduce changes to support remote plugin.

Added debug messages for when the new calls fail.

Dec 15 2020, 5:10 AM · Restricted Project
atmnpatel updated the diff for D93293: [OpenMP][Libomptarget] Introduce changes to support remote plugin.

Addresses inline comments (partially, fixing).

Dec 15 2020, 4:58 AM · Restricted Project
atmnpatel updated the summary of D93293: [OpenMP][Libomptarget] Introduce changes to support remote plugin.
Dec 15 2020, 4:05 AM · Restricted Project
atmnpatel requested review of D93293: [OpenMP][Libomptarget] Introduce changes to support remote plugin.
Dec 15 2020, 4:04 AM · Restricted Project
atmnpatel requested review of D93290: [OpenMP][NFC] Use CMake Variables.
Dec 15 2020, 3:21 AM · Restricted Project

Nov 30 2020

atmnpatel added inline comments to D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.
Nov 30 2020, 3:05 AM · Restricted Project, Restricted Project

Nov 29 2020

atmnpatel requested review of D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.
Nov 29 2020, 5:30 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

I believe this happened becase when I removed the loop, I did not update MemorySSA. The exact error was from GVN, but this update seems to fix the stage 2 build compile time error locally (I checked by running the build bot script).

Nov 29 2020, 5:29 PM · Restricted Project, Restricted Project
atmnpatel reopened D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

This introduced a compile-time error that showed up during a stage 2 build.

Nov 29 2020, 5:29 PM · Restricted Project, Restricted Project

Nov 9 2020

atmnpatel committed rGfd3cad7a6016: [clang] Fix ForStmt mustprogress handling (authored by atmnpatel).
[clang] Fix ForStmt mustprogress handling
Nov 9 2020, 8:38 AM
atmnpatel closed D91075: [clang] Fix ForStmt mustprogress handling.
Nov 9 2020, 8:38 AM · Restricted Project
atmnpatel requested review of D91075: [clang] Fix ForStmt mustprogress handling.
Nov 9 2020, 6:29 AM · Restricted Project

Nov 6 2020

atmnpatel added a comment to rG04a08964879f: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free….

I'm so sorry, I saw that you fixed it, thank you.

Nov 6 2020, 9:59 PM
atmnpatel added a comment to rG04a08964879f: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free….

I naively assumed that reverting it would be fine, I'm working on a fixing right now.

Nov 6 2020, 9:58 PM
atmnpatel added inline comments to rGb1878b4641e0: [CodeGen] Fixes sanitizer test.
Nov 6 2020, 9:35 PM
atmnpatel added a reverting change for rG0b17c6e4479d: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops: rG04a08964879f: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free….
Nov 6 2020, 9:32 PM
atmnpatel committed rG04a08964879f: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free… (authored by atmnpatel).
Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free…
Nov 6 2020, 9:32 PM
atmnpatel added a reverting change for rGb1878b4641e0: [CodeGen] Fixes sanitizer test: rGd3e75d31e3c8: Revert "[CodeGen] Fixes sanitizer test".
Nov 6 2020, 9:32 PM
atmnpatel added a reverting change for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops: rG04a08964879f: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free….
Nov 6 2020, 9:32 PM · Restricted Project, Restricted Project
atmnpatel committed rGd3e75d31e3c8: Revert "[CodeGen] Fixes sanitizer test" (authored by atmnpatel).
Revert "[CodeGen] Fixes sanitizer test"
Nov 6 2020, 9:32 PM
atmnpatel committed rGb1878b4641e0: [CodeGen] Fixes sanitizer test (authored by atmnpatel).
[CodeGen] Fixes sanitizer test
Nov 6 2020, 8:54 PM
atmnpatel committed rG569abb530ece: [LoopDeletion] Fixes failing test (authored by atmnpatel).
[LoopDeletion] Fixes failing test
Nov 6 2020, 7:46 PM
atmnpatel committed rG0b17c6e4479d: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops (authored by atmnpatel).
[LoopDeletion] Allows deletion of possibly infinite side-effect free loops
Nov 6 2020, 7:07 PM
atmnpatel closed D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.
Nov 6 2020, 7:07 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

final fixes.

Nov 6 2020, 5:29 PM · Restricted Project, Restricted Project
atmnpatel committed rG46a29e9c6e7f: [Inliner] Handle `mustprogress` functions (authored by atmnpatel).
[Inliner] Handle `mustprogress` functions
Nov 6 2020, 5:04 PM
atmnpatel closed D87262: [Inliner] Handle `mustprogress` functions.
Nov 6 2020, 5:04 PM · Restricted Project
atmnpatel committed rGbabc224c5d74: [LoopDeletion] Remove dead loops with no exit blocks (authored by atmnpatel).
[LoopDeletion] Remove dead loops with no exit blocks
Nov 6 2020, 2:09 PM
atmnpatel closed D90115: [LoopDeletion] Remove dead loops with no exit blocks.
Nov 6 2020, 2:09 PM · Restricted Project
atmnpatel updated the diff for D90115: [LoopDeletion] Remove dead loops with no exit blocks.
  • Fixed failing test
Nov 6 2020, 12:20 PM · Restricted Project

Nov 5 2020

atmnpatel updated the diff for D87262: [Inliner] Handle `mustprogress` functions.

Rebase

Nov 5 2020, 9:11 PM · Restricted Project
atmnpatel updated the diff for D90115: [LoopDeletion] Remove dead loops with no exit blocks.

removed non-parent revision.

Nov 5 2020, 9:03 PM · Restricted Project
atmnpatel updated the diff for D90115: [LoopDeletion] Remove dead loops with no exit blocks.

using buildkite recommended fix

Nov 5 2020, 8:55 PM · Restricted Project
atmnpatel updated the diff for D90115: [LoopDeletion] Remove dead loops with no exit blocks.
  • Addressed nits
  • Rebase
  • Final Pre-commit testing
Nov 5 2020, 8:46 PM · Restricted Project

Nov 4 2020

atmnpatel committed rGcea0599aa75b: [LangRef] Adds llvm.loop.mustprogress loop metadata (authored by atmnpatel).
[LangRef] Adds llvm.loop.mustprogress loop metadata
Nov 4 2020, 7:33 PM
atmnpatel closed D88464: [LangRef] Adds llvm.loop.mustprogress loop metadata.
Nov 4 2020, 7:33 PM · Restricted Project
atmnpatel committed rGac73b73c1652: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction (authored by atmnpatel).
[clang] Add mustprogress and llvm.loop.mustprogress attribute deduction
Nov 4 2020, 7:03 PM
atmnpatel closed D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.
Nov 4 2020, 7:03 PM · Restricted Project

Nov 3 2020

atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

Hopefully the unrelated hwasan test failure is now fixed on master, trying again.

Nov 3 2020, 10:04 AM · Restricted Project

Nov 2 2020

atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

try 2.

Nov 2 2020, 10:02 PM · Restricted Project
atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

ignore, testing pre-build bots again.

Nov 2 2020, 9:51 PM · Restricted Project
atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

Rebase.

Nov 2 2020, 9:49 PM · Restricted Project
atmnpatel committed rGa95b25b29ecf: [Libomptarget][NFC] Move global Libomptarget state to a struct (authored by atmnpatel).
[Libomptarget][NFC] Move global Libomptarget state to a struct
Nov 2 2020, 9:12 PM
atmnpatel closed D90519: [Libomptarget][NFC] Move global Libomptarget state to a struct.
Nov 2 2020, 9:12 PM · Restricted Project
atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.
  • Added triple to fix mangling errors in test
  • Modified (unrelated) recently added test to have the mustprogress attribute
Nov 2 2020, 2:21 PM · Restricted Project
atmnpatel updated the diff for D90519: [Libomptarget][NFC] Move global Libomptarget state to a struct.
  • Updated title, revision summary, and commit message
  • Added documentation for struct and members
Nov 2 2020, 1:02 PM · Restricted Project
atmnpatel retitled D90519: [Libomptarget][NFC] Move global Libomptarget state to a struct from [Libomptarget][NFC] Encapsulate Global Libomptarget State to [Libomptarget][NFC] Move global Libomptarget state to a struct.
Nov 2 2020, 12:59 PM · Restricted Project
atmnpatel committed rGeed8df6a1314: [Coroutines][Docs] Remove frame packing as a TODO (authored by atmnpatel).
[Coroutines][Docs] Remove frame packing as a TODO
Nov 2 2020, 12:57 PM
atmnpatel closed D90550: [Coroutines][Docs] Remove frame packing as a TODO.
Nov 2 2020, 12:57 PM · Restricted Project

Nov 1 2020

atmnpatel requested review of D90550: [Coroutines][Docs] Remove frame packing as a TODO.
Nov 1 2020, 3:52 AM · Restricted Project

Oct 30 2020

atmnpatel requested review of D90519: [Libomptarget][NFC] Move global Libomptarget state to a struct.
Oct 30 2020, 9:12 PM · Restricted Project

Oct 29 2020

atmnpatel abandoned D89654: [WIP][libomptarget][NFC] Refactor Libomptarget functionality into a class.

Thank you for the comments. I think I follow, I'll post another less intrusive patch soon.

Oct 29 2020, 8:22 PM · Restricted Project

Oct 25 2020

atmnpatel updated the diff for D90115: [LoopDeletion] Remove dead loops with no exit blocks.

Update comments.

Oct 25 2020, 5:36 PM · Restricted Project
atmnpatel updated the diff for D90115: [LoopDeletion] Remove dead loops with no exit blocks.
  • Adds test.
  • Uses getExitBlocks() instead of getUniqueExitBlocks() and moved definition.
  • Changed definition of hasNoExitBlocks() to use empty() instead of conditional
  • Style changes in deleteDeadLoop for readibility.
Oct 25 2020, 5:34 PM · Restricted Project
atmnpatel updated the diff for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

Added word back in.

Oct 25 2020, 3:26 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D90115: [LoopDeletion] Remove dead loops with no exit blocks.

Add parent revision for buildkite.

Oct 25 2020, 2:22 AM · Restricted Project
atmnpatel requested review of D90115: [LoopDeletion] Remove dead loops with no exit blocks.
Oct 25 2020, 2:21 AM · Restricted Project

Oct 21 2020

atmnpatel added a comment to D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

ping. @jyknight @aaron.ballman @rjmccall any more thoughts?

Oct 21 2020, 5:03 PM · Restricted Project
atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

rebase.

Oct 21 2020, 4:43 PM · Restricted Project

Oct 20 2020

atmnpatel committed rG595c61560684: [IR] Adds mustprogress as a LLVM IR attribute (authored by adpatel6).
[IR] Adds mustprogress as a LLVM IR attribute
Oct 20 2020, 12:10 AM
atmnpatel closed D85393: [IR] Adds mustprogress as a LLVM IR attribute.
Oct 20 2020, 12:10 AM · Restricted Project

Oct 19 2020

atmnpatel updated the diff for D87975: [IR] MaxObjSize Attribute.

Sorry, I understand now. Is this more correct?

Oct 19 2020, 2:28 PM · Restricted Project
atmnpatel committed rG1e55cf77f389: [LangRef] Define mustprogress attribute (authored by adpatel6).
[LangRef] Define mustprogress attribute
Oct 19 2020, 10:36 AM
atmnpatel closed D86233: [LangRef] Define mustprogress attribute.
Oct 19 2020, 10:35 AM · Restricted Project