In D121283#3392137, @thakis wrote:

The commit message got a bit mutilated: 33a9eac6aaa495fce6fd9b17cd48aa57a95461e6

Just FYI in case you didn't notice. In that case, update your commit workflow to make sure this doesn't happen next time :)

Mar 18 2022, 5:48 AM · Restricted Project, Restricted Project

egorzhdan committed rG33a9eac6aaa4: [Clang] Support multiple attributes in a single pragma (authored by egorzhdan).

[Clang] Support multiple attributes in a single pragma

Mar 18 2022, 5:21 AM · Restricted Project

egorzhdan closed D121283: [Clang] Support multiple attributes in a single pragma.

Mar 18 2022, 5:20 AM · Restricted Project, Restricted Project

Mar 17 2022

egorzhdan updated the diff for D121283: [Clang] Support multiple attributes in a single pragma.

Fix off-by-one error in fix-it generation logic: the last SubjectMatchRule

(SubjectMatchRule_variable_not_is_parameter) was not handled properly

Add a test for this

Mar 17 2022, 12:21 PM · Restricted Project, Restricted Project

egorzhdan requested review of D121911: [Clang] Add DriverKit support.

Mar 17 2022, 6:49 AM · Restricted Project, Restricted Project

Mar 15 2022

egorzhdan added a comment to D121283: [Clang] Support multiple attributes in a single pragma.

Thanks for the review @aaron.ballman!

Mar 15 2022, 11:47 AM · Restricted Project, Restricted Project

egorzhdan updated the diff for D121283: [Clang] Support multiple attributes in a single pragma.

Merge two test files into one to speed up testing

Mar 15 2022, 11:46 AM · Restricted Project, Restricted Project

Mar 14 2022

egorzhdan updated the diff for D121283: [Clang] Support multiple attributes in a single pragma.

Only allow one attribute syntax style per directive
Adjust documentation
Add a release note

Mar 14 2022, 1:25 PM · Restricted Project, Restricted Project

egorzhdan added a comment to D121283: [Clang] Support multiple attributes in a single pragma.

In D121283#3379225, @aaron.ballman wrote:

As a thought experiment, would it make sense to lift the restriction on the number of attributes allowed in a pragma, but not allow multiple attribute specifiers?

Mar 14 2022, 12:58 PM · Restricted Project, Restricted Project

egorzhdan committed rG6ca2f1938f96: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array… (authored by egorzhdan).

[Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array…

Mar 14 2022, 5:48 AM · Restricted Project

egorzhdan closed D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument.

Mar 14 2022, 5:47 AM · Restricted Project, Restricted Project

egorzhdan updated the diff for D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument.

Rename a lambda to improve readability

Mar 14 2022, 5:11 AM · Restricted Project, Restricted Project

Mar 11 2022

egorzhdan added a comment to D121283: [Clang] Support multiple attributes in a single pragma.

In D121283#3373560, @aaron.ballman wrote:

why do we support multiple attribute *specifiers* in the same pragma? I would not expect to be able to mix attribute styles in the same pragma given that all of the individual styles allow you to specify multiple attributes within a single specifier

Mar 11 2022, 11:32 AM · Restricted Project, Restricted Project

egorzhdan requested review of D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument.

Mar 11 2022, 10:02 AM · Restricted Project, Restricted Project

Mar 9 2022

egorzhdan updated the diff for D121283: [Clang] Support multiple attributes in a single pragma.

Remove unused include

Mar 9 2022, 4:48 AM · Restricted Project, Restricted Project

egorzhdan added a reviewer for D121283: [Clang] Support multiple attributes in a single pragma: aaron.ballman.

Mar 9 2022, 4:47 AM · Restricted Project, Restricted Project

egorzhdan requested review of D121283: [Clang] Support multiple attributes in a single pragma.

Mar 9 2022, 4:46 AM · Restricted Project, Restricted Project

Mar 7 2022

egorzhdan added reviewers for D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes: ldionne, var-const, zoecarver, Mordante.

Mar 7 2022, 11:38 AM · Restricted Project, Restricted Project

Herald added a project to D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features: Restricted Project.

Apologies for landing this too quickly! I'll adjust this logic in a separate patch: https://reviews.llvm.org/D121141

Mar 7 2022, 11:37 AM · Restricted Project, Restricted Project

egorzhdan requested review of D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes.

Mar 7 2022, 11:36 AM · Restricted Project, Restricted Project

Mar 1 2022

egorzhdan committed rG3cdc1c155b40: [Clang] Add `-funstable` flag to enable unstable and experimental features (authored by egorzhdan).

[Clang] Add `-funstable` flag to enable unstable and experimental features

Mar 1 2022, 4:35 AM

egorzhdan closed D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features.

Mar 1 2022, 4:35 AM · Restricted Project, Restricted Project

Feb 22 2022

egorzhdan committed rG3a1cb362370d: Add DriverKit support (authored by egorzhdan).

Add DriverKit support

Feb 22 2022, 5:43 AM

egorzhdan closed D118046: Add DriverKit support.

Feb 22 2022, 5:43 AM · Restricted Project

Feb 18 2022

egorzhdan added reviewers for D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features: ldionne, zoecarver, var-const.

Feb 18 2022, 1:12 PM · Restricted Project, Restricted Project

egorzhdan requested review of D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features.

Feb 18 2022, 1:11 PM · Restricted Project, Restricted Project

Feb 17 2022

egorzhdan updated the diff for D118046: Add DriverKit support.

Add unit-tests to verify that DriverKit version defaults to 19
Use DriverKit 20 as a minimum available version on arm & add a test for it

Feb 17 2022, 12:11 PM · Restricted Project

Feb 15 2022

egorzhdan added a comment to D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references.

Thank you @dgoldman, this approach looks good to me.
I don't have anything to add other than what @sammccall has already commented.

Feb 15 2022, 5:32 AM · Restricted Project

Feb 2 2022

egorzhdan accepted D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token.

LGTM!

Feb 2 2022, 6:17 AM · Restricted Project

Feb 1 2022

egorzhdan abandoned D117931: [Clang] Support `address_space` attribute in `#pragma clang attribute.

Thanks @aaron.ballman for your feedback. I will probably abandon this change until we have a more compelling reason to apply attributes to types via pragmas.

Feb 1 2022, 11:08 AM · Restricted Project