Oct 2 2018
Sep 26 2018
Sep 25 2018
After writing the last comment and thinking about this some more, I convinced myself that this is more of a problem with interceptors than exception handlers.
@rnk, do I guess correctly that the runtime pretty deeply assumes that it will never be unloaded? Interceptions, exception handlers, etc. never get cleaned up? If that's the case then I don't feel too bad about this hack. But if unloading is supported by the design, then maybe we should do something more graceful than this.
Sep 20 2018
Sep 14 2018
Sep 7 2018
This isn't strictly necessary for anything; I was just debugging something and noticed that a hook fell back to Trampoline rather than Hotpatch because the prefix nop was only 8 bytes.
Aug 16 2018
This broke Windows debug builds where MemalignFromLocalPool becomes an unresolved external. (I guess in optimized builds the call within the if(0) gets optimized away.)
Jun 5 2018
I don't know this code well enough to be a proper reviewer, but I want to offer moral support for this change. Not having atime updates on NTFS can be frustrating at times.
May 11 2018
May 4 2018
May 1 2018
Fixed AddrIsInMidShadow too.
Hmm, come to think of it, AddrIsInMidShadow has the same bug, right?
Apr 30 2018
Dec 14 2017
Anyway, I'm just venting. If rnk@ wants to lgtm this, I'm fine.
Dec 6 2017
@ruiu Does this patch look ok?
Nov 22 2017
While writing a test I found a problem: the code that infers /entry should not run if we've previously defined one in a drectve. (In Mozilla's build, it worked by accident because the drectve was redundantly specifying the same function that got inferred.) Updated the patch.
Nov 20 2017
Added a test. If this looks OK, do you mind landing it for me?