Page MenuHomePhabricator
Feed Advanced Search

May 25 2019

whitequark accepted D62456: [LLVM-C] Improve Bindings to The Internalize Pass.

LGTM. Maybe a comment about expected lifetime of Context would be useful, but it seems fairly obvious.

May 25 2019, 2:25 PM · Restricted Project

May 18 2019

whitequark abandoned D26501: [LICM] Retain load instruction invariant metadata when hoisting.
May 18 2019, 3:45 PM · Restricted Project
whitequark accepted D60378: [LLVM-C] Add Accessor for Mach-O Universal Binary Slices.

LGTM

May 18 2019, 3:45 PM · Restricted Project

May 5 2019

whitequark accepted D61567: [llvm-c-test] Make include-all.c do what its name says it does.
May 5 2019, 3:45 PM · Restricted Project
whitequark accepted D61568: [llvm-c] Make LLVMGetStringErrorTypeId a proper prototype.
May 5 2019, 3:45 PM · Restricted Project

Apr 24 2019

whitequark accepted D61034: [bindings/go] Add wrappers for atomic operations..

LGTM

Apr 24 2019, 7:25 AM · Restricted Project
whitequark accepted D60524: [LLVM-C] Deprecate the LLVMValueRef-returning metadata creation functions.

LGTM

Apr 24 2019, 6:34 AM · Restricted Project
whitequark committed rG50392a3b1b84: [LLVM-C] Use dyn_cast instead of unwrap in LLVMGetDebugLoc functions (authored by whitequark).
[LLVM-C] Use dyn_cast instead of unwrap in LLVMGetDebugLoc functions
Apr 24 2019, 6:29 AM
whitequark committed rL359093: [LLVM-C] Use dyn_cast instead of unwrap in LLVMGetDebugLoc functions.
[LLVM-C] Use dyn_cast instead of unwrap in LLVMGetDebugLoc functions
Apr 24 2019, 6:29 AM
whitequark closed D60473: [LLVM-C] Use dyn_cast instead of unwrap in LLVMGetDebugLoc functions.
Apr 24 2019, 6:29 AM · Restricted Project

Apr 21 2019

whitequark accepted D60527: [LLVM-C] Add accessors to the default floating-point metadata node.

LGTM

Apr 21 2019, 1:10 AM · Restricted Project

Apr 16 2019

whitequark accepted D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.

LGTM

Apr 16 2019, 2:35 PM · Restricted Project
whitequark committed rGd465ee662dfa: [OCaml] Update api to account for FNeg and CallBr instructions (authored by whitequark).
[OCaml] Update api to account for FNeg and CallBr instructions
Apr 16 2019, 7:59 AM
whitequark committed rL358501: [OCaml] Update api to account for FNeg and CallBr instructions.
[OCaml] Update api to account for FNeg and CallBr instructions
Apr 16 2019, 7:58 AM
whitequark closed D60680: [OCaml] Update api to account for FNeg and CallBr instructions.
Apr 16 2019, 7:58 AM · Restricted Project

Apr 15 2019

whitequark accepted D60680: [OCaml] Update api to account for FNeg and CallBr instructions.

LGTM

Apr 15 2019, 9:55 AM · Restricted Project

Apr 9 2019

whitequark accepted D60489: [LLVM-C] Add DIFile Field Accesssors.

LGTM

Apr 9 2019, 3:37 PM · Restricted Project
whitequark accepted D60484: [LLVM-C] Correct The Current Debug Location Accessors.

LGTM

Apr 9 2019, 3:28 PM · Restricted Project
whitequark added inline comments to D60484: [LLVM-C] Correct The Current Debug Location Accessors.
Apr 9 2019, 3:11 PM · Restricted Project
whitequark accepted D60481: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc.

LGTM

Apr 9 2019, 3:11 PM · Restricted Project
whitequark added a comment to D52239: [OCaml] Add OCaml APIs to access DebugLoc info.

I agree with @CodaFi, it's better to build on LLVMDILocation* functions here, if for no other reason that they are more robust (and not deprecated).

Apr 9 2019, 2:53 PM · Restricted Project
whitequark added inline comments to D60481: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc.
Apr 9 2019, 2:53 PM · Restricted Project
whitequark added inline comments to D60484: [LLVM-C] Correct The Current Debug Location Accessors.
Apr 9 2019, 2:49 PM · Restricted Project
whitequark accepted D60473: [LLVM-C] Use dyn_cast instead of unwrap in LLVMGetDebugLoc functions.

So, these are going to be deprecated in D60484, but I see no harm in merging this patch, as it's a straightforward bugfix.

Apr 9 2019, 2:48 PM · Restricted Project
whitequark added a comment to D60407: [LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries.

Yup, good catch! I'll make sure to check for this in the future as well.

Apr 9 2019, 2:45 PM · Restricted Project

Apr 8 2019

whitequark accepted D60407: [LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries.

LGTM

Apr 8 2019, 7:46 AM · Restricted Project

Apr 6 2019

whitequark accepted D60366: [LLVM-C] Allow Access to the Type of a Binary.
Apr 6 2019, 9:39 PM · Restricted Project

Apr 5 2019

whitequark accepted D60322: [LLVM-C] Begin to Expose A More General Binary Interface.

LGTM

Apr 5 2019, 1:55 PM · Restricted Project
whitequark accepted D59658: [LLVM-C] Add bindings to insert basic blocks.

LGTM

Apr 5 2019, 1:28 PM · Restricted Project
whitequark added a comment to D59658: [LLVM-C] Add bindings to insert basic blocks.

Sure.

Apr 5 2019, 1:08 PM · Restricted Project
whitequark added a comment to D59658: [LLVM-C] Add bindings to insert basic blocks.

Agreed; I think it should still have Existing in the name if it takes a reference to a block, to distinguish from the existing set of (somewhat poorly named) functions.

Apr 5 2019, 1:00 PM · Restricted Project
whitequark added a comment to D60322: [LLVM-C] Begin to Expose A More General Binary Interface.

SGTM, just one question about ownership.

Apr 5 2019, 12:44 PM · Restricted Project
whitequark added a comment to D60322: [LLVM-C] Begin to Expose A More General Binary Interface.

Can you provide a bit more context for this change? It looks good, I just want to understand the plan here in more detail.

Apr 5 2019, 12:28 PM · Restricted Project
whitequark added a comment to D59658: [LLVM-C] Add bindings to insert basic blocks.

I think the names are confusing. Why not something like LLVMInsertExistingBasicBlock and LLVMAppendExistingBasicBlock?

Apr 5 2019, 12:24 PM · Restricted Project

Apr 4 2019

whitequark added a comment to D52694: [bindings/go] Add EraseFromParent.

@aykevl I think you can ask for commit access, you've had more than a few patches merged.

Apr 4 2019, 3:31 PM · Restricted Project

Mar 25 2019

whitequark accepted D59697: [LLVM-C] Add binding to look up intrinsic by name.

LGTM

Mar 25 2019, 7:40 AM · Restricted Project

Mar 11 2019

whitequark accepted D58624: [LLVM-C] Expose the "Add Discriminators" Pass To LLVM-C.

LGTM

Mar 11 2019, 12:47 AM · Restricted Project
whitequark added inline comments to D58733: [LLVM-C] Move and Clean Up The Instrumentation Pass Bindings.
Mar 11 2019, 12:42 AM · Restricted Project

Feb 20 2019

whitequark accepted D58438: [LLVM-C] Add bindings to add DIGlobalVariableExpression to GlobalVariable..

LGTM

Feb 20 2019, 4:34 AM

Feb 17 2019

whitequark added inline comments to D58334: [LLVM-C] Add bindings to create macro debug info.
Feb 17 2019, 3:46 PM · Restricted Project

Feb 16 2019

whitequark committed rG21da42945b72: [bindings/go] Fix building on 32-bit systems (ARM etc.) (authored by whitequark).
[bindings/go] Fix building on 32-bit systems (ARM etc.)
Feb 16 2019, 2:35 PM
whitequark committed rL354207: [bindings/go] Fix building on 32-bit systems (ARM etc.).
[bindings/go] Fix building on 32-bit systems (ARM etc.)
Feb 16 2019, 2:35 PM
whitequark closed D58030: [bindings/go] Fix building on 32-bit systems (ARM etc.).
Feb 16 2019, 2:35 PM · Restricted Project
whitequark accepted D58323: [LLVM-C] Add bindings to create enumerators.

LGTM

Feb 16 2019, 2:35 PM · Restricted Project

Feb 12 2019

whitequark committed rG77ccc2eba4b2: [SelectionDAG] Fix return calling convention in expansion of ?MULO (authored by whitequark).
[SelectionDAG] Fix return calling convention in expansion of ?MULO
Feb 12 2019, 8:42 AM
whitequark committed rL353854: [SelectionDAG] Fix return calling convention in expansion of ?MULO.
[SelectionDAG] Fix return calling convention in expansion of ?MULO
Feb 12 2019, 8:42 AM
whitequark closed D45355: [SelectionDAG] Fix return calling convention in expansion of ?MULO.
Feb 12 2019, 8:42 AM · Restricted Project

Feb 11 2019

whitequark updated the diff for D45355: [SelectionDAG] Fix return calling convention in expansion of ?MULO.

Addressed review

Feb 11 2019, 10:53 PM · Restricted Project
whitequark updated the diff for D45355: [SelectionDAG] Fix return calling convention in expansion of ?MULO.

Added diff context

Feb 11 2019, 9:22 AM · Restricted Project
whitequark updated the diff for D45355: [SelectionDAG] Fix return calling convention in expansion of ?MULO.

Added a test, based on the one provided by @george-hopkins but modified to pass on master.

Feb 11 2019, 9:13 AM · Restricted Project
whitequark accepted D58030: [bindings/go] Fix building on 32-bit systems (ARM etc.).

Seems fine, with or without the length change. Hopefully this can get into 8.0.

Feb 11 2019, 3:16 AM · Restricted Project

Jan 25 2019

whitequark accepted D56177: [LLVM-C] Add Bindings to GlobalIFunc.

LGTM. Sorry for the delay

Jan 25 2019, 1:40 PM · Restricted Project

Jan 16 2019

whitequark accepted D56815: [FunctionComparator] Consider tail call kinds.

LGTM

Jan 16 2019, 3:17 PM

Jan 14 2019

whitequark added inline comments to D56556: [opaque pointer types] Update CallInst creation APIs to consistently accept a callee-type argument..
Jan 14 2019, 9:42 AM
whitequark accepted D56669: Remove NameLen argument from newly-introduced IR C APIs..
Jan 14 2019, 9:18 AM
whitequark added inline comments to D56556: [opaque pointer types] Update CallInst creation APIs to consistently accept a callee-type argument..
Jan 14 2019, 9:00 AM
whitequark added inline comments to D56556: [opaque pointer types] Update CallInst creation APIs to consistently accept a callee-type argument..
Jan 14 2019, 5:42 AM

Jan 10 2019

whitequark added inline comments to D56557: [opaque pointer types] Update InvokeInst creation APIs to consistently accept a callee-type argument..
Jan 10 2019, 7:40 PM
whitequark updated subscribers of D56556: [opaque pointer types] Update CallInst creation APIs to consistently accept a callee-type argument..
Jan 10 2019, 7:38 PM
whitequark requested changes to D56557: [opaque pointer types] Update InvokeInst creation APIs to consistently accept a callee-type argument..
Jan 10 2019, 7:35 PM
whitequark requested changes to D56556: [opaque pointer types] Update CallInst creation APIs to consistently accept a callee-type argument..
Jan 10 2019, 7:35 PM
whitequark accepted D56574: [MergeFunc] Erase unused duplicate functions if they are discardable.

LGTM, thanks!

Jan 10 2019, 7:26 PM

Jan 6 2019

whitequark accepted D53884: [bindings/go] Add bindings to LLVMGet?CmpPredicate.

LGTM

Jan 6 2019, 1:19 PM · Restricted Project

Jan 3 2019

whitequark accepted D56280: [LLVM-C] Allow Specifying Signedness in Int Cast.

LGTM

Jan 3 2019, 5:34 PM
whitequark accepted D56279: [LLVM-C] Allow For Creating a BasicBlock without a Parent Function.

LGTM

Jan 3 2019, 5:33 PM

Jan 1 2019

whitequark accepted D56187: [LLVM-C] Expand LLVMRelocMode.

LGTM

Jan 1 2019, 2:16 PM

Dec 31 2018

whitequark accepted D56179: [LLVM-C] Add Accessors for Discarding Value Names in the IR.

LGTM

Dec 31 2018, 12:55 PM

Nov 7 2018

whitequark committed rL346388: [bindings/go] Add Go bindings to LLVMGetIndices.
[bindings/go] Add Go bindings to LLVMGetIndices
Nov 7 2018, 8:06 PM
whitequark closed D53883: [bindings/go] Add Go bindings to LLVMGetIndices.
Nov 7 2018, 8:06 PM
whitequark committed rL346387: [OCaml] Fix incorrect use of CAMLlocal in nested blocks.
[OCaml] Fix incorrect use of CAMLlocal in nested blocks
Nov 7 2018, 8:04 PM
whitequark closed D53841: [OCaml] Fix incorrect use of CAMLlocal in nested blocks.
Nov 7 2018, 8:04 PM
whitequark added a comment to D53841: [OCaml] Fix incorrect use of CAMLlocal in nested blocks.

@CodaFi Did you mean to commentn on D52210? I'm confused here...

Nov 7 2018, 8:04 PM
whitequark committed rL346386: [MergeFuncs] Improve ordering of equal functions.
[MergeFuncs] Improve ordering of equal functions
Nov 7 2018, 8:00 PM
whitequark closed D53271: [MergeFuncs] Improve ordering of equal functions.
Nov 7 2018, 8:00 PM
whitequark committed rL346385: [MergeFuncs] Call removeUsers() prior to unnamed_addr RAUW.
[MergeFuncs] Call removeUsers() prior to unnamed_addr RAUW
Nov 7 2018, 8:00 PM
whitequark added a comment to D53285: [MergeFuncs] Generate alias instead of thunk if possible (default disabled).

As I don't have commit rights, could you please commit D53262, D53271 and this revision?

Nov 7 2018, 8:00 PM
whitequark closed D53262: [MergeFuncs] Call removeUsers() prior to unnamed_addr RAUW.
Nov 7 2018, 8:00 PM

Oct 31 2018

whitequark accepted D53883: [bindings/go] Add Go bindings to LLVMGetIndices.
Oct 31 2018, 12:38 AM

Oct 29 2018

whitequark accepted D52239: [OCaml] Add OCaml APIs to access DebugLoc info.
Oct 29 2018, 3:52 PM · Restricted Project
whitequark accepted D53841: [OCaml] Fix incorrect use of CAMLlocal in nested blocks.
Oct 29 2018, 3:51 PM
whitequark accepted D53626: [LLVM-C] Improve Intrinsics Bindings.
Oct 29 2018, 9:25 AM
whitequark accepted D53285: [MergeFuncs] Generate alias instead of thunk if possible (default disabled).
Oct 29 2018, 3:19 AM
whitequark added inline comments to D53285: [MergeFuncs] Generate alias instead of thunk if possible (default disabled).
Oct 29 2018, 2:57 AM
whitequark accepted D52694: [bindings/go] Add EraseFromParent.
Oct 29 2018, 12:00 AM · Restricted Project

Oct 28 2018

whitequark added inline comments to D52239: [OCaml] Add OCaml APIs to access DebugLoc info.
Oct 28 2018, 11:57 PM · Restricted Project
whitequark added inline comments to D53285: [MergeFuncs] Generate alias instead of thunk if possible (default disabled).
Oct 28 2018, 11:55 PM
whitequark accepted D53271: [MergeFuncs] Improve ordering of equal functions.
Oct 28 2018, 11:52 PM
whitequark requested changes to D53626: [LLVM-C] Improve Intrinsics Bindings.

LGTM other than the argument types.

Oct 28 2018, 11:52 PM
whitequark accepted D53555: [LLVM-C] Add Builder Bindings to Common Memory Intrinsics.

LGTM, and I am OK with merging a test later if that is more convenient. This is not a particularly complex change.

Oct 28 2018, 11:52 PM

Oct 15 2018

whitequark added a comment to D45355: [SelectionDAG] Fix return calling convention in expansion of ?MULO.

@george-hopkins Thanks, I will take a look.

Oct 15 2018, 7:24 AM · Restricted Project

Oct 14 2018

whitequark accepted D53262: [MergeFuncs] Call removeUsers() prior to unnamed_addr RAUW.

LGTM, thanks for fixing this!

Oct 14 2018, 7:24 PM

Oct 10 2018

whitequark accepted D52210: [LLVM-C] Add C APIs to access DebugLoc info.

Looks good to me now, thanks @compnerd !

Oct 10 2018, 12:39 PM

Oct 8 2018

whitequark accepted D52972: [bindings/go] Add Go bindings for CalledValue.
Oct 8 2018, 11:03 AM · Restricted Project

Sep 29 2018

whitequark accepted D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.

LGTM, thanks!

Sep 29 2018, 3:34 PM
whitequark added inline comments to D52694: [bindings/go] Add EraseFromParent.
Sep 29 2018, 9:13 AM · Restricted Project
whitequark added inline comments to D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.
Sep 29 2018, 8:50 AM
whitequark requested changes to D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.
Sep 29 2018, 8:42 AM

Sep 28 2018

whitequark committed rL343345: [bindings/go] Add Go bindings to the Token type.
[bindings/go] Add Go bindings to the Token type
Sep 28 2018, 10:42 AM
whitequark closed D47684: [bindings/go] Add Go bindings to the Token type.
Sep 28 2018, 10:42 AM
whitequark committed rL343339: [bindings/go] Add Go bindings for inline assembly.
[bindings/go] Add Go bindings for inline assembly
Sep 28 2018, 9:50 AM