Page MenuHomePhabricator
Feed Advanced Search

Jul 14 2020

friss committed rGbf8cfc6924a8: [lldb/testsuite] XFail TestBuiltinTrap.py not only on linux (authored by friss).
[lldb/testsuite] XFail TestBuiltinTrap.py not only on linux
Jul 14 2020, 4:35 PM
friss committed rGc27f2ce14b5b: [lldb/testsuite] Slightly rework TestHiddenIvars.py (authored by friss).
[lldb/testsuite] Slightly rework TestHiddenIvars.py
Jul 14 2020, 4:34 PM
friss committed rG61c326901941: [lldb/testsuite] Make TestObjCIvarStripped.py working with codesigning (authored by friss).
[lldb/testsuite] Make TestObjCIvarStripped.py working with codesigning
Jul 14 2020, 4:34 PM
friss committed rGccecfb19afa8: [lldb/testsuite] Rewrite TestThreadLocal.py (authored by friss).
[lldb/testsuite] Rewrite TestThreadLocal.py
Jul 14 2020, 4:34 PM
friss committed rG19c748a60919: [lldb/testsuite] Apply @skipIfDarwinEmbedded to part of TestHWBreakMultiThread (authored by friss).
[lldb/testsuite] Apply @skipIfDarwinEmbedded to part of TestHWBreakMultiThread
Jul 14 2020, 4:34 PM
friss committed rGebcc296d719c: [lldb/testsuite] Tweak TestBreakpointLocations.py to pass for arm64 (authored by friss).
[lldb/testsuite] Tweak TestBreakpointLocations.py to pass for arm64
Jul 14 2020, 4:34 PM
friss committed rG0317eb998b53: [lldb/MemoryHistoryAsan] Fix address resolution for recorded backtraces (authored by friss).
[lldb/MemoryHistoryAsan] Fix address resolution for recorded backtraces
Jul 14 2020, 4:34 PM
friss committed rGe8d7643689ee: [lldb/testsuite] Skip TestEmptyStdModule.py if using a remote platform (authored by friss).
[lldb/testsuite] Skip TestEmptyStdModule.py if using a remote platform
Jul 14 2020, 4:34 PM
friss committed rG57321fbb2207: [lldb/testsuite] Modernize 2 test Makefiles (authored by friss).
[lldb/testsuite] Modernize 2 test Makefiles
Jul 14 2020, 4:34 PM
GitHub <noreply@github.com> committed rGc48ec726309d: Merge pull request #904 from adrian-prantl/sdk-cherry-pick (authored by friss).
Merge pull request #904 from adrian-prantl/sdk-cherry-pick
Jul 14 2020, 4:33 PM
GitHub <noreply@github.com> committed rG79260c1ae5e9: Merge pull request #855 from fredriss/xfail-some-tests (authored by friss).
Merge pull request #855 from fredriss/xfail-some-tests
Jul 14 2020, 4:30 PM
friss committed rGe0e4b3d474f3: [lldb/testsuite] Skip 2 tests failing on arm64e (authored by friss).
[lldb/testsuite] Skip 2 tests failing on arm64e
Jul 14 2020, 4:30 PM
friss committed rGc19d8391ed28: [lldb/GDBRemote] Fix obvious typo in error message. (authored by friss).
[lldb/GDBRemote] Fix obvious typo in error message.
Jul 14 2020, 4:30 PM
GitHub <noreply@github.com> committed rG4faf4ca39466: Merge pull request #854 from fredriss/cherry-pick-typo-fix (authored by friss).
Merge pull request #854 from fredriss/cherry-pick-typo-fix
Jul 14 2020, 4:30 PM
GitHub <noreply@github.com> committed rGf94ec571afdd: Merge pull request #656 from Teemperor/BackportTypeSystemClangRenameTo20200108 (authored by friss).
Merge pull request #656 from Teemperor/BackportTypeSystemClangRenameTo20200108
Jul 14 2020, 4:16 PM
friss added inline comments to D83512: [lldb/Module] Allow for the creation of memory-only modules.
Jul 14 2020, 8:49 AM · Restricted Project
friss committed rGa4a00ced0cf8: [lldb/Module] Allow for the creation of memory-only modules (authored by friss).
[lldb/Module] Allow for the creation of memory-only modules
Jul 14 2020, 8:47 AM
friss closed D83512: [lldb/Module] Allow for the creation of memory-only modules.
Jul 14 2020, 8:47 AM · Restricted Project

Jul 13 2020

friss added inline comments to D83512: [lldb/Module] Allow for the creation of memory-only modules.
Jul 13 2020, 9:54 PM · Restricted Project
friss updated the diff for D83512: [lldb/Module] Allow for the creation of memory-only modules.

I went ahead and updated all unittests to use only in-memory modules.
This required tweaking both ObjectFileELF and ObjectFilePECOFF a little.

Jul 13 2020, 9:52 PM · Restricted Project

Jul 9 2020

friss added a comment to D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache.

I think this is a very interesting feature (lldb being able to load modules from memory; the mac shared cache thingy is interesting too, but in a different way). We have a feature request from people who are downloading modules from a network (from a proprietary symbol server, etc.) and would like to pass them to lldb without having to serialize them to disk. This would be a step towards making that happen. It could also be useful for our own unit tests which now have to do a similar thing.

However, I think this could use some clean up. There's a lot of juggling of data/file/object offsets going on, and it all seems inconsistent and avoidable to me. Please see inline comments for details.

I'll see what can be done. My main goal while working on this was to avoid changing the semantics outside of the shared cache usecase. I understand fairly well the codepath that I added and then just moved some other bits around to keep the existing semantics for the rest. Happy to rework this.

So, if an object file needs to access some data which is outside of "its" image then my idea about using sliced data buffers will probably not work. It that case, using the "object offset" field to communicate the location of the "object" might not be a bad idea (it's still different than the use in .a files, but maybe we can stretch that definition). The part that bugs me then is having this functionality key off of the "data" field being set. Ideally, these would be two orthogonal features:

  • the "data" would control whether you read the file system to obtain the object contents
  • the "object offset" would tell you where to locate the desired object inside these "jumbo" objects
Jul 9 2020, 3:00 PM · Restricted Project, Restricted Project
friss added a comment to D83512: [lldb/Module] Allow for the creation of memory-only modules.

This is the generic part of https://reviews.llvm.org/D83023

Jul 9 2020, 2:41 PM · Restricted Project
Herald added a project to D83512: [lldb/Module] Allow for the creation of memory-only modules: Restricted Project.
Jul 9 2020, 2:36 PM · Restricted Project
friss committed rGe529d774c4d5: [lldb] Use enum constant instead of raw value (authored by friss).
[lldb] Use enum constant instead of raw value
Jul 9 2020, 9:44 AM

Jul 8 2020

friss accepted D83443: Fix debugserver reporting of deployment target.

LGTM

Jul 8 2020, 5:14 PM · Restricted Project

Jul 2 2020

friss added a comment to D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache.

I think this is a very interesting feature (lldb being able to load modules from memory; the mac shared cache thingy is interesting too, but in a different way). We have a feature request from people who are downloading modules from a network (from a proprietary symbol server, etc.) and would like to pass them to lldb without having to serialize them to disk. This would be a step towards making that happen. It could also be useful for our own unit tests which now have to do a similar thing.

However, I think this could use some clean up. There's a lot of juggling of data/file/object offsets going on, and it all seems inconsistent and avoidable to me. Please see inline comments for details.

Jul 2 2020, 9:42 AM · Restricted Project, Restricted Project

Jul 1 2020

friss added a comment to D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache.

@labath I tagged you mostly for the generic parts of the patch. I don't suppose you care a lot about ObjectFileMachO.cpp

Jul 1 2020, 10:43 PM · Restricted Project, Restricted Project
friss created D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache.
Jul 1 2020, 10:16 PM · Restricted Project, Restricted Project
friss committed rGc9f251aa6f62: [lldb/build.py] Always pass an SDK to the compiler on Darwin (authored by friss).
[lldb/build.py] Always pass an SDK to the compiler on Darwin
Jul 1 2020, 8:31 PM
friss committed rG61d22ef23620: [lldb/ObjCRuntime] Implement support for small method lists (authored by friss).
[lldb/ObjCRuntime] Implement support for small method lists
Jul 1 2020, 8:31 PM
friss committed rG4a674b623796: [lldb/ObjC] Add support for direct selector references (authored by friss).
[lldb/ObjC] Add support for direct selector references
Jul 1 2020, 8:31 PM

Jun 25 2020

friss accepted D82507: [lldb/Docs] Add more details to the issues with custom Python installs on macOS.

LGTM

Jun 25 2020, 10:13 AM · Restricted Project

Jun 12 2020

friss accepted D81729: [lldb] Fix that SIGWINCH crashes IOHandlerEditline when we are not using the editline backend.

LGTM, thanks!

Jun 12 2020, 8:03 AM · Restricted Project

Jun 5 2020

friss added a comment to D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB.

This LGTM, with the caveat that it doesn't handle command line tools. But we didn't handle it correctly before, so not something we need to fix here.

Jun 5 2020, 9:25 AM · Restricted Project
friss accepted D81205: [dsymutil] Don't emit N_AST symbol entries in the Mach-O companion file.

LGTM

Jun 5 2020, 8:18 AM · Restricted Project

Jun 4 2020

friss added inline comments to D81205: [dsymutil] Don't emit N_AST symbol entries in the Mach-O companion file.
Jun 4 2020, 8:56 PM · Restricted Project
friss added inline comments to D81205: [dsymutil] Don't emit N_AST symbol entries in the Mach-O companion file.
Jun 4 2020, 5:41 PM · Restricted Project

Jun 2 2020

friss abandoned D80807: [lldb/Utility] Fix DecodeUUIDBytesFromString not to access past the input buffer.

Abandon in favor of D80755

Jun 2 2020, 9:52 AM · Restricted Project
friss added inline comments to D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef.
Jun 2 2020, 9:52 AM · Restricted Project

May 29 2020

friss committed rG977f00123a6d: [lldb/test] Fix TestAppleSimulatorOSType when multiple runtimes are installed (authored by friss).
[lldb/test] Fix TestAppleSimulatorOSType when multiple runtimes are installed
May 29 2020, 8:41 AM
friss added a comment to D80807: [lldb/Utility] Fix DecodeUUIDBytesFromString not to access past the input buffer.

I would have committed this right away if it weren't for the slight change in behavior I wanted to point out. With this patch, if an input string ends with a -, it won't be consumed anymore. I suppose it doesn't matter.

May 29 2020, 8:39 AM · Restricted Project
friss created D80807: [lldb/Utility] Fix DecodeUUIDBytesFromString not to access past the input buffer.
May 29 2020, 8:39 AM · Restricted Project
friss accepted D80789: [lldb] Pass -fPIC flag even when DYLIB_ONLY is set.

LGTM

May 29 2020, 7:34 AM · Restricted Project

May 27 2020

friss accepted D80680: save_crashlog should not be using the load_addr property of an SBAddress.

Thanks for adding a test! this LGTM

May 27 2020, 6:02 PM · Restricted Project

May 20 2020

friss accepted D79398: [dsymutil] Add reproducers to dsymutil.

I don't know enough about the VFS to do a thorough review, but the high level logic SGTM

May 20 2020, 4:00 PM · Restricted Project

May 12 2020

friss committed rGd9166ad27284: [lldb/Driver] Support terminal resizing (authored by friss).
[lldb/Driver] Support terminal resizing
May 12 2020, 12:22 PM
friss closed D79654: [lldb/Driver] Support terminal resizing.
May 12 2020, 12:22 PM · Restricted Project

May 11 2020

friss added a comment to D79654: [lldb/Driver] Support terminal resizing.

If we wanted to avoid delaying the change to the next keystroke, we could reuse the same mechanism that ^C/SIGINT uses (m_input_connection.InterruptRead()). That would probably require introduction of a new EditorStatus enum, and a careful modification to the code handling the input interruption. I don't expect that to be _too_ hard, but I also don't think that's required for this change.

I gave this a try, and indeed the changes do not seem too involved, but there's a bunch of details I don't get. Editline::Interrupt() and Editline::Cancel() take m_output_mutex before interrupting. If I do a similar thing in a resize handler, I don't see what prevents the signal to be delivered while the lock is held by GetLines but before it is released in GetCharacter.

May 11 2020, 7:59 PM · Restricted Project
friss added a comment to D79654: [lldb/Driver] Support terminal resizing.

Yes, resizing the window (or doing any other nontrivial task) from within a signal handler is a bad idea. Making a note of the signal and then bailing out is the right approach. Though, to be fully strictly correct, the variable ought to be a volatile std::sig_atomic_t instead of a plain bool. This still won't make the whole thing async-signal-safe (I haven't inspected the whole SIGWINCH call stack, but I am sure there are still some unsafe operations there), but it's a step towards that.

May 11 2020, 6:55 PM · Restricted Project
friss updated the diff for D79654: [lldb/Driver] Support terminal resizing.

Use sig_atomic_t as Pavel suggested

May 11 2020, 6:55 PM · Restricted Project

May 9 2020

friss committed rGc9537b9cc862: [lldb/debugserver] Include TargetConditionals.h where needed (authored by friss).
[lldb/debugserver] Include TargetConditionals.h where needed
May 9 2020, 10:37 AM

May 8 2020

friss created D79654: [lldb/Driver] Support terminal resizing.
May 8 2020, 4:08 PM · Restricted Project

May 6 2020

friss added inline comments to D79554: [lldb/Dataformatter] Add support to CF{Dictionary,Set}Ref types.
May 6 2020, 11:59 PM · Restricted Project
friss accepted D79536: [dsymutil] Avoid relocating DW_AT_call_pc twice.

Thanks for the test case!

May 6 2020, 6:46 PM · Restricted Project
friss added inline comments to D79513: [dsymutil] Print statistics about debug_info reduction in verbose mode..
May 6 2020, 2:09 PM · Restricted Project
friss accepted D79513: [dsymutil] Print statistics about debug_info reduction in verbose mode..

LGTM, with one potential suggestion:

May 6 2020, 1:35 PM · Restricted Project

May 5 2020

friss accepted D79273: Add an explicit API to read the Xcode SDK DWARF attribute from compile units.

This looks good to me. If a similar API made sense on Module, I guess it can live on SymboleFile.

May 5 2020, 9:41 AM

May 4 2020

friss accepted D79376: [dsymutil] Thread the VFS through dsymutil (NFC).

I don't know much about the VFS itself, but those ,technical changes look good

May 4 2020, 5:13 PM · Restricted Project

Apr 22 2020

friss added inline comments to D78675: Add an internal bit to the XcodeSDK class.
Apr 22 2020, 6:31 PM · Restricted Project

Apr 6 2020

friss updated the diff for D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr.

Remove the now useless code in TypeSummary.cpp, and change the C++
implementation of IsNilReference() to return true soemtimes. This
breaks other tests though...

Apr 6 2020, 9:16 PM · Restricted Project
friss added a comment to D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr.

This looks like what I'd like to implement, but unfortunately it breaks other tests. Some C tests start printing null pointers as nullptr too. I suppose this is because the expression evaluator is always in C++ mode. Is there a way to get the origin type/language of a variable through a ValueObject?

Apr 6 2020, 9:16 PM · Restricted Project
friss committed rG06ea05a3fbc6: [lldb/test] Fix TestDSYMSourcePathRemapping in the presence of symlnks (authored by friss).
[lldb/test] Fix TestDSYMSourcePathRemapping in the presence of symlnks
Apr 6 2020, 8:11 PM
friss updated the diff for D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr.

Implement null C++ printing at the ValueObjectPrinter level

Apr 6 2020, 8:10 PM · Restricted Project

Apr 1 2020

friss added a comment to D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr.

I was checking whether there is a way to catch null pointer before a type summary is even chosen. And found out that such logic exists, but only for Objective-C. Languages have a IsNilReference() virtual method that can tell whether a ValueObject is a nil reference. It's only implemented for ObjectiveC and value objects that test positive for this method are displayed as "nil" is the generic code of ValueObjectPrinter.cpp. I can see a few options:

  • I can rework the patch to affect only the libc++ string formatter which was the issue I was trying to solve in the first place
  • I can implement IsNilReference() for C++ and change ValueObjectPrinter to print C++ "nil references" as "nullptr".
  • I do the above and add another customization point in the Language plugins which tells ValueObjectPrinter out to display "nil" references, so that there's no Language specific code in ValueObjectPrinter.
Apr 1 2020, 3:45 PM · Restricted Project
friss added a comment to D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr.

It might be worth mentioning though that the title of the patch is somewhat misleading -- I believe the CXX in CXXFunctionSummaryFormat refers to the language the formatter is implemented in, not the language of the type itself. So this patch affects all types whose formatters are implemented as c++ functions, not all c++ pointers in the target program.

Apr 1 2020, 3:12 PM · Restricted Project

Mar 31 2020

friss created D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr.
Mar 31 2020, 10:52 AM · Restricted Project
friss added a comment to D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr.

I haven't tested the libstdc++ part, would be great if someone could confirm this works.

Mar 31 2020, 10:52 AM · Restricted Project
friss accepted D77123: [lldb] Inherit host environment when running shell commands.

I agree host shell command should run with the host environment.

Mar 31 2020, 8:16 AM · Restricted Project

Mar 27 2020

friss added a comment to D76955: [lldb/Test] Decode stdout and stderr in case it contains UTF-8.

I think this won't work with Python3, were out and err will be already "decoded" str objects

Mar 27 2020, 4:00 PM · Restricted Project

Mar 26 2020

friss added a comment to D76835: [lldb] Fix TestSettings.test_pass_host_env_vars on windows.

Thanks for fixing this Pavel!

Mar 26 2020, 9:11 AM · Restricted Project

Mar 23 2020

friss committed rGb6ae8937e031: [lldb/PlatformDarwin] Always delete destination file first in PutFile (authored by friss).
[lldb/PlatformDarwin] Always delete destination file first in PutFile
Mar 23 2020, 2:44 PM
friss closed D76450: [lldb/PlatformDarwin] Always delete destination file first in PutFile.
Mar 23 2020, 2:44 PM · Restricted Project
friss committed rG7e10581e8c15: [lldb/testsuite] Skip part of TestSettings.py on windows (authored by friss).
[lldb/testsuite] Skip part of TestSettings.py on windows
Mar 23 2020, 9:17 AM
friss committed rGb4a6e63ea123: [lldb/Target] Rework the way the inferior environment is created (authored by friss).
[lldb/Target] Rework the way the inferior environment is created
Mar 23 2020, 8:10 AM
friss closed D76470: [lldb/Target] Rework the way the inferior environment is created.
Mar 23 2020, 8:09 AM · Restricted Project
friss committed rGcd7b45057ca9: [lldb/API] Make Launch(Simple) use args and env from target properties (authored by friss).
[lldb/API] Make Launch(Simple) use args and env from target properties
Mar 23 2020, 8:09 AM
friss committed rG9228a9efc6c5: [lldb/Target] Initialize new targets environment variables from target.env-vars (authored by friss).
[lldb/Target] Initialize new targets environment variables from target.env-vars
Mar 23 2020, 8:09 AM
friss closed D76045: [lldb/API] Make Launch(Simple) use args and env from target properties.
Mar 23 2020, 8:09 AM · Restricted Project
friss closed D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars.
Mar 23 2020, 8:09 AM · Restricted Project

Mar 20 2020

friss updated the diff for D76470: [lldb/Target] Rework the way the inferior environment is created.

Simplify command definition

Mar 20 2020, 6:59 PM · Restricted Project
friss added a comment to D76470: [lldb/Target] Rework the way the inferior environment is created.

Is there any command-based way to see the entire environment that a process will get when it launches? By populating target.env-vars with the inherited environment there was a way to mostly do that, but I don't see that anymore. It seems a shame not to be able to see that...

No, there is no way to do this, but it's not really a regression. If you do settings show target.env-vars today before running then you won't see what is going to be passed. Only after the first run will it be populated. This was a surprise to me and I find it highly inconsistent. Maybe I can add another property that would get updated with the computed environment. Do we have anything like read-only properties?

No, but I don't think I'd do this with a property anyway. You are asking the target to compute the result of the various settings that affect the environment of a process it might launch. That sounds more like the result of a command ("target show-environment" or something like that.) If we knew how to get the environment from a running process, the same command could show the current environment in a running process, which would sometimes be handy.

I agree the behavior before was pretty unhelpful, so I don't think you need to add a new command to access this in this change set. But we should put it on our list of things to do.

Mar 20 2020, 4:18 PM · Restricted Project
friss updated the diff for D76470: [lldb/Target] Rework the way the inferior environment is created.

Add a new target command to dump the launch environment
Make env-vars override unset-env-vars

Mar 20 2020, 4:18 PM · Restricted Project
friss added a comment to D76470: [lldb/Target] Rework the way the inferior environment is created.

Is there any command-based way to see the entire environment that a process will get when it launches? By populating target.env-vars with the inherited environment there was a way to mostly do that, but I don't see that anymore. It seems a shame not to be able to see that...

Mar 20 2020, 11:23 AM · Restricted Project
friss updated the diff for D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars.

Make helper function name more descriptive.

Mar 20 2020, 9:44 AM · Restricted Project
friss added a comment to D76470: [lldb/Target] Rework the way the inferior environment is created.

I think this is a good change, and is in line with what we have discussed previously. I have just one question about the exact variable interactions here.

Since the raison d'être of the new setting is to be able to "un-inherit" a particular environment variable, I'm wondering if it should only take effect if inherit-env is true (as otherwise you can achieve the same effect by deleting stuff from env-vars)? So instead of the current flow, the sequence would be:

Mar 20 2020, 9:44 AM · Restricted Project
friss updated the diff for D76470: [lldb/Target] Rework the way the inferior environment is created.

Add tests and update m_launch_info when undet-vars change.
Improve docs.

Mar 20 2020, 9:44 AM · Restricted Project

Mar 19 2020

friss created D76470: [lldb/Target] Rework the way the inferior environment is created.
Mar 19 2020, 6:39 PM · Restricted Project
friss added a comment to D76470: [lldb/Target] Rework the way the inferior environment is created.

This needs some tests, but I wanted to put it out there for comments.

Mar 19 2020, 6:39 PM · Restricted Project
friss created D76450: [lldb/PlatformDarwin] Always delete destination file first in PutFile.
Mar 19 2020, 1:42 PM · Restricted Project
friss committed rG76a5451a524c: [lldb/testsuite] un-XFail TestInlineStepping.py on linux and windows (authored by friss).
[lldb/testsuite] un-XFail TestInlineStepping.py on linux and windows
Mar 19 2020, 9:48 AM
friss committed rGecc6c426977f: [lldb/testsuite] Fix TestInlineStepping on arm64 with newer compilers (authored by friss).
[lldb/testsuite] Fix TestInlineStepping on arm64 with newer compilers
Mar 19 2020, 8:38 AM
friss committed rG8758d02074be: [lldb/testsuite] Skip part of TestProcessCrashInfo.py on Darwin embedded (authored by friss).
[lldb/testsuite] Skip part of TestProcessCrashInfo.py on Darwin embedded
Mar 19 2020, 8:38 AM
friss committed rGe154cbb124a6: [lldb/testsuite] XFail TestBuiltinTrap.py not only on linux (authored by friss).
[lldb/testsuite] XFail TestBuiltinTrap.py not only on linux
Mar 19 2020, 8:38 AM
friss closed D76406: [lldb/testsuite] Fix TestInlineStepping on arm64 with newer compilers.
Mar 19 2020, 8:38 AM · Restricted Project
friss closed D76408: [lldb/testsuite] XFail TestBuiltinTrap.py not only on linux.
Mar 19 2020, 8:38 AM · Restricted Project
friss abandoned D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py.

I skipped the test for embedded in 8758d02074be7b80b804fad19e8b7de6ebd43c31. I'll abandon this for now

Mar 19 2020, 8:37 AM · Restricted Project
friss added a comment to D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py.

Could the inferior manually wipe the crash annotation?

Mar 19 2020, 7:31 AM · Restricted Project

Mar 18 2020

friss created D76408: [lldb/testsuite] XFail TestBuiltinTrap.py not only on linux.
Mar 18 2020, 9:42 PM · Restricted Project
friss created D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py.
Mar 18 2020, 9:42 PM · Restricted Project
friss created D76406: [lldb/testsuite] Fix TestInlineStepping on arm64 with newer compilers.
Mar 18 2020, 9:10 PM · Restricted Project