Page MenuHomePhabricator
Feed Advanced Search

Fri, Feb 7

friss added inline comments to D74187: [lldb] Add method Language::IsMangledName.
Fri, Feb 7, 5:53 PM · Restricted Project
friss added a comment to D74157: [lldb/API] NFC: Reformat SBThread::GetStopDescription().

I think we're on the same page then.

Fri, Feb 7, 11:03 AM · Restricted Project
friss updated the diff for D74157: [lldb/API] NFC: Reformat SBThread::GetStopDescription().

Remove the fallback code and assert that StopInfo returns a non-empty string.

Fri, Feb 7, 11:03 AM · Restricted Project
friss accepted D74212: [lldb/Target] Fix `frame recognizer list` crash when registered with nullptr.

LGTM

Fri, Feb 7, 8:18 AM · Restricted Project

Thu, Feb 6

friss added a comment to D74157: [lldb/API] NFC: Reformat SBThread::GetStopDescription().

Looks better. TBH, I'm not sure why/if we really need the case handling the situation where the thread does not have a stop description. Ideally I'd just move this code there (or delete it).

A thread that stops for no reason will have an empty StopInfoSP. So somebody has to check for that. I also don't want a thread that hasn't stopped for a reason to have a placeholder description like "no reason" because if you are using the API's you'd like to just print whatever the description is, and if you stop one thread at a breakpoint, having all the others say "no reason" is noisy and unhelpful.

Thu, Feb 6, 8:15 PM · Restricted Project
friss added inline comments to D74187: [lldb] Add method Language::IsMangledName.
Thu, Feb 6, 5:38 PM · Restricted Project
friss created D74157: [lldb/API] NFC: Reformat SBThread::GetStopDescription().
Thu, Feb 6, 1:01 PM · Restricted Project

Wed, Feb 5

friss added inline comments to D74096: [lldb/API] Fix the dangling pointer issue in SBThread::GetStopDescription.
Wed, Feb 5, 3:51 PM · Restricted Project
friss added inline comments to D73303: [lldb/Target] Add Assert StackFrame Recognizer.
Wed, Feb 5, 1:21 PM · Restricted Project

Tue, Jan 28

friss added a comment to D73303: [lldb/Target] Add Assert StackFrame Recognizer.

This generally looks good. I'm still not fond of registering this in the Target itself. But I don't have a immediately better idea as we don't have a C language runtime.

Tue, Jan 28, 10:58 AM · Restricted Project

Fri, Jan 24

friss added inline comments to D73303: [lldb/Target] Add Assert StackFrame Recognizer.
Fri, Jan 24, 11:12 AM · Restricted Project
friss added inline comments to D73303: [lldb/Target] Add Assert StackFrame Recognizer.
Fri, Jan 24, 8:31 AM · Restricted Project

Thu, Jan 23

friss added inline comments to D73303: [lldb/Target] Add Assert StackFrame Recognizer.
Thu, Jan 23, 9:35 PM · Restricted Project
friss added inline comments to D73225: Handle the new objc direct dispatch accelerator functions for uncommonly overridden methods.
Thu, Jan 23, 12:57 PM · Restricted Project

Tue, Jan 21

friss committed rG0478eadf73c1: [lldb/DataFormatters] Fix the `$$deference$$` synthetic child (authored by friss).
[lldb/DataFormatters] Fix the `$$deference$$` synthetic child
Tue, Jan 21, 1:38 PM
friss closed D73053: [lldb/DataFormatters] Fix the `$$deference$$` synthetic child.
Tue, Jan 21, 1:37 PM · Restricted Project

Mon, Jan 20

friss updated the diff for D73053: [lldb/DataFormatters] Fix the `$$deference$$` synthetic child.

use python formatting in docs

Mon, Jan 20, 12:08 PM · Restricted Project
friss created D73053: [lldb/DataFormatters] Fix the `$$deference$$` synthetic child.
Mon, Jan 20, 8:52 AM · Restricted Project

Jan 17 2020

friss committed rG546f8f426463: [lldb/testsuite] Modernize 2 test Makefiles (authored by friss).
[lldb/testsuite] Modernize 2 test Makefiles
Jan 17 2020, 9:07 PM
friss committed rG509b78883d4f: [lldb/Makefile.rules] Force the default target to be 'all' (authored by friss).
[lldb/Makefile.rules] Force the default target to be 'all'
Jan 17 2020, 9:07 PM

Jan 3 2020

friss accepted D72096: [lldb/Command] Add --force option for `watchpoint delete` command.
Jan 3 2020, 9:27 AM · Restricted Project

Jan 2 2020

friss added inline comments to D72096: [lldb/Command] Add --force option for `watchpoint delete` command.
Jan 2 2020, 11:08 AM · Restricted Project

Dec 17 2019

friss added a comment to D69309: Support template instantiation in the expression evaluator.

Basically, today the debug info will describe an entity named "Foo<int>". The accelerator tables all reference this name. So when Clang asks us if we know "Foo" (which is what happens when instantiating), we fail to find the right instantiations. The consensus of the above discussion was that we should change the debug info to have "Foo" as the name of any instantiation, with a child DIE describing the template arguments. Just doing this in the compiler causes test failures in LLDB, so there's some work to do in LLDB to support this.

Frederic, you say that "doing this in the compiler causes test failures in LLDB", which implies you have tried adding the template in the compiler. Do you have that compiler patch lying around so that we could have a look at what can be done on the lldb side?

I agree that a good long term fix is to have "Foo" as an entity in DWARF, although for backwards compatibility it might be better if the "Foo" template just contained references to the instantiations rather than having them as children.

I am afraid you're overestimating the scope of that idea. I *think* that Fred was referring to simply changing the string that gets put into the DW_AT_name field of the /instantation/ (and, by extension, the accelerator table). The debug info would still describe instantiations only.

Dec 17 2019, 8:03 AM · Restricted Project

Nov 21 2019

friss added a comment to D69309: Support template instantiation in the expression evaluator.

Sorry that I haven't reviewed the patch, but there's something I'd like to point out before anyone invests a lot of time into plugin holes in our current template support code.

It would be great to fix the way templates are represented, because currently the debug info doesn't allow us to answer Clang's requests correctly. There is the beginning of a discussion here: http://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20180507/040689.html

Basically, today the debug info will describe an entity named "Foo<int>". The accelerator tables all reference this name. So when Clang asks us if we know "Foo" (which is what happens when instantiating), we fail to find the right instantiations. The consensus of the above discussion was that we should change the debug info to have "Foo" as the name of any instantiation, with a child DIE describing the template arguments. Just doing this in the compiler causes test failures in LLDB, so there's some work to do in LLDB to support this.

Having an entity for the template itself would be great. However, that would require compiler changes, so only the code compiled with new compilers would benefit, no? I am afraid we need a story for older toolchains, too.

Nov 21 2019, 8:07 AM · Restricted Project

Nov 19 2019

friss added a comment to D69309: Support template instantiation in the expression evaluator.

Sorry that I haven't reviewed the patch, but there's something I'd like to point out before anyone invests a lot of time into plugin holes in our current template support code.

Nov 19 2019, 4:32 PM · Restricted Project

Nov 15 2019

friss committed rGa578adc1bc8e: dotest: Add a way for the run_to_* helpers to register dylibs (authored by friss).
dotest: Add a way for the run_to_* helpers to register dylibs
Nov 15 2019, 3:42 PM
friss closed D70134: dotest: Add a way for the run_to_* helpers to register dylibs.
Nov 15 2019, 3:42 PM · Restricted Project

Nov 12 2019

friss created D70134: dotest: Add a way for the run_to_* helpers to register dylibs.
Nov 12 2019, 10:18 AM · Restricted Project

Nov 7 2019

friss committed rGcbdd92be8a57: Modernize TestWeakSymbols Makefile (authored by friss).
Modernize TestWeakSymbols Makefile
Nov 7 2019, 2:55 PM

Nov 6 2019

friss committed rG8243918f43c6: Testuite: Support Asan test with remote testing (authored by friss).
Testuite: Support Asan test with remote testing
Nov 6 2019, 2:31 PM
friss added inline comments to D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance.
Nov 6 2019, 2:29 PM · Restricted Project
friss added inline comments to D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance.
Nov 6 2019, 12:31 PM · Restricted Project

Nov 5 2019

friss committed rG42beb8ed792d: TestBatchMode.py: add missing @skipIfRemote (authored by friss).
TestBatchMode.py: add missing @skipIfRemote
Nov 5 2019, 12:29 PM
friss committed rG270fe47aae4a: testsuite: skipIfNoSBHeaders should skip when running remotely (authored by friss).
testsuite: skipIfNoSBHeaders should skip when running remotely
Nov 5 2019, 12:29 PM
friss committed rG2ff545e76d11: Modernize add-dsym test Makefile (authored by friss).
Modernize add-dsym test Makefile
Nov 5 2019, 12:29 PM

Oct 29 2019

friss committed rG5dcd21e33be9: Fix merge conflict. (authored by friss).
Fix merge conflict.
Oct 29 2019, 2:51 PM
friss committed rGf7aaf76691ba: Merge commit 'ebf4bc96909c0a03185023fb12da0a60f0975462' into swift-4.0-branch (authored by friss).
Merge commit 'ebf4bc96909c0a03185023fb12da0a60f0975462' into swift-4.0-branch
Oct 29 2019, 2:19 PM
friss committed rG3aeab60aef15: Merge commit 'dc25d53fce91d393fad6c12c5354280b549f5452' into swift-4.0-branch (authored by friss).
Merge commit 'dc25d53fce91d393fad6c12c5354280b549f5452' into swift-4.0-branch
Oct 29 2019, 2:19 PM
friss committed rG99e0b760f7e5: Merge commit '79af0051777660d178cfcd3af61c5a02e61b5f73' into swift-4.0-branch (authored by friss).
Merge commit '79af0051777660d178cfcd3af61c5a02e61b5f73' into swift-4.0-branch
Oct 29 2019, 2:19 PM
friss committed rG0e48830252bf: Merge commit '339c153eef85d5fcaf74144bec341d2063d42cd0' into upstream-with-swift (authored by friss).
Merge commit '339c153eef85d5fcaf74144bec341d2063d42cd0' into upstream-with-swift
Oct 29 2019, 2:13 PM
friss committed rGf2a711ea5503: Fix previous merge. (authored by friss).
Fix previous merge.
Oct 29 2019, 2:13 PM
friss committed rGfea926c45e86: Fix merge conflict in include/clang/Basic/Builtins.def (authored by friss).
Fix merge conflict in include/clang/Basic/Builtins.def
Oct 29 2019, 1:52 PM
friss committed rGaeabcd027b92: Simplify expression (authored by friss).
Simplify expression
Oct 29 2019, 12:21 PM
friss committed rG1a571b5cd5fa: Merge branch 'master' of http://llvm.org/git/llvm into upstream-with-swift (authored by friss).
Merge branch 'master' of http://llvm.org/git/llvm into upstream-with-swift
Oct 29 2019, 12:21 PM
friss committed rG8065e0dec4e1: Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift (authored by friss).
Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift
Oct 29 2019, 12:21 PM
friss committed rGa2c174d9c5e0: Merge branch 'master' of http://llvm.org/git/llvm into upstream-with-swift (authored by friss).
Merge branch 'master' of http://llvm.org/git/llvm into upstream-with-swift
Oct 29 2019, 12:20 PM
friss committed rG03530f9358d2: Apply Swift-related changes to the swift-llvm repo (authored by friss).
Apply Swift-related changes to the swift-llvm repo
Oct 29 2019, 12:19 PM
friss committed rG489921b003af: Apply Swift-related changes to the swift-clang repo (authored by friss).
Apply Swift-related changes to the swift-clang repo
Oct 29 2019, 12:19 PM

Oct 10 2019

friss committed rG58417b3390e9: TestMTCSimple: Make Makefile portable. (authored by friss).
TestMTCSimple: Make Makefile portable.
Oct 10 2019, 2:24 PM
friss committed rL374451: TestMTCSimple: Make Makefile portable..
TestMTCSimple: Make Makefile portable.
Oct 10 2019, 2:24 PM
friss added inline comments to D68755: [test] Use a different module cache for Shell and API tests..
Oct 10 2019, 8:13 AM · Restricted Project
friss added a comment to D68727: Allow pexpect tests to work in remote testsuite runs.

I don't see harm in adding this, but I am curious about what are you planning to use this for. My takeaway from all of the pexpect discussions we've had in the past was that pexpect should only be used for stuff that really, really needs an interactive terminal to work (i.e., stuff like batch mode, the "gui" command, interactive command line editing/libedit stuff, etc.). All of these seem like innately host-related stuff, and I am having trouble imagining a feature/test that requires an interactive terminal, but only works on remote targets.

Oct 10 2019, 8:12 AM · Restricted Project

Oct 9 2019

friss committed rG80b080723ff7: TestMTCSimple.py: allow the test to run on Darwin embedded platforms (authored by friss).
TestMTCSimple.py: allow the test to run on Darwin embedded platforms
Oct 9 2019, 4:58 PM
friss committed rL374262: TestMTCSimple.py: allow the test to run on Darwin embedded platforms.
TestMTCSimple.py: allow the test to run on Darwin embedded platforms
Oct 9 2019, 4:50 PM
friss committed rGadc5043fa274: TestIndirectSymbols: Modernize the Makefile (authored by friss).
TestIndirectSymbols: Modernize the Makefile
Oct 9 2019, 3:54 PM
friss committed rL374256: TestIndirectSymbols: Modernize the Makefile.
TestIndirectSymbols: Modernize the Makefile
Oct 9 2019, 3:54 PM
friss committed rG0e891bcf797f: Makefile.rules: add missing CODESIGN call (authored by friss).
Makefile.rules: add missing CODESIGN call
Oct 9 2019, 3:35 PM
friss committed rL374251: Makefile.rules: add missing CODESIGN call.
Makefile.rules: add missing CODESIGN call
Oct 9 2019, 3:34 PM
friss committed rGffb26d9c7830: TestHelloWorld: Make compatible with remote testing (authored by friss).
TestHelloWorld: Make compatible with remote testing
Oct 9 2019, 2:42 PM
friss committed rL374234: TestHelloWorld: Make compatible with remote testing.
TestHelloWorld: Make compatible with remote testing
Oct 9 2019, 2:42 PM
friss created D68727: Allow pexpect tests to work in remote testsuite runs.
Oct 9 2019, 1:47 PM · Restricted Project
friss committed rG868b47fcbef1: Skip Apple simulator test for all remote testing scenarios. (authored by friss).
Skip Apple simulator test for all remote testing scenarios.
Oct 9 2019, 1:38 PM
friss committed rL374217: Skip Apple simulator test for all remote testing scenarios..
Skip Apple simulator test for all remote testing scenarios.
Oct 9 2019, 1:38 PM

Oct 8 2019

friss accepted D68680: [dsymutil] Fix handling of common symbols in multiple object files..

LGTM

Oct 8 2019, 8:02 PM · Restricted Project
friss committed rGb56e3a1723e3: Add test coverage to printing of enums and fix display of unsigned values (authored by friss).
Add test coverage to printing of enums and fix display of unsigned values
Oct 8 2019, 12:51 PM
friss committed rL374108: Add test coverage to printing of enums and fix display of unsigned values.
Add test coverage to printing of enums and fix display of unsigned values
Oct 8 2019, 12:50 PM
friss committed rG5d415b706f67: Fix sign extension handling in DumpEnumValue (authored by friss).
Fix sign extension handling in DumpEnumValue
Oct 8 2019, 11:07 AM
friss committed rL374095: Fix sign extension handling in DumpEnumValue.
Fix sign extension handling in DumpEnumValue
Oct 8 2019, 10:57 AM
friss committed rG3fb4e49a68f5: [Testsuite] Get rid of most of the recursive shared library Makefiles (authored by friss).
[Testsuite] Get rid of most of the recursive shared library Makefiles
Oct 8 2019, 9:25 AM
friss closed D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles.
Oct 8 2019, 9:24 AM · Restricted Project
friss committed rL374076: [Testsuite] Get rid of most of the recursive shared library Makefiles.
[Testsuite] Get rid of most of the recursive shared library Makefiles
Oct 8 2019, 9:23 AM
friss committed rG41ff39605ea1: Add pretty printing of Clang "bitfield" enums (authored by friss).
Add pretty printing of Clang "bitfield" enums
Oct 8 2019, 8:36 AM
friss closed D67520: Add pretty printing of Clang "bitfield" enums.
Oct 8 2019, 8:36 AM · Restricted Project
friss committed rGd6470fb01a08: Extract and simplify DumpEnumValue (authored by friss).
Extract and simplify DumpEnumValue
Oct 8 2019, 8:36 AM
friss committed rL374067: Add pretty printing of Clang "bitfield" enums.
Add pretty printing of Clang "bitfield" enums
Oct 8 2019, 8:35 AM
friss committed rL374066: Extract and simplify DumpEnumValue.
Extract and simplify DumpEnumValue
Oct 8 2019, 8:35 AM

Oct 7 2019

friss updated the diff for D67520: Add pretty printing of Clang "bitfield" enums.

Add comments to some tests.

Oct 7 2019, 5:27 PM · Restricted Project
friss added a comment to D67520: Add pretty printing of Clang "bitfield" enums.

(lldb) expr (enum bitfield) whatever

Be nice to see a test of that to make sure that works through the expression parser as well.

Oct 7 2019, 5:21 PM · Restricted Project
friss updated the diff for D67520: Add pretty printing of Clang "bitfield" enums.

Added a couple more tests

Oct 7 2019, 5:16 PM · Restricted Project
friss added inline comments to D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles.
Oct 7 2019, 4:14 PM · Restricted Project
friss updated the diff for D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles.

Addressed review feedback.

Oct 7 2019, 3:37 PM · Restricted Project
friss added a comment to D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles.

I like the idea of passing the variable values "inline". The MAKECMDGOALS thingy seems... clever. I sort of like it, and it also feels like it might be too much.

Oct 7 2019, 12:26 PM · Restricted Project

Oct 6 2019

friss created D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles.
Oct 6 2019, 6:31 PM · Restricted Project

Oct 3 2019

friss accepted D68361: [dsymutil] Tablegenify option parsing.

This seems a little heavyweight, but it reads nicely and gets rid of global state. Go for it.

Oct 3 2019, 8:17 AM · Restricted Project, Restricted Project

Oct 1 2019

friss added inline comments to D68316: [Host] Return the user's shell from GetDefaultShell.
Oct 1 2019, 8:16 PM · Restricted Project

Sep 16 2019

friss added a comment to D67520: Add pretty printing of Clang "bitfield" enums.

This looks like a really useful feature. The code seems fine, but I am wondering if we should really bail out when encountering a zero enumerator. It is not uncommon to use a special enumerator to mean "none of the above". Lldb does that occasionally (eEmulateInstructionOptionNone), and other APIs do that too (PROT_NONE, PROT_READ, PROT_WRITE, PROT_EXEC in mmap(2) for instance). I am guessing this practice is even more common for "class" enums, as those can't be implicitly constructed from integer constants.

I think it would be useful to add one or two tests with enum types where this heuristic does not kick in. Like a type which has a two-bit enumerator which is not covered by previous enumerators, or (if you decide to keep the current behavior) a type with a zero enumerator.

Sep 16 2019, 8:26 AM · Restricted Project

Sep 12 2019

friss created D67520: Add pretty printing of Clang "bitfield" enums.
Sep 12 2019, 1:59 PM · Restricted Project

Sep 11 2019

friss accepted D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols.

This LGTM, in principle, but it's weird to add the testing in a skipped test. I trust that it works on your machine, but we won't know if it works on all the tested configurations. Can committing this wait for the perf issue to be fixed? Do you know how much work this is going to be?

Sep 11 2019, 8:18 AM · Restricted Project

Sep 10 2019

friss added inline comments to D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols.
Sep 10 2019, 3:33 PM · Restricted Project

Sep 6 2019

friss committed rL371265: Request commit access for friss.
Request commit access for friss
Sep 6 2019, 3:18 PM

Sep 4 2019

friss added inline comments to D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols.
Sep 4 2019, 3:41 PM · Restricted Project
friss committed rGcc5b509b9eda: Workaround TestConcurrentMany* flakiness in a more pricipled way (authored by friss).
Workaround TestConcurrentMany* flakiness in a more pricipled way
Sep 4 2019, 9:14 AM
friss committed rL370916: Workaround TestConcurrentMany* flakiness in a more pricipled way.
Workaround TestConcurrentMany* flakiness in a more pricipled way
Sep 4 2019, 9:14 AM
friss accepted D66742: Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION.

I don't see reason to keep this around.

Sep 4 2019, 8:17 AM · Restricted Project

Sep 3 2019

friss added inline comments to D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols.
Sep 3 2019, 10:53 AM · Restricted Project

Aug 30 2019

friss accepted D67012: [lit] Only set DYLD_LIBRARY_PATH for shared builds.

This looks good to me with one small provision:

Aug 30 2019, 3:28 PM · Restricted Project, Restricted Project

Aug 26 2019

friss committed rL369930: TestFunctionStarts.py: add synchronization.
TestFunctionStarts.py: add synchronization
Aug 26 2019, 10:32 AM
friss committed rG7305397a142a: TestFunctionStarts.py: add synchronization (authored by friss).
TestFunctionStarts.py: add synchronization
Aug 26 2019, 10:26 AM

Aug 23 2019

friss added inline comments to D66626: Upstream support for macCatalyst Mach-O binaries..
Aug 23 2019, 10:54 AM · Restricted Project
friss added inline comments to D66626: Upstream support for macCatalyst Mach-O binaries..
Aug 23 2019, 10:54 AM · Restricted Project