Page MenuHomePhabricator
Feed Advanced Search

Aug 26 2020

friss accepted D86593: [lldb] Don't crash when LLDB can't extract the tsan report.

LGTM

Aug 26 2020, 8:24 AM · Restricted Project

Aug 12 2020

friss added inline comments to D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue() .
Aug 12 2020, 4:06 PM · Restricted Project

Aug 7 2020

friss accepted D85265: Add a setting to always run all threads when stepping.

Sure. As I said I know this is unrelated to the path. this LGTM

Aug 7 2020, 2:12 PM · Restricted Project
friss added inline comments to D85265: Add a setting to always run all threads when stepping.
Aug 7 2020, 11:40 AM · Restricted Project
friss accepted D85537: [lldb] Store the Apple SDK in the configuration and use it to determine the platform..

LGTM

Aug 7 2020, 10:44 AM · Restricted Project
friss added a comment to D85539: [lldb] Extend builder to pass the TRIPLE spec to Make.

lldbremote.py looks awfully Apple-specific, yet it is going to be called from the generic code. Is that not an issue?

Aug 7 2020, 10:43 AM · Restricted Project
friss added a comment to D85265: Add a setting to always run all threads when stepping.

This LGTM. The only comment I had is about a comment you added on preexisting code:

Aug 7 2020, 8:55 AM · Restricted Project

Aug 6 2020

friss accepted D85358: Correctly detect legacy iOS simulator Mach-O objectfiles.

LGTM!

Aug 6 2020, 12:35 PM · Restricted Project
friss added inline comments to D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue() .
Aug 6 2020, 10:44 AM · Restricted Project
friss committed rG99298c7fc540: [lldb/testsuite] Change get_debugserver_exe to support Rosetta (authored by friss).
[lldb/testsuite] Change get_debugserver_exe to support Rosetta
Aug 6 2020, 10:39 AM

Aug 5 2020

friss added inline comments to D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue() .
Aug 5 2020, 5:37 PM · Restricted Project
friss added inline comments to D85358: Correctly detect legacy iOS simulator Mach-O objectfiles.
Aug 5 2020, 2:01 PM · Restricted Project

Aug 4 2020

friss committed rG4c9ed3ed3d2f: [lldb/testsuite] Skip 'frame diagnose' tests based on architecture (authored by friss).
[lldb/testsuite] Skip 'frame diagnose' tests based on architecture
Aug 4 2020, 5:46 PM
friss accepted D85237: [lldb] Add an option to inherit TCC permissions from parent..

LGTM

Aug 4 2020, 4:32 PM · Restricted Project
friss added a comment to D85237: [lldb] Add an option to inherit TCC permissions from parent..

The logic of the patch itself looks fine, but the names, description and commit message are off. A process cannot disable TCC, it's always active. What your patch decides is whether the inferior is responsible for its own TCC permissions. If you don't make the inferior responsible, it inherits the permissions of its parent (which might have inherited them from its own parent). On the command line, you'll most likely get the Terminal.app permissions if nothing in the middle resets the responsible process.

Aug 4 2020, 2:55 PM · Restricted Project

Aug 3 2020

friss added a comment to D84576: Fix debugserver's qProcessInfo reporting of maccatalyst binaries.

This looks good outside of 2 cross-platform issues in the tests themselves.

Aug 3 2020, 4:42 PM · Restricted Project

Jul 27 2020

friss committed rG8120eba5fce3: [lldb/ArchSpec] Always match simulator environment in IsEqualTo (authored by friss).
[lldb/ArchSpec] Always match simulator environment in IsEqualTo
Jul 27 2020, 5:34 PM
friss closed D84716: [lldb/ArchSpec] Always match simulator environment in IsEqualTo.
Jul 27 2020, 5:34 PM · Restricted Project
friss added inline comments to D84716: [lldb/ArchSpec] Always match simulator environment in IsEqualTo.
Jul 27 2020, 5:19 PM · Restricted Project
Herald added a project to D84716: [lldb/ArchSpec] Always match simulator environment in IsEqualTo: Restricted Project.
Jul 27 2020, 5:07 PM · Restricted Project
friss committed rGef748b58d3b3: [lldb] NFC: Use early exit in ArchSpec::IsEqualTo (authored by friss).
[lldb] NFC: Use early exit in ArchSpec::IsEqualTo
Jul 27 2020, 2:12 PM
friss committed rG4c6eebf86a07: [lldb/AppleSimulator] Always provide a -simulator environment (authored by friss).
[lldb/AppleSimulator] Always provide a -simulator environment
Jul 27 2020, 12:51 PM

Jul 24 2020

friss updated the diff for D84537: [lldb/AppleSimulator] Always provide a -simulator environment.

Simplify the logic.

Jul 24 2020, 3:23 PM · Restricted Project
friss added inline comments to D84537: [lldb/AppleSimulator] Always provide a -simulator environment.
Jul 24 2020, 2:36 PM · Restricted Project
Herald added a project to D84537: [lldb/AppleSimulator] Always provide a -simulator environment: Restricted Project.
Jul 24 2020, 9:27 AM · Restricted Project
friss committed rG22c16360dd00: [lldb/ObjectFileMachO] Correctly account for resolver symbols (authored by friss).
[lldb/ObjectFileMachO] Correctly account for resolver symbols
Jul 24 2020, 9:20 AM
friss closed D84083: [lldb/ObjectFileMachO] Correctly account for resolver symbols.
Jul 24 2020, 9:20 AM · Restricted Project

Jul 23 2020

friss accepted D84480: debugserver: Support ios simulator load command disambiguation in qProcessInfo.

LGTM!

Jul 23 2020, 8:21 PM · Restricted Project

Jul 21 2020

friss accepted D83552: [lldb/test] Do a better job at setting (DY)LD_LIBRARY_PATH.

The lldbtest.py part LGTM, but I'm failing to see how this interacts with TestWeakSymbols.py? IIRC, registerSharedLibraryWithTarget is an API we call explicitly in the tests, but I don't see it called here.

It gets called from run_to_source_breakpoint, keying off of the extra_images argument.

Jul 21 2020, 8:09 AM · Restricted Project

Jul 20 2020

friss added a comment to D83552: [lldb/test] Do a better job at setting (DY)LD_LIBRARY_PATH.

The lldbtest.py part LGTM, but I'm failing to see how this interacts with TestWeakSymbols.py? IIRC, registerSharedLibraryWithTarget is an API we call explicitly in the tests, but I don't see it called here.

Jul 20 2020, 9:25 AM · Restricted Project

Jul 17 2020

Herald added a project to D84083: [lldb/ObjectFileMachO] Correctly account for resolver symbols: Restricted Project.
Jul 17 2020, 6:00 PM · Restricted Project

Jul 16 2020

friss committed rG8113a8bb7934: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache (authored by friss).
[lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache
Jul 16 2020, 10:40 AM
friss closed D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache.
Jul 16 2020, 10:40 AM · Restricted Project, Restricted Project
friss added a comment to D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache.

I'll commit after I've re-built top of tree and fully retested

Jul 16 2020, 8:33 AM · Restricted Project, Restricted Project
friss updated the diff for D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache.

Address review feedback

Jul 16 2020, 8:23 AM · Restricted Project, Restricted Project

Jul 15 2020

friss updated the diff for D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache.
  • Rebase on top of D83512
  • Change the ObjectFileMachO pieces to rewrite offsets to look like a standard Mach-o image instead of adding a bunch of conditionals to handle the new cases.
Jul 15 2020, 3:40 PM · Restricted Project, Restricted Project

Jul 14 2020

GitHub <noreply@github.com> committed rG2e659d4a4c28: Merge pull request #1432 from adrian-prantl/65001691 (authored by friss).
Merge pull request #1432 from adrian-prantl/65001691
Jul 14 2020, 4:57 PM
GitHub <noreply@github.com> committed rGfcb37a13fe5e: Merge pull request #1428 from Teemperor/cherry/3faec833760fa7ab6e3180378da8c8fb… (authored by friss).
Merge pull request #1428 from Teemperor/cherry/3faec833760fa7ab6e3180378da8c8fb…
Jul 14 2020, 4:57 PM
GitHub <noreply@github.com> committed rG1c73376be820: Merge pull request #1425 from Teemperor/cherry/35674976f09ec99e74d0d28b4a64b6bc… (authored by friss).
Merge pull request #1425 from Teemperor/cherry/35674976f09ec99e74d0d28b4a64b6bc…
Jul 14 2020, 4:56 PM
GitHub <noreply@github.com> committed rG01c7d75611d5: Merge pull request #1253 from Teemperor/cherry/d48ef7cab55878fbb598e7a968b6073f… (authored by friss).
Merge pull request #1253 from Teemperor/cherry/d48ef7cab55878fbb598e7a968b6073f…
Jul 14 2020, 4:56 PM
GitHub <noreply@github.com> committed rGf298ef47efc8: Merge pull request #1411 from fredriss/fix-SIGWINCH-crash (authored by friss).
Merge pull request #1411 from fredriss/fix-SIGWINCH-crash
Jul 14 2020, 4:56 PM
friss committed rG1974241e280f: [lldb] Fix that SIGWINCH crashes IOHandlerEditline when we are not using the… (authored by teemperor).
[lldb] Fix that SIGWINCH crashes IOHandlerEditline when we are not using the…
Jul 14 2020, 4:56 PM
GitHub <noreply@github.com> committed rG5c253cd01810: Merge pull request #1332 from JDevlieghere/lldb-line-table-perf (authored by friss).
Merge pull request #1332 from JDevlieghere/lldb-line-table-perf
Jul 14 2020, 4:54 PM
GitHub <noreply@github.com> committed rGd6fc7c9a0c16: Merge pull request #1316 from adrian-prantl/64000666 (authored by friss).
Merge pull request #1316 from adrian-prantl/64000666
Jul 14 2020, 4:54 PM
GitHub <noreply@github.com> committed rG3b11cbd7c057: Merge pull request #1305 from adrian-prantl/60926115 (authored by friss).
Merge pull request #1305 from adrian-prantl/60926115
Jul 14 2020, 4:53 PM
GitHub <noreply@github.com> committed rGd08d94ba7825: Merge pull request #1303 from adrian-prantl/cleanup-target (authored by friss).
Merge pull request #1303 from adrian-prantl/cleanup-target
Jul 14 2020, 4:53 PM
GitHub <noreply@github.com> committed rG97d0c2893726: Merge pull request #1294 from JDevlieghere/raise-runtime-error (authored by friss).
Merge pull request #1294 from JDevlieghere/raise-runtime-error
Jul 14 2020, 4:53 PM
GitHub <noreply@github.com> committed rGf8c380e9a97e: Merge pull request #1293 from JDevlieghere/correct-man-page (authored by friss).
Merge pull request #1293 from JDevlieghere/correct-man-page
Jul 14 2020, 4:53 PM
GitHub <noreply@github.com> committed rGa3ff3d43edc1: Merge pull request #1290 from JDevlieghere/stop-leaking-forked-procs (authored by friss).
Merge pull request #1290 from JDevlieghere/stop-leaking-forked-procs
Jul 14 2020, 4:53 PM
GitHub <noreply@github.com> committed rG0daeb37548a2: Merge pull request #1288 from fredriss/fix-sim-test-when-multiple-runtimes (authored by friss).
Merge pull request #1288 from fredriss/fix-sim-test-when-multiple-runtimes
Jul 14 2020, 4:53 PM
friss committed rGa731a7caf5f1: [lldb/test] Fix TestAppleSimulatorOSType when multiple runtimes are installed (authored by friss).
[lldb/test] Fix TestAppleSimulatorOSType when multiple runtimes are installed
Jul 14 2020, 4:53 PM
GitHub <noreply@github.com> committed rG04853a8252a9: Merge pull request #1280 from jimingham/fix-save-crashlog (authored by friss).
Merge pull request #1280 from jimingham/fix-save-crashlog
Jul 14 2020, 4:53 PM
GitHub <noreply@github.com> committed rGd0ed86400581: Merge pull request #1273 from adrian-prantl/use-after-free-sdk (authored by friss).
Merge pull request #1273 from adrian-prantl/use-after-free-sdk
Jul 14 2020, 4:52 PM
GitHub <noreply@github.com> committed rGd5650915b95b: Merge pull request #1269 from adrian-prantl/63547920 (authored by friss).
Merge pull request #1269 from adrian-prantl/63547920
Jul 14 2020, 4:52 PM
GitHub <noreply@github.com> committed rG85649e1dfaef: Merge pull request #1266 from JDevlieghere/lldbinit-man-page (authored by friss).
Merge pull request #1266 from JDevlieghere/lldbinit-man-page
Jul 14 2020, 4:52 PM
GitHub <noreply@github.com> committed rG2c22fbb14f75: Merge pull request #1259 from Teemperor/DontEarlyCompleteObjCInterfaces (authored by friss).
Merge pull request #1259 from Teemperor/DontEarlyCompleteObjCInterfaces
Jul 14 2020, 4:52 PM
GitHub <noreply@github.com> committed rG62eba3ff3745: Merge pull request #1264 from adrian-prantl/disable-asan-asan (authored by friss).
Merge pull request #1264 from adrian-prantl/disable-asan-asan
Jul 14 2020, 4:52 PM
GitHub <noreply@github.com> committed rG552360332bb9: Merge pull request #1263 from adrian-prantl/disable-asan-tests (authored by friss).
Merge pull request #1263 from adrian-prantl/disable-asan-tests
Jul 14 2020, 4:52 PM
GitHub <noreply@github.com> committed rG1f9c5cda9932: Merge pull request #1262 from JDevlieghere/python-decode… (authored by friss).
Merge pull request #1262 from JDevlieghere/python-decode…
Jul 14 2020, 4:52 PM
GitHub <noreply@github.com> committed rGb8534def798b: Merge pull request #1254 from jimingham/vanishing-threads (authored by friss).
Merge pull request #1254 from jimingham/vanishing-threads
Jul 14 2020, 4:52 PM
friss committed rG8c7b60ea9d4d: [lldb/Debugger] Fixup cherry-pick to work on the 20200108 branch (authored by friss).
[lldb/Debugger] Fixup cherry-pick to work on the 20200108 branch
Jul 14 2020, 4:51 PM
GitHub <noreply@github.com> committed rGdd0d195ff126: Merge pull request #1233 from medismailben/apple/stable/20200108 (authored by friss).
Merge pull request #1233 from medismailben/apple/stable/20200108
Jul 14 2020, 4:51 PM
GitHub <noreply@github.com> committed rG8cb7da6d12d8: Merge pull request #1217 from fredriss/super-resize-me (authored by friss).
Merge pull request #1217 from fredriss/super-resize-me
Jul 14 2020, 4:50 PM
friss committed rG7d80113cff5b: [lldb/Driver] Support terminal resizing (authored by friss).
[lldb/Driver] Support terminal resizing
Jul 14 2020, 4:50 PM
GitHub <noreply@github.com> committed rGfc78685df053: Merge pull request #1214 from jasonmolenda/eng/PR-62873581 (authored by friss).
Merge pull request #1214 from jasonmolenda/eng/PR-62873581
Jul 14 2020, 4:50 PM
GitHub <noreply@github.com> committed rG88dbfbc7d2a1: Merge pull request #1195 from apple/eng/r62995567-add-internal-posix-plist (authored by friss).
Merge pull request #1195 from apple/eng/r62995567-add-internal-posix-plist
Jul 14 2020, 4:50 PM
GitHub <noreply@github.com> committed rGa28b1b8408be: Merge pull request #1160 from Teemperor/cherry/TemplateSpezModuleOwnership (authored by friss).
Merge pull request #1160 from Teemperor/cherry/TemplateSpezModuleOwnership
Jul 14 2020, 4:49 PM
GitHub <noreply@github.com> committed rG4af0f7934dab: Merge pull request #1178 from apple/eng/r62709160-log-full-nserror-object (authored by friss).
Merge pull request #1178 from apple/eng/r62709160-log-full-nserror-object
Jul 14 2020, 4:49 PM
GitHub <noreply@github.com> committed rG40fe7cd62165: Merge pull request #1176 from fredriss/fix-linetables-leak (authored by friss).
Merge pull request #1176 from fredriss/fix-linetables-leak
Jul 14 2020, 4:49 PM
friss committed rG8ae23e6c5958: [lldb/DWARF] Fix a leak in line table construction (authored by labath).
[lldb/DWARF] Fix a leak in line table construction
Jul 14 2020, 4:49 PM
friss committed rGea0dc75aedba: [lldb] Use llvm::stable_sort in Line (authored by labath).
[lldb] Use llvm::stable_sort in Line
Jul 14 2020, 4:49 PM
friss committed rGd75068e46bdf: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort (authored by unnar).
Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort
Jul 14 2020, 4:49 PM
friss added a reverting change for rGf4db8e04fce5: [lldb/DWARF] Fix a leak in line table construction: rG53f0e98a3012: Revert "[lldb/DWARF] Fix a leak in line table construction".
Jul 14 2020, 4:49 PM
friss committed rG53f0e98a3012: Revert "[lldb/DWARF] Fix a leak in line table construction" (authored by friss).
Revert "[lldb/DWARF] Fix a leak in line table construction"
Jul 14 2020, 4:49 PM
GitHub <noreply@github.com> committed rGf962f649e44d: Merge pull request #1175 from jimingham/line-table-leak (authored by friss).
Merge pull request #1175 from jimingham/line-table-leak
Jul 14 2020, 4:49 PM
GitHub <noreply@github.com> committed rG6d50b5c3af5b: Merge pull request #1148 from Teemperor/cherry-b58af8d254ee (authored by friss).
Merge pull request #1148 from Teemperor/cherry-b58af8d254ee
Jul 14 2020, 4:48 PM
GitHub <noreply@github.com> committed rGe52e302dc2ed: Merge pull request #1119 from fredriss/dev/fix-communication (authored by friss).
Merge pull request #1119 from fredriss/dev/fix-communication
Jul 14 2020, 4:46 PM
friss committed rGf0782bb9441e: [lldb] Change Communication::SetConnection to take a unique_ptr (authored by labath).
[lldb] Change Communication::SetConnection to take a unique_ptr
Jul 14 2020, 4:46 PM
GitHub <noreply@github.com> committed rG47cb1b05ebb3: Merge pull request #1118 from shafik/49959225_fix_handling_of_not_defined_FromR… (authored by friss).
Merge pull request #1118 from shafik/49959225_fix_handling_of_not_defined_FromR…
Jul 14 2020, 4:46 PM
GitHub <noreply@github.com> committed rG23739bc35891: Merge pull request #1069 from jimingham/debug-config-build-fix (authored by friss).
Merge pull request #1069 from jimingham/debug-config-build-fix
Jul 14 2020, 4:42 PM
GitHub <noreply@github.com> committed rGcf40e73fcf4a: Merge pull request #1059 from adrian-prantl/deconstify (authored by friss).
Merge pull request #1059 from adrian-prantl/deconstify
Jul 14 2020, 4:42 PM
GitHub <noreply@github.com> committed rG2f6b2b2d7719: Merge pull request #1053 from jimingham/fix-merge-errors (authored by friss).
Merge pull request #1053 from jimingham/fix-merge-errors
Jul 14 2020, 4:41 PM
GitHub <noreply@github.com> committed rGd1d2f6e4c225: Merge pull request #1038 from fredriss/cherry-pick-threadplan-lifetime-fix (authored by friss).
Merge pull request #1038 from fredriss/cherry-pick-threadplan-lifetime-fix
Jul 14 2020, 4:40 PM
friss committed rG5a1164b921be: Don't access reference to a vector after pop_back (authored by bkramer).
Don't access reference to a vector after pop_back
Jul 14 2020, 4:40 PM
GitHub <noreply@github.com> committed rGbf6dea9818dc: Merge pull request #1033 from Teemperor/backport95054aeb07061dbfd6575c10673b956… (authored by friss).
Merge pull request #1033 from Teemperor/backport95054aeb07061dbfd6575c10673b956…
Jul 14 2020, 4:39 PM
GitHub <noreply@github.com> committed rGc843aed88d93: Merge pull request #1029 from fredriss/python-codec-fix (authored by friss).
Merge pull request #1029 from fredriss/python-codec-fix
Jul 14 2020, 4:39 PM
friss committed rGbe3480658999: [lldb/Test] Convert stdout to str by calling decode('utf-8') on it. (authored by JDevlieghere).
[lldb/Test] Convert stdout to str by calling decode('utf-8') on it.
Jul 14 2020, 4:39 PM
GitHub <noreply@github.com> committed rG9a054321fd78: Merge pull request #1001 from shafik/60383510_cppnameparser_does_not_handle_tem… (authored by friss).
Merge pull request #1001 from shafik/60383510_cppnameparser_does_not_handle_tem…
Jul 14 2020, 4:38 PM
friss committed rG82cc7bd839ad: [lldb/DataFormatters] Fix the `$$deference$$` synthetic child (authored by friss).
[lldb/DataFormatters] Fix the `$$deference$$` synthetic child
Jul 14 2020, 4:38 PM
GitHub <noreply@github.com> committed rG1e1f0df31586: Merge pull request #1004 from fredriss/cherry-pcik-dereference-fix (authored by friss).
Merge pull request #1004 from fredriss/cherry-pcik-dereference-fix
Jul 14 2020, 4:38 PM
GitHub <noreply@github.com> committed rG73c2e1760cec: Merge pull request #999 from shafik/59204123_fix_bit_field_handling_dwarf_when_… (authored by friss).
Merge pull request #999 from shafik/59204123_fix_bit_field_handling_dwarf_when_…
Jul 14 2020, 4:38 PM
friss committed rG363723ec997e: [lldb/PlatformDarwin] Always delete destination file first in PutFile (authored by friss).
[lldb/PlatformDarwin] Always delete destination file first in PutFile
Jul 14 2020, 4:36 PM
GitHub <noreply@github.com> committed rGbfdb4dc8ffe3: Merge pull request #959 from fredriss/platform-delete-dest-file (authored by friss).
Merge pull request #959 from fredriss/platform-delete-dest-file
Jul 14 2020, 4:36 PM
GitHub <noreply@github.com> committed rGa964c34b501d: Merge pull request #955 from fredriss/cherry-pick-environment-fixes (authored by friss).
Merge pull request #955 from fredriss/cherry-pick-environment-fixes
Jul 14 2020, 4:36 PM
friss committed rG6f04e9af8ca2: [lldb/Target] Rework the way the inferior environment is created (authored by friss).
[lldb/Target] Rework the way the inferior environment is created
Jul 14 2020, 4:36 PM
friss committed rG3f8d1cd8d4c6: [lldb/API] Make Launch(Simple) use args and env from target properties (authored by friss).
[lldb/API] Make Launch(Simple) use args and env from target properties
Jul 14 2020, 4:36 PM
friss committed rGdd4ee984edbf: [lldb/Target] Initialize new targets environment variables from target.env-vars (authored by friss).
[lldb/Target] Initialize new targets environment variables from target.env-vars
Jul 14 2020, 4:36 PM
GitHub <noreply@github.com> committed rG8a485a6b017d: Merge pull request #935 from fredriss/some-test-cherry-picks (authored by friss).
Merge pull request #935 from fredriss/some-test-cherry-picks
Jul 14 2020, 4:35 PM
friss committed rG33a8fe74ada2: [lldb/testsuite] Skip part of TestProcessCrashInfo.py on Darwin embedded (authored by friss).
[lldb/testsuite] Skip part of TestProcessCrashInfo.py on Darwin embedded
Jul 14 2020, 4:35 PM
friss committed rG4e82212c29b8: [lldb/testsuite] Fix TestInlineStepping on arm64 with newer compilers (authored by friss).
[lldb/testsuite] Fix TestInlineStepping on arm64 with newer compilers
Jul 14 2020, 4:35 PM