Page MenuHomePhabricator
Feed Advanced Search

Wed, Mar 31

scui committed rG00c0c8c87d30: [PowerPC] [MLICM] Enable hoisting of caller preserved registers on AIX (authored by scui).
[PowerPC] [MLICM] Enable hoisting of caller preserved registers on AIX
Wed, Mar 31, 9:49 AM
scui closed D99076: [PowerPC] [MachineLICM] Enable hoisting of caller preserved registers on AIX.
Wed, Mar 31, 9:49 AM · Restricted Project

Mon, Mar 29

scui added a comment to D99076: [PowerPC] [MachineLICM] Enable hoisting of caller preserved registers on AIX.

gentle ping

Mon, Mar 29, 6:28 AM · Restricted Project

Mon, Mar 22

scui requested review of D99076: [PowerPC] [MachineLICM] Enable hoisting of caller preserved registers on AIX.
Mon, Mar 22, 7:29 AM · Restricted Project

Feb 26 2021

scui added inline comments to D96280: [clang][cli] Round-trip the whole CompilerInvocation.
Feb 26 2021, 6:04 AM · Restricted Project

Feb 25 2021

scui added inline comments to D96280: [clang][cli] Round-trip the whole CompilerInvocation.
Feb 25 2021, 2:51 PM · Restricted Project

Jan 22 2021

scui added a comment to D94710: [Analysis] Support AIX vec_malloc routines.

Thanks Roland for the approval. I don't have commit access. Can you help pls to commit this? The author line should be --author="Shimin Cui <scui@ca.ibm.com>".

Jan 22 2021, 10:32 AM · Restricted Project
scui added inline comments to D94710: [Analysis] Support AIX vec_malloc routines.
Jan 22 2021, 7:24 AM · Restricted Project
scui updated the diff for D94710: [Analysis] Support AIX vec_malloc routines.

To Address comments from Roland - fix the comment in def and add missing vec_free in BuildLibCalls.cpp

Jan 22 2021, 7:23 AM · Restricted Project

Jan 21 2021

scui added a comment to D94710: [Analysis] Support AIX vec_malloc routines.

Test case?

Jan 21 2021, 12:45 PM · Restricted Project
scui added a reviewer for D94710: [Analysis] Support AIX vec_malloc routines: RolandF.
Jan 21 2021, 11:28 AM · Restricted Project

Jan 19 2021

scui added a comment to D94710: [Analysis] Support AIX vec_malloc routines.

Thanks Jeeva. I need your help to commit this, I don't have commit access yet. The author line should be --author="Shimin Cui <scui@ca.ibm.com>".

Jan 19 2021, 7:16 AM · Restricted Project

Jan 14 2021

scui added a reviewer for D94710: [Analysis] Support AIX vec_malloc routines: pjeeva01.
Jan 14 2021, 12:26 PM · Restricted Project
scui requested review of D94710: [Analysis] Support AIX vec_malloc routines.
Jan 14 2021, 12:23 PM · Restricted Project

Oct 22 2020

scui added a comment to D88669: [ValueTracking] Add tracking of the alignment assume bundle.

Reverse ping. More comments (nits) and notice that we should merge this, D89830 reimplemented it in the meantime, see my comment there too.

Oct 22 2020, 6:28 AM · Restricted Project
scui updated the diff for D88669: [ValueTracking] Add tracking of the alignment assume bundle.

Updated to address review comments: I adopted the use of Log2_32 from D89830, removed the parenthesis comment, and added a TODO comment in the test case.

Oct 22 2020, 6:25 AM · Restricted Project

Oct 14 2020

scui added inline comments to D88669: [ValueTracking] Add tracking of the alignment assume bundle.
Oct 14 2020, 9:58 AM · Restricted Project
scui updated the diff for D88669: [ValueTracking] Add tracking of the alignment assume bundle.

Rewrite the code using getKnowledgeValidInContext. The code is much cleaner than the previous version, but the result computed is less accurate if the size of the alignment bundle is three. I'll leave the improvement for the future, together with the improvement of value tracking of GEP (an example is that, with the future improvement, we can fold away the branch "br i1 %3, ...") in f2 of the added case assume-align.ll).

Oct 14 2020, 9:54 AM · Restricted Project

Oct 13 2020

scui added a comment to D88669: [ValueTracking] Add tracking of the alignment assume bundle.

What does the third operand of an align bundle mean? It doesn't seem to be documented in LangRef.

Oct 13 2020, 2:06 PM · Restricted Project
scui added a comment to D88669: [ValueTracking] Add tracking of the alignment assume bundle.

Anyone has any comments for this patch? Any comments or suggestions are appreciated.

Oct 13 2020, 8:58 AM · Restricted Project

Oct 9 2020

scui added a comment to D87850: [ConstantFold] Fold the comparison of bitcasted global values .

LGTM

Do you have commit access? If not, I can commit it for you; what should I put in the git "Author" line?

Oct 9 2020, 4:12 PM · Restricted Project

Oct 6 2020

scui edited reviewers for D87850: [ConstantFold] Fold the comparison of bitcasted global values , added: efriedma; removed: eli.friedman.
Oct 6 2020, 11:34 AM · Restricted Project

Oct 5 2020

scui added inline comments to D87850: [ConstantFold] Fold the comparison of bitcasted global values .
Oct 5 2020, 11:39 AM · Restricted Project
scui updated the diff for D87850: [ConstantFold] Fold the comparison of bitcasted global values .

Remove the added extra cases from the existing test files

Oct 5 2020, 11:36 AM · Restricted Project
scui updated the diff for D87850: [ConstantFold] Fold the comparison of bitcasted global values .

Adjust the test cases.

Oct 5 2020, 10:15 AM · Restricted Project
scui added inline comments to D87850: [ConstantFold] Fold the comparison of bitcasted global values .
Oct 5 2020, 10:11 AM · Restricted Project

Oct 2 2020

scui added reviewers for D88669: [ValueTracking] Add tracking of the alignment assume bundle: spatel, eli.friedman.
Oct 2 2020, 11:17 AM · Restricted Project
scui added a reviewer for D88669: [ValueTracking] Add tracking of the alignment assume bundle: nikic.
Oct 2 2020, 11:14 AM · Restricted Project

Oct 1 2020

scui requested review of D88669: [ValueTracking] Add tracking of the alignment assume bundle.
Oct 1 2020, 9:13 AM · Restricted Project

Sep 30 2020

scui added a comment to D87850: [ConstantFold] Fold the comparison of bitcasted global values .

Anyone has any comments for this patch? Any comments or suggestions are appreciated.

Sep 30 2020, 7:47 AM · Restricted Project

Sep 22 2020

scui added reviewers for D87850: [ConstantFold] Fold the comparison of bitcasted global values : pjeeva01, RolandF.
Sep 22 2020, 11:57 AM · Restricted Project

Sep 18 2020

scui updated the diff for D87850: [ConstantFold] Fold the comparison of bitcasted global values .

Fix previous reverion of 2004-11-27-SetCCForCastLargerAndConstant.ll and PR17073.ll

Sep 18 2020, 9:22 AM · Restricted Project
scui updated the diff for D87850: [ConstantFold] Fold the comparison of bitcasted global values .

Revert 2004-11-27-SetCCForCastLargerAndConstant.ll and PR17073.ll

Sep 18 2020, 9:04 AM · Restricted Project

Sep 17 2020

scui requested review of D87850: [ConstantFold] Fold the comparison of bitcasted global values .
Sep 17 2020, 12:24 PM · Restricted Project