Page MenuHomePhabricator
Feed Advanced Search

Mon, Jun 13

SeanP accepted D127650: [libc++] Remove macros for IBM compiler.

These look good to me. I do see the the AIX CI build is broken. This is due to -X32_64 being passed to llvm-ar. That appears independent of this change. @daltenty will need to take a look at that.

Mon, Jun 13, 4:52 PM · Restricted Project, Restricted Project

Apr 29 2022

SeanP added inline comments to D124555: [libcxx] basic_ios<wchar_t> cannot store fill character WCHAR_MAX.
Apr 29 2022, 10:07 AM · Restricted Project, Restricted Project
SeanP added inline comments to D124555: [libcxx] basic_ios<wchar_t> cannot store fill character WCHAR_MAX.
Apr 29 2022, 9:08 AM · Restricted Project, Restricted Project

Mar 7 2022

SeanP added inline comments to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
Mar 7 2022, 2:46 PM · Restricted Project, Restricted Project, Restricted Project
SeanP added inline comments to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
Mar 7 2022, 1:47 PM · Restricted Project, Restricted Project, Restricted Project
SeanP added inline comments to D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..
Mar 7 2022, 1:29 PM · Restricted Project, Restricted Project, Restricted Project

Feb 23 2022

SeanP added inline comments to D118179: [SystemZ][z/OS] Localize runtime error messages in libc++.
Feb 23 2022, 11:33 AM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2022

SeanP added inline comments to D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.
Feb 22 2022, 9:28 AM · Restricted Project
SeanP added a comment to D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.

There should also be a test changed somewhere in libcxx/test/std/localization, or is this only part of the fix?

Thanks for providing information, can you provide more detail about what change need for libcxx/test/localization, the patch will fix bunch of Assert d1==d2 issues in std/numerics/rand/rand.dis/rand.dist.bern/ on z/OS related to float point value.

I would have expected test failures in locale.categories/category.numeric/facet.num.get.members/get_float.pass.cpp, since this patch changes behavior of std::num_get on AIX IIUC. So either I'm not understanding something here or there are some test cases missing. Wait there are also no // XFAIL: AIX in std/numerics/rand.dis/rand.dis.bern/. Are these tests currently disabled on AIX somehow?

I will take a look at locale.categories/category.numeric/facet.num.get.members/get_float.pass.cpp, I didn't see this test case failing on z/OS. the patch will fix the following test cases on z/OS because z/OS has EBCDIC mode, I wasn't sure about AIX. @daltenty @hubert.reinterpretcast may know.

libc++ :: std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.bernoulli/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.bin/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.geo/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.negbin/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.cauchy/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.chisq/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.f/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.lognormal/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.normal/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.t/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.exp/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.extreme/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.gamma/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.poisson/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.weibull/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.samp/rand.dist.samp.plinear/io.pass.cpp
libc++ :: std/numerics/rand/rand.dis/rand.dist.uni/rand.dist.uni.real/io.pass.cpp

Oh, sorry. For some reason I thought z/OS and AIX were the same thing. Are you working on libc++ officially supporting z/OS? If that is the case, maybe it would be a good idea to add a CI node for that?

Feb 22 2022, 7:28 AM · Restricted Project, Restricted Project
SeanP added inline comments to D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.
Feb 22 2022, 7:12 AM · Restricted Project

Feb 16 2022

SeanP added a comment to D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.

@ldionne, did the explanation help? I was thinking we could clean this logic up even better by adding a reference parameter to __stage2_float_loop() to track whether __exp has been seen or not rather than trying to store state in the character.

Feb 16 2022, 9:52 AM · Restricted Project, Restricted Project

Feb 15 2022

SeanP added inline comments to D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .
Feb 15 2022, 10:46 AM · Restricted Project
SeanP accepted D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++..

We'll have to create another patch to apply the side deck renaming to the libc++exception added in https://reviews.llvm.org/D118620/new/.

Feb 15 2022, 10:39 AM · Restricted Project, Restricted Project, Restricted Project
SeanP accepted D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library.

LGTM

Feb 15 2022, 10:31 AM · Restricted Project, Restricted Project

Feb 9 2022

SeanP added inline comments to D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.
Feb 9 2022, 11:45 AM · Restricted Project

Feb 7 2022

SeanP added inline comments to D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.
Feb 7 2022, 3:41 PM · Restricted Project, Restricted Project

Feb 3 2022

SeanP added inline comments to D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.
Feb 3 2022, 1:59 PM · Restricted Project
SeanP added inline comments to D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.
Feb 3 2022, 9:12 AM · Restricted Project

Jan 14 2022

SeanP accepted D117315: [AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString.
Jan 14 2022, 10:15 AM · Restricted Project

Dec 6 2021

SeanP added a comment to D114473: [runtimes] Remove support for GCC-style 32 bit multilib builds.

Hi Louis, you missed us on z/OS and AIX (@daltenty) . We provide 32-bit builds. We'll need to recover from this and may need to add some things back.

Ah, yeah, sorry for missing that. Any reason why you can't use target triple approach mentioned above?

Dec 6 2021, 1:31 PM · Restricted Project, Restricted Project, Restricted Project
SeanP updated subscribers of D114473: [runtimes] Remove support for GCC-style 32 bit multilib builds.

Hi Louis, you missed us on z/OS and AIX (@daltenty) . We provide 32-bit builds. We'll need to recover from this and may need to add some things back.

Dec 6 2021, 11:27 AM · Restricted Project, Restricted Project, Restricted Project
SeanP added a comment to D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

We can chat on Discord if you want more info on what I'm thinking about.

Dec 6 2021, 10:44 AM · Restricted Project, Restricted Project

Nov 24 2021

SeanP added a comment to D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

Can you update the summary to remove the part about including the unwind header.

Nov 24 2021, 9:44 AM · Restricted Project, Restricted Project

Nov 11 2021

SeanP accepted D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.

LGTM

Nov 11 2021, 8:58 AM · Restricted Project, Restricted Project

Nov 9 2021

SeanP added a comment to D110349: [libcxx][SystemZ][z/OS] Added is_threading_api_enabled and might_have_multiple_threads to __threading_support.

Louis, we don't want to make the entire threading model for z/OS to be dynamic. We would like to say the threading model uses pthread, but we need to enable these guard functions to work in programs that use threading and not. As Daniel pointed out a number of the libc++ threading functions used by these guard functions are not trivial to implement for a non-threading application. I would also worry about other parts of the library that should be using threading behaving correctly. We are open to other options. We could change the conditional compilations so both forms of the guard functions are available and call the right one depending on if threading is enabled or not. Would that be acceptable?

Nov 9 2021, 9:25 AM · Restricted Project, Restricted Project

Oct 8 2021

SeanP added inline comments to D111323: [SystemZ][z/OS] ASCII/EBCDIC support for libc++.
Oct 8 2021, 12:25 PM · Restricted Project
SeanP added a comment to D111323: [SystemZ][z/OS] ASCII/EBCDIC support for libc++.

@Quuxplusone what parts of this do you feel are unmaintainable? We are open to ideas on how to address any concerns you have.

Oct 8 2021, 12:17 PM · Restricted Project

Jul 16 2021

SeanP added inline comments to D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .
Jul 16 2021, 10:39 AM · Restricted Project

Jun 23 2021

SeanP added inline comments to D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.
Jun 23 2021, 6:35 PM · Restricted Project

Jun 18 2021

SeanP added a comment to D102798: [SystemZ][z/OS][libcxx] mark aligned allocation tests UNSUPPORTED on z/OS.

LGTM, but just out of curiosity, will this stay unsupported forever, or will this be implemented eventually?

Normally, we try to support things unless we have a fundamental reason why it can't be done (for example supporting exceptions on an embedded system). But it seems a bit strange to me to mark aligned allocation function tests as unsupported based on the *architecture* - instead I would have expected it to be marked as unsupported based on specific OS versions that do not implement the feature yet.

Jun 18 2021, 11:14 AM · Restricted Project

May 29 2021

SeanP added inline comments to D103160: [libc++] Update ABI docs.
May 29 2021, 11:46 AM · Restricted Project

Apr 21 2021

SeanP added inline comments to D100986: [libc++][AIX] Define _LIBCPP_ELAST.
Apr 21 2021, 9:06 PM · Restricted Project
SeanP added a comment to D100777: [libc++] Add missing short wchar handling for codecvt_utf8, codecvt_utf16 and codecvt_utf8_utf16 .

Why did you have to add a specialization based on size? Could you provide a test case or two to help explain. My first thought is the _LIBCPP_SHORT_WCHAR macro should be good enough since aix & z/OS only support one wchar_t size per 32/64 bit mode.

Apr 21 2021, 8:59 PM · Restricted Project
SeanP added inline comments to D100483: [SystemZ][z/OS] Add the functions needed for handling EBCDIC I/O.
Apr 21 2021, 8:44 PM · Restricted Project

Apr 9 2021

SeanP updated the summary of D100197: Enable creation of large response file on z/OS.
Apr 9 2021, 7:33 AM · Restricted Project
SeanP requested review of D100197: Enable creation of large response file on z/OS.
Apr 9 2021, 7:31 AM · Restricted Project

Apr 8 2021

SeanP accepted D99897: Set IgnoreLLVMUsed to false in CallGraph::addToCallGraph().

LGTM

Apr 8 2021, 10:25 AM · Restricted Project

Mar 24 2021

SeanP added inline comments to D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.
Mar 24 2021, 1:11 PM · Restricted Project, Restricted Project

Mar 23 2021

SeanP added inline comments to D98554: Save strings for CC_PRINT env vars.
Mar 23 2021, 5:46 PM · Restricted Project
SeanP updated the diff for D98554: Save strings for CC_PRINT env vars.

Changed the code checking the env vars so it doesn't assign a null_ptr to the string.

Mar 23 2021, 5:44 PM · Restricted Project

Mar 12 2021

SeanP requested review of D98554: Save strings for CC_PRINT env vars.
Mar 12 2021, 1:52 PM · Restricted Project

Oct 20 2020

SeanP added inline comments to D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS.
Oct 20 2020, 9:25 AM · Restricted Project