Jun 18 2019
Jun 14 2019
LGTM, except for the IncludeDefaultHeader and DeclareOpenCLBuiltins logic.
Jun 3 2019
May 30 2019
Mar 20 2019
Feb 21 2019
Dec 12 2018
Dec 10 2018
Nov 26 2018
FWIW, I'd vote for the first revision of this patch. From myunderstanding, the test verifies that libclang is able to parse OpenCL code correctly. It doesn't do anything specific to x86: target for x86 just happens to support a set of OpenCL extensions.
I am trying to understand what exactly does it bring into testing if the code doesn't have anything target specific in there?
Nov 22 2018
FWIW, I'd vote for the first revision of this patch. From my
understanding, the test verifies that libclang is able to parse OpenCL
code correctly. It doesn't do anything specific to x86: target for x86 just
happens to support a set of OpenCL extensions.
Nov 8 2018
Committed in r346392.
Nov 7 2018
I reverted this change in r346338, as it breaks Index/opencl-types.cl LIT test. See http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/21503/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Aopencl-types.cl
Oct 29 2018
Oct 26 2018
Measure the performance / size impact
Oct 23 2018
Committed revision 345044
Oct 12 2018
Oct 11 2018
Sep 25 2018
Sep 17 2018
Sep 11 2018
With this setup, we can compile opencl-c-common.h, opencl-c-fp16.h and
opencl-c-fp64.h into PCHs with one set of extensions/OpenCL version,
and use them for any other set of extensions/OpenCL version. Clang
will detect this and throw out an error, which can be safely disabled
by -fno-validate-pch option.
However, keeping this as a permanent solution is unsafe. Because this way can result in unexpected errors to be silent out and allow erroneous configurations to be accepted successfully without any notification.
Sep 10 2018
Sep 7 2018
Currently the main header still contains everything, so the size of the PCH won't change.
The idea is that we don't pre-compile the whole opencl-c.h, we split
it into several headers (3 of them are target independent) and
pre-compile them instead.
Sep 6 2018
Sep 5 2018
It seems generally good to partition this big header but I am trying to understand what problem is it trying to solve now?
Aug 31 2018
Aug 20 2018
Aug 3 2018
Aug 2 2018
Aug 1 2018
I've requested a commit access from Chris, and hopefully I will commit this patch soon. Otherwise I'll ask someone to commit it.
Thanks for the review!
Jul 31 2018
Jul 30 2018
Jul 27 2018
Rollback accidentally squashed commit.
Jul 26 2018
Moved unrelated change to https://reviews.llvm.org/D49723.
Moved another chunk from https://reviews.llvm.org/D49725
Jul 25 2018
This patch also adds check for array of structs. Can you include this in title or split to a separate patch?
Added a diagnostic note for typedefs; moved unrelated changes to
Moved a chunk from https://reviews.llvm.org/D49725; added 2 more tests.