Page MenuHomePhabricator
Feed Advanced Search

Today

kiranchandramohan added a comment to D81264: [mlir][OpenMP] Add custom parser and pretty printer for parallel construct.

@DavidTruby I have a few questions/comments.

Fri, Jun 5, 9:25 AM · Restricted Project

Yesterday

kiranchandramohan added a comment to D81034: [flang] add ConvertType to lowering.

A few questions.

Thu, Jun 4, 11:04 AM · Restricted Project, Unknown Object (Project)

Sun, May 31

kiranchandramohan accepted D80815: [flang] Introduce stub targets for the lowering of Open MP directives in the flang bridge to MLIR.

Thanks @schweitz for this stub. It will be a good place to start for the OpenMP lowering.

Sun, May 31, 3:58 PM · Restricted Project, Unknown Object (Project)

Fri, May 29

kiranchandramohan accepted D80689: [MLIR][OpenMP] Defined master operation in OpenMP Dialect.

LGTM.

Fri, May 29, 7:34 AM · Restricted Project, Restricted Project

Thu, May 28

kiranchandramohan accepted D80449: [flang] Upstream changes to the PFT data structure.

Looks OK to me. It will be great if @tskeith can review.

Thu, May 28, 4:32 PM · Restricted Project, Unknown Object (Project)
kiranchandramohan added a comment to D80689: [MLIR][OpenMP] Defined master operation in OpenMP Dialect.

It uses the custom parser and printer.

Thu, May 28, 10:25 AM · Restricted Project, Restricted Project

Mon, May 25

kiranchandramohan added a comment to D80449: [flang] Upstream changes to the PFT data structure.

Thanks @schweitz for submitting this change. I also felt that putting out all the changes in PFTBuilder as a single step is the best way forward while preparing D79731. I guess this will simplify the introduction of the bridge code.

Mon, May 25, 12:19 PM · Restricted Project, Unknown Object (Project)

Sun, May 24

kiranchandramohan accepted D80377: [flang] Google test infrastructure support for unittests.

Thanks @sameeranjoshi for working on this.

Sun, May 24, 4:31 PM · Restricted Project, Unknown Object (Project)

Mon, May 18

kiranchandramohan accepted D79937: [MLIR] Support for flush operation, and translating the same to LLVM IR.

LGTM.

Mon, May 18, 7:29 AM · Restricted Project, Restricted Project

Thu, May 14

kiranchandramohan added inline comments to D79410: [MLIR] [OpenMP] Add basic OpenMP parallel operation.
Thu, May 14, 9:10 AM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D79937: [MLIR] Support for flush operation, and translating the same to LLVM IR.
Thu, May 14, 8:05 AM · Restricted Project, Restricted Project

Tue, May 12

kiranchandramohan added a comment to D79578: [mlir] NFC: Rename LoopOps dialect to SCF (Structured Control Flow).

There is now a buildbot for flang.
http://lab.llvm.org:8011/builders/flang-aarch64-ubuntu

Tue, May 12, 11:57 PM · Restricted Project

Wed, May 6

kiranchandramohan added inline comments to D79514: [flang] Response to Steve Scalpone's suggestion to improve a message.
Wed, May 6, 1:00 PM · Unknown Object (Project), Restricted Project

May 5 2020

kiranchandramohan added inline comments to D79410: [MLIR] [OpenMP] Add basic OpenMP parallel operation.
May 5 2020, 3:40 PM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D79410: [MLIR] [OpenMP] Add basic OpenMP parallel operation.

Can you add a pointers to

  1. the discourse discussion for context in the summary?

https://llvm.discourse.group/t/openmp-parallel-operation-design-issues/686

  1. the openmp spec ( I think the link above has a pointer to it). Also say allocate from 5.0 is not there.
May 5 2020, 9:08 AM · Restricted Project, Restricted Project

May 1 2020

kiranchandramohan added a comment to D79092: [Flang][Driver]Add new flang driver main() entrypoint.

I think @sscalpone's point is that the following currently works but will not work after this patch since we need to build clang (add to DLLVM_ENABLE_PROJECTS) also.
cmake ../llvm -DLLVM_ENABLE_PROJECTS="mlir;flang"

May 1 2020, 1:27 AM · Unknown Object (Project), Restricted Project

Apr 30 2020

kiranchandramohan accepted D79089: [flang] Add the proposal document and rationale for the internal naming module that was previously added..

The uniquing is required in the context of the MLIR Module symbol space. (Artifacts with a process lifetime such as functions, globals, etc.) Locals need not be uniqued as they have a unique identity as ssa-> values. (Their names are tracked with name attributes attached to the Op.)

Apr 30 2020, 10:08 AM · Unknown Object (Project), Restricted Project
kiranchandramohan added a comment to D79089: [flang] Add the proposal document and rationale for the internal naming module that was previously added..

Thanks @schweitz for the detailed reply.

Apr 30 2020, 9:02 AM · Unknown Object (Project), Restricted Project
kiranchandramohan accepted D79177: [flang] Add the header file for the conversion of FIR(MLIR) to LLVM-IR dialect.

LGTM.
Is the plan to upstream the code for conversion to LLVM IR before the code for lowering from parse tree to FIR?

Apr 30 2020, 9:02 AM · Restricted Project, Unknown Object (Project)

Apr 29 2020

kiranchandramohan added a comment to D79089: [flang] Add the proposal document and rationale for the internal naming module that was previously added..

Could you comment on whether this mangling will have any effect on interfacing with C/C++? Will this have any effects on LTO. What happens if a bind name is specified?
http://web.mit.edu/tibbetts/Public/inside-c/www/mangling.html

Apr 29 2020, 11:59 PM · Unknown Object (Project), Restricted Project

Apr 24 2020

kiranchandramohan added a comment to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

If all the concerns are addressed, you can merge. Thanks for working on this.

Apr 24 2020, 1:34 AM · Restricted Project, Unknown Object (Project)

Apr 21 2020

kiranchandramohan committed rGa6c1692cb30e: [Flang] fix dependency issues after D78215 (authored by clementval).
[Flang] fix dependency issues after D78215
Apr 21 2020, 1:00 PM
kiranchandramohan closed D78340: [Flang] fix dependency issues after D78215.
Apr 21 2020, 1:00 PM · Unknown Object (Project), Restricted Project
kiranchandramohan added a comment to D78340: [Flang] fix dependency issues after D78215.

I have just pushed this to the repo.
https://github.com/llvm/llvm-project/commit/a6c1692cb30e62c94513c2c6262cd76df92ef892

Apr 21 2020, 12:59 PM · Unknown Object (Project), Restricted Project

Apr 20 2020

kiranchandramohan added a comment to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

Thanks for addressing the comments.

Apr 20 2020, 3:12 PM · Restricted Project, Unknown Object (Project)

Apr 19 2020

kiranchandramohan added inline comments to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
Apr 19 2020, 2:57 PM · Restricted Project, Unknown Object (Project)

Apr 18 2020

kiranchandramohan added inline comments to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
Apr 18 2020, 2:00 PM · Restricted Project, Unknown Object (Project)

Apr 9 2020

kiranchandramohan added a comment to D71267: [OpenMPIRBuilder] Add support for generating kmpc_for_static_fini.

I see the same crash without my change when enabling openmp-irbuilder in for_codegen.cpp tests. Command and stack trace below.

Apr 9 2020, 3:48 PM · Restricted Project
kiranchandramohan added a comment to D71267: [OpenMPIRBuilder] Add support for generating kmpc_for_static_fini.

After rebasing, I see some crashes in the tests. That is why i did not submit. I will have a look again and see what is the issue.

Apr 9 2020, 2:57 PM · Restricted Project
kiranchandramohan committed rG582b93254248: [flang] Semantic checks for critical construct (authored by kiranchandramohan).
[flang] Semantic checks for critical construct
Apr 9 2020, 12:39 PM
kiranchandramohan committed rG69d01593b4c5: [flang] Mark ieee_get_flag and ieee_get_halting_mode as elemental (authored by kiranchandramohan).
[flang] Mark ieee_get_flag and ieee_get_halting_mode as elemental
Apr 9 2020, 12:35 PM
kiranchandramohan committed rG911cb63719be: [flang] Fix for segfault in invalid proc interface message (authored by kiranchandramohan).
[flang] Fix for segfault in invalid proc interface message
Apr 9 2020, 11:41 AM
kiranchandramohan committed rGed92b04e4964: [flang] C1167 : Check for exit statments in do-concurrent (authored by kiranchandramohan).
[flang] C1167 : Check for exit statments in do-concurrent
Apr 9 2020, 10:26 AM

Apr 7 2020

kiranchandramohan updated subscribers of D77634: [MLIR] Support for taskwait and taskyield operations, and translating the same to LLVM IR.

Thanks @kiranktp for working on this. Looks OK to me.

Apr 7 2020, 10:20 AM · Restricted Project

Mar 5 2020

kiranchandramohan committed rG92a295eb3995: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR (authored by kiranchandramohan).
[MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR
Mar 5 2020, 4:24 AM
kiranchandramohan closed D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.
Mar 5 2020, 4:24 AM · Restricted Project
kiranchandramohan added a comment to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Thanks for the reviews. Committing with changes suggested.

Mar 5 2020, 3:51 AM · Restricted Project

Feb 28 2020

kiranchandramohan added a comment to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Just wanted to check whether @rriddle has more comments on this patch.

Feb 28 2020, 3:45 AM · Restricted Project

Feb 21 2020

kiranchandramohan added a comment to D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing.

Will tests come in a later patch?

Feb 21 2020, 7:10 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Do @rriddle and @ftynse require further changes?

Feb 21 2020, 4:26 AM · Restricted Project

Feb 20 2020

kiranchandramohan updated the diff for D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Added LLVMFrontendOpenMP and MLIROpenMP to the dependency of MLIRLLVMIR and also linking these libraries along with MLIRLLVMIR. Removed from other clients.

Feb 20 2020, 1:44 PM · Restricted Project

Feb 19 2020

kiranchandramohan added inline comments to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.
Feb 19 2020, 11:01 AM · Restricted Project
kiranchandramohan updated the diff for D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

This revision includes the following changes,
-> Rebased.
-> Removed the enable-openmp flag.
-> Addressed review comments from @ftynse.

Feb 19 2020, 10:58 AM · Restricted Project

Feb 12 2020

kiranchandramohan added a comment to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Thanks for your comments.

MLIROpenMP and LLVMFrontendOpenMP libraries looks like an additional dependency for MLIR users who wants LLVM lowering and doesn't want anything to do with the OpenMP! I think Toy example cmake file changes is one of the early symptoms.

One way to handle that would be to go back to the first version of this patch which implements translation by deriving from public LLVM::ModuleTranslation.

I think conversion patterns would be more appropriate. But, I think, that is dependent on the decision to emit LLVM IR instead of LLVM Dialect.

Feb 12 2020, 1:56 PM · Restricted Project
kiranchandramohan added a comment to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Thanks for your comments.

Feb 12 2020, 10:15 AM · Restricted Project
kiranchandramohan accepted D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling.

LGTM. You can wait for a day in case other reviewers have comments.

Feb 12 2020, 3:10 AM · Restricted Project, Restricted Project

Feb 11 2020

kiranchandramohan added inline comments to D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling.
Feb 11 2020, 3:44 PM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling.

Looks OK to me.
Couple of comments inline.

Feb 11 2020, 3:26 PM · Restricted Project, Restricted Project

Feb 7 2020

kiranchandramohan added inline comments to D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling.
Feb 7 2020, 4:58 PM · Restricted Project, Restricted Project

Feb 6 2020

kiranchandramohan added inline comments to D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling.
Feb 6 2020, 8:24 AM · Restricted Project, Restricted Project

Feb 4 2020

kiranchandramohan committed rGa969e051a5d9: [OpenMP] Add Flush directive to OpenMPIRBuilder (authored by kiranchandramohan).
[OpenMP] Add Flush directive to OpenMPIRBuilder
Feb 4 2020, 3:00 PM
kiranchandramohan closed D70712: Adding Flush support in OpenMPIRBuilder.
Feb 4 2020, 3:00 PM · Restricted Project, Restricted Project
kiranchandramohan updated subscribers of D70712: Adding Flush support in OpenMPIRBuilder.
Feb 4 2020, 3:39 AM · Restricted Project, Restricted Project

Feb 3 2020

kiranchandramohan added a comment to D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling.

Had a quick look today. Will spend some more time tomorrow.
Please see a few comments inline.

Feb 3 2020, 8:28 AM · Restricted Project, Restricted Project

Jan 28 2020

kiranchandramohan added a comment to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Thanks @ftynse for the comments. I will make a patch soon to address comments. The only question is regarding the necessity of the flag. Please see comment inline.

Jan 28 2020, 7:45 AM · Restricted Project

Jan 27 2020

kiranchandramohan added a comment to D72400: [MLIR] Add OpenMP dialect with barrier operation.

I don't remember that we ever fully resolved this(adding OpenMP Dialect). Can you make a ping on llvm.discourse.group to make sure?

Jan 27 2020, 4:07 AM · Restricted Project
kiranchandramohan added inline comments to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.
Jan 27 2020, 1:52 AM · Restricted Project
kiranchandramohan updated the diff for D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

The enable-openmp flag is now local to file mlir/lib/Target/LLVMIR/ModuleTranslation.cpp. Added a function to lazily create the OpenMPIR builder when an OpenMP dialect op is detected.

Jan 27 2020, 1:47 AM · Restricted Project

Jan 23 2020

kiranchandramohan added a comment to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

I have taken @rriddle's suggestion and moved the translation into the LLVM translator. Also using unique pointer for the OpenMPIRBuilder. I believe this fixes the null pointer issue pointed out by @jdoerfert.

Jan 23 2020, 11:55 AM · Restricted Project
kiranchandramohan updated the diff for D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

In this patch the code for translation is added to the existing LLVM dialect translation to LLVM IR. A new flag enable-openmp is used to enable the OpenMP translation.

Jan 23 2020, 11:51 AM · Restricted Project

Jan 17 2020

kiranchandramohan updated the diff for D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Made changes suggested by the clang-format bot.

Jan 17 2020, 4:08 PM · Restricted Project
kiranchandramohan added a reviewer for D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR: ftynse.
Jan 17 2020, 3:39 PM · Restricted Project
kiranchandramohan retitled D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR from Translation of OpenMP barrier construct to LLVM IR to [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.
Jan 17 2020, 3:39 PM · Restricted Project
kiranchandramohan created D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.
Jan 17 2020, 3:39 PM · Restricted Project

Dec 10 2019

kiranchandramohan created D71267: [OpenMPIRBuilder] Add support for generating kmpc_for_static_fini.
Dec 10 2019, 6:29 AM · Restricted Project
kiranchandramohan committed rG965ed1e974e8: [AArch64] Fix issues with large arrays on stack (authored by kiranchandramohan).
[AArch64] Fix issues with large arrays on stack
Dec 10 2019, 3:54 AM
kiranchandramohan closed D70496: [AArch64] Fix issues with large arrays on stack.
Dec 10 2019, 3:54 AM · Restricted Project

Dec 5 2019

kiranchandramohan added a comment to D70496: [AArch64] Fix issues with large arrays on stack.

Thanks @eli.friedman.
@fpetrogalli are you OK with the changes I made to your suggestions? Might need some handholding to land this patch.

Dec 5 2019, 4:41 AM · Restricted Project

Nov 29 2019

kiranchandramohan added a comment to D70496: [AArch64] Fix issues with large arrays on stack.

In general, I also worry that i might have missed some checks. I was hoping to get some pointers on how to run some tests so that we can minimise this. At the same time, I also feel that this change should not cause regressions.

Nov 29 2019, 6:26 AM · Restricted Project
kiranchandramohan updated the diff for D70496: [AArch64] Fix issues with large arrays on stack.
Nov 29 2019, 6:14 AM · Restricted Project
kiranchandramohan retitled D70712: Adding Flush support in OpenMPIRBuilder from [WIP][NFC] Adding Flush support in OpenMPIRBuilder to Adding Flush support in OpenMPIRBuilder.
Nov 29 2019, 4:52 AM · Restricted Project, Restricted Project
kiranchandramohan updated the diff for D70712: Adding Flush support in OpenMPIRBuilder.

Addressed review comments.

  1. Adding a test
  2. Change emitFlush to CreateFlush in OpenMPIRBuilder.cpp
  3. Use updateLoc
  4. Fixed formatting
Nov 29 2019, 4:52 AM · Restricted Project, Restricted Project

Nov 28 2019

kiranchandramohan added inline comments to D69828: [OpenMP] Lower taskwait using OpenMP IR Builder.
Nov 28 2019, 4:27 PM · Restricted Project, Restricted Project

Nov 26 2019

kiranchandramohan added a comment to D70496: [AArch64] Fix issues with large arrays on stack.

Apologies, will wait for the reviews.

Nov 26 2019, 2:48 PM · Restricted Project
kiranchandramohan updated the summary of D70712: Adding Flush support in OpenMPIRBuilder.
Nov 26 2019, 7:57 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D70496: [AArch64] Fix issues with large arrays on stack.

Does this patch need additional reviews or changes?

Nov 26 2019, 7:57 AM · Restricted Project
kiranchandramohan created D70712: Adding Flush support in OpenMPIRBuilder.
Nov 26 2019, 4:51 AM · Restricted Project, Restricted Project

Nov 25 2019

kiranchandramohan added inline comments to D70496: [AArch64] Fix issues with large arrays on stack.
Nov 25 2019, 4:23 AM · Restricted Project
kiranchandramohan updated the diff for D70496: [AArch64] Fix issues with large arrays on stack.

Addressed review comments by @fpetrogalli and @eli.friedman,

  1. Fixed formatting in llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
  2. Updated test to work with minimal attributes and removed prefixes for checks
Nov 25 2019, 4:16 AM · Restricted Project

Nov 22 2019

kiranchandramohan updated subscribers of D70496: [AArch64] Fix issues with large arrays on stack.

Thanks @fpetrogalli, @eli.friedman for the review.

Nov 22 2019, 7:54 AM · Restricted Project

Nov 20 2019

kiranchandramohan added reviewers for D70496: [AArch64] Fix issues with large arrays on stack: sdesmalen, efriedma, fhahn, aemerson.
Nov 20 2019, 9:28 AM · Restricted Project
kiranchandramohan created D70496: [AArch64] Fix issues with large arrays on stack.
Nov 20 2019, 7:57 AM · Restricted Project

Nov 19 2019

kiranchandramohan added a comment to D69922: [OpenMP] Use the OpenMP-IR-Builder.

Thanks @jdoerfert for working on this.

Nov 19 2019, 8:24 AM · Restricted Project, Restricted Project

Sep 18 2019

kiranchandramohan added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Some minor comments about Filetypes and file extensions. Can be ignored or considered for a separate commit.

Sep 18 2019, 6:30 AM · Restricted Project