Page MenuHomePhabricator
Feed Advanced Search

Today

t.p.northover added inline comments to D66180: [GlobalISel][CallLowering] Add support for splitting types according to calling conventions.
Thu, Aug 22, 6:36 AM · Restricted Project
t.p.northover updated the diff for D66287: GlobalISel: add combiner for indexed loads and stores.

Updated according to most comments.

Thu, Aug 22, 4:22 AM · Restricted Project
t.p.northover added inline comments to D66287: GlobalISel: add combiner for indexed loads and stores.
Thu, Aug 22, 3:49 AM · Restricted Project

Fri, Aug 16

t.p.northover committed rG22970d66be78: AssumptionCache: remove old affected values after RAUW. (authored by t.p.northover).
AssumptionCache: remove old affected values after RAUW.
Fri, Aug 16, 2:37 AM
t.p.northover closed D65852: AssumptionCache: remove old affected values after RAUW.

Thanks Hal. Committed as r369091.

Fri, Aug 16, 2:37 AM · Restricted Project

Thu, Aug 15

t.p.northover added a reviewer for D66287: GlobalISel: add combiner for indexed loads and stores: paquette.
Thu, Aug 15, 5:00 AM · Restricted Project
t.p.northover created D66287: GlobalISel: add combiner for indexed loads and stores.
Thu, Aug 15, 4:46 AM · Restricted Project
t.p.northover added a comment to D55562: Atomics: support min/max orthogonally.

Ping.

Thu, Aug 15, 2:28 AM · Restricted Project

Fri, Aug 9

t.p.northover committed rG01eb869114bd: AArch64: support TLS on Darwin platforms in GlobalISel. (authored by t.p.northover).
AArch64: support TLS on Darwin platforms in GlobalISel.
Fri, Aug 9, 2:33 AM
t.p.northover committed rGe1a5f668b3b5: GlobalISel: pack various parameters for lowerCall into a struct. (authored by t.p.northover).
GlobalISel: pack various parameters for lowerCall into a struct.
Fri, Aug 9, 1:28 AM

Wed, Aug 7

t.p.northover committed rG3c10f346dcd4: GlobalISel: factor common code from translateCall and translateInvoke. NFC. (authored by t.p.northover).
GlobalISel: factor common code from translateCall and translateInvoke. NFC.
Wed, Aug 7, 5:45 AM
t.p.northover added a comment to D65653: [AArch64] Change location of frame-record within callee-save area..

Unfortunately I don't think this is viable for Darwin platforms, at least not yet. Our compact unwind encoding just has a bitmask for which registers are saved rather than saying where relative to fp.

Wed, Aug 7, 2:11 AM · Restricted Project
t.p.northover created D65852: AssumptionCache: remove old affected values after RAUW.
Wed, Aug 7, 1:49 AM · Restricted Project
t.p.northover created D65850: GlobalISel: pack various parameters for lowerCall into a struct..
Wed, Aug 7, 1:43 AM · Restricted Project

Tue, Aug 6

t.p.northover committed rGb5abc425d27f: AArch64: bail instead of asserting on unexpected type in G_CONSTANT 0. (authored by t.p.northover).
AArch64: bail instead of asserting on unexpected type in G_CONSTANT 0.
Tue, Aug 6, 6:34 AM
t.p.northover committed rGde98e92bc2b6: AArch64: use xzr/wzr for constant 0 in GlobalISel. (authored by t.p.northover).
AArch64: use xzr/wzr for constant 0 in GlobalISel.
Tue, Aug 6, 2:19 AM

Mon, Aug 5

t.p.northover added inline comments to D65656: AArch64: support @llvm.{return,frame}address in GlobalISel.
Mon, Aug 5, 7:21 AM · Restricted Project
t.p.northover updated the diff for D61259: AArch64: support arm64_32, an ILP32 slice for watchOS..

Ah sorry, it was part of an NFC change in a different commit. I've rolled it into this diff; it's splitting off GEP sinking from the useAA callback since they're not really related.

Mon, Aug 5, 3:19 AM · Restricted Project

Sat, Aug 3

t.p.northover committed rG71b447605afa: IR: Cleanup after test to silence ASAN builds (authored by t.p.northover).
IR: Cleanup after test to silence ASAN builds
Sat, Aug 3, 8:40 AM
t.p.northover committed rGa009a60a917b: IR: print value numbers for unnamed function arguments (authored by t.p.northover).
IR: print value numbers for unnamed function arguments
Sat, Aug 3, 7:31 AM
t.p.northover closed D65582: IR: accept and print numbered %N names for function args.
Sat, Aug 3, 7:30 AM · Restricted Project, Restricted Project
t.p.northover accepted D65582: IR: accept and print numbered %N names for function args.

Thanks Reid, committed as r367755.

Sat, Aug 3, 7:30 AM · Restricted Project, Restricted Project

Fri, Aug 2

t.p.northover updated the diff for D65582: IR: accept and print numbered %N names for function args.
  • Added release note
  • Added hacky script to utils so that I can refer to it from the release note.
  • Removed "<badref>" handling from printArgument. Printing a free-standing Argument goes down a different path.
Fri, Aug 2, 10:31 AM · Restricted Project, Restricted Project
t.p.northover committed rG522fb7eedc1b: GlobalISel: support swiftself attribute (authored by t.p.northover).
GlobalISel: support swiftself attribute
Fri, Aug 2, 7:11 AM
t.p.northover created D65656: AArch64: support @llvm.{return,frame}address in GlobalISel.
Fri, Aug 2, 6:58 AM · Restricted Project
t.p.northover added inline comments to D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..
Fri, Aug 2, 5:54 AM · Restricted Project

Thu, Aug 1

t.p.northover created D65582: IR: accept and print numbered %N names for function args.
Thu, Aug 1, 8:28 AM · Restricted Project, Restricted Project

Jul 20 2019

t.p.northover added a comment to D65037: push LR before mcount on ARM.

What a horrible function. AAPCS? Who cares about that?

Jul 20 2019, 1:22 AM · Restricted Project, Restricted Project

Jul 19 2019

t.p.northover added inline comments to D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 19 2019, 5:06 AM · Restricted Project

Jul 11 2019

t.p.northover committed rG67828edbbd6f: OpaquePtr: switch to GlobalValue::getValueType in a few places. NFC. (authored by t.p.northover).
OpaquePtr: switch to GlobalValue::getValueType in a few places. NFC.
Jul 11 2019, 6:15 AM
t.p.northover committed rGf2d6597653e5: OpaquePtr: use byval accessor instead of inspecting pointer type. NFC. (authored by t.p.northover).
OpaquePtr: use byval accessor instead of inspecting pointer type. NFC.
Jul 11 2019, 6:15 AM
t.p.northover committed rG27658ed512c4: OpaquePtr: use load instruction directly for type. NFC. (authored by t.p.northover).
OpaquePtr: use load instruction directly for type. NFC.
Jul 11 2019, 6:14 AM
t.p.northover committed rG030bb3d36373: InstructionSimplify: Simplify InstructionSimplify. NFC. (authored by t.p.northover).
InstructionSimplify: Simplify InstructionSimplify. NFC.
Jul 11 2019, 6:14 AM

Jul 9 2019

t.p.northover committed rG13b204fee1ee: OpaquePtr: pass type to CreateLoad. NFC. (authored by t.p.northover).
OpaquePtr: pass type to CreateLoad. NFC.
Jul 9 2019, 5:37 AM
t.p.northover committed rG4bc20fa14948: OpaquePtr: Update polly's calls to Loads.h API (authored by t.p.northover).
OpaquePtr: Update polly's calls to Loads.h API
Jul 9 2019, 5:14 AM
t.p.northover committed rG60afa49abed6: OpaquePtr: add Type parameter to Loads analysis API. (authored by t.p.northover).
OpaquePtr: add Type parameter to Loads analysis API.
Jul 9 2019, 4:37 AM
t.p.northover closed D64203: [OpaquePtr] add Type parameter to Loads.h analysis API..
Jul 9 2019, 4:35 AM · Restricted Project
t.p.northover added a comment to D64203: [OpaquePtr] add Type parameter to Loads.h analysis API..

Thanks David. Committed with your suggestions as r365468.

Jul 9 2019, 4:35 AM · Restricted Project

Jul 8 2019

t.p.northover added inline comments to D61259: AArch64: support arm64_32, an ILP32 slice for watchOS..
Jul 8 2019, 5:29 AM · Restricted Project
t.p.northover updated the diff for D61259: AArch64: support arm64_32, an ILP32 slice for watchOS..
  1. Switched back to SmallVector to track registers used, reducing code perturbation. I decided to add a SmallSet too for queries instead of using std::find_if directly because searches actually happen regardless.
  2. Disabled special handling for [N x i32] except on arm64_32 MachO.
  3. Noticed a bug in 2 above, where we allocated 2N registers anyway and fixed it.
  4. Added getPointerType comment.
Jul 8 2019, 5:28 AM · Restricted Project
t.p.northover added a comment to D61259: AArch64: support arm64_32, an ILP32 slice for watchOS..

At a high level, my main care about here is that what is upstreamed here doesn't conflict with also adding support at some point in the future for the AArch64 ILP32 ABI - for which a beta quality specification from Arm exists.

Jul 8 2019, 3:09 AM · Restricted Project

Jul 4 2019

t.p.northover created D64203: [OpaquePtr] add Type parameter to Loads.h analysis API..
Jul 4 2019, 4:37 AM · Restricted Project
t.p.northover accepted D64069: [ARM] Add sign and zero extend patterns for MVE.

Looks reasonable to me.

Jul 4 2019, 4:20 AM · Restricted Project

Jul 2 2019

t.p.northover added a comment to D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

Sorry for the double reply, Phab ate my comment.

Jul 2 2019, 2:34 AM · Restricted Project
t.p.northover added inline comments to D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..
Jul 2 2019, 2:32 AM · Restricted Project

Jun 28 2019

t.p.northover added a comment to D63842: [PGO] Update ICP pass for recent byval type changes.

How about this: https://reviews.llvm.org/differential/diff/207034/?revisionID=63842.

Jun 28 2019, 4:46 AM · Restricted Project
t.p.northover updated the diff for D61259: AArch64: support arm64_32, an ILP32 slice for watchOS..

Rebased patch.

Jun 28 2019, 4:40 AM · Restricted Project

Jun 27 2019

t.p.northover added inline comments to D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters.
Jun 27 2019, 7:55 AM · Restricted Project
t.p.northover closed D62742: [OpaquePtr] BitcodeReader: don't rely on Types derived from a Value to provide pointer structure.

Thanks. Should be committed as r364550.

Jun 27 2019, 7:50 AM · Restricted Project
t.p.northover committed rGa4771e9dfdb0: Bitcode: derive all types used from records instead of Values. (authored by t.p.northover).
Bitcode: derive all types used from records instead of Values.
Jun 27 2019, 7:49 AM
t.p.northover added a comment to D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

I think the clang-format should be restricted to the actual diff. Doing the whole file makes this change really hard to read, and disrupts the blame for the future. git-clang-format in the Clang repo does the right thing by default I think.

Jun 27 2019, 7:49 AM · Restricted Project
t.p.northover committed rG22c96a966b11: IR: compare type attributes deeply when looking into functions. (authored by t.p.northover).
IR: compare type attributes deeply when looking into functions.
Jun 27 2019, 4:46 AM

Jun 26 2019

t.p.northover added inline comments to D63842: [PGO] Update ICP pass for recent byval type changes.
Jun 26 2019, 2:10 PM · Restricted Project

Jun 11 2019

t.p.northover added a comment to D61259: AArch64: support arm64_32, an ILP32 slice for watchOS..

Ping.

Jun 11 2019, 7:31 AM · Restricted Project
t.p.northover created D63131: arm64_32: implement the desired ABI for the ILP32 triple..
Jun 11 2019, 4:22 AM · Restricted Project
t.p.northover retitled D61939: AArch64: add support for arm64_32 (ILP32) triple and -arch option. from AArch64: add support for arm64_23 (ILP32) IR generation to AArch64: add support for arm64_32 (ILP32) triple and -arch option..
Jun 11 2019, 4:19 AM · Restricted Project
t.p.northover updated the diff for D61939: AArch64: add support for arm64_32 (ILP32) triple and -arch option..

This diff now only covers the trivial additions so that "arm64_32" is understood by the driver and creates AArch64 instantiations of relevant classes. Code generated is still wildly incorrect (not even ILP32 yet).

Jun 11 2019, 4:16 AM · Restricted Project
t.p.northover added a comment to D61939: AArch64: add support for arm64_32 (ILP32) triple and -arch option..

Thanks for the suggestion Florian, and sorry it's taken so long to act on it. I've split the patch up as you suggest, I'll make this one cover the Triple bits.

Jun 11 2019, 4:16 AM · Restricted Project

Jun 5 2019

t.p.northover committed rGc46827c7eda3: LLVM IR: Generate new-style byval-with-Type from Clang (authored by t.p.northover).
LLVM IR: Generate new-style byval-with-Type from Clang
Jun 5 2019, 2:10 PM
t.p.northover committed rG8d7f118ab2b9: InstCombine: correctly change byval type attribute alongside call args. (authored by t.p.northover).
InstCombine: correctly change byval type attribute alongside call args.
Jun 5 2019, 1:37 PM
t.p.northover committed rG607c8a9d1481: IR: make getParamByValType Just Work. NFC. (authored by t.p.northover).
IR: make getParamByValType Just Work. NFC.
Jun 5 2019, 1:36 PM

May 31 2019

t.p.northover created D62742: [OpaquePtr] BitcodeReader: don't rely on Types derived from a Value to provide pointer structure.
May 31 2019, 10:13 AM · Restricted Project

May 30 2019

t.p.northover added a comment to D61259: AArch64: support arm64_32, an ILP32 slice for watchOS..

Ping.

May 30 2019, 3:15 PM · Restricted Project
t.p.northover added a comment to D61939: AArch64: add support for arm64_32 (ILP32) triple and -arch option..

Ping.

May 30 2019, 3:15 PM · Restricted Project
t.p.northover committed rGfcb00d4aec7d: Reapply: LLVM IR: update Clang tests for byval being a typed attribute. (authored by t.p.northover).
Reapply: LLVM IR: update Clang tests for byval being a typed attribute.
May 30 2019, 11:50 AM
t.p.northover committed rGb7141207a483: Reapply: IR: add optional type to 'byval' function parameters (authored by t.p.northover).
Reapply: IR: add optional type to 'byval' function parameters
May 30 2019, 11:49 AM
t.p.northover accepted D62664: [DAGCombine] (A+C1)-C2 -> A+(C1-C2) constant-fold.

Looks reasonable.

May 30 2019, 9:56 AM · Restricted Project
t.p.northover accepted D62662: [DAGCombine] ((A-c1)+c2) -> (A+(c2-c1)) constant-fold.

LGTM.

May 30 2019, 9:55 AM · Restricted Project
t.p.northover accepted D62689: [DAGCombine] (A-C1)-C2 -> A-(C1+C2) constant-fold.

LGTM.

May 30 2019, 9:53 AM · Restricted Project

May 29 2019

t.p.northover committed rG71ee3d02372a: Revert "IR: add optional type to 'byval' function parameters" (authored by t.p.northover).
Revert "IR: add optional type to 'byval' function parameters"
May 29 2019, 1:49 PM
t.p.northover committed rG4b281755ae49: Revert "LLVM IR: update Clang tests for byval being a typed attribute." (authored by t.p.northover).
Revert "LLVM IR: update Clang tests for byval being a typed attribute."
May 29 2019, 1:43 PM
t.p.northover committed rG45e8cc6639e9: LLVM IR: update Clang tests for byval being a typed attribute. (authored by t.p.northover).
LLVM IR: update Clang tests for byval being a typed attribute.
May 29 2019, 12:12 PM
t.p.northover committed rG6e07f16fae60: IR: add optional type to 'byval' function parameters (authored by t.p.northover).
IR: add optional type to 'byval' function parameters
May 29 2019, 12:11 PM
t.p.northover closed D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters.

Thanks David. I've committed it as r362012 and r362013 with the tweak you suggested.

May 29 2019, 12:10 PM · Restricted Project
t.p.northover updated the diff for D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters.

I think I've fixed everything suggested, including making the comparison assert if it ever happens since that seems to be the consensus.

May 29 2019, 11:15 AM · Restricted Project

May 28 2019

t.p.northover added a comment to D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters.

Some replies, and I'll upload a new revision tomorrow with the things that definitely need fixing.

May 28 2019, 7:09 PM · Restricted Project

May 25 2019

t.p.northover added inline comments to D61947: [AArch64] Merge globals when optimising for size.
May 25 2019, 1:33 AM · Restricted Project

May 24 2019

t.p.northover added inline comments to D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters.
May 24 2019, 7:18 AM · Restricted Project
t.p.northover updated the diff for D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters.

Switched to ternary operators as Matt suggested.

May 24 2019, 5:55 AM · Restricted Project
t.p.northover updated the diff for D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters.

Accidentally included half-done Clang changes in last upload, so this removes them.

May 24 2019, 5:38 AM · Restricted Project
t.p.northover updated the diff for D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters.

While modifying Clang to emit this new style attribute, it turned out I'd got the printing incorrect and you could end up with things like byval(%mystruct = type { i32 }). Fixed that and added a unit test for it.

May 24 2019, 5:36 AM · Restricted Project
t.p.northover retitled D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters from IR: add 'size <N>' attribute to 'byval' function parameters to IR: add 'byval(<ty>)' variant to 'byval' function parameters.
May 24 2019, 5:34 AM · Restricted Project
t.p.northover updated the diff for D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters.

Switched to byval(<ty>) syntax, still optional for now but auto-upgraded when reading .bc files.

May 24 2019, 5:04 AM · Restricted Project
t.p.northover committed rG3b2157aeed84: GlobalISel: support swifterror attribute on AArch64. (authored by t.p.northover).
GlobalISel: support swifterror attribute on AArch64.
May 24 2019, 1:40 AM
t.p.northover committed rG3d7a057b0d1d: CodeGen: factor out swifterror value tracking. (authored by t.p.northover).
CodeGen: factor out swifterror value tracking.
May 24 2019, 1:40 AM
t.p.northover closed D62248: GlobalISel: support swifterror on AArch64.

Thanks Amara, committed as r361608 with the suggested fix.

May 24 2019, 1:39 AM · Restricted Project
t.p.northover closed D62247: CodeGen: refactor swifterror tracking into CodeGen.

Thanks Amara. Committed as r361607.

May 24 2019, 1:37 AM · Restricted Project
t.p.northover accepted D62297: [ARM] ARMExpandPseudoInsts: add debug messages.

Thanks. LGTM.

May 24 2019, 1:16 AM · Restricted Project

May 23 2019

t.p.northover added a comment to D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters.

I'm liking the type idea more and more. I'll get started reworking the patch to do that.

May 23 2019, 9:17 AM · Restricted Project
t.p.northover added a comment to D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters.

One of the other suggestions was to pass a _type_ as a parameter to byval. IMO that would be the nicest idea (but I don't know if it's infeasibly difficult?)

May 23 2019, 9:04 AM · Restricted Project
t.p.northover added a comment to D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters.

ie: What about adding an integer parameter to 'byval'?

May 23 2019, 8:30 AM · Restricted Project
t.p.northover created D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters.
May 23 2019, 7:45 AM · Restricted Project
t.p.northover accepted D62285: [AArch64] Add nvcast patterns for v2f32 -> v1f64.

LGTM.

May 23 2019, 7:44 AM · Restricted Project
t.p.northover added a comment to D62308: [AArch64] support neon_sshl and neon_ushl in performIntrinsicCombine..

I think there are probably other shifts that we can include while we're in the area. Most obviously aarch64_neon_ushl, but maybe others too.

May 23 2019, 7:13 AM · Restricted Project
t.p.northover added a comment to D62297: [ARM] ARMExpandPseudoInsts: add debug messages.

I like the Expanding/To, but I think dumping the whole function is a bit excessive. That's what -print-after-all is for really.

May 23 2019, 5:40 AM · Restricted Project
t.p.northover added inline comments to D62301: Fold Address Computations into Load/Store instructions for AArch64.
May 23 2019, 5:32 AM
t.p.northover added a comment to D61259: AArch64: support arm64_32, an ILP32 slice for watchOS..

Looks like there's no reviewers set here. @t.p.northover who should review this?

May 23 2019, 1:44 AM · Restricted Project

May 22 2019

t.p.northover added a comment to D61939: AArch64: add support for arm64_32 (ILP32) triple and -arch option..

Oops, yes. I'll leave it wrong though, the best that could come out of any attempt to change it would be to split the thread on llvm-commits.

May 22 2019, 7:03 AM · Restricted Project
t.p.northover accepted D62252: [DAGCombiner][X86][AArch64][SPARC][SystemZ] y - (x + C) -> (y - x) - C fold.

Looks reasonable to me.

May 22 2019, 7:03 AM · Restricted Project
t.p.northover added a comment to D61259: AArch64: support arm64_32, an ILP32 slice for watchOS..

Ping.

May 22 2019, 5:13 AM · Restricted Project