Page MenuHomePhabricator
Feed Advanced Search

Dec 10 2017

jpdeplaix added a comment to D37326: Fix the OCaml external linking problem.

poke @mgorny
That would be awesome to have this merged before the feature freeze (6th of January I believe)

Dec 10 2017, 5:56 PM

Oct 24 2017

jpdeplaix added a comment to D37326: Fix the OCaml external linking problem.

@whitequark don't worry, I don't mind. Thanks. I've updated the diff with requested change. As far as I tested (using opam and llvm-5.0.0), it's working.

Oct 24 2017, 4:57 PM
jpdeplaix updated the diff for D37326: Fix the OCaml external linking problem.

Use ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}${LLVM_VERSION_SUFFIX} directly and put -L before -l.

Oct 24 2017, 4:54 PM
jpdeplaix added a comment to D37326: Fix the OCaml external linking problem.

Can you try the LLVMCore target?

Oct 24 2017, 4:15 PM
jpdeplaix added a comment to D37326: Fix the OCaml external linking problem.

By the way, does anybody have any idea how to fix the get_target_property() called with non-existent target "LLVM". problem ?
Otherwise I can always do like the patch in use in opam right now: replace the lines 71 and 72 with a single line:

list(APPEND ocaml_flags "-lLLVM-${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}${LLVM_VERSION_SUFFIX}")

it just works but it's not really a solid solution it seems.

Oct 24 2017, 3:03 AM

Oct 17 2017

jpdeplaix added a comment to D37326: Fix the OCaml external linking problem.

Wow, I replied to the comments two months ago but it seems that Phabricator made those only visible to me... I was supposed to click on submit at the end of the page or something maybe ? (let's see now)

Oct 17 2017, 5:33 AM

Aug 31 2017

jpdeplaix created D37326: Fix the OCaml external linking problem.
Aug 31 2017, 2:20 AM

Jul 29 2017

jpdeplaix added a comment to D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc.

Can you also backport this commit ? https://github.com/llvm-mirror/llvm/commit/876aa0d1c66ddcb1952d5153b4cb8486d5ac0ecc

Jul 29 2017, 7:48 AM
jpdeplaix added a comment to D35995: [OCaml] Install dynamic libraries in 'stubdirs' directory.

Is it possible to backport this to the 5.0 branch ?

Jul 29 2017, 7:39 AM
jpdeplaix added a comment to D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc.

Is it possible to backport this to the 5.0 branch ?

Jul 29 2017, 7:39 AM

Jul 28 2017

jpdeplaix accepted D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc.

Seems fair.

Jul 28 2017, 7:47 AM

Sep 9 2016

jpdeplaix added a comment to D24354: cmake: Install the OCaml libraries into a more correct path.

It works well. I updated my pull request.

Sep 9 2016, 7:45 PM

Sep 8 2016

jpdeplaix added a comment to D24354: cmake: Install the OCaml libraries into a more correct path.

Is there a reason to use multiple META.* files then? Considering that installing the files in a subdirectory is necessary anyway, I think it might be cleaner to just combine and install one META file for all of them. This will also make the logic simpler since it would be limited to a single flexible installation path with no need to reference parent/subdirectory structure.

Of course, another option is to just make the top directory configurable, and always create 'llvm' in it. I think this is the solution you were proposing, correct?

Sep 8 2016, 1:45 PM
jpdeplaix added a comment to D24354: cmake: Install the OCaml libraries into a more correct path.

ocamlfind is looking for a "META" file in subdirectories so META.llvm (for example) is not handled.
META files in the form "META.thing" are handled only in the base directory.

Sep 8 2016, 1:04 PM
jpdeplaix added a comment to D24354: cmake: Install the OCaml libraries into a more correct path.

This patch won't work because the META files should be installed in ${OCAML_STDLIB_PATH}.
Otherwise ocamlfind won't be able to locate them. You also have to modify the directory field in the META files accordingly.

Sep 8 2016, 12:59 PM
jpdeplaix added a comment to D24354: cmake: Install the OCaml libraries into a more correct path.

Well, I did an opam package with a few patches if you want to know what I'd personally expect: https://github.com/ocaml/opam-repository/pull/7346

Sep 8 2016, 12:27 PM
jpdeplaix added a comment to D24354: cmake: Install the OCaml libraries into a more correct path.

Where does the META files are going to be installed ? $LLVM_LIBRARY_DIR/ocaml or $OCAML_INSTALL_PATH ?

Sep 8 2016, 11:31 AM