Page MenuHomePhabricator
Feed Advanced Search

Oct 15 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

@vitalybuka I plan to debug this failure as soon as I can. I imagine I'd have to use QEmu to emulate ppc64/s390x since I don't have such a machine on hand. Thanks for committing my other diff though!

Oct 15 2019, 10:48 AM · Restricted Project, Restricted Project

Oct 10 2019

dgg5503 added a comment to D68752: [sancov] Use LLVM Support library JSON writer in favor of individual implementation.
In D68752#1705235, @kcc wrote:

I was actually hoping to get rid of this code entirely.
Why do you need this change?

Hi @kcc,

Oct 10 2019, 6:54 PM · Restricted Project, Restricted Project

Oct 9 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

@vitalybuka thanks for the explanation. I believe I did it correctly, please let me know otherwise. It is my first time submitting a change to the LLVM project!

Oct 9 2019, 6:13 PM · Restricted Project, Restricted Project
dgg5503 added a child revision for D51018: [sancov] Accommodate sancov and coverage report server for use under Windows: D68752: [sancov] Use LLVM Support library JSON writer in favor of individual implementation.
Oct 9 2019, 6:13 PM · Restricted Project, Restricted Project
dgg5503 added a parent revision for D68752: [sancov] Use LLVM Support library JSON writer in favor of individual implementation: D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.
Oct 9 2019, 6:13 PM · Restricted Project, Restricted Project
dgg5503 updated the diff for D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Split out JSON changes to D68752.

Oct 9 2019, 6:13 PM · Restricted Project, Restricted Project
dgg5503 created D68752: [sancov] Use LLVM Support library JSON writer in favor of individual implementation.
Oct 9 2019, 6:04 PM · Restricted Project, Restricted Project
dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

@vsk thanks for the review! It looks like the JSON support library implements what JSONWriter does in this tool. To reduce maintenance, I've updated sancov to use the JSON support library implementation instead. The only downside to this change is that the JSON text format differs compared to the original implementation. I'm open to reverting this diff and simply adding your suggested change which also worked. Let me know what you think.

EDIT:
I've also updated the title and description to better describe the changes in this diff.

I like the change.

Could you move JSONWriter -> JSON refactoring into separate patch and rebase win stuff ontop?
If you don't have commiter access, someone will need to commit it for you
So I don't mind to split the patch and commit myself.

Oct 9 2019, 3:14 PM · Restricted Project, Restricted Project

Oct 8 2019

dgg5503 updated the diff for D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

@vsk thanks for the review! It looks like the JSON support library implements what JSONWriter does in this tool. To reduce maintenance, I've updated sancov to use the JSON support library implementation instead. The only downside to this change is that the JSON text format differs compared to the original implementation. I'm open to reverting this diff and simply adding your suggested change which also worked. Let me know what you think.

Oct 8 2019, 7:00 PM · Restricted Project, Restricted Project
dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Oct 8 2019, 11:44 AM · Restricted Project, Restricted Project

Sep 30 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Sep 30 2019, 12:57 PM · Restricted Project, Restricted Project

Sep 23 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Sep 23 2019, 9:03 AM · Restricted Project, Restricted Project

Sep 16 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Sep 16 2019, 9:07 AM · Restricted Project, Restricted Project

Sep 9 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Sep 9 2019, 9:16 AM · Restricted Project, Restricted Project

Sep 3 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Sep 3 2019, 1:26 PM · Restricted Project, Restricted Project

Aug 26 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Aug 26 2019, 9:20 AM · Restricted Project, Restricted Project

Aug 19 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Aug 19 2019, 10:08 AM · Restricted Project, Restricted Project

Aug 16 2019

dgg5503 added a reviewer for D51018: [sancov] Accommodate sancov and coverage report server for use under Windows: phosek.
Aug 16 2019, 4:40 PM · Restricted Project, Restricted Project
dgg5503 added a reviewer for D51018: [sancov] Accommodate sancov and coverage report server for use under Windows: filcab.
Aug 16 2019, 4:37 PM · Restricted Project, Restricted Project

Aug 12 2019

dgg5503 added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Ping.

Aug 12 2019, 9:39 AM · Restricted Project, Restricted Project

Aug 5 2019

dgg5503 updated the diff for D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Rebase over mono-repo.

Aug 5 2019, 10:25 AM · Restricted Project, Restricted Project

Aug 20 2018

dgg5503 created D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.
Aug 20 2018, 5:27 PM · Restricted Project, Restricted Project