Changed variable names to camel back style
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Nov 3 2022
Oct 31 2022
This patch fixes the repeating index issue.
Sep 22 2022
Refactoring
Make gpu.alloc op implement AllocLikeOpInterface
Sep 5 2022
LGTM
Thanks for implementing the suggested changes.
Aug 26 2022
Minor NFC changes.
Aug 23 2022
Minor changes.
Addressed comments by nicolas.
Aug 22 2022
Removed wrong changes in clang-format.sh
Addressed comments.
@nicolasvasilache I've made the required changes in the API. Also added tests featuring memref.load/store. However I've not handled folding related to vector transfer ops, so no tests involving those ops.
Addressed comments
I think this change alters the semantics, and won't work if the op has deallocate + some other effects on val. Those type of ops still qualify as dealloc ops.
Aug 12 2022
I'm getting the following error:
Jul 25 2022
@nicolasvasilache can you please take a look at my comments?
Jul 18 2022
Jul 17 2022
ping @nicolasvasilache can you please re-review?
Jul 13 2022
Addressd review comments.
Addressed review comments.
Jul 1 2022
Discarding unnecessary changes.
May 13 2022
Rebased on latest master.
May 12 2022
Addressed comments by @bondhugula.
Addressed comments by @bondhugula.
May 6 2022
Addressed comments by @bondhugula.
Apr 29 2022
Addressed comments by @bondhugula.
Fixed linting errors.
Added hasSingleEffect() as a part of SideEffectInterface.
Apr 22 2022
Apr 21 2022
Can you please provide the test case for which incorrect IR is generated?
I will provide the fix. Thanks in advance.
Apr 19 2022
Removed trailing white spaces.
Apr 18 2022
Fixed build issues.
Apr 14 2022
Addressed review comments and rebased on latest master.
Apr 13 2022
Adressed comments by @csigg, @bondhugula
Mar 23 2022
ping @csigg, can you please take look at my comment?
Mar 16 2022
Resolved build issues.
Mar 15 2022
Addressed comments by @csigg.
Mar 12 2022
Addressed comments by @bondhugula
Mar 10 2022
Addressed comments by @bondhugula
Addressed comments by @bondhugula
Mar 9 2022
Addressed review comments by @csigg.
Set hasVerifier field in gpu.memcpy removed earlier by mistake.
Jan 19 2022
Fixed build errors.
Jan 6 2022
ping @ JianyiCheng, can you please let me know if this revision has been abandoned? I actually require a similar kind of pass.
Dec 19 2021
Initially Linalg::ConvOp had padding attribute, but the current set of convolution ops don't have them. Is there anyway I can define convolution with padding with the current Linalg Dialect?
CC - @bondhugula , @gysit , @nicolasvasilache
Nov 26 2021
Added doc comments for the getMaxDimAndSymbol().
Nov 25 2021
Rebased on latest master.
Rebased on latest master.
Removed extra parenthesis as suggested by @bondhugula.
@nicolasvasilache, @bondhugula and @rriddle, I have addressed all your comments. Please take a look.
Addressed comments by @nicolasvasilache and @bondhugula
ping @nicolasvasilache, I have addressed your comments. You can take a look.
Addressed comments by @nicolasvasilache and @bondhugula.
Nov 21 2021
ping @rriddle and @nicolasvasilache can you please take a look at the replies of your respective comments.
Removed unnecessary #include<algorithm>.
Addressed comments.
Nov 20 2021
Addressed comments by @bondhugula.
Nov 19 2021
Fixed documentation @bondhugula .
ping @dcaballe and @springerm , can you please take a look and review this? This is a continuation of semi affine expression simplification PR.
Addressed all comments by @bondhugula
Added test cases.
Nov 13 2021
ping @springerm and @dcaballe , can you please let me know whether the revision is ok or if any more changes are required to be made? Thanks in advance!
Nov 12 2021
Added CHECK-LABEL in unit tests.
Nov 10 2021
In D112808#3122209, @bondhugula wrote:In D112808#3118161, @arnab-oss wrote:Fixed a bug in the loop iterating over localExprs vector. Addressed comments
by @springerm.Could you add a test case that exercises that part of the code? (if not already)
Added an example which is giving correct output now after the previous update bug fix.
Nov 9 2021
Fixed a bug in the loop iterating over localExprs vector. Addressed comments
by @springerm.
Nov 7 2021
Addressed all the comments by @bondhugula and @dcaballe.
Removed unwanted changes from clang-format.sh
Added an example showing the contents of indices, indexToExprMap and coefficients.
Nov 6 2021
Addressed all the comments by springerm.