Page MenuHomePhabricator
Feed Advanced Search

Yesterday

aaron.ballman added inline comments to D59455: Thread safety analysis: Add note for unlock kind mismatch.
Mon, Mar 18, 2:24 PM · Restricted Project
aaron.ballman accepted D59455: Thread safety analysis: Add note for unlock kind mismatch.

LGTM aside from a small nit.

Mon, Mar 18, 1:08 PM · Restricted Project
aaron.ballman added a comment to D59467: [clang] Adding the Likely Attribute from C++2a to AST.

if likely/unlikely can be applied to any statement or label what should be generated when it is applied to a statement that don't have any conditional branch ? should it be ignored ?

Mon, Mar 18, 6:17 AM · Restricted Project
aaron.ballman added a comment to D57571: [clang-tidy] A new OpenMP module.

While I'm okay with this, I would mildly prefer it if landed with at least one check rather than entirely empty (IIRC, that's how we'd added new modules in the past).

Mon, Mar 18, 5:48 AM · Restricted Project, Restricted Project, Restricted Project
aaron.ballman accepted D59296: [pp-trace] Delete -ignore and add a new option -callbacks.

LGTM aside from some small nits. Feel free to fix and commit without further review if you'd like.

Mon, Mar 18, 5:45 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling.
Mon, Mar 18, 5:39 AM · Restricted Project, Restricted Project

Sun, Mar 17

aaron.ballman added inline comments to D59467: [clang] Adding the Likely Attribute from C++2a to AST.
Sun, Mar 17, 12:42 PM · Restricted Project
aaron.ballman added a comment to D59467: [clang] Adding the Likely Attribute from C++2a to AST.

I believe this has the incorrect modeling -- in the following code example, the attribute appertains to the substatement of the if statement, not the if statement itself:

if (foo) [[likely]] {
  blah;
}

This falls out from: http://eel.is/c++draft/stmt.stmt#1. You model this by applying the attribute to the if statement, which will have the wrong semantics when you hook up the hints to the backend.

Sun, Mar 17, 12:28 PM · Restricted Project
aaron.ballman added inline comments to D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling.
Sun, Mar 17, 7:34 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling.
Sun, Mar 17, 7:19 AM · Restricted Project, Restricted Project

Sat, Mar 16

aaron.ballman added inline comments to D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers.
Sat, Mar 16, 11:53 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling.
Sat, Mar 16, 11:49 AM · Restricted Project, Restricted Project
aaron.ballman accepted D59453: [ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher..

LGTM aside from a nit.

Sat, Mar 16, 11:49 AM · Restricted Project

Fri, Mar 15

aaron.ballman accepted D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics.

LGTM aside from some minor nits.

Fri, Mar 15, 11:16 AM · Restricted Project
aaron.ballman accepted D45978: dllexport const variables must have external linkage..

LGTM!

Fri, Mar 15, 10:40 AM
aaron.ballman added a comment to D59296: [pp-trace] Delete -ignore and add a new option -callbacks.

I think the release notes should be updated to mention that a previously-supported option has been removed and that there's a new option available as a replacement; I don't think we have any other docs for pp-trace to worry about updating, do we?

Fri, Mar 15, 7:34 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓.
Fri, Mar 15, 7:26 AM · Restricted Project

Thu, Mar 14

aaron.ballman accepted D58896: Suppress -Wchar-subscripts if the index is a literal char.

Do you have some evidence that the current behavior is causing a lot of false positives in the wild? For ASCII character literals, I can sort of guess at why people might want to do this, but for things like wide character literals, or character literals relying on the current code page, etc, I'm less convinced.

I don't know about the false positive rate, just the one report on twitter which triggered me to submit this change. As for wide character literals I was under the impression that they would be promoted to integers and wouldn't have triggered the -Wchar-subscript anyway?

Thu, Mar 14, 11:47 AM · Restricted Project
aaron.ballman added inline comments to D33841: [clang-tidy] redundant keyword check.
Thu, Mar 14, 11:30 AM · Restricted Project
aaron.ballman requested changes to D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓.

This is missing test cases that demonstrate the behavior is what we expect it to be for ObjC++ code vs C++ code.

Thu, Mar 14, 10:48 AM · Restricted Project
aaron.ballman added inline comments to D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations.
Thu, Mar 14, 8:00 AM · Restricted Project
aaron.ballman added inline comments to D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations.
Thu, Mar 14, 7:22 AM · Restricted Project
aaron.ballman accepted D59327: [Sema] Fix a use-after-free of a _Nonnull ParsedAttr.

LGTM!

Thu, Mar 14, 5:54 AM · Restricted Project, Restricted Project
aaron.ballman added a reviewer for D59286: Allow pointer to static member function: rsmith.

This is valid C++ codes. Both GCC and MSVC accepts this.

Thu, Mar 14, 5:47 AM
aaron.ballman added a comment to D59280: Allow 'static' storage specifier on an out-of-line class member template declaration in MSVCCompat mode.

I feel like I must be missing something, because MSVC does not accept the code from your test case: https://godbolt.org/z/r6evxY Are there other language options required to get MSVC to accept this code, or perhaps is it only accepted by certain versions of MSVC?

Thu, Mar 14, 5:13 AM

Mon, Mar 11

aaron.ballman added reviewers for D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations: rsmith, aaron.ballman.
Mon, Mar 11, 4:37 PM · Restricted Project
aaron.ballman added inline comments to D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations.
Mon, Mar 11, 1:37 PM · Restricted Project
aaron.ballman added inline comments to D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations.
Mon, Mar 11, 12:43 PM · Restricted Project
aaron.ballman added inline comments to D56160: [clang-tidy] modernize-use-trailing-return-type check.
Mon, Mar 11, 6:11 AM · Restricted Project

Fri, Mar 8

aaron.ballman added a comment to D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator.

Another idea that came to my mind would be to enable this check only for annotated types. So warning for missing field access would be only given for types that have for example [[clang::annotate("value type")]] annotation. Possibly other kinds of checks could be also developed for types that have the given annotation.

Fri, Mar 8, 2:02 PM · Restricted Project, Restricted Project
aaron.ballman added a comment to D45978: dllexport const variables must have external linkage..

I think we're pretty close! Some of the testing code can be cleaned up, but I could also use some help verifying that we're correctly matching the behavior of GCC as well.

Fri, Mar 8, 1:55 PM
aaron.ballman added inline comments to D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics.
Fri, Mar 8, 1:29 PM · Restricted Project
aaron.ballman added a comment to D59135: Add check for matching HeaderFilter before emitting Diagnostic.

Hello,
Can you please support how to do that? :-)

Fri, Mar 8, 7:34 AM · Restricted Project
aaron.ballman added a comment to D59135: Add check for matching HeaderFilter before emitting Diagnostic.

Can you add test coverage that demonstrates the fix behaves as expected?

Fri, Mar 8, 7:22 AM · Restricted Project

Thu, Mar 7

aaron.ballman added a comment to D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator.

I'm definitely worried about the false positive rate for this check -- from a quick look at the diagnostics from LLVM, every one of them is a false positive (though perhaps I've missed something; it was a very quick look). Requiring users to explicitly use a declaration within the operator seems like it could get onerous for complex classes that support the notion of equality from a few members as opposed to all members.

Thu, Mar 7, 1:31 PM · Restricted Project, Restricted Project
aaron.ballman committed rG7eb66ba14a3a: expected-no-diagnostics@ does not make sense, switching to a more idiomatic… (authored by aaron.ballman).
expected-no-diagnostics@ does not make sense, switching to a more idiomatic…
Thu, Mar 7, 7:04 AM
aaron.ballman added inline comments to D45978: dllexport const variables must have external linkage..
Thu, Mar 7, 6:58 AM

Wed, Mar 6

aaron.ballman added a comment to D58154: Add support for -fpermissive..

I don't have particularly strong feelings one way or the other about accepting -fpermissive at all. For GCC compatibility, it seems like a moderately useful thing to support, but I don't think we have any interest in accepting everything that GCC accepts under -fpermissive.

Wed, Mar 6, 2:08 PM · Restricted Project
aaron.ballman added a comment to D58216: Support attribute used in member funcs of class templates II.

Both approaches make sense to me. I'll re-land the previous patch in favor of gcc compatibility, since the semantics of attribute used in member functions of class templates were first implemented in gcc.

Wed, Mar 6, 12:55 PM · Restricted Project
aaron.ballman added inline comments to D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..
Wed, Mar 6, 9:38 AM
aaron.ballman added inline comments to D56160: [clang-tidy] modernize-use-trailing-return-type check.
Wed, Mar 6, 9:29 AM · Restricted Project
aaron.ballman added a comment to D58896: Suppress -Wchar-subscripts if the index is a literal char.

Do you have some evidence that the current behavior is causing a lot of false positives in the wild? For ASCII character literals, I can sort of guess at why people might want to do this, but for things like wide character literals, or character literals relying on the current code page, etc, I'm less convinced.

Wed, Mar 6, 9:04 AM · Restricted Project
aaron.ballman accepted D57855: [analyzer] Reimplement checker options.

LGTM aside from some minor nits, but you should wait for someone more well-versed in the static analyzer to sign off before committing.

Wed, Mar 6, 8:58 AM · Restricted Project
aaron.ballman added a comment to D58216: Support attribute used in member funcs of class templates II.

Friendly ping! @aaron.ballman it looks like you accepted D56928, could you take a look at this as well?

Wed, Mar 6, 8:38 AM · Restricted Project
aaron.ballman added inline comments to D58757: Add a version of the pass_object_size attribute that works with builtin_dynamic_object_size.
Wed, Mar 6, 8:09 AM · Restricted Project
aaron.ballman added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

@aaron.ballman does it make sense to warn for this case only in C/pre-C++11 mode? Since this case in C++11/14/17 is handled by -Wnarrowing, as we see from tests.

Wed, Mar 6, 7:59 AM
aaron.ballman added a comment to D58154: Add support for -fpermissive..

The errors disabled by this feature are default-error warnings -- you can already get the same effect by using -Wno-<lots-of-things>. Why is it bad to additionally allow -fpermissive to disable them? (If we have any diagnostics which are currently default-on-warnings which should not _ever_ be disable-able, then maybe we should just fix those?)

Wed, Mar 6, 6:37 AM · Restricted Project

Tue, Mar 5

aaron.ballman added a comment to D58154: Add support for -fpermissive..

I'm not super keen on supporting -fpermissive -- what is the impetus for supporting this? Is it just for GCC compatibility?

Yes, exactly that -- this is to improve our drop-in compatibility with GCC. See http://llvm.org/PR40670 for an example user request for this.

Tue, Mar 5, 7:23 AM · Restricted Project

Mon, Mar 4

aaron.ballman added a comment to D58154: Add support for -fpermissive..

I'm not super keen on supporting -fpermissive -- what is the impetus for supporting this? Is it just for GCC compatibility?

Mon, Mar 4, 12:51 PM · Restricted Project

Wed, Feb 27

aaron.ballman added inline comments to D45978: dllexport const variables must have external linkage..
Wed, Feb 27, 6:14 PM

Sat, Feb 23

aaron.ballman added inline comments to D58292: Add support for importing ChooseExpr AST nodes..
Sat, Feb 23, 9:15 AM · Restricted Project, Restricted Project

Thu, Feb 21

aaron.ballman added inline comments to D58292: Add support for importing ChooseExpr AST nodes..
Thu, Feb 21, 3:24 PM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D58292: Add support for importing ChooseExpr AST nodes..
Thu, Feb 21, 11:09 AM · Restricted Project, Restricted Project
aaron.ballman accepted D58292: Add support for importing ChooseExpr AST nodes..

LGTM!

Thu, Feb 21, 10:56 AM · Restricted Project, Restricted Project

Wed, Feb 20

aaron.ballman added inline comments to D58292: Add support for importing ChooseExpr AST nodes..
Wed, Feb 20, 4:44 PM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D58292: Add support for importing ChooseExpr AST nodes..
Wed, Feb 20, 4:29 PM · Restricted Project, Restricted Project
aaron.ballman accepted D58365: [attributes] Add a MIG server routine attribute..

LGTM with a minor documentation nit.

Wed, Feb 20, 3:17 PM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D58365: [attributes] Add a MIG server routine attribute..
Wed, Feb 20, 10:23 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D58292: Add support for importing ChooseExpr AST nodes..
Wed, Feb 20, 10:11 AM · Restricted Project, Restricted Project
aaron.ballman added a comment to D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈.

Still LGTM, thanks for adding the license snippet!

Wed, Feb 20, 10:01 AM · Restricted Project

Tue, Feb 19

aaron.ballman added a comment to D58365: [attributes] Add a MIG server routine attribute..

@aaron.ballman, are you actually interested in reviewing these attributes? 'Cause George added you on his reviews but i totally understand that these are fairly exotic.

Tue, Feb 19, 12:27 PM · Restricted Project, Restricted Project

Feb 15 2019

aaron.ballman added a reviewer for D58292: Add support for importing ChooseExpr AST nodes.: aaron.ballman.

Please be sure to update Registry.cpp to expose the new AST matcher to the dynamic matcher infrastructure, regenerate the AST matcher documentation (run clang\docs\tools\dump_ast_matchers.py), and add tests for the matcher.

Feb 15 2019, 12:16 PM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D45978: dllexport const variables must have external linkage..
Feb 15 2019, 10:43 AM
aaron.ballman updated subscribers of D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs".

(Following up on a discussion on IRC) I have looked at what would be needed to revert the set of patches which introduced this change, but this results in a >1k lines diff which do not apply cleanly. I think it might be safer to just merge this fix. Unless @aaron.ballman disagree, @hans could you please merge this into the release branch ?

Feb 15 2019, 10:26 AM · Restricted Project

Feb 14 2019

aaron.ballman accepted D17444: [MSVC] Recognize "static_assert" keyword in C mode.

LGTM!

Feb 14 2019, 11:34 AM · Restricted Project
aaron.ballman accepted D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression..

LGTM!

Feb 14 2019, 11:30 AM · Restricted Project

Feb 13 2019

aaron.ballman accepted D58152: [Sema] Delay checking whether objc_designated_initializer is being applied to an init method.

LGTM with a testing request.

Feb 13 2019, 11:57 AM · Restricted Project
aaron.ballman added a comment to D58140: [libc++] Enable deprecation warnings by default.

This seems sensible to me, but I leave it to the libc++ maintainers to sign off on the review. Thank you for working on this!

Feb 13 2019, 11:03 AM · Restricted Project
aaron.ballman added a comment to D58091: Customize warnings for missing built-in type.
  • but I wonder why those diagnostics are happening in the first place. It seems like the warning is still useful when it triggers outside of that situation, no?

The underlying conceptual problem, which I didn't know when I added GE_Missing_type, is that this has _nothing_ to do with the location of the declaration. We say, include the header X.h, if we were not able to build a type for recognized built-in Y that should be declared in X.h. However, we should report _why_ we could not build the type instead. For built-ins we do not have a type on record (GE_Missing_type), this is always, so no warning for now. For the ones that we only fail to build a type because some requirement is missing, we should report that, at least when we are in the respective header. I don't have a perfect solution of what to do actually.

I could check if the declaration is (probably) in the respective header so we can switch between warnings?

Feb 13 2019, 8:56 AM · Restricted Project
aaron.ballman added a reviewer for D58091: Customize warnings for missing built-in type: rsmith.

If I'm following along properly, it sounds like we want to disable this warning largely because it can appear in header files attempting to declare the functions in question -- but I wonder why those diagnostics are happening in the first place. It seems like the warning is still useful when it triggers outside of that situation, no?

Feb 13 2019, 8:04 AM · Restricted Project
aaron.ballman added inline comments to D45978: dllexport const variables must have external linkage..
Feb 13 2019, 7:47 AM
aaron.ballman added inline comments to D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression..
Feb 13 2019, 7:35 AM · Restricted Project
aaron.ballman added inline comments to D58152: [Sema] Delay checking whether objc_designated_initializer is being applied to an init method.
Feb 13 2019, 7:16 AM · Restricted Project
aaron.ballman added inline comments to D57855: [analyzer] Reimplement checker options.
Feb 13 2019, 6:55 AM · Restricted Project
aaron.ballman accepted D45978: dllexport const variables must have external linkage..

LGTM!

Feb 13 2019, 6:43 AM
aaron.ballman accepted D57080: [clang-tidy] Delete obsolete objc-property-declaration options ✂️.

LGTM!

Feb 13 2019, 6:36 AM · Restricted Project, Restricted Project
aaron.ballman accepted D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈.

LGTM!

Feb 13 2019, 6:36 AM · Restricted Project

Feb 12 2019

aaron.ballman accepted D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs".

LGTM!

Feb 12 2019, 1:20 PM · Restricted Project
aaron.ballman added a comment to D45978: dllexport const variables must have external linkage..

Oops, sorry, I think I added some comments to a previous revision of the review. To recap:

Feb 12 2019, 8:12 AM
aaron.ballman added inline comments to D45978: dllexport const variables must have external linkage..
Feb 12 2019, 8:09 AM
aaron.ballman added inline comments to D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈.
Feb 12 2019, 5:32 AM · Restricted Project
aaron.ballman added a comment to D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression..

Considering that this has been fertile ground for buggy edge cases, should we revert my original changes from the 8.0 branch to give this more time to bake on trunk before releasing? Or do you think this is fine to move onto the release branch once finalized?

Feb 12 2019, 5:28 AM · Restricted Project
aaron.ballman committed rGce667f6df971: Renaming yet another diagnostic to not conflict; NFC. (authored by aaron.ballman).
Renaming yet another diagnostic to not conflict; NFC.
Feb 12 2019, 5:20 AM
aaron.ballman committed rG76126c01b011: Renaming this diagnostic to not conflict with another; NFC. (authored by aaron.ballman).
Renaming this diagnostic to not conflict with another; NFC.
Feb 12 2019, 5:14 AM
aaron.ballman committed rG52c9ad200116: Fixing a typo; NFC. (authored by aaron.ballman).
Fixing a typo; NFC.
Feb 12 2019, 5:04 AM

Feb 11 2019

aaron.ballman accepted D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions.

LGTM aside from some very minor nits.

Feb 11 2019, 1:42 PM · Restricted Project, Restricted Project
aaron.ballman added a comment to D17444: [MSVC] Recognize "static_assert" keyword in C mode.

Also, I suppose this is really actually an -fms-compatibility thing not -fms-extensions because it takes an identifier from outside the implementer's namespace.

Feb 11 2019, 1:22 PM · Restricted Project
aaron.ballman added inline comments to D45978: dllexport const variables must have external linkage..
Feb 11 2019, 10:32 AM
aaron.ballman added inline comments to D33841: [clang-tidy] redundant keyword check.
Feb 11 2019, 6:07 AM · Restricted Project
aaron.ballman added inline comments to D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions.
Feb 11 2019, 5:47 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs".
Feb 11 2019, 5:37 AM · Restricted Project
aaron.ballman added a comment to D45978: dllexport const variables must have external linkage..

It looks like the patch got mucked up somehow, I only see three testing files in the patch now?

Feb 11 2019, 5:27 AM
aaron.ballman added a comment to D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression..

Thank you for working on this! It looks like we did have to add the new AST node after all, but the changes seem pretty good. Should anything be updated in the AST dumper for this (such as printing whether a Stmt is a value-producing statement or not)?

Feb 11 2019, 5:24 AM · Restricted Project

Feb 8 2019

aaron.ballman added a comment to D57267: [AST] Factor out the logic of the various Expr::Ignore*.

I don't think there was an explicit reason beyond "I didn't need to do it at the time". So probably just an oversight on my part. I don't know the code nearly as well as @rnk, so I could be wrong, but I think the existing tests should tell you if something went haywire if you skip FullExprs.

I see. I am a bit weary about relying on test coverage to validate a change. It is certainly a necessary condition but I am not sure that it is a sufficient condition.

Yes, @rsmith asked me to skip all FullExprs, but that change did not pass tests, so I only made IgnoreParens ignore ConstantExpr to preserve existing behavior. There is no good design reason for it to be that way, and if you can adjust the callers to account for the new behavior, I think making them consistent would be good.

I agree, but for now what I would like to do is just make sure that IgnoreParenImpCasts skips, among other things, every node skipped by IgnoreImpCasts. Not doing so is highly misleading given the names. (An other fun one is that you would think that IgnoreParenImpCasts() = IgnoreParens() + IgnoreImpCasts() but sadly that's not the case since IgnoreParenImpCasts() skips additionally MaterializeTemporaryExpr and SubstNonTypeTemplateParmExpr, even though IgnoreParenCasts() = IgnoreParens() + IgnoreCasts()).

Feb 8 2019, 12:57 PM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions.
Feb 8 2019, 12:00 PM · Restricted Project, Restricted Project

Feb 7 2019

aaron.ballman accepted D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals.

LGTM aside from a testing nit.

Feb 7 2019, 1:42 PM · Restricted Project, Restricted Project, Restricted Project

Feb 6 2019

aaron.ballman accepted D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way.

LGTM, though I am by no means a gtest expert.

Feb 6 2019, 4:42 PM · Restricted Project
aaron.ballman accepted D57267: [AST] Factor out the logic of the various Expr::Ignore*.

LGTM! You should give @rsmith a few days in case he wants to express an opinion though.

Feb 6 2019, 11:25 AM · Restricted Project, Restricted Project
aaron.ballman accepted D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604).

LGTM aside from a nit.

Feb 6 2019, 11:08 AM · Restricted Project, Restricted Project, Restricted Project
aaron.ballman added a comment to D45978: dllexport const variables must have external linkage..

Can you add tests for C mode as well, as it seems the behavior differs there. Given:

__declspec(dllexport) int const x = 3;
__declspec(dllexport) const int y;
extern int const z = 4;
Feb 6 2019, 11:05 AM