Page MenuHomePhabricator
Feed Advanced Search

Tue, May 16

rui.zhang added a comment to D150684: [LoopReroll] Remove unused LoopReroll pass.

Can we keep this pass around for some time? I have some tentative plan to extend it to cover some scenarios though not concrete yet.

Tue, May 16, 11:37 AM · Restricted Project, Restricted Project

Mar 8 2023

Herald added a project to D89322: [LV] Initial VPlan cost modelling: Restricted Project.
Mar 8 2023, 10:02 AM · Restricted Project, Restricted Project

Oct 21 2022

rui.zhang updated subscribers of D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types..

Rebased on current main

I like the direction where this change is leading to and hope there is some way to land it incrementally. Since BuiltinType has the above mentioned concern on void *, how about we focus on RecordType pointers as a first step instead? Are there any pitfalls if we distinguish RecordType pointers by depth?

An initial restriction like that sounds reasonable to me. @jcranmer-intel @efriedma @rjmccall WDYT?

I also updated the type sanitizer patches and posted https://discourse.llvm.org/t/reviving-typesanitizer-a-sanitizer-to-catch-type-based-aliasing-violations/66092 to discuss ways to move forward with the sanitizer.

Oct 21 2022, 8:50 AM · Restricted Project, Restricted Project

Sep 16 2022

rui.zhang accepted D134077: [RISCV] Support -mno-implicit-float..

Thanks for fixing it.

Sep 16 2022, 9:43 PM · Restricted Project, Restricted Project

Aug 29 2022

rui.zhang accepted D132700: [DSE] Add value type checks for masked store candidates in Dead Store Elimination.

Your change looks great to me. Thanks for improving this case.

Aug 29 2022, 11:33 AM · Restricted Project, Restricted Project

Jul 5 2022

rui.zhang added a comment to D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types..

I like the direction where this change is leading to and hope there is some way to land it incrementally. Since BuiltinType has the above mentioned concern on void *, how about we focus on RecordType pointers as a first step instead? Are there any pitfalls if we distinguish RecordType pointers by depth?

Jul 5 2022, 10:11 AM · Restricted Project, Restricted Project

Jun 29 2022

rui.zhang added a comment to D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types..

Well, if you can find a solution to the void* <-> T** problem, that might make it tractable. Or you can introduce a flag to control whether we do this — I guess on some level -fstrict-aliasing ought to be the full language model, so this would mean introducing a -fless-strict-aliasing or something like it.

Is it helpful if we only track pointers to user defined types so that void * or char * is not in the picture?

Jun 29 2022, 2:46 PM · Restricted Project, Restricted Project

Jun 15 2022

rui.zhang accepted D127877: [ValueTypes] Add types for nxv16bf16 and nxv32bf16..
Jun 15 2022, 10:14 AM · Restricted Project, Restricted Project

May 18 2022

Herald added a project to D99354: [SimpleLoopUnswitch] Port partially invariant unswitch from LoopUnswitch to SimpleLoopUnswitch: Restricted Project.

I was able to see the speed up on omnetpp of SPEC2006 but there was no speedup on omentpp of SPEC2017. I guess you are looking SPEC2017 one.

May 18 2022, 9:14 PM · Restricted Project, Restricted Project