Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Feed Advanced Search

Aug 23 2023

strega-nil abandoned D158221: [llvm-lit] copy CRT/STL DLLs into the output directory.

It turns out I misunderstood how this release process works; it is _only_ important inside our internal test harness, not inside the LLVM public test harness; I apologize for opening this non-useful PR.

Aug 23 2023, 2:23 PM · Restricted Project, Restricted Project

Aug 18 2023

strega-nil updated the diff for D158221: [llvm-lit] copy CRT/STL DLLs into the output directory.

oops, missed a commit (ignore)

Aug 18 2023, 2:57 PM · Restricted Project, Restricted Project
strega-nil updated the diff for D158221: [llvm-lit] copy CRT/STL DLLs into the output directory.

Fix the code to work with built-in lit/main.py

Aug 18 2023, 2:56 PM · Restricted Project, Restricted Project

Aug 17 2023

strega-nil planned changes to D158221: [llvm-lit] copy CRT/STL DLLs into the output directory.
Aug 17 2023, 3:45 PM · Restricted Project, Restricted Project
strega-nil requested review of D158221: [llvm-lit] copy CRT/STL DLLs into the output directory.
Aug 17 2023, 2:58 PM · Restricted Project, Restricted Project
strega-nil added a comment to D157038: ASan: Add additional wcs* interceptors on Windows.

(ping; I'd like to get this reviewed so that we can merge it at the same time into public LLVM as into MSVC's version)

Aug 17 2023, 2:22 PM · Restricted Project, Restricted Project

Aug 10 2023

strega-nil added reviewers for D157038: ASan: Add additional wcs* interceptors on Windows: vitalybuka, alvinhochun.
Aug 10 2023, 3:08 PM · Restricted Project, Restricted Project
strega-nil updated the diff for D157038: ASan: Add additional wcs* interceptors on Windows.

Attempting to add more metadata

Aug 10 2023, 3:04 PM · Restricted Project, Restricted Project
strega-nil requested changes to D155879: Summary: [asan][win][msvc] override new and delete and seperate TUs.

Some minor nits, mostly.

Aug 10 2023, 2:22 PM · Restricted Project, Restricted Project

Aug 9 2023

strega-nil updated the diff for D157038: ASan: Add additional wcs* interceptors on Windows.

minor naming change

Aug 9 2023, 11:37 AM · Restricted Project, Restricted Project

Aug 4 2023

strega-nil updated the diff for D157038: ASan: Add additional wcs* interceptors on Windows.

Add interceptors for the debug runtime on x86

Aug 4 2023, 11:40 AM · Restricted Project, Restricted Project

Aug 3 2023

strega-nil updated subscribers of D157038: ASan: Add additional wcs* interceptors on Windows.
Aug 3 2023, 3:11 PM · Restricted Project, Restricted Project
strega-nil requested review of D157038: ASan: Add additional wcs* interceptors on Windows.
Aug 3 2023, 2:26 PM · Restricted Project, Restricted Project

Jun 14 2023

strega-nil accepted D151008: [sanitizer][asan][msvc] Teach GetInstructionSize about many instructions that appear in MSVC generated code..
Jun 14 2023, 11:09 AM · Restricted Project, Restricted Project

May 31 2023

strega-nil accepted D151008: [sanitizer][asan][msvc] Teach GetInstructionSize about many instructions that appear in MSVC generated code..

We can go back and do a formatting pass later, all the actual code looks correct to me though.

May 31 2023, 4:35 PM · Restricted Project, Restricted Project
strega-nil added a comment to D151008: [sanitizer][asan][msvc] Teach GetInstructionSize about many instructions that appear in MSVC generated code..
May 31 2023, 4:31 PM · Restricted Project, Restricted Project

May 25 2023

strega-nil abandoned D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".

This is no longer necessary, as llvm::is_trivially_copyable no longer exists; closing the bugs.

May 25 2023, 10:34 AM · Restricted Project, Restricted Project
strega-nil added a comment to D149769: [sanitizer][asan][win][msvc] Correct interception of strdup on windows, additionally correclty intercept memmove/memcpy on i386 windows..

Probably good to rename the title as well.

May 25 2023, 10:23 AM · Restricted Project, Restricted Project
strega-nil requested changes to D149769: [sanitizer][asan][win][msvc] Correct interception of strdup on windows, additionally correclty intercept memmove/memcpy on i386 windows..
May 25 2023, 10:22 AM · Restricted Project, Restricted Project
strega-nil added inline comments to D151008: [sanitizer][asan][msvc] Teach GetInstructionSize about many instructions that appear in MSVC generated code..
May 25 2023, 10:18 AM · Restricted Project, Restricted Project

May 24 2023

strega-nil added inline comments to D151008: [sanitizer][asan][msvc] Teach GetInstructionSize about many instructions that appear in MSVC generated code..
May 24 2023, 7:24 PM · Restricted Project, Restricted Project
strega-nil requested changes to D151008: [sanitizer][asan][msvc] Teach GetInstructionSize about many instructions that appear in MSVC generated code..
May 24 2023, 3:30 PM · Restricted Project, Restricted Project
strega-nil accepted D149876: [sanitizer][asan][win] Intercept _strdup on windows instead of strdup..
May 24 2023, 3:12 PM · Restricted Project, Restricted Project

Feb 21 2023

strega-nil added a comment to D144262: [libc++][ranges] Implement LWG-3865 Sorting a range of pairs.

Given that the MSVC-STL team is planning on backporting this fix to C++14 (the earliest supported version), I think it's reasonable to backport this to at least C++11 (see the comment thread).

Feb 21 2023, 11:07 AM · Restricted Project, Restricted Project

Nov 19 2020

strega-nil added a comment to D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".
  1. Fix the llvm:: implementation to match std::
Nov 19 2020, 9:41 AM · Restricted Project, Restricted Project

Oct 30 2020

strega-nil added a comment to D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".

Yeah I dunno what's happening here.

Oct 30 2020, 7:35 AM · Restricted Project, Restricted Project

Aug 18 2020

strega-nil added reviewers for D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734": chandlerc, rsmith.

Adding the two people who implemented the function.

Aug 18 2020, 10:32 AM · Restricted Project, Restricted Project
strega-nil updated the diff for D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".

Just for you @CaseyCarter :) (thanks!)

Aug 18 2020, 9:51 AM · Restricted Project, Restricted Project
strega-nil added inline comments to D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".
Aug 18 2020, 9:29 AM · Restricted Project, Restricted Project

Aug 17 2020

strega-nil requested review of D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".
Aug 17 2020, 9:41 PM · Restricted Project, Restricted Project