Page MenuHomePhabricator
Feed Advanced Search

Sat, Sep 26

CodaFi committed rG55f727306e72: [LLVM-C] Turn a ShuffleVector Constant Into a Getter. (authored by CodaFi).
[LLVM-C] Turn a ShuffleVector Constant Into a Getter.
Sat, Sep 26, 4:34 PM
CodaFi closed D88367: [LLVM-C] Turn a ShuffleVector Constant Into a Getter..
Sat, Sep 26, 4:33 PM · Restricted Project
CodaFi added a comment to D88367: [LLVM-C] Turn a ShuffleVector Constant Into a Getter..

@cdisselkoen I believe we were talking past each other in the other revision - sorry about the confusion I may have caused. Hopefully this is clearer.

Sat, Sep 26, 3:47 PM · Restricted Project
CodaFi updated the diff for D88367: [LLVM-C] Turn a ShuffleVector Constant Into a Getter..
Sat, Sep 26, 3:46 PM · Restricted Project
CodaFi updated the diff for D88367: [LLVM-C] Turn a ShuffleVector Constant Into a Getter..
Sat, Sep 26, 3:40 PM · Restricted Project
CodaFi requested review of D88367: [LLVM-C] Turn a ShuffleVector Constant Into a Getter..
Sat, Sep 26, 3:39 PM · Restricted Project
CodaFi closed D88190: C API: functions to get mask of a ShuffleVector.

This has already been committed, it should remain closed.

Sat, Sep 26, 3:29 PM · Restricted Project
CodaFi added inline comments to D88190: C API: functions to get mask of a ShuffleVector.
Sat, Sep 26, 3:28 PM · Restricted Project
CodaFi added inline comments to D88190: C API: functions to get mask of a ShuffleVector.
Sat, Sep 26, 3:21 PM · Restricted Project
CodaFi added inline comments to D88190: C API: functions to get mask of a ShuffleVector.
Sat, Sep 26, 3:18 PM · Restricted Project
CodaFi added inline comments to D88190: C API: functions to get mask of a ShuffleVector.
Sat, Sep 26, 12:09 PM · Restricted Project
CodaFi added inline comments to D88190: C API: functions to get mask of a ShuffleVector.
Sat, Sep 26, 11:58 AM · Restricted Project
CodaFi added inline comments to D88190: C API: functions to get mask of a ShuffleVector.
Sat, Sep 26, 11:42 AM · Restricted Project

Fri, Sep 25

CodaFi added inline comments to D88190: C API: functions to get mask of a ShuffleVector.
Fri, Sep 25, 10:18 PM · Restricted Project

Aug 28 2020

CodaFi updated the diff for D86823: [clang][Modules] Perform an Extra Consistency Check When Searching The ModuleManager's Cache For Implicit Modules.
Aug 28 2020, 5:18 PM · Restricted Project
CodaFi requested review of D86823: [clang][Modules] Perform an Extra Consistency Check When Searching The ModuleManager's Cache For Implicit Modules.
Aug 28 2020, 4:25 PM · Restricted Project
CodaFi abandoned D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.

We have tested this proposed change out on our CI systems and have seen no relief from the symptoms of inode reuse with this approach. Abandoning this revision in favor of a more narrow fix.

Aug 28 2020, 4:21 PM · Restricted Project

Aug 19 2020

CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 19 2020, 5:45 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 19 2020, 3:40 PM · Restricted Project

Aug 18 2020

CodaFi added a comment to D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.

@aprantl Good idea. Updated.

Aug 18 2020, 7:36 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 18 2020, 7:35 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 18 2020, 11:06 AM · Restricted Project
CodaFi added a comment to D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.

Switched tactics here. Rather than just change the source of the entropy, let's increase it from just inodes to (64-bits of inode) plus (file size) plus (mod time). It is still possible to defeat this scheme, but it means an attacker would have to replace the PCM with one that has been padded out to the same size then backdate its modtime to match the one in the cache - or some cascading failure of the syscalls providing these data conspires to make this happen.

Aug 18 2020, 10:19 AM · Restricted Project
CodaFi updated the summary of D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 18 2020, 10:12 AM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 18 2020, 10:12 AM · Restricted Project

Aug 17 2020

CodaFi added a comment to D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.

Figured it out for myself. The test is forming paths that are using non-canonical path separators. Naively using those as keys means that the subsequent canonicalization done by the ASTWriter renders the keys useless for lookups into these structures. I'm going to switch to FileEntry::tryGetRealPathName since it's quite literally what ASTWriter is doing as part of its canonicalization phase. I worry about that as a solution in general though. In the future, it would be great to expose the canonicalization utilities in the ASTWriter as a more general kind of facility that could be shared between the implementations so we don't desync things again.

Aug 17 2020, 10:32 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 17 2020, 10:19 PM · Restricted Project

Aug 15 2020

CodaFi updated subscribers of D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.

Okay, I'm done throwing revisions at the bots. This windows-only failure is bizarre. @rsmith Do you have any insight into what's going wrong here?

Aug 15 2020, 7:49 PM · Restricted Project
CodaFi added inline comments to D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 15 2020, 7:35 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 15 2020, 7:26 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 15 2020, 6:38 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 15 2020, 5:33 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 15 2020, 3:57 PM · Restricted Project
CodaFi added a comment to D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 15 2020, 1:03 PM · Restricted Project

Aug 14 2020

CodaFi requested review of D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 14 2020, 10:55 AM · Restricted Project